Skip to contentSkip to conversation

platform/chrome: cros_ec: Unregister notifier in cros_ec_unregister()

PATCH In review Tzung-Bi Shih 2 participants 3 messages Jul 22, 2025 – Jul 23, 2025

Subsystems (3)
lore
Share & tools
lore

Tzung-Bi Shih

author maintainer
#0 lore raw

PATCH 1/1 platform/chrome: cros_ec: Unregister notifier in cros_ec_unregister()

The blocking notifier is registered in cros_ec_register(); however, it isn't unregistered in cros_ec_unregister().

Fix it.

Fixes 42cd0ab476e2 ("platform/chrome: cros_ec: Query EC protocol version if EC transitions between RO/RW")

---
This is separated from a series (https://lore.kernel.org/chrome-platform/[email protected]/).

While I'm still figuring out/testing the series, it'd be better to send the fix earlier (to catch up the upcoming merge window for example).

 drivers/platform/chrome/cros_ec.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/platform/chrome/cros_ec.c +3 -0
index 110771a8645e..fd58781a2fb7 100644
@@ -318,6 +318,9 @@ EXPORT_SYMBOL(cros_ec_register);
  */
 void cros_ec_unregister(struct cros_ec_device *ec_dev)
 {
+	if (ec_dev->mkbp_event_supported)
+		blocking_notifier_chain_unregister(&ec_dev->event_notifier,
+						   &ec_dev->notifier_ready);
 	platform_device_unregister(ec_dev->pd);
 	platform_device_unregister(ec_dev->ec);
 	mutex_destroy(&ec_dev->lock);
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Tzung-Bi Shih

The blocking notifier is registered in cros_ec_register(); however, it isn't unregistered in cros_ec_unregister().

Fix it.

Fixes 42cd0ab476e2 ("platform/chrome: cros_ec: Query EC protocol version if EC transitions between RO/RW")
Quoted 26 lines

---
This is separated from a series (https://lore.kernel.org/chrome-platform/[email protected]/).

While I'm still figuring out/testing the series, it'd be better to send the fix earlier (to catch up the upcoming merge window for example).

 drivers/platform/chrome/cros_ec.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/platform/chrome/cros_ec.c +3 -0
index 110771a8645e..fd58781a2fb7 100644
@@ -318,6 +318,9 @@ EXPORT_SYMBOL(cros_ec_register);
  */
 void cros_ec_unregister(struct cros_ec_device *ec_dev)
 {
+	if (ec_dev->mkbp_event_supported)
+		blocking_notifier_chain_unregister(&ec_dev->event_notifier,
+						   &ec_dev->notifier_ready);
 	platform_device_unregister(ec_dev->pd);
 	platform_device_unregister(ec_dev->ec);
 	mutex_destroy(&ec_dev->lock);
Signature · 1 line
2.50.0.727.gbf7dc18ff4-goog