libxl: allow to run non-HVM guest without any device model being available
PATCH 1/1 libxl: allow to run non-HVM guest without any device model being available
When removing qemu-trad support, libxl__domain_build_info_setdefault() was modified to only allow qemu-xen as a device model. This change resulted in an error at domain creation when qemu-xen isn't there.
As this is a perfectly fine situation for PV and PVH guests without any qemu based backends, handle this case gracefully.
Fixes 19ab8356abe4 ("tools: remove support for running a guest with qemu-traditional")
Signed-off-by Juergen Gross <[email protected]>
--- tools/libs/light/libxl_create.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/libs/light/libxl_create.c +2 -2
@@ -105,8 +105,8 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, dm =libxl__domain_device_model (gc, b_info); rc =access (dm,X_OK );if (rc <0 ) { -LOGE (ERROR ,"qemu-xen access error" ); -return ERROR_FAIL ; +LOGE (INFO ,"qemu-xen is unavailable" ); + b_info->device_model_version =LIBXL_DEVICE_MODEL_VERSION_UNKNOWN ; } }
Signature · 1 line
2.43.0
Quoted 9 lines · Juergen Gross
When removing qemu-trad support,
libxl__domain_build_info_setdefault()was modified to only allow qemu-xen as a device model. This change resulted in an error at domain creation when qemu-xen isn't there.As this is a perfectly fine situation for PV and PVH guests without any qemu based backends, handle this case gracefully.
Fixes 19ab8356abe4 ("tools: remove support for running a guest with qemu-traditional")Signed-off-by Juergen Gross <[email protected]>
Reviewed-by Anthony PERARD <[email protected]>
Thanks,
Signature · 1 line
Anthony PERARD