Skip to contentSkip to conversation

Update systemd service name param to match command

PATCH In review Terrance 4 participants 5 messages Jul 29, 2025 – Jul 31, 2025

lore
Share & tools
lore

Terrance

author
#0 lore raw

PATCH 1/1 Update systemd service name param to match command

From: Terrance <[email protected]...>

The service name displays %I which invokes systemd's path mangling (notably, converting - to /), suggesting you need to provide an encoded parameter (via e.g. systemd-escape), but the start command itself uses %i which doesn't do the conversion.

This updates the service name to match the start command.
---
Additional discussion: https://github.com/OpenVPN/openvpn/pull/802

 distro/systemd/[email protected]... | 2 +-
 distro/systemd/[email protected]... | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
distro/systemd/[email protected]... +1 -1
index ae62e8c7..c32bb333 100644
@@ -1,4 +1,4 @@
 [Unit]
-Description=OpenVPN tunnel for %I
+Description=OpenVPN tunnel for %i
 After=network-online.target
 Wants=network-online.target
distro/systemd/[email protected]... +1 -1
index 5123e072..547f5f54 100644
@@ -1,4 +1,4 @@
 [Unit]
-Description=OpenVPN service for %I
+Description=OpenVPN service for %i
 After=network-online.target
 Wants=network-online.target

--
2.50.1

Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Terrance via Openvpn-devel

From: Terrance <[email protected]...>

The service name displays %I which invokes systemd's path mangling (notably, converting - to /), suggesting you need to provide an encoded parameter (via e.g. systemd-escape), but the start command itself uses %i which doesn't do the conversion.

This updates the service name to match the start command.

Change makes sense to me. I haven't specifically tested it but it only changes the description so I don't see how it could break anything.

Regards,

Signature · 1 line
  Frank Lichtenheld
#2 lore raw
In reply to Terrance
Quoted 8 lines · Terrance via Openvpn-devel

From: Terrance <[email protected]...>

The service name displays %I which invokes systemd's path mangling (notably, converting - to /), suggesting you need to provide an encoded parameter (via e.g. systemd-escape), but the start command itself uses %i which doesn't do the conversion.

This updates the service name to match the start command.

This makes me wonder if it isn't the one passed to the start command that's actually not what it was intended to be.

Cause using %I there would enable to put configs in subdirs. With %i that's impossible, since it can't contain slashes.

#3 lore raw
Quoted 8 lines · Timo Rothenpieler
Quoted 7 lines · Terrance via Openvpn-devel

From: Terrance <[email protected]...>

The service name displays %I which invokes systemd's path mangling (notably, converting - to /), suggesting you need to provide an encoded parameter (via e.g. systemd-escape), but the start command itself uses %i which doesn't do the conversion.

Quoted 7 lines
Quoted 1 line

This updates the service name to match the start command.

This makes me wonder if it isn't the one passed to the start command that's actually not what it was intended to be.

Cause using %I there would enable to put configs in subdirs. With %i that's impossible, since it can't contain slashes.

Yes, I agree. I think %I would have been better to use exactly for the reason you mention. But I think it is too late now. If we would switch to %I now it would break existing configs.

Regards,

Signature · 1 line
  Frank Lichtenheld
#4 lore raw
In reply to Terrance

I have not tested this, but "since this is systemd description only", I wouldn't really know what to test - and Frank knows better, so fine with me :-)

I have added a signed-off-by: line as we require (and our docs say "this will be added if missing").

Thanks, Terrance, for helping us make OpenVPN better ;-)

Your patch has been applied to the master branch.

commit 8854550d4da0b29af122723def898d38e6b3fea2

Author: Terrance
Date:   Tue Jul 29 19:00:05 2025 +0100
     Update systemd service name param to match command

     Signed-off-by: Terrance <[email protected]...>
     Acked-by: Frank Lichtenheld <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg32423.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering