Skip to contentSkip to conversation

PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()

PATCH Applied Dan Carpenter 3 participants 3 messages Aug 1, 2025 – Aug 11, 2025

Subsystems (4)
Kernel janitors PCI PCI native host bridge and endpoint drivers PCI MSI driver for appliedmicro xgene
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()

There is a typo so we accidentally return positive EINVAL instead of negative -EINVAL. Add the missing '-' character.

Fixes 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/pci/controller/pci-xgene-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-xgene-msi.c +1 -1
index 0a37a3f1809c..654639bccd10 100644
@@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
 		msi_val = xgene_msi_int_read(xgene_msi, i);
 		if (msi_val) {
 			dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
-			return EINVAL;
+			return -EINVAL;
 		}
 
 		irq = platform_get_irq(pdev, i);
Signature · 1 line
2.47.2
Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · Dan Carpenter

There is a typo so we accidentally return positive EINVAL instead of negative -EINVAL. Add the missing '-' character.

Fixes 6aceb36f17ab ("PCI: xgene-msi: Restructure handler setup/teardown")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/pci/controller/pci-xgene-msi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/pci-xgene-msi.c +0 -0
index 0a37a3f1809c..654639bccd10 100644

drivers/pci/controller/pci-xgene-msi.c static int xgene_msi_handler_setup(struct platform_device *pdev) · line 317

Quoted 8 lines
drivers/pci/controller/pci-xgene-msi.c +1 -1
@@ -311,7 +311,7 @@ static int xgene_msi_handler_setup(struct platform_device *pdev)
 		msi_val = xgene_msi_int_read(xgene_msi, i);
 		if (msi_val) {
 			dev_err(&pdev->dev, "Failed to clear spurious IRQ\n");
-			return EINVAL;
+			return -EINVAL;
 		}
 
 		irq = platform_get_irq(pdev, i);
Acked-by Marc Zyngier <[email protected]>
	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
maintainer Applied
#2 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

There is a typo so we accidentally return positive EINVAL instead of negative -EINVAL. Add the missing '-' character.

Applied, thanks!

[1/1] PCI: xgene-msi: Return negative -EINVAL in xgene_msi_handler_setup()

      commit: b26fc701a25195134ff0327709a0421767c4c7b2

Best regards,

Signature · 1 line
Manivannan Sadhasivam <[email protected]>