qcom_defconfig: Add VID/PID to represent fastboot device
PATCH v2 1/1 qcom_defconfig: Add VID/PID to represent fastboot device
From: Sumit Garg <[email protected]>
Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is not appropriate. On Qcom platforms, fastboot mode is rather enumerated as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the same VID/PID pair in U-Boot to represent fastboot mode.
---
Changes in v2:
- Rebased to tip of master since v1 didn't apply cleanly there.
configs/qcom_defconfig | 2 ++ 1 file changed, 2 insertions(+)
configs/qcom_defconfig +2 -0
@@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_DWC3=y CONFIG_USB_DWC3_GENERIC=y CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1 +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d CONFIG_USB_FUNCTION_MASS_STORAGE=y CONFIG_UFS=y CONFIG_QCOM_UFS=y
Signature · 1 line
2.43.0
Quoted 21 lines · Sumit Garg
From: Sumit Garg <[email protected]>
Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is not appropriate. On Qcom platforms, fastboot mode is rather enumerated as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the same VID/PID pair in U-Boot to represent fastboot mode.
Signed-off-by Sumit Garg <[email protected]>---
Changes in v2:
- Rebased to tip of master since v1 didn't apply cleanly there.configs/qcom_defconfig | 2 ++ 1 file changed, 2 insertions(+)configs/qcom_defconfig +0
-0
configs/qcom_defconfig CONFIG_USB_XHCI_DWC3=y · line 147
Quoted 8 lines
configs/qcom_defconfig +2
-0@@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_DWC3=y CONFIG_USB_DWC3_GENERIC=y CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1 +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d CONFIG_USB_FUNCTION_MASS_STORAGE=y CONFIG_UFS=y CONFIG_QCOM_UFS=y
Quoted 8 lines · Sumit Garg
From: Sumit Garg <[email protected]>
Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is not appropriate. On Qcom platforms, fastboot mode is rather enumerated as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the same VID/PID pair in U-Boot to represent fastboot mode.
Signed-off-by Sumit Garg <[email protected]>
Quoted 21 lines
---
Changes in v2:
- Rebased to tip of master since v1 didn't apply cleanly there.configs/qcom_defconfig | 2 ++ 1 file changed, 2 insertions(+)configs/qcom_defconfig +2
-0@@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_DWC3=y CONFIG_USB_DWC3_GENERIC=y CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1 +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d CONFIG_USB_FUNCTION_MASS_STORAGE=y CONFIG_UFS=y CONFIG_QCOM_UFS=y
Signature · 1 line
// Casey (she/her)
Hi Sumit,
Quoted 6 lines · Sumit Garg
From: Sumit Garg <[email protected]>
Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is not appropriate. On Qcom platforms, fastboot mode is rather enumerated as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the same VID/PID pair in U-Boot to represent fastboot mode.
Since we have different defconfigs going on for Qualcomm, I think it makes more sense to set defaults in drivers/usb/gadget/Kconfig like rockchip does, then we don't need to update all the defconfigs and we can just override them if desired. Would you mind respinning this? Sorry this is coming so late...
Kind regards,>
Quoted 22 lines
Signed-off-by Sumit Garg <[email protected]>---
Changes in v2:
- Rebased to tip of master since v1 didn't apply cleanly there.configs/qcom_defconfig | 2 ++ 1 file changed, 2 insertions(+)configs/qcom_defconfig +2
-0@@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_DWC3=y CONFIG_USB_DWC3_GENERIC=y CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1 +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d CONFIG_USB_FUNCTION_MASS_STORAGE=y CONFIG_UFS=y CONFIG_QCOM_UFS=y
Signature · 1 line
// Casey (she/her)
Quoted 10 lines · Casey Connolly
Hi Sumit,
Quoted 6 lines · Sumit Garg
From: Sumit Garg <[email protected]>
Currently fastboot mode is enumerated as VID/PID: 0000:0000 which is not appropriate. On Qcom platforms, fastboot mode is rather enumerated as VID/PID: 18d1:d00d in ABL or from fastboot.efi app. So lets use the same VID/PID pair in U-Boot to represent fastboot mode.
Quoted 5 lines
Since we have different defconfigs going on for Qualcomm, I think it makes more sense to set defaults in
drivers/usb/gadget/Kconfiglike rockchip does, then we don't need to update all the defconfigs and we can just override them if desired. Would you mind respinning this? Sorry this is coming so late...
No worries, Kconfig option sounds reasonable to me. I can spin up a v3 with that.
-Sumit
Quoted 28 lines
Kind regards,>
Quoted 22 lines
Signed-off-by Sumit Garg <[email protected]>---
Changes in v2:
- Rebased to tip of master since v1 didn't apply cleanly there.configs/qcom_defconfig | 2 ++ 1 file changed, 2 insertions(+)configs/qcom_defconfig +2
-0@@ -140,6 +140,8 @@ CONFIG_USB_XHCI_DWC3=y CONFIG_USB_DWC3=y CONFIG_USB_DWC3_GENERIC=y CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_VENDOR_NUM=0x18d1 +CONFIG_USB_GADGET_PRODUCT_NUM=0xd00d CONFIG_USB_FUNCTION_MASS_STORAGE=y CONFIG_UFS=y CONFIG_QCOM_UFS=ySignature · 1 line
// Casey (she/her)