Skip to contentSkip to conversation

Input: sysrq: delete unnecessary check

PATCH In review Dan Carpenter 2 participants 2 messages Aug 6, 2025 – Aug 7, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: sysrq: delete unnecessary check

This code checks if (write) is true twice in a row. It's more readable to delete the first check.

---
 drivers/tty/sysrq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/tty/sysrq.c +1 -2
index 97f8a9a52285..1f78b0db3b25 100644
@@ -1133,8 +1133,7 @@ static int sysrq_sysctl_handler(const struct ctl_table *table, int write,
 	 * Behaves like do_proc_dointvec as t does not have min nor max.
 	 */
 	ret = proc_dointvec_minmax(&t, write, buffer, lenp, ppos);
-
-	if (ret || !write)
+	if (ret)
 		return ret;
 
 	if (write)
Signature · 1 line
2.47.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Dan Carpenter

This code checks if (write) is true twice in a row. It's more readable to delete the first check.

Not sure why "Input" in $SUBJ, but regardless:

thanks,

Signature · 2 lines
js
suse labs