binder: Add missing module description
PATCH 1/1 binder: Add missing module description
During build modpost issues a warning:
# MODPOST Module.symvers
./scripts/mod/modpost -M -m -b -o Module.symvers -n -T modules.order vmlinux.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/android/binder_linux.o
Fix this by adding the missing module description.
--- drivers/android/binder.c | 1 + 1 file changed, 1 insertion(+)
drivers/android/binder.c +1 -0
@@ -7090,3 +7090,4 @@ device_initcall(binder_init);#include "binder_trace.h" MODULE_LICENSE ("GPL v2" ); +MODULE_DESCRIPTION ("Android Binder IPC Driver" );
Signature · 1 line
2.50.1
Quoted 6 lines · Salvatore Bonaccorso
During build modpost issues a warning:
# MODPOST Module.symvers
./scripts/mod/modpost-M -m -b -o Module.symvers -n -T modules.order vmlinux.o
WARNING: modpost: missingMODULE_DESCRIPTION()indrivers/android/binder_linux.o
Quoted 6 lines
Fix this by adding the missing module description.
Reported-by Ben Hutchings <[email protected]>Suggested-by Ben Hutchings <[email protected]>Signed-off-by Salvatore Bonaccorso <[email protected]>
Carlos Llamas
maintainerQuoted 7 lines · Salvatore Bonaccorso
During build modpost issues a warning:
# MODPOST Module.symvers
./scripts/mod/modpost-M -m -b -o Module.symvers -n -T modules.order vmlinux.o
WARNING: modpost: missingMODULE_DESCRIPTION()indrivers/android/binder_linux.oFix this by adding the missing module description.
I'm not against having a description but binder is not tristate. Judging from the 'binder_linux.o' this seems to be some OOT version? Otherwise, I'm not sure you would be able to reproduce the warn.
Quoted 21 lines
Reported-by Ben Hutchings <[email protected]>Suggested-by Ben Hutchings <[email protected]>Signed-off-by Salvatore Bonaccorso <[email protected]>--- drivers/android/binder.c | 1 + 1 file changed, 1 insertion(+)drivers/android/binder.c +1
-0@@ -7090,3 +7090,4 @@ device_initcall(binder_init);#include "binder_trace.h" MODULE_LICENSE ("GPL v2" ); +MODULE_DESCRIPTION ("Android Binder IPC Driver" );Signature · 1 line
2.50.1
Hi,
Quoted 7 lines · Carlos Llamas
Quoted 6 lines · Salvatore Bonaccorso
During build modpost issues a warning:
# MODPOST Module.symvers
./scripts/mod/modpost-M -m -b -o Module.symvers -n -T modules.order vmlinux.o
WARNING: modpost: missingMODULE_DESCRIPTION()indrivers/android/binder_linux.o
Quoted 5 lines
Quoted 1 line
Fix this by adding the missing module description.
I'm not against having a description but binder is not tristate. Judging from the 'binder_linux.o' this seems to be some OOT version? Otherwise, I'm not sure you would be able to reproduce the warn.
This is entirely my fault. We saw the warning while building in Debian, but missed that we apply the following patch:
https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/patches/debian/android-enable-building-binder-as-module.patch?ref_type=heads
which allows to build binder as module.
I got confused by the fact that we haveMODULE_LICENSE("GPL v2");
in the upstream variant, but no description.
So you want to still have the description added or drop this proposed patch completely instead?
Regards,
Salvatore
Carlos Llamas
maintainerQuoted 21 lines · Salvatore Bonaccorso
Hi,
Quoted 7 lines · Carlos Llamas
Quoted 6 lines · Salvatore Bonaccorso
During build modpost issues a warning:
# MODPOST Module.symvers
./scripts/mod/modpost-M -m -b -o Module.symvers -n -T modules.order vmlinux.o
WARNING: modpost: missingMODULE_DESCRIPTION()indrivers/android/binder_linux.oQuoted 5 lines
Quoted 1 line
Fix this by adding the missing module description.
I'm not against having a description but binder is not tristate. Judging from the 'binder_linux.o' this seems to be some OOT version? Otherwise, I'm not sure you would be able to reproduce the warn.
This is entirely my fault. We saw the warning while building in Debian, but missed that we apply the following patch:
https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/patches/debian/android-enable-building-binder-as-module.patch?ref_type=heads
which allows to build binder as module.
Quoted 6 lines
I got confused by the fact that we have
MODULE_LICENSE("GPL v2");
in the upstream variant, but no description.So you want to still have the description added or drop this proposed patch completely instead?
I think it is best to drop all MODULE_* macros and avoid further confusion. Including the current MODULE_LICENSE(), this is misleading. I'll send a patch fixing this.
However, I don't see why we couldn't take all those patches to support binder tristate later on. Assuming that other maintainers would be ok exporting all those symbols used by binder that is. We are not using binder as a module but it doesn't hurt either. wdyt?
--
Carlos Llamas
Greg Kroah-Hartman
maintainerQuoted 26 lines · Carlos Llamas
Quoted 25 lines · Salvatore Bonaccorso
Hi,
Quoted 7 lines · Carlos Llamas
Quoted 6 lines · Salvatore Bonaccorso
During build modpost issues a warning:
# MODPOST Module.symvers
./scripts/mod/modpost-M -m -b -o Module.symvers -n -T modules.order vmlinux.o
WARNING: modpost: missingMODULE_DESCRIPTION()indrivers/android/binder_linux.oQuoted 5 lines
Quoted 1 line
Fix this by adding the missing module description.
I'm not against having a description but binder is not tristate. Judging from the 'binder_linux.o' this seems to be some OOT version? Otherwise, I'm not sure you would be able to reproduce the warn.
This is entirely my fault. We saw the warning while building in Debian, but missed that we apply the following patch:
https://salsa.debian.org/kernel-team/linux/-/blob/debian/latest/debian/patches/debian/android-enable-building-binder-as-module.patch?ref_type=heads
which allows to build binder as module.I got confused by the fact that we have
MODULE_LICENSE("GPL v2");
in the upstream variant, but no description.
Quoted 6 lines
Quoted 2 lines
So you want to still have the description added or drop this proposed patch completely instead?
I think it is best to drop all MODULE_* macros and avoid further confusion. Including the current
MODULE_LICENSE(), this is misleading. I'll send a patch fixing this.
Please do, that should make it more obvious that this can't be a module.
thanks,
greg k-h
Carlos Llamas
maintainerQuoted 10 lines · Greg Kroah-Hartman
Quoted 3 lines · Carlos Llamas
I think it is best to drop all MODULE_* macros and avoid further confusion. Including the current
MODULE_LICENSE(), this is misleading. I'll send a patch fixing this.Please do, that should make it more obvious that this can't be a module.
thanks,
greg k-h
Oops, I forgot to hit send. Here it is: