audit: add a missing tab
Subsystems (2)
PATCH 1/1 audit: add a missing tab
Someone got a bit carried away deleting tabs. Add it back.
--- kernel/auditsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/auditsc.c +1 -1
@@ -1778,7 +1778,7 @@ static void audit_log_exit(void) axs->target_sessionid[i], &axs->target_ref[i], axs->target_comm[i])) - call_panic =1 ; + call_panic =1 ; } if (context->target_pid &&
Signature · 1 line
2.47.2
Quoted 1 line · Dan Carpenter
Someone got a bit carried away deleting tabs. Add it back.
Of course, it should be the way you want it to be, but I don't see the reasoning. Help me understand.
Quoted 19 lines
Signed-off-by Dan Carpenter <[email protected]>--- kernel/auditsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/auditsc.c +1
-1@@ -1778,7 +1778,7 @@ static void audit_log_exit(void) axs->target_sessionid[i], &axs->target_ref[i], axs->target_comm[i])) - call_panic =1 ; + call_panic =1 ; } if (context->target_pid &&
Quoted 4 lines · Casey Schaufler
Quoted 1 line · Dan Carpenter
Someone got a bit carried away deleting tabs. Add it back.
Of course, it should be the way you want it to be, but I don't see the reasoning. Help me understand.
OK, I see it. Looks like a rebase error.
Quoted 19 lines
Quoted 19 lines
Signed-off-by Dan Carpenter <[email protected]>--- kernel/auditsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/auditsc.c +1
-1@@ -1778,7 +1778,7 @@ static void audit_log_exit(void) axs->target_sessionid[i], &axs->target_ref[i], axs->target_comm[i])) - call_panic =1 ; + call_panic =1 ; } if (context->target_pid &&
Quoted 6 lines · Casey Schaufler
Quoted 1 line · Dan Carpenter
Someone got a bit carried away deleting tabs. Add it back.
Of course, it should be the way you want it to be, but I don't see the reasoning. Help me understand.
The "call_panic = 1;" has to be indent one tab more than the if (audit_log_pid_context()) check otherwise static checkers complain that the if statement isn't indented.
1771 ________for (aux = context->aux_pids; aux; aux = aux->next) {
1772 ________ struct audit_aux_data_pids *axs = (void *)aux;
1773 ________
1774 ________ for (i = 0; i < axs->pid_count; i++)
1775 ________ ________if (audit_log_pid_context(context, axs->target_pid[i],
1776 ________ ________ axs->target_auid[i],
1777 ________ ________ axs->target_uid[i],
1778 ________ ________ axs->target_sessionid[i],
1779 ________ ________ &axs->target_ref[i],
1780 ________ ________ axs->target_comm[i]))
1781 ________ ________ call_panic = 1;
1782 ________}regards,
dan carpenter
Paul Moore
maintainerQuoted 7 lines · On Aug 13, 2025 Dan Carpenter <[email protected]> wrote:
Someone got a bit carried away deleting tabs. Add it back.
Signed-off-by Dan Carpenter <[email protected]>--- kernel/auditsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Good catch, thanks Dan; merged into audit/dev.
--
paul-moore.com