staging: media: atomisp: Whitespaces style cleanup in gdc.c
Subsystems (4)
PATCH 1/1 staging: media: atomisp: Whitespaces style cleanup in gdc.c
NFC: This patch cleans up coding style whitespace issues in drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
Fixes include:
- removal of unnecessary line breaks
- correcting spacing around operators
- correcting spaces between types and names
--- .../pci/hive_isp_css_common/host/gdc.c | 33 +++++++------------ 1 file changed, 12 insertions(+), 21 deletions(-)
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +12 -21
@@ -14,10 +14,8 @@/* * Local function declarations */ -static inline void gdc_reg_store ( -const gdc_ID_t ID , -const unsigned int reg, -const hrt_data value); +static inline void gdc_reg_store (const gdc_ID_t ID ,const unsigned int reg, +const hrt_data value);#ifndef __INLINE_GDC__#include "gdc_private.h"
@@ -26,9 +24,7 @@ static inline void gdc_reg_store(/* * Exported function implementations */ -void gdc_lut_store ( -const gdc_ID_t ID , -const int data[4 ][HRT_GDC_N ]) +void gdc_lut_store (const gdc_ID_t ID ,const int data[4 ][HRT_GDC_N ]) {unsigned int i, lut_offset =HRT_GDC_LUT_IDX ;
@@ -36,15 +32,13 @@ void gdc_lut_store(assert (HRT_GDC_LUT_COEFF_OFFSET <= (4 *sizeof (hrt_data)));for (i =0 ; i <HRT_GDC_N ; i++) { -hrt_data entry_0 = data[0 ][i] &HRT_GDC_BCI_COEF_MASK ; -hrt_data entry_1 = data[1 ][i] &HRT_GDC_BCI_COEF_MASK ; -hrt_data entry_2 = data[2 ][i] &HRT_GDC_BCI_COEF_MASK ; -hrt_data entry_3 = data[3 ][i] &HRT_GDC_BCI_COEF_MASK ; +hrt_data entry_0 = data[0 ][i] &HRT_GDC_BCI_COEF_MASK ; +hrt_data entry_1 = data[1 ][i] &HRT_GDC_BCI_COEF_MASK ; +hrt_data entry_2 = data[2 ][i] &HRT_GDC_BCI_COEF_MASK ; +hrt_data entry_3 = data[3 ][i] &HRT_GDC_BCI_COEF_MASK ; -hrt_data word_0 = entry_0 | - (entry_1 <<HRT_GDC_LUT_COEFF_OFFSET ); -hrt_data word_1 = entry_2 | - (entry_3 <<HRT_GDC_LUT_COEFF_OFFSET ); +hrt_data word_0 = entry_0 | (entry_1 <<HRT_GDC_LUT_COEFF_OFFSET ); +hrt_data word_1 = entry_2 | (entry_3 <<HRT_GDC_LUT_COEFF_OFFSET );gdc_reg_store (ID , lut_offset++, word_0);gdc_reg_store (ID , lut_offset++, word_1);
@@ -85,8 +79,7 @@ void gdc_lut_convert_to_isp_format(const int in_lut[4][HRT_GDC_N], } } -int gdc_get_unity ( -const gdc_ID_t ID ) +int gdc_get_unity (const gdc_ID_t ID ) {assert (ID <N_GDC_ID ); (void )ID ;
@@ -96,10 +89,8 @@ int gdc_get_unity(/* * Local function implementations */ -static inline void gdc_reg_store ( -const gdc_ID_t ID , -const unsigned int reg, -const hrt_data value) +static inline void gdc_reg_store (const gdc_ID_t ID ,const unsigned int reg, +const hrt_data value) {ia_css_device_store_uint32 (GDC_BASE [ID ] + reg *sizeof (hrt_data), value);return ;
Signature · 1 line
2.51.0.rc1.167.g924127e9c0-goog
Quoted 1 line · Adrian Barnaś
NFC: This patch cleans up coding style whitespace issues
What does "NFC" mean in this context? I only know it as the networking protocol.
Quoted 9 lines
in
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.cFixes include:
- removal of unnecessary line breaks
- correcting spacing around operators
- correcting spaces between types and namesSigned-off-by Adrian Barnaś <[email protected]>---
[ snip ]
Quoted 11 lines
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +1
-2@@ -85,8 +79,7 @@ void gdc_lut_convert_to_isp_format(const int in_lut[4][HRT_GDC_N], } } -int gdc_get_unity ( -const gdc_ID_t ID ) +int gdc_get_unity (const gdc_ID_t ID ) {assert (ID <N_GDC_ID ); (void )ID ;
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c int gdc_get_unity( · line 92
Quoted 8 lines
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +1
-4@@ -96,10 +89,8 @@ int gdc_get_unity(/* * Local function implementations */ -static inline void gdc_reg_store ( -const gdc_ID_t ID , -const unsigned int reg, -const hrt_data value) +static inline void gdc_reg_store(const gdc_ID_t ID, const unsigned int reg,
^^^^^^^
Replace this tab with a space.
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c int gdc_get_unity( · line 96
Quoted 4 lines
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +1
-0+ const hrt_data value) {ia_css_device_store_uint32 (GDC_BASE [ID ] + reg *sizeof (hrt_data), value);return ;
regards,
dan carpenter
Greg Kroah-Hartman
maintainerQuoted 2 lines · Adrian Barnaś
NFC: This patch cleans up coding style whitespace issues in
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
What does "NFC:" mean?
And take a look at the kernel documentation, it recommends not using stuff like "This patch", but write it in an imperitive mode:
Clean up coding style whitespace issues in...
hope this helps,
greg k-h
Quoted 7 lines · Adrian Barnaś
NFC: This patch cleans up coding style whitespace issues in
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.cFixes include:
- removal of unnecessary line breaks
- correcting spacing around operators
- correcting spaces between types and names
...
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c line 18
Quoted 6 lines
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +2
-4-static inline void gdc_reg_store ( -const gdc_ID_t ID , -const unsigned int reg, -const hrt_data value); +static inline void gdc_reg_store (const gdc_ID_t ID ,const unsigned int reg, +const hrt_data value);
Can you rather refactor code to get rid of the forward declaration?
...
Quoted 1 line
+static inline void gdc_reg_store(const
gdc_ID_tID, const unsigned int reg,
This still is wrong, shouldn't be any tabs here.
Quoted 1 line
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c +1
-0+ const hrt_data value)
Signature · 2 lines
With Best Regards, Andy Shevchenko
A message that is not in the archive (sent off-list or not yet received): CAATBrPGqkuLrVhKi8aj-tugZNVMD3kqv5_v3WB=kJvt4FVtFzw@mail.gmail.com
PATCH 1/1 staging: media: atomisp: Whitespaces style cleanup in gdc.c
Hi Dan, Greg, Andy
Will fix the message and replace the tab I missed. Also will refactor the unnecessary forward declaration.
Thank you for review
Adrian Barnaś