gpiolib: acpi: Add quirk for ASUS ProArt PX13
Subsystems (6)
PATCH 1/2 gpiolib: acpi: Add quirk for ASUS ProArt PX13
The ASUS ProArt PX13 has a spurious wakeup event from the touchpad a few moments after entering hardware sleep. This can be avoided by preventing the touchpad from being a wake source.
Add to the wakeup ignore list.
--- drivers/gpio/gpiolib-acpi-quirks.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/gpio/gpiolib-acpi-quirks.c +14 -0
@@ -344,6 +344,20 @@ static const struct dmi_system_id gpiolib_acpi_quirks[] __initconst = { .ignore_interrupt = "AMDI0030:00@8", }, }, + { + /* + * Spurious wakeups from TP_ATTN# pin + * Found in BIOS 5.35 + * https://gitlab.freedesktop.org/drm/amd/-/issues/4482 + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_PRODUCT_FAMILY, "ProArt PX13"), + }, + .driver_data = &(struct acpi_gpiolib_dmi_quirk) { + .ignore_wake = "ASCP1A00:00@8", + }, + }, {} /* Terminating entry */ };
Signature · 1 line
2.43.0
PATCH 2/2 pinctrl: amd: Add PM debugging message for turning on/off wakes
The GPIOs for devices not in _AEI/_EVT such as touchpad or touchscreen won't have wakeup turned on until the suspend sequence starts.
Due to code in amd_gpio_suspend_hibernate_common() masking the interrupt can make this difficult to follow what's going on. Add an explicit debugging message to tell when that was turned on/off.
--- drivers/pinctrl/pinctrl-amd.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/pinctrl/pinctrl-amd.c +3 -0
@@ -448,6 +448,9 @@ static int amd_gpio_irq_set_wake(struct irq_data *d, unsigned int on)u32 wake_mask =BIT (WAKE_CNTRL_OFF_S0I3 ) |BIT (WAKE_CNTRL_OFF_S3 );int err; +pm_pr_dbg ("Setting wake for GPIO %lu to %s\n" , + d->hwirq,str_enable_disable (on)); +raw_spin_lock_irqsave (&gpio_dev->lock, flags); pin_reg =readl (gpio_dev->base + (d->hwirq)*4 );
Signature · 1 line
2.43.0
Andy Shevchenko
maintainerRe: [PATCH 2/2] pinctrl: amd: Add PM debugging message for turning on/off wakes
Quoted 6 lines · Mario Limonciello (AMD)
The GPIOs for devices not in _AEI/_EVT such as touchpad or touchscreen won't have wakeup turned on until the suspend sequence starts.
Due to code in
amd_gpio_suspend_hibernate_common()masking the interrupt can make this difficult to follow what's going on. Add an explicit debugging message to tell when that was turned on/off.
...
drivers/pinctrl/pinctrl-amd.c static int amd_gpio_irq_set_wake(struct irq_data *d, unsigned int on) · line 452
Quoted 2 lines
drivers/pinctrl/pinctrl-amd.c +2
-0+pm_pr_dbg ("Setting wake for GPIO %lu to %s\n" , + d->hwirq,str_enable_disable (on));
Can you send a follow up to move from dereference to an API for hwirq?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines · Mario Limonciello (AMD)
The ASUS ProArt PX13 has a spurious wakeup event from the touchpad a few moments after entering hardware sleep. This can be avoided by preventing the touchpad from being a wake source.
Add to the wakeup ignore list.
Reported-by Amit Chaudhari <[email protected]>Tested-by Amit Chaudhari <[email protected]>Signed-off-by Mario Limonciello (AMD) <[email protected]>
Quoted 10 lines · Mario Limonciello (AMD)
The ASUS ProArt PX13 has a spurious wakeup event from the touchpad a few moments after entering hardware sleep. This can be avoided by preventing the touchpad from being a wake source.
Add to the wakeup ignore list.
Reported-by Amit Chaudhari <[email protected]>Tested-by Amit Chaudhari <[email protected]>Signed-off-by Mario Limonciello (AMD) <[email protected]>
Bartosz is on vacation and this patch series is half-pinctrl so I applied this and patch 2/2 for pin control fixes.
Yours,
Linus Walleij
Andy Shevchenko
maintainerQuoted 9 lines · Linus Walleij
Quoted 6 lines · Mario Limonciello (AMD)
The ASUS ProArt PX13 has a spurious wakeup event from the touchpad a few moments after entering hardware sleep. This can be avoided by preventing the touchpad from being a wake source.
Add to the wakeup ignore list.
Quoted 7 lines
Quoted 4 lines
Reported-by Amit Chaudhari <[email protected]>Tested-by Amit Chaudhari <[email protected]>Signed-off-by Mario Limonciello (AMD) <[email protected]>Bartosz is on vacation and this patch series is half-pinctrl so I applied this and patch 2/2 for pin control fixes.
I also was on vacation and become to full speed next week. But series is fine, just one nit-pick I commented on, it can be addressed in a separate followup.
Signature · 2 lines
With Best Regards, Andy Shevchenko