usb: chipidea: imx: Add a missing blank line
Subsystems (5)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/3 usb: chipidea: imx: Add a missing blank line
Fix a checkpatch warning:
CHECK: Please use a blank line after function/struct/union/enum declarations
--- drivers/usb/chipidea/usbmisc_imx.c | 1 + 1 file changed, 1 insertion(+)
drivers/usb/chipidea/usbmisc_imx.c +1 -0
@@ -1118,6 +1118,7 @@ static int usbmisc_imx6sx_power_lost_check(struct imx_usbmisc_data *data)else return 0 ; } +static int usbmisc_s32g_power_lost_check (struct imx_usbmisc_data *data) {return 1 ;
Signature · 1 line
2.47.2
Quoted 5 lines · Dan Carpenter
Fix a checkpatch warning:
CHECK: Please use a blank line after function/struct/union/enum declarationsReported-by Xu Yang <[email protected]>Signed-off-by Dan Carpenter <[email protected]>
Peter
Quoted 19 lines
--- drivers/usb/chipidea/usbmisc_imx.c | 1 + 1 file changed, 1 insertion(+)drivers/usb/chipidea/usbmisc_imx.c +1
-0@@ -1118,6 +1118,7 @@ static int usbmisc_imx6sx_power_lost_check(struct imx_usbmisc_data *data)else return 0 ; } +static int usbmisc_s32g_power_lost_check (struct imx_usbmisc_data *data) {return 1 ;Signature · 1 line
2.47.2
Signature · 2 lines
Best regards, Peter
PATCH 2/3 arm64: dts: s32g3: Fix whitespace issue in device tree
In reply to a message not in the archiveCheckpatch points out that this should use spaces instead of tabs. "ERROR: code indent should use tabs where possible".
--- arch/arm64/boot/dts/freescale/s32g3.dtsi | 32 ++++++++++++------------ 1 file changed, 16 insertions(+), 16 deletions(-)
arch/arm64/boot/dts/freescale/s32g3.dtsi +16 -16
@@ -489,22 +489,22 @@ usbmisc: usbmisc@44064200 { reg = <0x44064200 0x200>; }; - usbotg: usb@44064000 { - compatible = "nxp,s32g3-usb", "nxp,s32g2-usb"; - reg = <0x44064000 0x200>; - interrupt-parent = <&gic>; - interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */ - <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */ - clocks = <&clks 94>, <&clks 95>; - fsl,usbmisc = <&usbmisc 0>; - ahb-burst-config = <0x3>; - tx-burst-size-dword = <0x10>; - rx-burst-size-dword = <0x10>; - phy_type = "ulpi"; - dr_mode = "host"; - maximum-speed = "high-speed"; - status = "disabled"; - }; + usbotg: usb@44064000 { + compatible = "nxp,s32g3-usb", "nxp,s32g2-usb"; + reg = <0x44064000 0x200>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */ + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */ + clocks = <&clks 94>, <&clks 95>; + fsl,usbmisc = <&usbmisc 0>; + ahb-burst-config = <0x3>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; + phy_type = "ulpi"; + dr_mode = "host"; + maximum-speed = "high-speed"; + status = "disabled"; + }; i2c0: i2c@401e4000 { compatible = "nxp,s32g3-i2c",
Signature · 1 line
2.47.2
Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree
Quoted 6 lines · Dan Carpenter
Checkpatch points out that this should use spaces instead of tabs. "ERROR: code indent should use tabs where possible".
Quoted 47 lines
--- arch/arm64/boot/dts/freescale/s32g3.dtsi | 32 ++++++++++++------------ 1 file changed, 16 insertions(+), 16 deletions(-)arch/arm64/boot/dts/freescale/s32g3.dtsi +16
-16@@ -489,22 +489,22 @@ usbmisc: usbmisc@44064200 { reg = <0x44064200 0x200>; }; - usbotg: usb@44064000 { - compatible = "nxp,s32g3-usb", "nxp,s32g2-usb"; - reg = <0x44064000 0x200>; - interrupt-parent = <&gic>; - interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */ - <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */ - clocks = <&clks 94>, <&clks 95>; - fsl,usbmisc = <&usbmisc 0>; - ahb-burst-config = <0x3>; - tx-burst-size-dword = <0x10>; - rx-burst-size-dword = <0x10>; - phy_type = "ulpi"; - dr_mode = "host"; - maximum-speed = "high-speed"; - status = "disabled"; - }; + usbotg: usb@44064000 { + compatible = "nxp,s32g3-usb", "nxp,s32g2-usb"; + reg = <0x44064000 0x200>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */ + <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */ + clocks = <&clks 94>, <&clks 95>; + fsl,usbmisc = <&usbmisc 0>; + ahb-burst-config = <0x3>; + tx-burst-size-dword = <0x10>; + rx-burst-size-dword = <0x10>; + phy_type = "ulpi"; + dr_mode = "host"; + maximum-speed = "high-speed"; + status = "disabled"; + }; i2c0: i2c@401e4000 { compatible = "nxp,s32g3-i2c",
Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree
In reply to Dan CarpenterQuoted 7 lines · Dan Carpenter
Checkpatch points out that this should use spaces instead of tabs. "ERROR: code indent should use tabs where possible".
Reported-by Xu Yang <[email protected]>Closes https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ open hereSigned-off-by Dan Carpenter <[email protected]>---
Patches were not merged, so this should be squashed there... or you meant they went with Greg USB? Then no, that's dissapointing, you are not supposed to send DTS patches to Greg's subsystem.
Best regards,
Krzysztof
Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree
Quoted 4 lines · Krzysztof Kozlowski
Quoted 3 lines · Dan Carpenter
Checkpatch points out that this should use spaces instead of tabs. "ERROR: code indent should use tabs where possible".
Quoted 8 lines
Quoted 4 lines
Reported-by Xu Yang <[email protected]>Closes https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ open hereSigned-off-by Dan Carpenter <[email protected]>---
Patches were not merged, so this should be squashed there... or you meant they went with Greg USB? Then no, that's dissapointing, you are not supposed to send DTS patches to Greg's subsystem.
I worry that I have accidentally stepped into politics...
Yes, it went through Greg's tree. I'm just using get_maintainer.pl. Looking at it now, Greg and linux-usb weren't even on the Cc list for the DTS patches. There was probably some b4 magic which let him apply the whole series.
How was this supposed to have worked?
regards,
dan carpenter
Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree
Quoted 10 lines · Dan Carpenter
Quoted 9 lines · Krzysztof Kozlowski
Quoted 7 lines · Dan Carpenter
Checkpatch points out that this should use spaces instead of tabs. "ERROR: code indent should use tabs where possible".
Reported-by Xu Yang <[email protected]>Closes https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/ open hereSigned-off-by Dan Carpenter <[email protected]>---
Quoted 7 lines
Quoted 3 lines
Patches were not merged, so this should be squashed there... or you meant they went with Greg USB? Then no, that's dissapointing, you are not supposed to send DTS patches to Greg's subsystem.
I worry that I have accidentally stepped into politics...
Yes, it went through Greg's tree.
I don't find two DTS patches in v6.17-rc1. I tried to pick them up, but this one doesn't apply. So you may want to resend them.
Quoted 6 lines
I'm just using get_maintainer.pl.
Looking at it now, Greg and linux-usb weren't even on the Cc list for the DTS patches. There was probably some b4 magic which let him apply the whole series.How was this supposed to have worked?
The DTS changes should be sent separately from usb driver ones.
Shawn
Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree
In reply to Dan CarpenterQuoted 7 lines · Dan Carpenter
Yes, it went through Greg's tree. I'm just using get_maintainer.pl. Looking at it now, Greg and linux-usb weren't even on the Cc list for the DTS patches. There was probably some b4 magic which let him apply the whole series.
How was this supposed to have worked?
There are few maintainers who pick up entire patchsets, including DTS. You must not combine DTS into the same patchset targeting such maintainers (Greg, and in the past sometimes watchdog and netdev).
Best regards,
Krzysztof
PATCH 3/3 arm64: dts: s32g2: Re-order usbmisc device tree section
In reply to a message not in the archiveThe compatible line is supposed to be first.
--- arch/arm64/boot/dts/freescale/s32g2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/s32g2.dtsi +1 -1
@@ -424,8 +424,8 @@ spi2: spi@401dc000 { }; usbmisc: usbmisc@44064200 { - #index-cells = <1>; compatible = "nxp,s32g2-usbmisc"; + #index-cells = <1>; reg = <0x44064200 0x200>; };
Signature · 1 line
2.47.2
Re: [PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section
Quoted 5 lines · Dan Carpenter
The compatible line is supposed to be first.
Quoted 18 lines
--- arch/arm64/boot/dts/freescale/s32g2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/freescale/s32g2.dtsi +1
-1@@ -424,8 +424,8 @@ spi2: spi@401dc000 { }; usbmisc: usbmisc@44064200 { - #index-cells = <1>; compatible = "nxp,s32g2-usbmisc"; + #index-cells = <1>; reg = <0x44064200 0x200>; };