drm/xe/svm: Consult madvise preferred location in prefetch
Hello Himal Prasad Ghimiray,
Commit c1bb69a2e8e2 ("drm/xe/svm: Consult madvise preferred location in prefetch") from Aug 21, 2025 (linux-next), leads to the following Smatch static checker warning:
drivers/gpu/drm/xe/xe_vm.c:3175 op_lock_and_prep() error: uninitialized symbol 'region'.
drivers/gpu/drm/xe/xe_vm.c
3125 static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm,
3126 struct xe_vma_op *op)
3127 {
3128 int err = 0;
3129
3130 switch (op->base.op) {
3131 case DRM_GPUVA_OP_MAP:
3132 if (!op->map.invalidate_on_bind)
3133 err = vma_lock_and_validate(exec, op->map.vma,
3134 !xe_vm_in_fault_mode(vm) ||
3135 op->map.immediate);
3136 break;
3137 case DRM_GPUVA_OP_REMAP:
3138 err = check_ufence(gpuva_to_vma(op->base.remap.unmap->va));
3139 if (err)
3140 break;
3141
3142 err = vma_lock_and_validate(exec,
3143 gpuva_to_vma(op->base.remap.unmap->va),
3144 false);
3145 if (!err && op->remap.prev)
3146 err = vma_lock_and_validate(exec, op->remap.prev, true);
3147 if (!err && op->remap.next)
3148 err = vma_lock_and_validate(exec, op->remap.next, true);
3149 break;
3150 case DRM_GPUVA_OP_UNMAP:
3151 err = check_ufence(gpuva_to_vma(op->base.unmap.va));
3152 if (err)
3153 break;
3154
3155 err = vma_lock_and_validate(exec,
3156 gpuva_to_vma(op->base.unmap.va),
3157 false);
3158 break;
3159 case DRM_GPUVA_OP_PREFETCH:
3160 {
3161 struct xe_vma *vma = gpuva_to_vma(op->base.prefetch.va);
3162 u32 region;
3163
3164 if (!xe_vma_is_cpu_addr_mirror(vma)) {
3165 region = op->prefetch.region;
3166 xe_assert(vm->xe, region == DRM_XE_CONSULT_MEM_ADVISE_PREF_LOC ||
3167 region <= ARRAY_SIZE(region_to_mem_type));
3168 }region used to be initialized on the else path as well, but now it's not.
3169
3170 err = vma_lock_and_validate(exec,
3171 gpuva_to_vma(op->base.prefetch.va),
3172 false);
3173 if (!err && !xe_vma_has_no_bo(vma))
3174 err = xe_bo_migrate(xe_vma_bo(vma),
--> 3175 region_to_mem_type[region]);
3176 break;
3177 }
3178 default:
3179 drm_warn(&vm->xe->drm, "NOT POSSIBLE");
3180 }
3181
3182 return err;
3183 }regards,
dan carpenter
Quoted 55 lines · Dan Carpenter
Hello Himal Prasad Ghimiray,
Commit
c1bb69a2e8e2("drm/xe/svm: Consult madvise preferred location in prefetch") from Aug 21, 2025 (linux-next), leads to the following Smatch static checker warning:drivers/gpu/drm/xe/xe_vm.c:3175 op_lock_and_prep() error: uninitialized symbol 'region'.
drivers/gpu/drm/xe/xe_vm.c3125 static int op_lock_and_prep(struct drm_exec *exec, struct xe_vm *vm, 3126 struct xe_vma_op *op) 3127 { 3128 int err = 0; 3129 3130 switch (op->base.op) { 3131 case DRM_GPUVA_OP_MAP: 3132 if (!op->map.invalidate_on_bind) 3133 err = vma_lock_and_validate(exec, op->map.vma, 3134 !xe_vm_in_fault_mode(vm) || 3135 op->map.immediate); 3136 break; 3137 case DRM_GPUVA_OP_REMAP: 3138 err = check_ufence(gpuva_to_vma(op->base.remap.unmap->va)); 3139 if (err) 3140 break; 3141 3142 err = vma_lock_and_validate(exec, 3143 gpuva_to_vma(op->base.remap.unmap->va), 3144 false); 3145 if (!err && op->remap.prev) 3146 err = vma_lock_and_validate(exec, op->remap.prev, true); 3147 if (!err && op->remap.next) 3148 err = vma_lock_and_validate(exec, op->remap.next, true); 3149 break; 3150 case DRM_GPUVA_OP_UNMAP: 3151 err = check_ufence(gpuva_to_vma(op->base.unmap.va)); 3152 if (err) 3153 break; 3154 3155 err = vma_lock_and_validate(exec, 3156 gpuva_to_vma(op->base.unmap.va), 3157 false); 3158 break; 3159 case DRM_GPUVA_OP_PREFETCH: 3160 { 3161 struct xe_vma *vma = gpuva_to_vma(op->base.prefetch.va); 3162 u32 region; 3163 3164 if (!xe_vma_is_cpu_addr_mirror(vma)) { 3165 region = op->prefetch.region; 3166 xe_assert(vm->xe, region == DRM_XE_CONSULT_MEM_ADVISE_PREF_LOC || 3167 region <= ARRAY_SIZE(region_to_mem_type)); 3168 }
Quoted 7 lines
region used to be initialized on the else path as well, but now it's not.
3169 3170 err = vma_lock_and_validate(exec, 3171 gpuva_to_vma(op->base.prefetch.va), 3172 false); 3173 if (!err && !xe_vma_has_no_bo(vma))
This condition can only be reached if (!xe_vma_is_cpu_addr_mirror(vma)) is true hence region is always set here.
can be marked false error.
Quoted 13 lines
3174 err = xe_bo_migrate(xe_vma_bo(vma),
--> 3175 region_to_mem_type[region]); 3176 break; 3177 } 3178 default: 3179 drm_warn(&vm->xe->drm, "NOT POSSIBLE"); 3180 } 3181 3182 return err; 3183 }regards,
dan carpenter