i2c: Main i2c-*.c files and algos/ subdirectory : Fix errors and warnings generated by checkpatch
Subsystems (4)
PATCH 1/1 i2c: Main i2c-*.c files and algos/ subdirectory : Fix errors and warnings generated by checkpatch
Fixed some coding style errors and warnings plus some minor changes in code as reported by checkpatch script. The busses/ and muxes/ subfolders will be dealt with another commit. Main changes were done to comments, defines of 'if' statement, swapping 'unsigned' with 'unsigned int' and other minor changes.
--- drivers/i2c/Kconfig | 2 +- drivers/i2c/algos/i2c-algo-bit.c | 29 +++++++++------ drivers/i2c/algos/i2c-algo-pca.c | 25 +++++++++---- drivers/i2c/algos/i2c-algo-pcf.c | 61 ++++++++++++++++++++++---------- drivers/i2c/algos/i2c-algo-pcf.h | 10 +++--- drivers/i2c/i2c-boardinfo.c | 2 +- drivers/i2c/i2c-core-base.c | 59 +++++++++++++++++++----------- drivers/i2c/i2c-dev.c | 47 ++++++++++++++---------- drivers/i2c/i2c-mux.c | 1 + drivers/i2c/i2c-slave-eeprom.c | 2 +- drivers/i2c/i2c-smbus.c | 2 +- drivers/i2c/i2c-stub.c | 29 +++++++-------- 12 files changed, 170 insertions(+), 99 deletions(-)
drivers/i2c/Kconfig +1 -1
@@ -48,7 +48,7 @@ config I2C_CHARDEV programs use the I2C bus. Information on how to do this is contained in the file <file:Documentation/i2c/dev-interface.rst>. - This support is also available as a module. If so, the module + This support is also available as a module. If so, the module will be called i2c-dev. config I2C_MUX
drivers/i2c/algos/i2c-algo-bit.c +18 -11
@@ -33,12 +33,12 @@/* ----- global variables --------------------------------------------- */ static int bit_test;/* see if the line-setting functions work */ -module_param (bit_test, int,S_IRUGO ); +module_param (bit_test, int,0444 );MODULE_PARM_DESC (bit_test,"lines testing - 0 off; 1 report; 2 fail if stuck" );#ifdef DEBUG static int i2c_debug =1 ; -module_param (i2c_debug, int,S_IRUGO |S_IWUSR ); +module_param (i2c_debug, int,0644 );MODULE_PARM_DESC (i2c_debug,"debug level - 0 off; 1 normal; 2 verbose; 3 very verbose" );#endif
@@ -142,9 +142,12 @@ static void i2c_stop(struct i2c_algo_bit_data *adap) -/* send a byte without start cond., look for arbitration, -check ackn. from slave */ -/* returns: +/* +* send a byte without start cond., look for arbitration, +* check ackn. from slave +*/ +/* +* returns: * 1 if the device acknowledged * 0 if the device did not ack * -ETIMEDOUT if an error occurred (while raising the scl line)
@@ -404,7 +407,7 @@ static int readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msg)int rdcount =0 ;/* counts bytes read */ unsigned char *temp = msg->buf;int count = msg->len; -const unsigned flags = msg->flags; +const unsigned int flags = msg->flags;struct i2c_algo_bit_data *adap = i2c_adap->algo_data;if (!adap->getsda)
@@ -422,8 +425,10 @@ static int readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msg) temp++; count--; -/* Some SMBus transactions require that we receive the -transaction length as the first read byte. */ +/* +* Some SMBus transactions require that we receive the +* transaction length as the first read byte. +*/ if (rdcount ==1 && (flags &I2C_M_RECV_LEN )) {if (inval <=0 || inval >I2C_SMBUS_BLOCK_MAX ) {if (!(flags &I2C_M_NO_RD_ACK ))
@@ -433,9 +438,11 @@ static int readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msg) inval);return -EPROTO ; } -/* The original count value accounts for the extra -bytes, that is, either 1 for a regular transaction, -or 2 for a PEC transaction. */ +/* +* The original count value accounts for the extra +* bytes, that is, either 1 for a regular transaction, +* or 2 for a PEC transaction. +*/ count += inval; msg->len += inval; }
drivers/i2c/algos/i2c-algo-pca.c +18 -7
@@ -14,12 +14,18 @@#include <linux/i2c.h> #include <linux/i2c-algo-pca.h> -#define DEB1(fmt, args...) do { if (i2c_debug >= 1) \ - printk(KERN_DEBUG fmt, ## args); } while (0) -#define DEB2(fmt, args...) do { if (i2c_debug >= 2) \ - printk(KERN_DEBUG fmt, ## args); } while (0) -#define DEB3(fmt, args...) do { if (i2c_debug >= 3) \ - printk(KERN_DEBUG fmt, ## args); } while (0) +#define DEB1(fmt, args...) do { \ + if (i2c_debug >= 1) \ + printk(KERN_DEBUG fmt, ## args); \ + } while (0) +#define DEB2(fmt, args...) do { \ + if (i2c_debug >= 2) \ + printk(KERN_DEBUG fmt, ## args); \ + } while (0) +#define DEB3(fmt, args...) do { \ + if (i2c_debug >= 3) \ + printk(KERN_DEBUG fmt, ## args); \ + } while (0)static int i2c_debug;
@@ -68,6 +74,7 @@ static void pca_reset(struct i2c_algo_pca_data *adap)static int pca_start (struct i2c_algo_pca_data *adap) {int sta =pca_get_con (adap); +DEB2 ("=== START\n" ); sta |=I2C_PCA_CON_STA ; sta &= ~(I2C_PCA_CON_STO |I2C_PCA_CON_SI );
@@ -83,6 +90,7 @@ static int pca_start(struct i2c_algo_pca_data *adap)static int pca_repeated_start (struct i2c_algo_pca_data *adap) {int sta =pca_get_con (adap); +DEB2 ("=== REPEATED START\n" ); sta |=I2C_PCA_CON_STA ; sta &= ~(I2C_PCA_CON_STO |I2C_PCA_CON_SI );
@@ -102,6 +110,7 @@ static int pca_repeated_start(struct i2c_algo_pca_data *adap)static void pca_stop (struct i2c_algo_pca_data *adap) {int sta =pca_get_con (adap); +DEB2 ("=== STOP\n" ); sta |=I2C_PCA_CON_STO ; sta &= ~(I2C_PCA_CON_STA |I2C_PCA_CON_SI );
@@ -139,6 +148,7 @@ static int pca_tx_byte(struct i2c_algo_pca_data *adap, __u8 b) {int sta =pca_get_con (adap); +DEB2 ("=== WRITE %#04x\n" , b);pca_outw (adap,I2C_PCA_DAT , b);
@@ -207,9 +217,10 @@ static int pca_xfer(struct i2c_adapter *i2c_adap,if (i2c_debug >=2 ) {for (curmsg =0 ; curmsg < num; curmsg++) {int addr, i; + msg = &msgs[curmsg]; - addr = (0x7f & msg->addr) ; + addr = (0x7f & msg->addr);if (msg->flags &I2C_M_RD ) printk(KERN_INFO " [%02d] RD %d bytes from %#02x [%#02x, ...]\n",
drivers/i2c/algos/i2c-algo-pcf.c +42 -19
153 lines not on this page · raw message
drivers/i2c/algos/i2c-algo-pcf.h +5 -5
@@ -2,9 +2,9 @@/* -------------------------------------------------------------------- */ /* i2c-pcf8584.h: PCF 8584 global defines */ /* -------------------------------------------------------------------- */ -/* Copyright (C) 1996 Simon G. Vogl -1999 Hans Berglund - +/* Copyright (C) 1996 Simon G. Vogl +* 1999 Hans Berglund +* */ /* -------------------------------------------------------------------- */
@@ -25,7 +25,7 @@#define I2C_PCF_START (I2C_PCF_PIN | I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)#define I2C_PCF_STOP (I2C_PCF_PIN | I2C_PCF_ESO | I2C_PCF_STO | I2C_PCF_ACK) -#define I2C_PCF_REPSTART ( I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK) +#define I2C_PCF_REPSTART (I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)#define I2C_PCF_IDLE (I2C_PCF_PIN | I2C_PCF_ESO | I2C_PCF_ACK)/* ----- Status register bits ----------------------------------------- */
@@ -55,7 +55,7 @@/* ----- Access to internal registers according to ES1,ES2 ------------ */ -/* they are mapped to the data port ( a0 = 0 ) */ +/* they are mapped to the data port ( a0 = 0 ) */ /* available when ESO == 0 : */ #define I2C_PCF_OWNADR 0
drivers/i2c/i2c-boardinfo.c +1 -1
@@ -48,7 +48,7 @@ EXPORT_SYMBOL_GPL(__i2c_first_dynamic_bus_num);* The board info passed can safely be __initdata, but be careful of embedded * pointers (for platform_data, functions, etc) since that won't be copied. */ -int i2c_register_board_info (int busnum,struct i2c_board_info const *info,unsigned len) +int i2c_register_board_info (int busnum,struct i2c_board_info const *info,unsigned int len) {int status;
drivers/i2c/i2c-core-base.c +38 -21
178 lines not on this page · raw message
drivers/i2c/i2c-dev.c +29 -18
114 lines not on this page · raw message
drivers/i2c/i2c-mux.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * Multiplexed I2C bus driver. *
drivers/i2c/i2c-slave-eeprom.c +1 -1
@@ -164,7 +164,7 @@ static int i2c_slave_eeprom_probe(struct i2c_client *client)sysfs_bin_attr_init (&eeprom->bin); eeprom->bin.attr.name ="slave-eeprom" ; - eeprom->bin.attr.mode =S_IRUSR |S_IWUSR ; + eeprom->bin.attr.mode =0600 ; eeprom->bin.read = i2c_slave_eeprom_bin_read; eeprom->bin.write = i2c_slave_eeprom_bin_write; eeprom->bin.size = size;
drivers/i2c/i2c-smbus.c +1 -1
@@ -468,7 +468,7 @@ static void i2c_register_spd(struct i2c_adapter *adap, bool write_disabled)if (!IS_ERR (i2c_new_scanned_device (adap, &info, addr_list,NULL ))) {dev_info (&adap->dev, -"Successfully instantiated SPD at 0x%hx\n" , +"Successfully instantiated SPD at 0x%x\n" , addr_list[0 ]); dimm_count--; }
drivers/i2c/i2c-stub.c +15 -14
@@ -1,11 +1,10 @@// SPDX-License-Identifier: GPL-2.0-or-later /* -i2c-stub.c - I2C/SMBus chip emulator - -Copyright (c) 2004 Mark M. Hoffman <[email protected]> -Copyright (C) 2007-2014 Jean Delvare <[email protected]> - -*/ +* i2c-stub.c - I2C/SMBus chip emulator +* +* Copyright (c) 2004 Mark M. Hoffman <[email protected]> +* Copyright (C) 2007-2014 Jean Delvare <[email protected]> +*/ #define pr_fmt (fmt) "i2c-stub: " fmt
@@ -33,30 +32,30 @@ (STUB_FUNC_DEFAULT | I2C_FUNC_SMBUS_BLOCK_DATA)static unsigned short chip_addr[MAX_CHIPS ]; -module_param_array (chip_addr, ushort,NULL ,S_IRUGO ); +module_param_array (chip_addr, ushort,NULL ,0444 );MODULE_PARM_DESC (chip_addr,"Chip addresses (up to 10, between 0x03 and 0x77)" );static unsigned long functionality =STUB_FUNC_DEFAULT ; -module_param (functionality, ulong,S_IRUGO |S_IWUSR ); +module_param (functionality, ulong,0644 );MODULE_PARM_DESC (functionality,"Override functionality bitfield" );/* Some chips have banked register ranges */ static u8 bank_reg[MAX_CHIPS ]; -module_param_array (bank_reg, byte,NULL ,S_IRUGO ); +module_param_array (bank_reg, byte,NULL ,0444 );MODULE_PARM_DESC (bank_reg,"Bank register" );static u8 bank_mask[MAX_CHIPS ]; -module_param_array (bank_mask, byte,NULL ,S_IRUGO ); +module_param_array (bank_mask, byte,NULL ,0444 );MODULE_PARM_DESC (bank_mask,"Bank value mask" );static u8 bank_start[MAX_CHIPS ]; -module_param_array (bank_start, byte,NULL ,S_IRUGO ); +module_param_array (bank_start, byte,NULL ,0444 );MODULE_PARM_DESC (bank_start,"First banked register" );static u8 bank_end[MAX_CHIPS ]; -module_param_array (bank_end, byte,NULL ,S_IRUGO ); +module_param_array (bank_end, byte,NULL ,0444 );MODULE_PARM_DESC (bank_end,"Last banked register" );struct smbus_block_data {
@@ -68,8 +67,10 @@ struct smbus_block_data {struct stub_chip {u8 pointer; -u16 words[256 ];/* Byte operations use the LSB as per SMBus -specification */ +u16 words[256 ];/* +* Byte operations use the LSB as per SMBus +* specification +*/ struct list_head smbus_blocks;/* For chips with banks, extra registers are allocated dynamically */
Signature · 1 line
2.43.0
Andi Shyti
maintainerHi Cezar,
Quoted 7 lines · Cezar Chiru
Fixed some coding style errors and warnings plus some minor changes in code as reported by checkpatch script. The busses/ and muxes/ subfolders will be dealt with another commit. Main changes were done to comments, defines of 'if' statement, swapping 'unsigned' with 'unsigned int' and other minor changes.
Signed-off-by Cezar Chiru <[email protected]>
Quoted 14 lines
--- drivers/i2c/Kconfig | 2 +- drivers/i2c/algos/i2c-algo-bit.c | 29 +++++++++------ drivers/i2c/algos/i2c-algo-pca.c | 25 +++++++++---- drivers/i2c/algos/i2c-algo-pcf.c | 61 ++++++++++++++++++++++---------- drivers/i2c/algos/i2c-algo-pcf.h | 10 +++--- drivers/i2c/i2c-boardinfo.c | 2 +- drivers/i2c/i2c-core-base.c | 59 +++++++++++++++++++----------- drivers/i2c/i2c-dev.c | 47 ++++++++++++++---------- drivers/i2c/i2c-mux.c | 1 + drivers/i2c/i2c-slave-eeprom.c | 2 +- drivers/i2c/i2c-smbus.c | 2 +- drivers/i2c/i2c-stub.c | 29 +++++++-------- 12 files changed, 170 insertions(+), 99 deletions(-)
first of all, thanks for your patch, but I can't accept it. Please split your patch in several smaller patches with single changes.
Granularity is very important for reviews and git blame.
Thanks,
Andi
Quoted 25 lines · Andi Shyti
Hi Cezar,
Quoted 7 lines · Cezar Chiru
Fixed some coding style errors and warnings plus some minor changes in code as reported by checkpatch script. The busses/ and muxes/ subfolders will be dealt with another commit. Main changes were done to comments, defines of 'if' statement, swapping 'unsigned' with 'unsigned int' and other minor changes.
Signed-off-by Cezar Chiru <[email protected]>Quoted 14 lines
--- drivers/i2c/Kconfig | 2 +- drivers/i2c/algos/i2c-algo-bit.c | 29 +++++++++------ drivers/i2c/algos/i2c-algo-pca.c | 25 +++++++++---- drivers/i2c/algos/i2c-algo-pcf.c | 61 ++++++++++++++++++++++---------- drivers/i2c/algos/i2c-algo-pcf.h | 10 +++--- drivers/i2c/i2c-boardinfo.c | 2 +- drivers/i2c/i2c-core-base.c | 59 +++++++++++++++++++----------- drivers/i2c/i2c-dev.c | 47 ++++++++++++++---------- drivers/i2c/i2c-mux.c | 1 + drivers/i2c/i2c-slave-eeprom.c | 2 +- drivers/i2c/i2c-smbus.c | 2 +- drivers/i2c/i2c-stub.c | 29 +++++++-------- 12 files changed, 170 insertions(+), 99 deletions(-)
Quoted 5 lines
first of all, thanks for your patch, but I can't accept it. Please split your patch in several smaller patches with single changes.
Granularity is very important for reviews and git blame.
Same comment as previous patch: describe testing please
A message that is not in the archive (sent off-list or not yet received): CANvS2vUf=kOdGKTcy8XWz2aO2uHTf7TkF-EQSedMSYE863oFcA@mail.gmail.com
Hello Andi, Wolfram,
Resending email to entire receipients in plain text mode from Gmail client with [email protected] and [email protected] who rejected the email as being not plain mode. I thought maybe you didn't receive it. sorry if I sent twice..
I am new to submitting linux kernel patches. The first patch i submitted "[PATCH] Fix checkpatch.pl warnings and errors in i2c driver directory and subdirectories" was wrong and also missed signed--off--by git signature. Some change i made originally broke the build . I rushed and sent it before I built the kernel and modules. rookie mistake.
But on the second patch I submitted, I built the kernel and modules after i made the changes and fixed the build errors. I activated all i2c external modules and built in modules in the .config under Device Drivers---> I2C in the menuconfig. But didn't tested the kernel on my linux laptop and didn't loaded all the external modules to see if they generate dmesg errors.
I plan to resubmit and break down changes from 1 commit to several commits(patches) as Andi suggested. I will create a commit in git explaining how the patches apply (their order) and this patch can be disregarded. And along with it i will send 1 patch for each i2c file i submit changes for. Also after I commit locally on git the final version of the commits I will create a build with everything under Device Drivers---> I2C menuconfig . Upon success I will locally test the build on my laptop. load manually all external i2c modules and make sure there aren't any dmesg errors and modules are loaded successfully. Other than that I don't own any I2C hardware device that I could test with my laptop.
Wolfram, Andi, if you have other ideas on how i could test the i2c functionality to make sure i don't break anything with my changes please let me know.
I am a newbie to linux kernel development and want to take it slow
with small changes in the beginning and then possibly to grow this in a full time Linux Kernel Developer career.
I will be back to you with next patches by Sunday night. Sorry for the long email but I wanted you to know the whole process I did to submit the patches.
Best regards,
Cezar Chiru
Quoted 48 lines · Cezar Chiru
Hello Andi, Wolfram,
I am new to submitting linux kernel patches. The first patch i submitted "[PATCH] Fix checkpatch.pl warnings and errors in i2c driver directory and subdirectories" was wrong and also missed signed--off--by git signature. Some change i made originally broke the build . I rushed and sent it before I built the kernel and modules. rookie mistake.
But on the second patch I submitted, I built the kernel and modules after i made the changes and fixed the build errors. I activated all i2c external modules and built in modules in the .config under Device Drivers---> I2C in the menuconfig. But didn't tested the kernel on my linux laptop and didn't loaded all the external modules to see if they generate dmesg errors.
I plan to resubmit and break down changes from 1 commit to several commits(patches) as Andi suggested. I will create a commit in git explaining how the patches apply (their order) and this patch can be disregarded. And along with it i will send 1 patch for each i2c file i submit changes for. Also after I commit locally on git the final version of the commits I will create a build with everything under Device Drivers---> I2C menuconfig . Upon success I will locally test the build on my laptop. load manually all external i2c modules and make sure there aren't any dmesg errors and modules are loaded successfully. Other than that I don't own any I2C hardware device that I could test with my laptop. Wolfram, Andi, if you have other ideas on how i could test the i2c functionality to make sure i don't break anything with my changes please let me know.
I am a newbie to linux kernel development and want to take it slow with small changes in the beginning and then possibly to grow this in a full time Linux Kernel Developer career.Best regards,
Cezar ChiruQuoted 35 lines · Wolfram Sang
Quoted 25 lines · Andi Shyti
Hi Cezar,
Quoted 7 lines · Cezar Chiru
Fixed some coding style errors and warnings plus some minor changes in code as reported by checkpatch script. The busses/ and muxes/ subfolders will be dealt with another commit. Main changes were done to comments, defines of 'if' statement, swapping 'unsigned' with 'unsigned int' and other minor changes.
Signed-off-by Cezar Chiru <[email protected]>Quoted 14 lines
--- drivers/i2c/Kconfig | 2 +- drivers/i2c/algos/i2c-algo-bit.c | 29 +++++++++------ drivers/i2c/algos/i2c-algo-pca.c | 25 +++++++++---- drivers/i2c/algos/i2c-algo-pcf.c | 61 ++++++++++++++++++++++---------- drivers/i2c/algos/i2c-algo-pcf.h | 10 +++--- drivers/i2c/i2c-boardinfo.c | 2 +- drivers/i2c/i2c-core-base.c | 59 +++++++++++++++++++----------- drivers/i2c/i2c-dev.c | 47 ++++++++++++++---------- drivers/i2c/i2c-mux.c | 1 + drivers/i2c/i2c-slave-eeprom.c | 2 +- drivers/i2c/i2c-smbus.c | 2 +- drivers/i2c/i2c-stub.c | 29 +++++++-------- 12 files changed, 170 insertions(+), 99 deletions(-)Quoted 5 lines
first of all, thanks for your patch, but I can't accept it. Please split your patch in several smaller patches with single changes.
Granularity is very important for reviews and git blame.
Same comment as previous patch: describe testing please
Andi Shyti
maintainerHi Cezar,
I think your first email reached everyone.
Quoted 18 lines · Cezar Chiru
I am new to submitting linux kernel patches. The first patch i submitted " [PATCH] Fix checkpatch.pl warnings and errors in i2c driver directory and subdirectories" was wrong and also missed signed--off--by git signature. Some change i made originally broke the build . I rushed and sent it before I built the kernel and modules. rookie mistake.
But on the second patch I submitted, I built the kernel and modules after i made the changes and fixed the build errors. I activated all i2c external modules and built in modules in the .config under Device Drivers---> I2C in the menuconfig. But didn't tested the kernel on my linux laptop and didn't loaded all the external modules to see if they generate dmesg errors.
I plan to resubmit and break down changes from 1 commit to several commits (patches) as Andi suggested. I will create a commit in git explaining how the patches apply (their order) and this patch can be disregarded. And along with it i will send 1 patch for each i2c file i submit changes for. Also after I commit locally on git the final version of the commits I will create a build with everything under Device Drivers---> I2C menuconfig . Upon success I will locally test the build on my laptop. load manually all external i2c modules and make sure there aren't any dmesg errors and modules are loaded successfully.
Quoted 8 lines
Other than that I don't own any I2C hardware device that I could test with my laptop.
Wolfram, Andi, if you have other ideas on how i could test the i2c functionality to make sure i don't break anything with my changes please let me know.
I am a newbie to linux kernel development and want to take it slow with small changes in the beginning and then possibly to grow this in a full time Linux Kernel Developer career.
First of all, welcome to the community, any effort is appreciated.
Start small: one file at a time. Some files are affected by different kind of checkpatch issues, split them in separate patches.
Before sending a patch make sure that everything builds (if it doesn't maintainers don't like it) and that checkpatch doesn't provide errors and warnings.
Woflram asked you how you tested your changes and this is the major challenge. On one hand I can accept obvious changes, but for major refactorings, I will require the changes to be tested. I'm sure you can ask for help for further testing on some drivers.
Finally make sure you have skimmed through the guidelines:
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html
https://kernelnewbies.org/KernelHacking
https://www.ietf.org/rfc/rfc1855.txt
The latter tells how to properly write email.
Andi
Quoted 26 lines · Wolfram Sang
Quoted 25 lines · Andi Shyti
Hi Cezar,
Quoted 21 lines · Cezar Chiru
Fixed some coding style errors and warnings plus some minor changes in code as reported by checkpatch script. The busses/ and muxes/ subfolders will be dealt with another commit. Main changes were done to comments, defines of 'if' statement, swapping 'unsigned' with 'unsigned int' and other minor changes.
Signed-off-by Cezar Chiru <[email protected]>--- drivers/i2c/Kconfig | 2 +- drivers/i2c/algos/i2c-algo-bit.c | 29 +++++++++------ drivers/i2c/algos/i2c-algo-pca.c | 25 +++++++++---- drivers/i2c/algos/i2c-algo-pcf.c | 61 ++++++++++++++++++++++---------- drivers/i2c/algos/i2c-algo-pcf.h | 10 +++--- drivers/i2c/i2c-boardinfo.c | 2 +- drivers/i2c/i2c-core-base.c | 59 +++++++++++++++++++----------- drivers/i2c/i2c-dev.c | 47 ++++++++++++++---------- drivers/i2c/i2c-mux.c | 1 + drivers/i2c/i2c-slave-eeprom.c | 2 +- drivers/i2c/i2c-smbus.c | 2 +- drivers/i2c/i2c-stub.c | 29 +++++++-------- 12 files changed, 170 insertions(+), 99 deletions(-)
Quoted 8 lines
Quoted 5 lines
first of all, thanks for your patch, but I can't accept it. Please split your patch in several smaller patches with single changes.
Granularity is very important for reviews and git blame.
Same comment as previous patch: describe testing please
Hello Andi, Wolfram,
Resending email to entire receipients in plain text mode from my mutt
client with [email protected] and [email protected]
as my initial reply was rejected because of Gmail client being not in plain mode. I thought maybe you didn't receive it. sorry if I sent twice or three times the same message .
I am new to submitting linux kernel patches. The first patch i submitted "[PATCH] Fix checkpatch.pl warnings and errors in i2c driver directory and subdirectories" was wrong and also missed signed--off--by git signature. Some change i made originally broke the build . I rushed and sent it before I built the kernel and modules. rookie mistake.
But on the second patch I submitted, I built the kernel and modules after i made the changes and fixed the build errors. I activated all i2c external modules and built in modules in the .config under Device Drivers---> I2C in the menuconfig. But didn't tested the kernel on my linux laptop and didn't loaded all the external modules to see if they generate dmesg errors.
I plan to resubmit and break down changes from 1 commit to several commits(patches) as Andi suggested. I will create a commit in git explaining how the patches apply (their order) and this patch can be disregarded. And along with it i will send 1 patch for each i2c file i submit changes for. Also after I commit locally on git the final version of the commits I will create a build with everything under Device Drivers---> I2C menuconfig activated. Upon success I will locally test the build on my laptop. load manually all external i2c modules and make sure there aren't any dmesg errors and modules are loaded successfully. Other than that I don't own any I2C hardware device that I could test with my laptop.
Wolfram, Andi, if you have other ideas on how i could test the i2c functionality to make sure i don't break anything with my changes please let me know.
I am a newbie to linux kernel development and want to take it slow
with small changes in the beginning and then possibly to grow this in a full time Linux Kernel Developer career.
I will be back to you with next patches by Sunday night this week. Sorry for the long email but I wanted you to know the whole process I did to submit the patches.
Best regards,
Cezar Chiru