Skip to contentSkip to conversation

mtd: Add driver for concatenating devices

bug report Dan Carpenter 1 participant 1 message Sep 11, 2025 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hello Amit Kumar Mahapatra,

Commit fa47dc829519 ("mtd: Add driver for concatenating devices") from Jun 23, 2025 (linux-next), leads to the following Smatch static checker warnings:

drivers/media/pci/cobalt/cobalt-flash.c:114 cobalt_flash_remove() warn: passing freed memory 'cobalt->mtd' (line 113) drivers/mtd/devices/block2mtd.c:523 block2mtd_exit() warn: 'dev->mtd.name' double freed drivers/mtd/devices/docg3.c:1882 doc_release_device() error: double free of 'mtd' (line 1879) drivers/mtd/devices/mtdram.c:119 cleanup_mtdram() error: dereferencing freed memory 'mtd_info' (line 118) drivers/mtd/devices/phram.c:120 unregister_devices() error: double free of 'this->mtd.name' (line 118) drivers/mtd/devices/pmc551.c:839 cleanup_pmc551() error: double free of 'mtd' (line 838) drivers/mtd/devices/slram.c:206 unregister_devices() error: dereferencing freed memory 'slram_mtdlist->mtdinfo' (line 205) drivers/mtd/hyperbus/hyperbus-core.c:133 hyperbus_unregister_device() warn: passing freed memory 'hbdev->mtd' (line 132) drivers/mtd/maps/amd76xrom.c:87 amd76xrom_cleanup() warn: passing freed memory 'map->mtd' (line 86) drivers/mtd/maps/ck804xrom.c:99 ck804xrom_cleanup() warn: passing freed memory 'map->mtd' (line 98) drivers/mtd/maps/esb2rom.c:133 esb2rom_cleanup() warn: passing freed memory 'map->mtd' (line 132) drivers/mtd/maps/ichxrom.c:74 ichxrom_cleanup() warn: passing freed memory 'map->mtd' (line 73) drivers/mtd/maps/l440gx.c:157 cleanup_l440gx() warn: 'mymtd' was already freed. (line 156) drivers/mtd/maps/netsc520.c:114 cleanup_netsc520() warn: 'mymtd' was already freed. (line 113) drivers/mtd/maps/nettel.c:410 nettel_init() warn: 'intel_mtd' was already freed. (line 408) drivers/mtd/maps/nettel.c:431 nettel_cleanup() warn: 'amd_mtd' was already freed. (line 430) drivers/mtd/maps/nettel.c:444 nettel_cleanup() warn: 'intel_mtd' was already freed. (line 443) drivers/mtd/maps/pci.c:311 mtd_pci_remove() warn: 'mtd' was already freed. (line 310) drivers/mtd/maps/pcmciamtd.c:662 pcmciamtd_detach() error: dereferencing freed memory 'dev->mtd_info' (line 661) drivers/mtd/maps/physmap-core.c:78 physmap_flash_remove() warn: passing freed memory 'info->cmtd' (line 75) drivers/mtd/maps/plat-ram.c:79 platram_remove() warn: passing freed memory 'info->mtd' (line 78) drivers/mtd/maps/sbc_gxx.c:174 cleanup_sbc_gxx() warn: 'all_mtd' was already freed. (line 173) drivers/mtd/maps/sc520cdp.c:274 cleanup_sc520cdp() warn: 'merged_mtd' was already freed. (line 273) drivers/mtd/maps/scb2_flash.c:183 scb2_flash_probe() warn: passing freed memory 'scb2_mtd' (line 182) drivers/mtd/maps/scb2_flash.c:208 scb2_flash_remove() warn: passing freed memory 'scb2_mtd' (line 207) drivers/mtd/maps/ts5500_flash.c:93 cleanup_ts5500_map() warn: 'mymtd' was already freed. (line 92) drivers/mtd/mtd_virt_concat.c:78 mtd_virt_concat_destroy_joins() error: dereferencing freed memory 'mtd' (line 77) drivers/mtd/nand/onenand/onenand_base.c:4020 onenand_release() error: dereferencing freed memory 'mtd' (line 4003) drivers/mtd/nand/raw/ams-delta.c:412 gpio_nand_remove() warn: 'mtd' was already freed. (line 410) drivers/mtd/ubi/gluebi.c:371 gluebi_remove() error: dereferencing freed memory 'mtd' (line 369) drivers/mtd/ubi/gluebi.c:487 ubi_gluebi_exit() error: dereferencing freed memory 'mtd' (line 485)

drivers/media/pci/cobalt/cobalt-flash.c

    110 void cobalt_flash_remove(struct cobalt *cobalt)
    111 {
    112         if (cobalt->mtd) {
    113                 mtd_device_unregister(cobalt->mtd);

--> 114 map_destroy(cobalt->mtd);

This is a use after free and a double free etc.

    115         }
    116 }

The problem is that mtd_virt_concat_destroy() frees the mtd.

drivers/mtd/mtdcore.c

    91  int mtd_virt_concat_destroy(struct mtd_info *mtd)
    92  {
    93          struct mtd_info *child, *master = mtd_get_master(mtd);
    94          struct mtd_virt_concat_node *item, *tmp;
    95          struct mtd_concat *concat;
    96          int idx, ret = 0;
    97          bool is_mtd_found;
    98  
    99          list_for_each_entry_safe(item, tmp, &concat_node_list, head) {
   100                  is_mtd_found = false;
   101  
   102                  /* Find the concat item that hold the mtd device */
   103                  for (idx = 0; idx < item->count; idx++) {
   104                          if (item->nodes[idx] == mtd->dev.of_node) {
   105                                  is_mtd_found = true;
   106                                  break;
   107                          }
   108                  }
   109                  if (!is_mtd_found)
   110                          continue;
   111                  concat = item->concat;
   112  
   113                  /*
   114                   * Since this concatenated device is being removed, retrieve
   115                   * all MTD devices that are part of it and register them
   116                   * individually.
   117                   */
   118                  for (idx = 0; idx < concat->num_subdev; idx++) {
   119                          child = concat->subdev[idx];
   120                          if (child->dev.of_node != mtd->dev.of_node) {
   121                                  ret = add_mtd_device(child);
   122                                  if (ret)
   123                                          goto out;
   124                          }
   125                  }
   126                  /* Destroy the concat */
   127                  if (concat->mtd.name) {
   128                          del_mtd_device(&concat->mtd);
   129                          kfree(concat->mtd.name);
   130                          mtd_concat_destroy(&concat->mtd);
   131                          mtd_virt_concat_put_mtd_devices(item->concat);
   132                  }
   133  
   134                  for (idx = 0; idx < item->count; idx++)
   135                          of_node_put(item->nodes[idx]);
   136  
   137                  kfree(item->nodes);
   138                  kfree(item);
   139          }
   140          return 0;
   141  out:
   142          mutex_lock(&master->master.partitions_lock);
   143          list_del(&child->part.node);
   144          mutex_unlock(&master->master.partitions_lock);
   145          kfree(mtd->name);
   146          kfree(mtd);
                ^^^^^^^^^^

147
148 return ret;
149 }

regards,
dan carpenter