Skip to contentSkip to conversation

Initial support for Qualcomm Hamoa IOT EVK board

PATCH Superseded Yijie Yang 5 participants 24 messages Sep 10, 2025 – Sep 16, 2025

Subsystems (3)

v11 of 12 Superseded Latest is v12 →

lore
Share & tools
lore

Yijie Yang

author
#0 lore raw

v11 cover Initial support for Qualcomm Hamoa IOT EVK board

Introduce the device tree, DT bindings, and driver modifications required to bring up the HAMOA-IOT-EVK evaluation board—based on the X1E80100 SoC—to a UART shell.
This patch set focuses on two key hardware components: the HAMOA-IOT-SOM and the HAMOA-IOT-EVK carrier board.
The HAMOA-IOT-SOM is a compact System on Module that integrates the SoC, GPIOs, and PMICs. It is designed to be modular and can be paired with various carrier boards to support different use cases.
The HAMOA-IOT-EVK is one such carrier board, designed for IoT scenarios. It provides essential peripherals such as UART, on-board PMICs, and USB-related components.
Together, these components form a flexible and scalable platform, and this patch set enables their initial bring-up through proper device tree configuration and driver support.

Qualcomm SoCs often have multiple product variants, each identified by a different SoC ID. For instance, the x1e80100 SoC has closely related variants such as x1e78100 and x1e001de. This diversity in SoC identifiers can lead to confusion and unnecessary maintenance complexity in the device tree and related subsystems.
To address this, code names offer a more consistent and project-agnostic way to represent SoC families. They tend to remain stable across development efforts.
This patch series introduces "hamoa" as the codename for the x1e80100 SoC. Going forward, all x1e80100-related variants—including x1e81000 and others in the same family—will be represented under the "hamoa" designation in the device tree.
This improves readability, streamlines future maintenance, and aligns with common naming practices across Qualcomm-based platforms.

Features added and enabled:
- UART
- On-board regulators
- Regulators on the SOM
- PMIC GLINK
- USB0 through USB6 and their PHYs
- Embedded USB (eUSB) repeaters
- USB Type-C mux
- PCIe6a and its PHY
- PCIe4 and its PHY
- Reserved memory regions
- Pinctrl
- NVMe
- ADSP, CDSP
- WLAN, Bluetooth (M.2 interface)
- USB DisplayPort
- Graphic
- Audio
- Video

Depends on the following change to ensure compliance with the Device Tree schema:
https://lore.kernel.org/linux-arm-msm/[email protected]/

---
Changes in v11:
- Update the high-speed PHY repeater for the USB MP to the correct one.
- Update base commit.
- Format the audio-routing property and the i2c5 device node.
- Link to v10: https://lore.kernel.org/r/[email protected]

Changes in v10:
- Update the commit description.
- Remove the redundant space in 'stdout-path'.
- Move GPU nodes to the SoM's .dtsi file.
- Integrate the changes that enable video support into this patch series.
- Link to v9: https://lore.kernel.org/r/[email protected]

Changes in v9:
- Sort the nodes within the root node in alphabetical order.
- Add WLAN control pin to the PMU.
- Link to v8: https://lore.kernel.org/r/[email protected]

Changes in v8:
- Change the style of how collaborators are listed.
- Link to v7: https://lore.kernel.org/r/[email protected]

Changes in v7:
- Configure the EDP regulator to boot-on.
- Change back to a year‑less copyright statement.
- Update base commit.
- Link to v6: https://lore.kernel.org/r/[email protected]

Changes in v6:
- Restore the full change log for each revision.
- Merge the changes related to Audio and Graphics into the patch series.
- Link to v5: https://lore.kernel.org/r/[email protected]

Changes in v5:
- Update base commit.
- Drop an already merged patch:
https://lore.kernel.org/all/[email protected]/
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Update commit messages.
- Update base commit.
- Update the format of the node mdss_dp3_out.
- Add comments to clarify certain nodes.
- Update the configuration of regulator-wcn-3p3 from regulator-boot-on to regulator-always-on.
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Add compatible string and dt-bindings for SOM.
- Restore PMU-related regulators to comply with dt-binding rules and enable kernel-level power management.
- Adjust commit description accordingly.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Merge the compatible rules and remove the compatible string map.
- Align the ADSP and CDSP firmware paths with other x1e80100 platforms.
- Remove the regulators on the M.2 card, as well as those managed by UEFI on this board.
- Merge another patch series that enables USB DisplayPort functionality on this platform: https://lore.kernel.org/all/[email protected]/
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Wangao Wang (1):

      arm64: dts: qcom: x1e80100: add video node

Yijie Yang (3):
dt-bindings: arm: qcom: Document HAMOA-IOT-EVK board
arm64: dts: qcom: Add HAMOA-IOT-SOM platform
arm64: dts: qcom: Add base HAMOA-IOT-EVK board

 Documentation/devicetree/bindings/arm/qcom.yaml |    6 +
 arch/arm64/boot/dts/qcom/Makefile               |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts      | 1221 +++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi     |  621 ++++++++++++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi          |   82 ++
 5 files changed, 1931 insertions(+)

---
base-commit: c62a516303b963817a9d008c432013b18581997e
change-id: 20250604-hamoa_initial-0cd7036d7271
prerequisite-message-id: <[email protected]>
prerequisite-patch-id: 037bb113706198fca6a87000e46907bc23f9d7e2

Best regards,

Signature · 1 line
Yijie Yang <[email protected]>
author
#1 lore raw

PATCH v11 1/4 dt-bindings: arm: qcom: Document HAMOA-IOT-EVK board

Document the device tree binding for the HAMOA-IOT-EVK board, which uses the Qualcomm X1E80100 SoC.

The EVK consists of a carrier board and a modular System-on-Module (SoM). The SoM integrates the SoC, PMICs, and essential GPIOs, while the EVK carrier board provides additional peripherals such as UART and USB interfaces.

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/qcom.yaml +6 -0
index 7d47d0c04376..d03084cb0e52 100644
@@ -1073,6 +1073,12 @@ properties:
               - qcom,x1e80100-qcp
           - const: qcom,x1e80100
 
+      - items:
+          - enum:
+              - qcom,hamoa-iot-evk
+          - const: qcom,hamoa-iot-som
+          - const: qcom,x1e80100
+
       - items:
           - enum:
               - asus,zenbook-a14-ux3407qa
Signature · 1 line
2.34.1
author
#2 lore raw

PATCH v11 2/4 arm64: dts: qcom: x1e80100: add video node

In reply to Yijie Yang

From: Wangao Wang <[email protected]>

Add the IRIS video-codec node on X1E80100 platform to support video functionality.

---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 82 ++++++++++++++++++++++++++++++++++
 1 file changed, 82 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100.dtsi +82 -0
index 737c5dbd1c80..4a450738b695 100644
@@ -5186,6 +5186,88 @@ usb_1_ss1_dwc3_ss: endpoint {
 			};
 		};
 
+		iris: video-codec@aa00000 {
+			compatible = "qcom,x1e80100-iris", "qcom,sm8550-iris";
+
+			reg = <0x0 0x0aa00000 0x0 0xf0000>;
+			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+
+			power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>,
+					<&videocc VIDEO_CC_MVS0_GDSC>,
+					<&rpmhpd RPMHPD_MXC>,
+					<&rpmhpd RPMHPD_MMCX>;
+			power-domain-names = "venus",
+					     "vcodec0",
+					     "mxc",
+					     "mmcx";
+			operating-points-v2 = <&iris_opp_table>;
+
+			clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
+				 <&videocc VIDEO_CC_MVS0C_CLK>,
+				 <&videocc VIDEO_CC_MVS0_CLK>;
+			clock-names = "iface",
+				      "core",
+				      "vcodec0_core";
+
+			interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+					 &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
+					<&mmss_noc MASTER_VIDEO QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+			interconnect-names = "cpu-cfg",
+					     "video-mem";
+
+			memory-region = <&video_mem>;
+
+			resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
+			reset-names = "bus";
+
+			iommus = <&apps_smmu 0x1940 0x0>,
+				 <&apps_smmu 0x1947 0x0>;
+			dma-coherent;
+
+			status = "disabled";
+
+			iris_opp_table: opp-table {
+				compatible = "operating-points-v2";
+
+				opp-192000000 {
+					opp-hz = /bits/ 64 <192000000>;
+					required-opps = <&rpmhpd_opp_low_svs_d1>,
+							<&rpmhpd_opp_low_svs_d1>;
+				};
+
+				opp-240000000 {
+					opp-hz = /bits/ 64 <240000000>;
+					required-opps = <&rpmhpd_opp_low_svs>,
+							<&rpmhpd_opp_low_svs>;
+				};
+
+				opp-338000000 {
+					opp-hz = /bits/ 64 <338000000>;
+					required-opps = <&rpmhpd_opp_svs>,
+							<&rpmhpd_opp_svs>;
+				};
+
+				opp-366000000 {
+					opp-hz = /bits/ 64 <366000000>;
+					required-opps = <&rpmhpd_opp_svs_l1>,
+							<&rpmhpd_opp_svs_l1>;
+				};
+
+				opp-444000000 {
+					opp-hz = /bits/ 64 <444000000>;
+					required-opps = <&rpmhpd_opp_nom>,
+							<&rpmhpd_opp_nom>;
+				};
+
+				opp-481000000 {
+					opp-hz = /bits/ 64 <481000000>;
+					required-opps = <&rpmhpd_opp_turbo>,
+							<&rpmhpd_opp_turbo>;
+				};
+			};
+		};
+
 		videocc: clock-controller@aaf0000 {
 			compatible = "qcom,x1e80100-videocc";
 			reg = <0 0x0aaf0000 0 0x10000>;
Signature · 1 line
2.34.1
#3 lore raw

Re: [PATCH v11 2/4] arm64: dts: qcom: x1e80100: add video node

Quoted 64 lines · YijieYang

From: Wangao Wang <[email protected]>

Add the IRIS video-codec node on X1E80100 platform to support video functionality.

---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 82 ++++++++++++++++++++++++++++++++++
 1 file changed, 82 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100.dtsi +44 -0
index 737c5dbd1c80..4a450738b695 100644
@@ -5186,6 +5186,88 @@ usb_1_ss1_dwc3_ss: endpoint {
 			};
 		};
 
+		iris: video-codec@aa00000 {
+			compatible = "qcom,x1e80100-iris", "qcom,sm8550-iris";
+
+			reg = <0x0 0x0aa00000 0x0 0xf0000>;
+			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+
+			power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>,
+					<&videocc VIDEO_CC_MVS0_GDSC>,
+					<&rpmhpd RPMHPD_MXC>,
+					<&rpmhpd RPMHPD_MMCX>;
+			power-domain-names = "venus",
+					     "vcodec0",
+					     "mxc",
+					     "mmcx";
+			operating-points-v2 = <&iris_opp_table>;
+
+			clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
+				 <&videocc VIDEO_CC_MVS0C_CLK>,
+				 <&videocc VIDEO_CC_MVS0_CLK>;
+			clock-names = "iface",
+				      "core",
+				      "vcodec0_core";
+
+			interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+					 &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
+					<&mmss_noc MASTER_VIDEO QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+			interconnect-names = "cpu-cfg",
+					     "video-mem";
+
+			memory-region = <&video_mem>;
+
+			resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
+			reset-names = "bus";
+
+			iommus = <&apps_smmu 0x1940 0x0>,
+				 <&apps_smmu 0x1947 0x0>;
+			dma-coherent;
+
+			status = "disabled";
+
+			iris_opp_table: opp-table {
+				compatible = "operating-points-v2";
+

arch/arm64/boot/dts/qcom/x1e80100.dtsi usb_1_ss1_dwc3_ss: endpoint { · line 5242

Quoted 10 lines
arch/arm64/boot/dts/qcom/x1e80100.dtsi +10 -0
+				opp-192000000 {
+					opp-hz = /bits/ 64 <192000000>;
+					required-opps = <&rpmhpd_opp_low_svs_d1>,
+							<&rpmhpd_opp_low_svs_d1>;
+				};
+
+				opp-240000000 {
+					opp-hz = /bits/ 64 <240000000>;
+					required-opps = <&rpmhpd_opp_low_svs>,
+							<&rpmhpd_opp_low_svs>;

You need &rpmhpd_opp_svs here for one of the OPPs, because this describes not just the requirements for the derived clocks but also the requirements for the PLL itself. sm8550.dtsi has the same.

I didn't realize that you sent a DT patch for qcom,x1e80100-iris, so I sent my own patch yesterday [1] that was just waiting for the dt-bindings to land in linux-next.

Have you talked to your colleagues in the video team before submitting this patch? I'm pretty sure they could have pointed that out during internal review. They also have access to my patch (which has been shared in a public branch for over a year now) and knew I was going to send it as soon as the binding lands in linux-next. I just wish we could have coordinated this better to avoid the duplicate work. :/

I suggest that you add a dependency on my patch series or postpone enabling IRIS support for a follow up patch, it's better to have it separate from a new board addition.

Thanks,
Stephan

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

author
#4 lore raw

Re: [PATCH v11 2/4] arm64: dts: qcom: x1e80100: add video node

Quoted 91 lines · Stephan Gerhold
Quoted 64 lines · YijieYang

From: Wangao Wang <[email protected]>

Add the IRIS video-codec node on X1E80100 platform to support video functionality.

---
  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 82 ++++++++++++++++++++++++++++++++++
  1 file changed, 82 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100.dtsi +44 -0
index 737c5dbd1c80..4a450738b695 100644
@@ -5186,6 +5186,88 @@ usb_1_ss1_dwc3_ss: endpoint {
  			};
  		};
 
+		iris: video-codec@aa00000 {
+			compatible = "qcom,x1e80100-iris", "qcom,sm8550-iris";
+
+			reg = <0x0 0x0aa00000 0x0 0xf0000>;
+			interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+
+			power-domains = <&videocc VIDEO_CC_MVS0C_GDSC>,
+					<&videocc VIDEO_CC_MVS0_GDSC>,
+					<&rpmhpd RPMHPD_MXC>,
+					<&rpmhpd RPMHPD_MMCX>;
+			power-domain-names = "venus",
+					     "vcodec0",
+					     "mxc",
+					     "mmcx";
+			operating-points-v2 = <&iris_opp_table>;
+
+			clocks = <&gcc GCC_VIDEO_AXI0_CLK>,
+				 <&videocc VIDEO_CC_MVS0C_CLK>,
+				 <&videocc VIDEO_CC_MVS0_CLK>;
+			clock-names = "iface",
+				      "core",
+				      "vcodec0_core";
+
+			interconnects = <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+					 &config_noc SLAVE_VENUS_CFG QCOM_ICC_TAG_ACTIVE_ONLY>,
+					<&mmss_noc MASTER_VIDEO QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+			interconnect-names = "cpu-cfg",
+					     "video-mem";
+
+			memory-region = <&video_mem>;
+
+			resets = <&gcc GCC_VIDEO_AXI0_CLK_ARES>;
+			reset-names = "bus";
+
+			iommus = <&apps_smmu 0x1940 0x0>,
+				 <&apps_smmu 0x1947 0x0>;
+			dma-coherent;
+
+			status = "disabled";
+
+			iris_opp_table: opp-table {
+				compatible = "operating-points-v2";
+

arch/arm64/boot/dts/qcom/x1e80100.dtsi usb_1_ss1_dwc3_ss: endpoint { · line 5242

Quoted 10 lines
arch/arm64/boot/dts/qcom/x1e80100.dtsi +10 -0
+				opp-192000000 {
+					opp-hz = /bits/ 64 <192000000>;
+					required-opps = <&rpmhpd_opp_low_svs_d1>,
+							<&rpmhpd_opp_low_svs_d1>;
+				};
+
+				opp-240000000 {
+					opp-hz = /bits/ 64 <240000000>;
+					required-opps = <&rpmhpd_opp_low_svs>,
+							<&rpmhpd_opp_low_svs>;

You need &rpmhpd_opp_svs here for one of the OPPs, because this describes not just the requirements for the derived clocks but also the requirements for the PLL itself. sm8550.dtsi has the same.

I didn't realize that you sent a DT patch for qcom,x1e80100-iris, so I sent my own patch yesterday [1] that was just waiting for the dt-bindings to land in linux-next.

Have you talked to your colleagues in the video team before submitting this patch? I'm pretty sure they could have pointed that out during internal review. They also have access to my patch (which has been shared in a public branch for over a year now) and knew I was going to send it as soon as the binding lands in linux-next. I just wish we could have coordinated this better to avoid the duplicate work. :/

Quoted 8 lines

I suggest that you add a dependency on my patch series or postpone enabling IRIS support for a follow up patch, it's better to have it separate from a new board addition.

Thanks,
Stephan

[1]: https://lore.kernel.org/linux-arm-msm/[email protected]/

You're right. I checked with my colleagues, and I’ll remove it from my patch series and list yours as a dependency.

Signature · 2 lines
Best Regards,
Yijie
author
#5 lore raw

PATCH v11 3/4 arm64: dts: qcom: Add HAMOA-IOT-SOM platform

In reply to Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

---
 arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
 1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +621 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+	compatible = "hamoa-iot-som", "qcom,x1e80100";
+
+	reserved-memory {
+		linux,cma {
+			compatible = "shared-dma-pool";
+			size = <0x0 0x8000000>;
+			reusable;
+			linux,cma-default;
+		};
+	};
+};
+
+&apps_rsc {
+	/* PMC8380C_B */
+	regulators-0 {
+		compatible = "qcom,pm8550-rpmh-regulators";
+		qcom,pmic-id = "b";
+
+		vdd-bob1-supply = <&vph_pwr>;
+		vdd-bob2-supply = <&vph_pwr>;
+		vdd-l1-l4-l10-supply = <&vreg_s4c_1p8>;
+		vdd-l2-l13-l14-supply = <&vreg_bob1>;
+		vdd-l5-l16-supply = <&vreg_bob1>;
+		vdd-l6-l7-supply = <&vreg_bob2>;
+		vdd-l8-l9-supply = <&vreg_bob1>;
+		vdd-l12-supply = <&vreg_s5j_1p2>;
+		vdd-l15-supply = <&vreg_s4c_1p8>;
+		vdd-l17-supply = <&vreg_bob2>;
+
+		vreg_bob1: bob1 {
+			regulator-name = "vreg_bob1";
+			regulator-min-microvolt = <3008000>;
+			regulator-max-microvolt = <3960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_bob2: bob2 {
+			regulator-name = "vreg_bob2";
+			regulator-min-microvolt = <2504000>;
+			regulator-max-microvolt = <3008000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1b_1p8: ldo1 {
+			regulator-name = "vreg_l1b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2b_3p0: ldo2 {
+			regulator-name = "vreg_l2b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l4b_1p8: ldo4 {
+			regulator-name = "vreg_l4b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l5b_3p0: ldo5 {
+			regulator-name = "vreg_l5b_3p0";
+			regulator-min-microvolt = <3000000>;
+			regulator-max-microvolt = <3000000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l6b_1p8: ldo6 {
+			regulator-name = "vreg_l6b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <2960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l7b_2p8: ldo7 {
+			regulator-name = "vreg_l7b_2p8";
+			regulator-min-microvolt = <2800000>;
+			regulator-max-microvolt = <2800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l8b_3p0: ldo8 {
+			regulator-name = "vreg_l8b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l9b_2p9: ldo9 {
+			regulator-name = "vreg_l9b_2p9";
+			regulator-min-microvolt = <2960000>;
+			regulator-max-microvolt = <2960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l10b_1p8: ldo10 {
+			regulator-name = "vreg_l10b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l12b_1p2: ldo12 {
+			regulator-name = "vreg_l12b_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-always-on;
+		};
+
+		vreg_l13b_3p0: ldo13 {
+			regulator-name = "vreg_l13b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l14b_3p0: ldo14 {
+			regulator-name = "vreg_l14b_3p0";
+			regulator-min-microvolt = <3072000>;
+			regulator-max-microvolt = <3072000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l15b_1p8: ldo15 {
+			regulator-name = "vreg_l15b_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+			regulator-always-on;
+		};
+
+		vreg_l16b_2p9: ldo16 {
+			regulator-name = "vreg_l16b_2p9";
+			regulator-min-microvolt = <2912000>;
+			regulator-max-microvolt = <2912000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l17b_2p5: ldo17 {
+			regulator-name = "vreg_l17b_2p5";
+			regulator-min-microvolt = <2504000>;
+			regulator-max-microvolt = <2504000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	/* PMC8380VE_C */
+	regulators-1 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "c";
+
+		vdd-l1-supply = <&vreg_s5j_1p2>;
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s4-supply = <&vph_pwr>;
+
+		vreg_s4c_1p8: smps4 {
+			regulator-name = "vreg_s4c_1p8";
+			regulator-min-microvolt = <1856000>;
+			regulator-max-microvolt = <2000000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1c_1p2: ldo1 {
+			regulator-name = "vreg_l1c_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2c_0p8: ldo2 {
+			regulator-name = "vreg_l2c_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3c_0p8: ldo3 {
+			regulator-name = "vreg_l3c_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	/* PMC8380_D */
+	regulators-2 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "d";
+
+		vdd-l1-supply = <&vreg_s1f_0p7>;
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s4c_1p8>;
+		vdd-s1-supply = <&vph_pwr>;
+
+		vreg_l1d_0p8: ldo1 {
+			regulator-name = "vreg_l1d_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2d_0p9: ldo2 {
+			regulator-name = "vreg_l2d_0p9";
+			regulator-min-microvolt = <912000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3d_1p8: ldo3 {
+			regulator-name = "vreg_l3d_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	/* PMC8380_E */
+	regulators-3 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "e";
+
+		vdd-l2-supply = <&vreg_s1f_0p7>;
+		vdd-l3-supply = <&vreg_s5j_1p2>;
+
+		vreg_l2e_0p8: ldo2 {
+			regulator-name = "vreg_l2e_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3e_1p2: ldo3 {
+			regulator-name = "vreg_l3e_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	/* PMC8380_F */
+	regulators-4 {
+		compatible = "qcom,pmc8380-rpmh-regulators";
+		qcom,pmic-id = "f";
+
+		vdd-l1-supply = <&vreg_s5j_1p2>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s5j_1p2>;
+		vdd-s1-supply = <&vph_pwr>;
+
+		vreg_s1f_0p7: smps1 {
+			regulator-name = "vreg_s1f_0p7";
+			regulator-min-microvolt = <700000>;
+			regulator-max-microvolt = <1100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1f_1p0: ldo1 {
+			regulator-name = "vreg_l1f_1p0";
+			regulator-min-microvolt = <1024000>;
+			regulator-max-microvolt = <1024000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2f_1p0: ldo2 {
+			regulator-name = "vreg_l2f_1p0";
+			regulator-min-microvolt = <1024000>;
+			regulator-max-microvolt = <1024000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3f_1p0: ldo3 {
+			regulator-name = "vreg_l3f_1p0";
+			regulator-min-microvolt = <1024000>;
+			regulator-max-microvolt = <1024000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	/* PMC8380VE_I */
+	regulators-6 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "i";
+
+		vdd-l1-supply = <&vreg_s4c_1p8>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s1-supply = <&vph_pwr>;
+		vdd-s2-supply = <&vph_pwr>;
+
+		vreg_s1i_0p9: smps1 {
+			regulator-name = "vreg_s1i_0p9";
+			regulator-min-microvolt = <900000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_s2i_1p0: smps2 {
+			regulator-name = "vreg_s2i_1p0";
+			regulator-min-microvolt = <1000000>;
+			regulator-max-microvolt = <1100000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1i_1p8: ldo1 {
+			regulator-name = "vreg_l1i_1p8";
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2i_1p2: ldo2 {
+			regulator-name = "vreg_l2i_1p2";
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3i_0p8: ldo3 {
+			regulator-name = "vreg_l3i_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+
+	/* PMC8380VE_J */
+	regulators-7 {
+		compatible = "qcom,pm8550ve-rpmh-regulators";
+		qcom,pmic-id = "j";
+
+		vdd-l1-supply = <&vreg_s1f_0p7>;
+		vdd-l2-supply = <&vreg_s5j_1p2>;
+		vdd-l3-supply = <&vreg_s1f_0p7>;
+		vdd-s5-supply = <&vph_pwr>;
+
+		vreg_s5j_1p2: smps5 {
+			regulator-name = "vreg_s5j_1p2";
+			regulator-min-microvolt = <1256000>;
+			regulator-max-microvolt = <1304000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l1j_0p8: ldo1 {
+			regulator-name = "vreg_l1j_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l2j_1p2: ldo2 {
+			regulator-name = "vreg_l2j_1p2";
+			regulator-min-microvolt = <1256000>;
+			regulator-max-microvolt = <1256000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		vreg_l3j_0p8: ldo3 {
+			regulator-name = "vreg_l3j_0p8";
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
+};
+
+&iris {
+	status = "okay";
+};
+
+&gpu {
+	status = "okay";
+};
+
+&gpu_zap_shader {
+	firmware-name = "qcom/x1e80100/gen70500_zap.mbn";
+};
+
+&pcie4 {
+	perst-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>;
+
+	pinctrl-0 = <&pcie4_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&pcie4_phy {
+	vdda-phy-supply = <&vreg_l3i_0p8>;
+	vdda-pll-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&pcie6a {
+	perst-gpios = <&tlmm 152 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 154 GPIO_ACTIVE_LOW>;
+
+	pinctrl-0 = <&pcie6a_default>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&pcie6a_phy {
+	vdda-phy-supply = <&vreg_l1d_0p8>;
+	vdda-pll-supply = <&vreg_l2j_1p2>;
+
+	status = "okay";
+};
+
+&qupv3_0 {
+	status = "okay";
+};
+
+&qupv3_1 {
+	status = "okay";
+};
+
+&qupv3_2 {
+	status = "okay";
+};
+
+&remoteproc_adsp {
+	firmware-name = "qcom/x1e80100/adsp.mbn",
+			"qcom/x1e80100/adsp_dtb.mbn";
+
+	status = "okay";
+};
+
+&remoteproc_cdsp {
+	firmware-name = "qcom/x1e80100/cdsp.mbn",
+			"qcom/x1e80100/cdsp_dtb.mbn";
+
+	status = "okay";
+};
+
+&tlmm {
+	gpio-reserved-ranges = <34 2>, /* TPM LP & INT */
+			       <44 4>; /* SPI (TPM) */
+
+	pcie4_default: pcie4-default-state {
+		clkreq-n-pins {
+			pins = "gpio147";
+			function = "pcie4_clk";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-n-pins {
+			pins = "gpio146";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-disable;
+		};
+
+		wake-n-pins {
+			pins = "gpio148";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+	};
+
+	pcie6a_default: pcie6a-default-state {
+		clkreq-n-pins {
+			pins = "gpio153";
+			function = "pcie6a_clk";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
+
+		perst-n-pins {
+			pins = "gpio152";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-disable;
+		};
+
+		wake-n-pins {
+			pins = "gpio154";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+
+		};
+	};
+};
+
+&usb_1_ss0 {
+	status = "okay";
+};
+
+&usb_1_ss0_dwc3 {
+	dr_mode = "otg";
+	usb-role-switch;
+};
+
+&usb_1_ss0_hsphy {
+	vdd-supply = <&vreg_l3j_0p8>;
+	vdda12-supply = <&vreg_l2j_1p2>;
+
+	status = "okay";
+};
+
+&usb_1_ss0_qmpphy {
+	vdda-phy-supply = <&vreg_l2j_1p2>;
+	vdda-pll-supply = <&vreg_l1j_0p8>;
+
+	status = "okay";
+};
+
+&usb_1_ss1 {
+	status = "okay";
+};
+
+&usb_1_ss1_dwc3 {
+	dr_mode = "otg";
+	usb-role-switch;
+};
+
+&usb_1_ss1_hsphy {
+	vdd-supply = <&vreg_l3j_0p8>;
+	vdda12-supply = <&vreg_l2j_1p2>;
+
+	status = "okay";
+};
+
+&usb_1_ss1_qmpphy {
+	vdda-phy-supply = <&vreg_l2j_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p9>;
+
+	status = "okay";
+};
+
+&usb_1_ss2 {
+	status = "okay";
+};
+
+&usb_1_ss2_dwc3 {
+	dr_mode = "otg";
+	usb-role-switch;
+};
+
+&usb_1_ss2_hsphy {
+	vdd-supply = <&vreg_l3j_0p8>;
+	vdda12-supply = <&vreg_l2j_1p2>;
+
+	status = "okay";
+};
+
+&usb_1_ss2_qmpphy {
+	vdda-phy-supply = <&vreg_l2j_1p2>;
+	vdda-pll-supply = <&vreg_l2d_0p9>;
+
+	status = "okay";
+};
+
+&usb_2 {
+	status = "okay";
+};
+
+&usb_2_dwc3 {
+	dr_mode = "host";
+};
+
+&usb_2_hsphy {
+	vdd-supply = <&vreg_l2e_0p8>;
+	vdda12-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&usb_mp {
+	status = "okay";
+};
+
+&usb_mp_hsphy0 {
+	vdd-supply = <&vreg_l2e_0p8>;
+	vdda12-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&usb_mp_hsphy1 {
+	vdd-supply = <&vreg_l2e_0p8>;
+	vdda12-supply = <&vreg_l3e_1p2>;
+
+	status = "okay";
+};
+
+&usb_mp_qmpphy0 {
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l3c_0p8>;
+
+	status = "okay";
+};
+
+&usb_mp_qmpphy1 {
+	vdda-phy-supply = <&vreg_l3e_1p2>;
+	vdda-pll-supply = <&vreg_l3c_0p8>;
+
+	status = "okay";
+};
Signature · 1 line
2.34.1
#6 lore raw

Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

Quoted 15 lines · Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Quoted 3 lines

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 15 lines
---
 arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
 1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +2 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*

arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi line 12

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +10 -0
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+	compatible = "hamoa-iot-som", "qcom,x1e80100";

Undocumented compatible (without "qcom," prefix). I think you can just drop this?

Thanks,
Stephan

author
#7 lore raw

Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

Quoted 16 lines · Stephan Gerhold
Quoted 15 lines · Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Quoted 6 lines
Quoted 3 lines

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

We’ve agreed on this as the preferred method for marking collaboration, as discussed earlier in this thread.

Quoted 21 lines
Quoted 21 lines
---
  arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
  1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +7 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi line 12

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +5 -0
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+	compatible = "hamoa-iot-som", "qcom,x1e80100";

Undocumented compatible (without "qcom," prefix). I think you can just drop this?

This compatible string was also discussed previously and is the preferred choice. I’ll add the missing 'qcom,' prefix.

Quoted 3 lines

Thanks,
Stephan

Signature · 2 lines
Best Regards,
Yijie
#8 lore raw

Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

Quoted 23 lines · Yijie Yang
Quoted 20 lines · Stephan Gerhold
Quoted 18 lines · Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

Quoted 6 lines
Quoted 2 lines

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

We’ve agreed on this as the preferred method for marking collaboration, as discussed earlier in this thread.

I can't say I agree with Bjorn there, but ok, he's the maintainer. :-)

Quoted 30 lines
Quoted 21 lines
Quoted 21 lines
---
  arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
  1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +7 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi line 12

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +5 -0
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+	compatible = "hamoa-iot-som", "qcom,x1e80100";

Undocumented compatible (without "qcom," prefix). I think you can just drop this?

Quoted 3 lines

This compatible string was also discussed previously and is the preferred choice. I’ll add the missing 'qcom,' prefix.

Even compatible = "qcom,hamoa-iot-som", "qcom,x1e80100"; is not documented. And it doesn't make much sense to document it either, each of the boards using the SoM should have a more specific compatible and therefore needs to override this property. I think you can really just drop this line.

Thanks,
Stephan

author
#9 lore raw

Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

Quoted 67 lines · Stephan Gerhold
Quoted 23 lines · Yijie Yang
Quoted 20 lines · Stephan Gerhold
Quoted 18 lines · Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

Quoted 6 lines
Quoted 2 lines

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

We’ve agreed on this as the preferred method for marking collaboration, as discussed earlier in this thread.

I can't say I agree with Bjorn there, but ok, he's the maintainer. :-)

Quoted 30 lines
Quoted 21 lines
Quoted 21 lines
---
   arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
   1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +7 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi line 12

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +5 -0
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+	compatible = "hamoa-iot-som", "qcom,x1e80100";

Undocumented compatible (without "qcom," prefix). I think you can just drop this?

Quoted 3 lines

This compatible string was also discussed previously and is the preferred choice. I’ll add the missing 'qcom,' prefix.

Quoted 5 lines

Even compatible = "qcom,hamoa-iot-som", "qcom,x1e80100"; is not documented. And it doesn't make much sense to document it either, each of the boards using the SoM should have a more specific compatible and therefore needs to override this property. I think you can really just drop this line.

Patch 1/4 documents this compatible. It’s another requirement that SoC/SoM should follow, which Krzysztof pointed out in v2:
https://lore.kernel.org/all/[email protected]/

Quoted 4 lines

Thanks,
Stephan

Signature · 2 lines
Best Regards,
Yijie
#10 lore raw

Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

Quoted 76 lines · Yijie Yang
Quoted 67 lines · Stephan Gerhold
Quoted 23 lines · Yijie Yang
Quoted 20 lines · Stephan Gerhold
Quoted 18 lines · Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

Quoted 6 lines
Quoted 2 lines

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

We’ve agreed on this as the preferred method for marking collaboration, as discussed earlier in this thread.

I can't say I agree with Bjorn there, but ok, he's the maintainer. :-)

Quoted 30 lines
Quoted 21 lines
Quoted 21 lines
---
   arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
   1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +7 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi line 12

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +5 -0
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+	compatible = "hamoa-iot-som", "qcom,x1e80100";

Undocumented compatible (without "qcom," prefix). I think you can just drop this?

Quoted 3 lines

This compatible string was also discussed previously and is the preferred choice. I’ll add the missing 'qcom,' prefix.

Quoted 5 lines

Even compatible = "qcom,hamoa-iot-som", "qcom,x1e80100"; is not documented. And it doesn't make much sense to document it either, each of the boards using the SoM should have a more specific compatible and therefore needs to override this property. I think you can really just drop this line.

Quoted 4 lines

Patch 1/4 documents this compatible. It’s another requirement that SoC/SoM should follow, which Krzysztof pointed out in v2:
https://lore.kernel.org/all/[email protected]/

I'm not saying you should drop the "qcom,hamoa-iot-som" compatible. My point is that only the compatible list you use in hamoa-iot-evk.dts is documented in PATCH 1/4:

compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";

The compatible list you are using in hamoa-iot-som.dtsi is *not* documented:

compatible = "(qcom,)hamoa-iot-som", "qcom,x1e80100";

because the board-specific compatible string (e.g. "qcom,hamoa-iot-evk") is missing.

The compatible property you have in hamoa-iot-som.dtsi is redundant, because you override it with the valid one in hamoa-iot-evk.dts. And every other board using the SoM should do the same.

I would expect that you can just drop this line in hamoa-iot-som.dtsi.

Thanks,
Stephan

author
#11 lore raw

Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

Quoted 93 lines · Stephan Gerhold
Quoted 76 lines · Yijie Yang
Quoted 67 lines · Stephan Gerhold
Quoted 23 lines · Yijie Yang
Quoted 20 lines · Stephan Gerhold
Quoted 18 lines · Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

Quoted 6 lines
Quoted 2 lines

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

We’ve agreed on this as the preferred method for marking collaboration, as discussed earlier in this thread.

I can't say I agree with Bjorn there, but ok, he's the maintainer. :-)

Quoted 30 lines
Quoted 21 lines
Quoted 21 lines
---
    arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
    1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +7 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi line 12

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +5 -0
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+	compatible = "hamoa-iot-som", "qcom,x1e80100";

Undocumented compatible (without "qcom," prefix). I think you can just drop this?

Quoted 3 lines

This compatible string was also discussed previously and is the preferred choice. I’ll add the missing 'qcom,' prefix.

Quoted 5 lines

Even compatible = "qcom,hamoa-iot-som", "qcom,x1e80100"; is not documented. And it doesn't make much sense to document it either, each of the boards using the SoM should have a more specific compatible and therefore needs to override this property. I think you can really just drop this line.

Quoted 4 lines

Patch 1/4 documents this compatible. It’s another requirement that SoC/SoM should follow, which Krzysztof pointed out in v2:
https://lore.kernel.org/all/[email protected]/

I'm not saying you should drop the "qcom,hamoa-iot-som" compatible. My point is that only the compatible list you use in hamoa-iot-evk.dts is documented in PATCH 1/4:

compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";

The compatible list you are using in hamoa-iot-som.dtsi is *not* documented:

compatible = "(qcom,)hamoa-iot-som", "qcom,x1e80100";

Quoted 8 lines

because the board-specific compatible string (e.g. "qcom,hamoa-iot-evk") is missing.

The compatible property you have in hamoa-iot-som.dtsi is redundant, because you override it with the valid one in hamoa-iot-evk.dts. And every other board using the SoM should do the same.

I would expect that you can just drop this line in hamoa-iot-som.dtsi.

Yes, the compatible property in this context will ultimately be overridden by the board file and does not have any direct functional impact.

However, DTS/DTSI files are intended to describe the hardware itself, and this compatible string helps characterize the SOM—even if it is later overridden. This is similar to the role of compatible strings in certain soc.dtsi files.

Therefore, I believe it is appropriate to retain this compatible and provide documentation to clarify its purpose.

A useful reference for this approach is the imx8mp-sr-som.dtsi file from another vendor.

Quoted 3 lines

Thanks,
Stephan

Signature · 2 lines
Best Regards,
Yijie
#12 lore raw

Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

Quoted 103 lines · Yijie Yang
Quoted 100 lines · Stephan Gerhold
Quoted 76 lines · Yijie Yang
Quoted 67 lines · Stephan Gerhold
Quoted 23 lines · Yijie Yang
Quoted 20 lines · Stephan Gerhold
Quoted 18 lines · Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

Quoted 6 lines
Quoted 2 lines

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

We’ve agreed on this as the preferred method for marking collaboration, as discussed earlier in this thread.

I can't say I agree with Bjorn there, but ok, he's the maintainer. :-)

Quoted 30 lines
Quoted 21 lines
Quoted 21 lines

---
    arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++

    1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +7 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi line 12

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +5 -0
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+    compatible = "hamoa-iot-som", "qcom,x1e80100";

Undocumented compatible (without "qcom," prefix). I think you can just drop this?

Quoted 3 lines

This compatible string was also discussed previously and is the preferred choice. I’ll add the missing 'qcom,' prefix.

Quoted 5 lines

Even compatible = "qcom,hamoa-iot-som", "qcom,x1e80100"; is not documented. And it doesn't make much sense to document it either, each of the boards using the SoM should have a more specific compatible and therefore needs to override this property. I think you can really just drop this line.

Quoted 4 lines

Patch 1/4 documents this compatible. It’s another requirement that SoC/SoM should follow, which Krzysztof pointed out in v2:
https://lore.kernel.org/all/[email protected]/

I'm not saying you should drop the "qcom,hamoa-iot-som" compatible. My point is that only the compatible list you use in hamoa-iot-evk.dts is documented in PATCH 1/4:

compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";

The compatible list you are using in hamoa-iot-som.dtsi is *not* documented:

compatible = "(qcom,)hamoa-iot-som", "qcom,x1e80100";

because the board-specific compatible string (e.g. "qcom,hamoa-iot-evk") is missing.

The compatible property you have in hamoa-iot-som.dtsi is redundant, because you override it with the valid one in hamoa-iot-evk.dts. And every other board using the SoM should do the same.

Quoted 7 lines
Quoted 1 line

I would expect that you can just drop this line in hamoa-iot-som.dtsi.

Yes, the compatible property in this context will ultimately be overridden by the board file and does not have any direct functional impact.

However, DTS/DTSI files are intended to describe the hardware itself, and this compatible string helps characterize the SOM—even if it is later overridden. This is similar to the role of compatible strings in certain soc.dtsi files.

Therefore, I believe it is appropriate to retain this compatible and provide documentation to clarify its purpose.

No, if the compatible and model are not overriden, the carrier board DT is invalid. The SoM dtsi isn't supposed to be a "functional" dt, but rather a fragment, like a code header, containing most of the common functionality for includers (which is derived from the presence of the Hamoa SoM).

Konrad

Quoted 7 lines

A useful reference for this approach is the imx8mp-sr-som.dtsi file from another vendor.

Quoted 3 lines

Thanks,
Stephan

author
#13 lore raw

Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

Quoted 108 lines · Konrad Dybcio
Quoted 107 lines · Yijie Yang
Quoted 93 lines · Stephan Gerhold
Quoted 76 lines · Yijie Yang
Quoted 67 lines · Stephan Gerhold
Quoted 23 lines · Yijie Yang
Quoted 20 lines · Stephan Gerhold
Quoted 18 lines · Yijie Yang

The HAMOA-IOT-SOM is a compact computing module that integrates a System on Chip (SoC) — specifically the x1e80100 — along with essential components optimized for IoT applications. It is designed to be mounted on carrier boards, enabling the development of complete embedded systems.

Make the following peripherals on the SOM enabled:
- Regulators on the SOM
- Reserved memory regions
- PCIe6a and its PHY
- PCIe4 and its PHY
- USB0 through USB6 and their PHYs
- ADSP, CDSP
- Graphic
- Video

Written in collaboration with Yingying Tang (PCIe4) <[email protected]> and Wangao Wang (Video) <[email protected]>.

Quoted 6 lines
Quoted 2 lines

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

We’ve agreed on this as the preferred method for marking collaboration, as discussed earlier in this thread.

I can't say I agree with Bjorn there, but ok, he's the maintainer. :-)

Quoted 30 lines
Quoted 21 lines
Quoted 21 lines
---
     arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
     1 file changed, 621 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +7 -0
new file mode 100644
index 000000000000..c7c3a167eb6a
@@ -0,0 +1,621 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+#include "x1e80100.dtsi"
+#include "x1e80100-pmics.dtsi"
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi line 12

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi new file +5 -0
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
+
+/ {
+    compatible = "hamoa-iot-som", "qcom,x1e80100";

Undocumented compatible (without "qcom," prefix). I think you can just drop this?

Quoted 3 lines

This compatible string was also discussed previously and is the preferred choice. I’ll add the missing 'qcom,' prefix.

Quoted 5 lines

Even compatible = "qcom,hamoa-iot-som", "qcom,x1e80100"; is not documented. And it doesn't make much sense to document it either, each of the boards using the SoM should have a more specific compatible and therefore needs to override this property. I think you can really just drop this line.

Quoted 4 lines

Patch 1/4 documents this compatible. It’s another requirement that SoC/SoM should follow, which Krzysztof pointed out in v2:
https://lore.kernel.org/all/[email protected]/

I'm not saying you should drop the "qcom,hamoa-iot-som" compatible. My point is that only the compatible list you use in hamoa-iot-evk.dts is documented in PATCH 1/4:

compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";

The compatible list you are using in hamoa-iot-som.dtsi is *not* documented:

compatible = "(qcom,)hamoa-iot-som", "qcom,x1e80100";

Quoted 8 lines

because the board-specific compatible string (e.g. "qcom,hamoa-iot-evk") is missing.

The compatible property you have in hamoa-iot-som.dtsi is redundant, because you override it with the valid one in hamoa-iot-evk.dts. And every other board using the SoM should do the same.

I would expect that you can just drop this line in hamoa-iot-som.dtsi.

Yes, the compatible property in this context will ultimately be overridden by the board file and does not have any direct functional impact.

Quoted 8 lines
Quoted 3 lines

However, DTS/DTSI files are intended to describe the hardware itself, and this compatible string helps characterize the SOM—even if it is later overridden. This is similar to the role of compatible strings in certain soc.dtsi files.

Therefore, I believe it is appropriate to retain this compatible and provide documentation to clarify its purpose.

No, if the compatible and model are not overriden, the carrier board DT is invalid. The SoM dtsi isn't supposed to be a "functional" dt, but rather a fragment, like a code header, containing most of the common functionality for includers (which is derived from the presence of the Hamoa SoM).

Understood, I will remove this line.

Quoted 9 lines

Konrad

Quoted 7 lines

A useful reference for this approach is the imx8mp-sr-som.dtsi file from another vendor.

Quoted 3 lines

Thanks,
Stephan

Signature · 2 lines
Best Regards,
Yijie
author
#14 lore raw

PATCH v11 4/4 arm64: dts: qcom: Add base HAMOA-IOT-EVK board

In reply to Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 0e4e0e0b833b..3d11e93cd5cc 100644
@@ -13,6 +13,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8039-t2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= hamoa-iot-evk.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq5018-rdp432-c2.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq5018-tplink-archer-ax55-v1.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp441.dtb
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +1221 -0

1,221 lines not on this page · raw message

Signature · 1 line
2.34.1
#15 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 22 lines
---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)

[...]

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +8 -0
new file mode 100644
index 000000000000..6eedad7e858a
@@ -0,0 +1,1221 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include "hamoa-iot-som.dtsi"

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +9 -0
+
+/ {
+	model = "Qualcomm Technologies, Inc. Hamoa IoT EVK";
+	compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";
+	chassis-type = "embedded";
+
[...]
+	/*
+	 * TODO: These two regulators are actually part of the removable M.2
+	 * card and not the CRD mainboard. Need to describe this differently.

This is not a CRD, I think?

Quoted 26 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +26 -0
+	 * Functionally it works correctly, because all we need to do is to
+	 * turn on the actual 3.3V supply above.
+	 */
+	vreg_wcn_0p95: regulator-wcn-0p95 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_0P95";
+		regulator-min-microvolt = <950000>;
+		regulator-max-microvolt = <950000>;
+
+		vin-supply = <&vreg_wcn_3p3>;
+	};
+
+	vreg_wcn_1p9: regulator-wcn-1p9 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_1P9";
+		regulator-min-microvolt = <1900000>;
+		regulator-max-microvolt = <1900000>;
+
+		vin-supply = <&vreg_wcn_3p3>;
+	};
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 396

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

Quoted 7 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +5 -0
+		regulator-always-on;
+	};
+
[...]
+};
+
[...]

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 779

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+&mdss {
+	status = "okay";
+};
+
+&mdss_dp0 {
+	status = "okay";
+};
+
+&mdss_dp0_out {
+	data-lanes = <0 1>;

This is unneeded unless you really want to limit this to just 2 lanes. x1e80100.dtsi specifies 4 lanes by default.

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 788

Quoted 9 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +9 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp1 {
+	status = "okay";
+};
+
+&mdss_dp1_out {
+	data-lanes = <0 1>;

Same here.

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 797

Quoted 9 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +9 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp2 {
+	status = "okay";
+};
+
+&mdss_dp2_out {
+	data-lanes = <0 1>;

And here.

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 802

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +5 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp3 {
+	/delete-property/ #sound-dai-cells;

You need to define pinctrl for the HPD pin here.

Thanks,
Stephan

#16 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

Quoted 91 lines · Stephan Gerhold
Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 22 lines
---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)

[...]

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +8 -0
new file mode 100644
index 000000000000..6eedad7e858a
@@ -0,0 +1,1221 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include "hamoa-iot-som.dtsi"

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +9 -0
+
+/ {
+	model = "Qualcomm Technologies, Inc. Hamoa IoT EVK";
+	compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";
+	chassis-type = "embedded";
+
[...]
+	/*
+	 * TODO: These two regulators are actually part of the removable M.2
+	 * card and not the CRD mainboard. Need to describe this differently.

This is not a CRD, I think?

Quoted 30 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +30 -0
+	 * Functionally it works correctly, because all we need to do is to
+	 * turn on the actual 3.3V supply above.
+	 */
+	vreg_wcn_0p95: regulator-wcn-0p95 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_0P95";
+		regulator-min-microvolt = <950000>;
+		regulator-max-microvolt = <950000>;
+
+		vin-supply = <&vreg_wcn_3p3>;
+	};
+
+	vreg_wcn_1p9: regulator-wcn-1p9 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_1P9";
+		regulator-min-microvolt = <1900000>;
+		regulator-max-microvolt = <1900000>;
+
+		vin-supply = <&vreg_wcn_3p3>;
+	};
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 396

Quoted 6 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +6 -0
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

It shoulde be regulator-always-on

Quoted 56 lines
Quoted 8 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +5 -0
+		regulator-always-on;
+	};
+
[...]
+};
+
[...]

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 779

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+&mdss {
+	status = "okay";
+};
+
+&mdss_dp0 {
+	status = "okay";
+};
+
+&mdss_dp0_out {
+	data-lanes = <0 1>;

This is unneeded unless you really want to limit this to just 2 lanes. x1e80100.dtsi specifies 4 lanes by default.

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 788

Quoted 9 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +9 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp1 {
+	status = "okay";
+};
+
+&mdss_dp1_out {
+	data-lanes = <0 1>;

Same here.

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 797

Quoted 9 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +9 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp2 {
+	status = "okay";
+};
+
+&mdss_dp2_out {
+	data-lanes = <0 1>;

And here.

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 802

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +5 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp3 {
+	/delete-property/ #sound-dai-cells;

You need to define pinctrl for the HPD pin here.

Thanks,
Stephan

#17 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

Quoted 53 lines · Yingying Tang
Quoted 33 lines · Stephan Gerhold
Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 7 lines
---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)
Quoted 16 lines
Quoted 4 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +4 -0
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 396

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

Quoted 1 line

It shoulde be regulator-always-on

Why it's not boot-on and always-on?

Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +3 -0
+		regulator-always-on;
+	};
+
Signature · 2 lines
With best wishes
Dmitry
#18 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

Quoted 54 lines · Dmitry Baryshkov
Quoted 53 lines · Yingying Tang
Quoted 49 lines · Stephan Gerhold
Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 11 lines
---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +4 -0
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 396

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

Quoted 4 lines
Quoted 1 line

It shoulde be regulator-always-on

Why it's not boot-on and always-on?

As I described before, connectivity power is voted by UEFI in boot phase.So PCIe link between connetivity card and RC4 is established once RC4 is on. If we set this node as "regulator-boot-on", connectivity power will be down first then up. That cause PCIe link down and the link can't be trained again unless you reboot board. So we can't set it to "regulator-boot-on"

Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +3 -0
+		regulator-always-on;
+	};
+
#19 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

Quoted 57 lines · Yingying Tang
Quoted 54 lines · Dmitry Baryshkov
Quoted 53 lines · Yingying Tang
Quoted 49 lines · Stephan Gerhold
Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 11 lines
---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +4 -0
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 396

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

It shoulde be regulator-always-on

Why it's not boot-on and always-on?

As I described before, connectivity power is voted by UEFI in boot phase.So PCIe link between connetivity card and RC4 is established once RC4 is on. If we set this node as "regulator-boot-on", connectivity power will be down first then up. That cause PCIe link down and the link can't be trained again unless you reboot board. So we can't set it to "regulator-boot-on"

Surely gpio-regulator.c implements .get_voltage which reads the pin state though? Did you test this, or are you theorycrafting?

Konrad

#20 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

Quoted 60 lines · Konrad Dybcio
Quoted 59 lines · Yingying Tang
Quoted 56 lines · Dmitry Baryshkov
Quoted 54 lines · Yingying Tang
Quoted 33 lines · Stephan Gerhold
Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 7 lines
---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)
Quoted 16 lines
Quoted 4 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +4 -0
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 396

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

It shoulde be regulator-always-on

Quoted 9 lines
Quoted 5 lines
Quoted 2 lines

Why it's not boot-on and always-on?

As I described before, connectivity power is voted by UEFI in boot phase.So PCIe link between connetivity card and RC4 is established once RC4 is on. If we set this node as "regulator-boot-on", connectivity power will be down first then up. That cause PCIe link down and the link can't be trained again unless you reboot board. So we can't set it to "regulator-boot-on"

Surely gpio-regulator.c implements .get_voltage which reads the pin state though? Did you test this, or are you theorycrafting?

Yes we tested this case many times, "regulator-boot-on" causes PCIe link down. No any issue with "regulator-always-on"

Quoted 2 lines

Konrad

#21 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

Quoted 65 lines · Yingying Tang
Quoted 62 lines · Konrad Dybcio
Quoted 61 lines · Yingying Tang
Quoted 58 lines · Dmitry Baryshkov
Quoted 53 lines · Yingying Tang
Quoted 33 lines · Stephan Gerhold
Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 7 lines
---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)
Quoted 16 lines
Quoted 4 lines
(quoted diff) +4 -0
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+

Review

Quoted 10 lines
(quoted diff) +10 -0
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

Quoted 1 line

It shoulde be regulator-always-on

Why it's not boot-on and always-on?

Quoted 8 lines
Quoted 7 lines
Quoted 3 lines

As I described before, connectivity power is voted by UEFI in boot phase.So PCIe link between connetivity card and RC4 is established once RC4 is on. If we set this node as "regulator-boot-on", connectivity power will be down first then up. That cause PCIe link down and the link can't be trained again unless you reboot board. So we can't set it to "regulator-boot-on"

Surely gpio-regulator.c implements .get_voltage which reads the pin state though? Did you test this, or are you theorycrafting?

Yes we tested this case many times, "regulator-boot-on" causes PCIe link down. No any issue with "regulator-always-on"

We didn't ask you to remove 'always-on'. That makes sense because it avoids an extra call to (re-)assert the GPIO if both are specified

Konrad

#22 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

In reply to Yingying Tang
Quoted 57 lines · Yingying Tang
Quoted 54 lines · Dmitry Baryshkov
Quoted 53 lines · Yingying Tang
Quoted 49 lines · Stephan Gerhold
Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Quoted 11 lines
---
 arch/arm64/boot/dts/qcom/Makefile          |    1 +
 arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
 2 files changed, 1222 insertions(+)
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +4 -0
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 396

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

It shoulde be regulator-always-on

Why it's not boot-on and always-on?

As I described before, connectivity power is voted by UEFI in boot phase.So PCIe link between connetivity card and RC4 is established once RC4 is on. If we set this node as "regulator-boot-on", connectivity power will be down first then up. That cause PCIe link down and the link can't be trained again unless you reboot board. So we can't set it to "regulator-boot-on"

I've asked about it being boot-on + always-on. Any issues with that? I doubt that it will cause a spike on the regulator.

Quoted 7 lines
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +3 -0
+		regulator-always-on;
+	};
+
Signature · 2 lines
With best wishes
Dmitry
author
#23 lore raw

Re: [PATCH v11 4/4] arm64: dts: qcom: Add base HAMOA-IOT-EVK board

In reply to Stephan Gerhold
Quoted 18 lines · Stephan Gerhold
Quoted 17 lines · Yijie Yang

The HAMOA-IOT-EVK is an evaluation platform for IoT products, composed of the Hamoa IoT SoM and a carrier board. Together, they form a complete embedded system capable of booting to UART.

Make the following peripherals on the carrier board enabled:
- UART
- On-board regulators
- USB Type-C mux
- Pinctrl
- Embedded USB (EUSB) repeaters
- NVMe
- pmic-glink
- USB DisplayPorts
- Bluetooth
- WLAN
- Audio

Quoted 7 lines
Quoted 4 lines

Written in collaboration with Quill Qi (Audio) <[email protected]>, Jie Zhang (Graphics) <[email protected]>, Shuai Zhang (Bluetooth) <[email protected]>, Yingying Tang (WLAN) <[email protected]>, and Yongxing Mou (USB DisplayPorts) <[email protected]>.

This looks like you should have Co-developed-by: tags together with their Signed-off-by: tags.

Same with 3/4.

Quoted 27 lines
Quoted 27 lines
---
  arch/arm64/boot/dts/qcom/Makefile          |    1 +
  arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts | 1221 ++++++++++++++++++++++++++++
  2 files changed, 1222 insertions(+)

[...]

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +12 -0
new file mode 100644
index 000000000000..6eedad7e858a
@@ -0,0 +1,1221 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
+ */
+
+/dts-v1/;
+
+#include "hamoa-iot-som.dtsi"
+
+/ {
+	model = "Qualcomm Technologies, Inc. Hamoa IoT EVK";
+	compatible = "qcom,hamoa-iot-evk", "qcom,hamoa-iot-som", "qcom,x1e80100";
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 360

Quoted 6 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +5 -0
+	chassis-type = "embedded";
+
[...]
+	/*
+	 * TODO: These two regulators are actually part of the removable M.2
+	 * card and not the CRD mainboard. Need to describe this differently.

This is not a CRD, I think?

I will update.

Quoted 52 lines
Quoted 27 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +26 -0
+	 * Functionally it works correctly, because all we need to do is to
+	 * turn on the actual 3.3V supply above.
+	 */
+	vreg_wcn_0p95: regulator-wcn-0p95 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_0P95";
+		regulator-min-microvolt = <950000>;
+		regulator-max-microvolt = <950000>;
+
+		vin-supply = <&vreg_wcn_3p3>;
+	};
+
+	vreg_wcn_1p9: regulator-wcn-1p9 {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_WCN_1P9";
+		regulator-min-microvolt = <1900000>;
+		regulator-max-microvolt = <1900000>;
+
+		vin-supply = <&vreg_wcn_3p3>;
+	};
+
+	vreg_wcn_3p3: regulator-wcn-3p3 {
+		compatible = "regulator-fixed";
+

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 396

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+		regulator-name = "VREG_WCN_3P3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		gpio = <&tlmm 214 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&wcn_sw_en>;
+		pinctrl-names = "default";
+

regulator-boot-on?

Quoted 12 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +10 -0
+		regulator-always-on;
+	};
+
[...]
+};
+
[...]
+&mdss {
+	status = "okay";
+};
+
+&mdss_dp0 {
Quoted 8 lines

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 779

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +5 -0
+	status = "okay";
+};
+
+&mdss_dp0_out {
+	data-lanes = <0 1>;

This is unneeded unless you really want to limit this to just 2 lanes. x1e80100.dtsi specifies 4 lanes by default.

Great reminder! I’ll rebase on top of the latest code.

Quoted 25 lines

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 788

Quoted 10 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +9 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp1 {
+	status = "okay";
+};
+
+&mdss_dp1_out {
+	data-lanes = <0 1>;

Same here.

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 797

Quoted 9 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +9 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp2 {
+	status = "okay";
+};
+
+&mdss_dp2_out {
+	data-lanes = <0 1>;

And here.

Quoted 7 lines

arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts line 802

Quoted 5 lines
arch/arm64/boot/dts/qcom/hamoa-iot-evk.dts new file +5 -0
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+};
+
+&mdss_dp3 {
+	/delete-property/ #sound-dai-cells;

You need to define pinctrl for the HPD pin here.

Will do.

Quoted 3 lines

Thanks,
Stephan

Signature · 2 lines
Best Regards,
Yijie