pmdomain: thead: Fix error pointer vs NULL bug in th1520_pd_reboot_init()
Subsystems (4)
PATCH 1/1 pmdomain: thead: Fix error pointer vs NULL bug in th1520_pd_reboot_init()
The devm_auxiliary_device_create() returns NULL on error. It never returns error pointers. Using PTR_ERR_OR_ZERO() here means the function always returns success. Replace the PTR_ERR_OR_ZERO() call check with a NULL check.
--- drivers/pmdomain/thead/th1520-pm-domains.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/pmdomain/thead/th1520-pm-domains.c +3 -1
@@ -179,8 +179,10 @@ static int th1520_pd_reboot_init(struct device *dev,struct auxiliary_device *adev; adev =devm_auxiliary_device_create (dev,"reboot" , aon_chan); +if (!adev) +return -ENODEV ; -return PTR_ERR_OR_ZERO (adev); +return 0 ; }static int th1520_pd_probe (struct platform_device *pdev)
Signature · 1 line
2.51.0
Quoted 2 lines · 在 2025-09-26星期五的 07:03 +0300,Dan Carpenter写道:
The
devm_auxiliary_device_create()returns NULL on error. It never returns error pointers. UsingPTR_ERR_OR_ZERO()here means the
Checked the implementation of auxiliary devices, and this is true.
So
``` Acked-by: Icenowy Zheng <[email protected]> ```
Quoted 31 lines
function
always returns success. Replace thePTR_ERR_OR_ZERO()call check with
a NULL check.Fixes 64581f41f4c4 ("pmdomain: thead: create auxiliary device forrebooting")
Signed-off-by Dan Carpenter <[email protected]>---
drivers/pmdomain/thead/th1520-pm-domains.c | 4 +++-1 file changed, 3 insertions(+), 1 deletion(-)drivers/pmdomain/thead/th1520-pm-domains.c +0
-0@@ -179,8 +179,10 @@ static int th1520_pd_reboot_init(struct device *dev, struct auxiliary_device *adev;
adev =devm_auxiliary_device_create(dev, "reboot", aon_chan); + if (!adev)
+ return-ENODEV;
- returnPTR_ERR_OR_ZERO(adev);
+ return 0;
}
static intth1520_pd_probe(struct platform_device *pdev)
Quoted 8 lines · Dan Carpenter
The
devm_auxiliary_device_create()returns NULL on error. It never returns error pointers. UsingPTR_ERR_OR_ZERO()here means the function always returns success. Replace thePTR_ERR_OR_ZERO()call check with a NULL check.Fixes 64581f41f4c4 ("pmdomain: thead: create auxiliary device for rebooting")Signed-off-by Dan Carpenter <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 23 lines
--- drivers/pmdomain/thead/th1520-pm-domains.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/pmdomain/thead/th1520-pm-domains.c +3
-2@@ -179,8 +179,10 @@ static int th1520_pd_reboot_init(struct device *dev,struct auxiliary_device *adev; adev =devm_auxiliary_device_create (dev,"reboot" , aon_chan); +if (!adev) +return -ENODEV ; -return PTR_ERR_OR_ZERO (adev); +return 0 ; }static int th1520_pd_probe (struct platform_device *pdev) --2.51.0