Skip to contentSkip to conversation

Patch "clk: at91: peripheral: fix return value" has been added to the 6.17-stable tree

DISCUSSION Brian Masney 1 participant 1 message Oct 15, 2025 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Sasha,

Quoted 29 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

clk: at91: peripheral: fix return value

to the 6.17-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
clk-at91-peripheral-fix-return-value.patch
and it can be found in the queue-6.17 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

commit cbddc84a11e6112835fced8f7266d9810efc52f3

Author: Brian Masney <[email protected]>
Date:   Mon Aug 11 11:17:53 2025 -0400

clk: at91: peripheral: fix return value

[ Upstream commit 47b13635dabc14f1c2fdcaa5468b47ddadbdd1b5 ]

determine_rate() is expected to return an error code, or 0 on success. clk_sam9x5_peripheral_determine_rate() has a branch that returns the parent rate on a certain case. This is the behavior of round_rate(), so let's go ahead and fix this by setting req->rate.

Quoted 5 lines
Fixes b4c115c76184f ("clk: at91: clk-peripheral: add support for changeable parent rate")

Please don't backport any of my round_rate() to determine_rate() migrations to the stable kernels. I have maybe close to 200 of these patches for various clk drivers, and stable can stay on round_rate(). There's no functional change.

Stephen mentioned this work on his pull to Linus about how this is all prerequisite work to get to the real task of improving the clk rate setting process.
https://lore.kernel.org/linux-clk/[email protected]/

Thanks,

Brian