vmalloc: Update __vmalloc_node_noprof() documentation
Subsystems (2)
Uladzislau Rezki (Sony)
maintainerPATCH 1/1 vmalloc: Update __vmalloc_node_noprof() documentation
The kernel-doc for the __vmalloc_node_noprof() incorrectly states that __GFP_NOFAIL reclaim modifier is not supported. In fact it has been supported since commit 9376130c390a ("mm/vmalloc: add support for __GFP_NOFAIL").
To avoid duplication and future drift, point this helper's doc to __vmalloc_node_range_noprof() for details and the full description.
--- mm/vmalloc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
mm/vmalloc.c +2 -5
@@ -4027,11 +4027,8 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align,* Allocate enough pages to cover @size from the page level allocator with * @gfp_mask flags. Map them into contiguous kernel virtual space. * -* Reclaim modifiers in @gfp_mask - __GFP_NORETRY, __GFP_RETRY_MAYFAIL -* and __GFP_NOFAIL are not supported -* -* Any use of gfp flags outside of GFP_KERNEL should be consulted -* with mm people. +* Semantics of @gfp_mask(including reclaim/retry modifiers such as +* __GFP_NOFAIL) are the same as in __vmalloc_node_range_noprof(). * * Return: pointer to the allocated memory or %NULL on error */
Signature · 1 line
2.47.3
Quoted 5 lines · Uladzislau Rezki (Sony)
The kernel-doc for the
__vmalloc_node_noprof()incorrectly states that__GFP_NOFAILreclaim modifier is not supported. In fact it has been supported since commit9376130c390a("mm/vmalloc: add support for__GFP_NOFAIL").
Quoted 7 lines
To avoid duplication and future drift, point this helper's doc to
__vmalloc_node_range_noprof()for details and the full description.Signed-off-by Uladzislau Rezki (Sony) <[email protected]>--- mm/vmalloc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
Quoted 22 lines
mm/vmalloc.c +2
-5@@ -4027,11 +4027,8 @@ void *__vmalloc_node_range_noprof(unsigned long size, unsigned long align,* Allocate enough pages to cover @size from the page level allocator with * @gfp_mask flags. Map them into contiguous kernel virtual space. * -* Reclaim modifiers in @gfp_mask - __GFP_NORETRY, __GFP_RETRY_MAYFAIL -* and __GFP_NOFAIL are not supported -* -* Any use of gfp flags outside of GFP_KERNEL should be consulted -* with mm people. +* Semantics of @gfp_mask(including reclaim/retry modifiers such as +* __GFP_NOFAIL) are the same as in __vmalloc_node_range_noprof(). * * Return: pointer to the allocated memory or %NULL on error */ Signature · 1 line
2.47.3