RISC-V: Define pgprot_dmacoherent() for non-coherent devices
Subsystems (2)
PATCH 1/1 RISC-V: Define pgprot_dmacoherent() for non-coherent devices
The pgprot_dmacoherent() is used when allocating memory for non-coherent devices and by default pgprot_dmacoherent() is same as pgprot_noncached() unless architecture overrides it.
Currently, there is no pgprot_dmacoherent() definition for RISC-V hence non-coherent device memory is being mapped as IO thereby making CPU access to such memory slow.
Define pgprot_dmacoherent() to be same as pgprot_writecombine() for RISC-V so that CPU access non-coherent device memory as NOCACHE which is better than accessing it as IO.
--- arch/riscv/include/asm/pgtable.h | 2 ++ 1 file changed, 2 insertions(+)
arch/riscv/include/asm/pgtable.h +2 -0
@@ -653,6 +653,8 @@ static inline pgprot_t pgprot_writecombine(pgprot_t _prot)return __pgprot (prot); } +#define pgprot_dmacoherent pgprot_writecombine +/* * Both Svade and Svadu control the hardware behavior when the PTE A/D bits need to be set. By * default the M-mode firmware enables the hardware updating scheme when only Svadu is present in
Signature · 1 line
2.43.0
Quoted 23 lines · Anup Patel
The
pgprot_dmacoherent()is used when allocating memory for non-coherent devices and by defaultpgprot_dmacoherent()is same aspgprot_noncached()unless architecture overrides it.Currently, there is no
pgprot_dmacoherent()definition for RISC-V hence non-coherent device memory is being mapped as IO thereby making CPU access to such memory slow.Define
pgprot_dmacoherent()to be same aspgprot_writecombine()for RISC-V so that CPU access non-coherent device memory as NOCACHE which is better than accessing it as IO.Fixes ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/asm/pgtable.h | 2 ++ 1 file changed, 2 insertions(+)arch/riscv/include/asm/pgtable.h +0
-0
arch/riscv/include/asm/pgtable.h static inline pgprot_t pgprot_writecombine(pgprot_t _prot) · line 656
Quoted 4 lines
arch/riscv/include/asm/pgtable.h +1
-0@@ -653,6 +653,8 @@ static inline pgprot_t pgprot_writecombine(pgprot_t _prot)return __pgprot (prot); } +#define pgprot_dmacoherent pgprot_writecombine
I missed this patch and sent out a duplicate one [1]. Maybe the comments from [1] could be appended to this one.
Quoted 13 lines
arch/riscv/include/asm/pgtable.h +1
-0+/* * Both Svade and Svadu control the hardware behavior when the PTE A/D bits need to be set. By * default the M-mode firmware enables the hardware updating scheme when only Svadu is present in Signature · 7 lines
2.43.0 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 27 lines · Guo Ren
Quoted 26 lines · Anup Patel
The
pgprot_dmacoherent()is used when allocating memory for non-coherent devices and by defaultpgprot_dmacoherent()is same aspgprot_noncached()unless architecture overrides it.Currently, there is no
pgprot_dmacoherent()definition for RISC-V hence non-coherent device memory is being mapped as IO thereby making CPU access to such memory slow.Define
pgprot_dmacoherent()to be same aspgprot_writecombine()for RISC-V so that CPU access non-coherent device memory as NOCACHE which is better than accessing it as IO.Fixes ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")Signed-off-by Anup Patel <[email protected]>--- arch/riscv/include/asm/pgtable.h | 2 ++ 1 file changed, 2 insertions(+)arch/riscv/include/asm/pgtable.h +0
-0@@ -653,6 +653,8 @@ static inline pgprot_t pgprot_writecombine(pgprot_t _prot)return __pgprot (prot); }
Quoted 3 lines
arch/riscv/include/asm/pgtable.h static inline pgprot_t pgprot_writecombine(pgprot_t _prot) · line 656
Quoted 1 line
arch/riscv/include/asm/pgtable.h +1
-0+#define pgprot_dmacoherent pgprot_writecombineI missed this patch and sent out a duplicate one [1]. Maybe the comments from [1] could be appended to this one.
[1]: https://lore.kernel.org/linux-riscv/[email protected]/
Quoted 22 lines
Quoted 13 lines
arch/riscv/include/asm/pgtable.h +1
-0+/* * Both Svade and Svadu control the hardware behavior when the PTE A/D bits need to be set. By * default the M-mode firmware enables the hardware updating scheme when only Svadu is present in Signature · 7 lines
2.43.0 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 12 lines · Anup Patel
The
pgprot_dmacoherent()is used when allocating memory for non-coherent devices and by defaultpgprot_dmacoherent()is same aspgprot_noncached()unless architecture overrides it.Currently, there is no
pgprot_dmacoherent()definition for RISC-V hence non-coherent device memory is being mapped as IO thereby making CPU access to such memory slow.
Quoted 6 lines
Define
pgprot_dmacoherent()to be same aspgprot_writecombine()for RISC-V so that CPU access non-coherent device memory as NOCACHE which is better than accessing it as IO.Fixes ff689fd21cb1 ("riscv: add RISC-V Svpbmt extension support")Signed-off-by Anup Patel <[email protected]>
Quoted 26 lines
---
arch/riscv/include/asm/pgtable.h| 2 ++1 file changed, 2 insertions(+)arch/riscv/include/asm/pgtable.h +2
-0@@ -653,6 +653,8 @@ static inline pgprot_t pgprot_writecombine(pgprot_t _prot)return __pgprot (prot); } +#define pgprot_dmacoherent pgprot_writecombine +/* * Both Svade and Svadu control the hardware behavior when the PTE A/D bits need to be set. By * default the M-mode firmware enables the hardware updating scheme when only Svadu is present in Signature · 7 lines
2.43.0 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
This patch was applied to riscv/linux.git (fixes) by Paul Walmsley <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (fixes)
by Paul Walmsley <[email protected]>:
Quoted 9 lines · On Wed, 20 Aug 2025 20:53:16 +0530 you wrote:
The
pgprot_dmacoherent()is used when allocating memory for non-coherent devices and by defaultpgprot_dmacoherent()is same aspgprot_noncached()unless architecture overrides it.Currently, there is no
pgprot_dmacoherent()definition for RISC-V hence non-coherent device memory is being mapped as IO thereby making CPU access to such memory slow.[...]
Here is the summary with links:
- RISC-V: Define pgprot_dmacoherent() for non-coherent devices
https://git.kernel.org/riscv/c/ca525d53f994
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Hi,
arch/riscv/include/asm/pgtable.h static inline pgprot_t pgprot_writecombine(pgprot_t _prot) · line 656
Quoted 10 lines · Anup Patel
The
pgprot_dmacoherent()is used when allocating memory for non-coherent devices and by defaultpgprot_dmacoherent()is same aspgprot_noncached()unless architecture overrides it.arch/riscv/include/asm/pgtable.h +1
-0+#define pgprot_dmacoherent pgprot_writecombine
This single-line patch, as implemented in commit 00b58d2c25d10fecffbebaa0c369fc9d0a6de397 for 6.6.y, breaks allwinner D1 SDcard handling:
[ 0.000000] Linux version 6.6.115 (surfin@nedoserver) (riscv64-unknown-linux-gnu-gcc () 11.3.0, GNU ld (GNU Binutils) 2.38) #1 Tue May 5 10:25:47 MSK 2026
[ 4.886823] sunxi-mmc 4020000.mmc: Got CD GPIO [ 4.893625] sunxi-mmc 4021000.mmc: allocated mmc-pwrseq [ 4.941711] sunxi-mmc 4021000.mmc: initialized, max. request size: 2048 KB, uses new timings mode [ 4.958033] sunxi-mmc 4020000.mmc: initialized, max. request size: 2048 KB, uses new timings mode [ 4.990692] sunxi-mmc 4021000.mmc: card claims to support voltages below defined range [ 5.009712] mmc1: new high speed SDIO card at address 0001
then following never happens with that patch, i.e. no SD card is found.
#[ 5.109896] mmc0: new high speed SDHC card at address 0001 #[ 5.116546] mmcblk0: mmc0:0001 EB1QT 29.8 GiB #[ 5.128887] mmcblk0: p1 p2
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv