Skip to contentSkip to conversation

mkfs: fix copy-paste error in calculate_rtgroup_geometry

PATCH In review Darrick J. Wong 2 participants 2 messages Oct 11, 2025 – Oct 13, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mkfs: fix copy-paste error in calculate_rtgroup_geometry

From: Darrick J. Wong <[email protected]>

Fix this copy-paste error -- we should calculate the rt volume concurrency either if the user gave us an explicit option, or if they didn't but the rt volume is an SSD.

Cc <[email protected]> # v6.13.0
Fixes 34738ff0ee80de ("mkfs: allow sizing realtime allocation groups for concurrency")
---
 mkfs/xfs_mkfs.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mkfs/xfs_mkfs.c +1 -1
index 0511f1745c47c1..bc6a28b63c24b2 100644
@@ -4506,7 +4506,7 @@ _("rgsize (%s) not a multiple of fs blk size (%d)\n"),
 		cfg->rgsize = cfg->rtblocks;
 		cfg->rgcount = 0;
 	} else if (cli->rtvol_concurrency > 0 ||
-		   (cli->data_concurrency == -1 && rtdev_is_solidstate(xi))) {
+		   (cli->rtvol_concurrency == -1 && rtdev_is_solidstate(xi))) {
 		calc_concurrency_rtgroup_geometry(cfg, cli, xi);
 	} else if (is_power_of_2(cfg->rtextblocks)) {
 		cfg->rgsize = calc_rgsize_extsize_power(cfg);