Skip to contentSkip to conversation

checkpatch: Don't warn on "orhapned" DT schema file

PATCH Superseded Andy Shevchenko 2 participants 4 messages Oct 27, 2025 Checkpatch

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 checkpatch: Don't warn on "orhapned" DT schema file

Currently checkpatch warns is the DT schema file is absent in MAINTAINERS. However the DT schema files are self-contained in this sense and have embedded information about maintainers of it. This is a requirement. Hence, avoid checkpatch warning about it.

---

v2: drop some leftovers

 scripts/checkpatch.pl | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
scripts/checkpatch.pl +6 -3
index 6729f18e5654..db274a7c2fb0 100755
@@ -3441,9 +3441,12 @@ sub process {
 		     ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
 		      (defined($1) || defined($2))))) {
 			$is_patch = 1;
-			$reported_maintainer_file = 1;
-			WARN("FILE_PATH_CHANGES",
-			     "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
+			# DT bindings are incorporate maintainer information, no need to report
+			if ($realfile !~ m@^Documentation/devicetree/bindings/@)) {
+				$reported_maintainer_file = 1;
+				WARN("FILE_PATH_CHANGES",
+				     "added, moved or deleted file(s), does MAINTAINERS need updating?\n" . $herecurr);
+			}
 		}
 
 # Check for adding new DT bindings not in schema format
Signature · 1 line
2.50.1
#1 lore raw
Quoted 6 lines · Andy Shevchenko

Currently checkpatch warns is the DT schema file is absent in MAINTAINERS. However the DT schema files are self-contained in this sense and have embedded information about maintainers of it. This is a requirement. Hence, avoid checkpatch warning about it.

No, that's not true.

First, there is no such tag. Second, I never requested it.

NAK

Best regards,
Krzysztof

#2 lore raw
Quoted 11 lines · Krzysztof Kozlowski
Quoted 6 lines · Andy Shevchenko

Currently checkpatch warns is the DT schema file is absent in MAINTAINERS. However the DT schema files are self-contained in this sense and have embedded information about maintainers of it. This is a requirement. Hence, avoid checkpatch warning about it.

No, that's not true.

First, there is no such tag.

No, that's not true.

$ git log --oneline --grep ^Requested-by: | wc -l
357
Quoted 3 lines

Second, I never requested it.

NAK

Fair enough, I'll drop the tag.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw
Quoted 9 lines · Andy Shevchenko
Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · Andy Shevchenko

Currently checkpatch warns is the DT schema file is absent in MAINTAINERS. However the DT schema files are self-contained in this sense and have embedded information about maintainers of it. This is a requirement. Hence, avoid checkpatch warning about it.

Quoted 7 lines
Quoted 3 lines

No, that's not true.

First, there is no such tag.

No, that's not true.

$ git log --oneline --grep ^Requested-by: | wc -l

No, you do like this:
git grep Requested-by
and then find it in the list of approved tags.

Quoted 7 lines

357

Quoted 3 lines

Second, I never requested it.

NAK

Fair enough, I'll drop the tag.

It's not even solving the problem you wanted. You claimed there is some sort of problem that maintainer update is one at last patch of patchset. I claimed that there is no, because it is standard and completely fine way of doing things and whatever checkpatch is reported is just false positive.

You did not fix that false positive.

Best regards,
Krzysztof