Skip to contentSkip to conversation

drm/amdgpu: unlock and cleanup on error in amdgpu_cs_parser_bos()

PATCH New Dan Carpenter 1 participant 1 message Oct 22, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: unlock and cleanup on error in amdgpu_cs_parser_bos()

If amdgpu_hmm_range_alloc() fails then free the previous iterations and call mutex_unlock(&p->bo_list->bo_list_mutex) before returning.

Fixes e095b55155ef ("drm/amdgpu: use user provided hmm_range buffer in amdgpu_ttm_tt_get_user_pages")
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +4 -2
index ecdfe6cb36cc..dac0b15823f2 100644
@@ -892,8 +892,10 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
 		struct amdgpu_bo *bo = e->bo;
 
 		e->range = amdgpu_hmm_range_alloc(NULL);
-		if (unlikely(!e->range))
-			return -ENOMEM;
+		if (unlikely(!e->range)) {
+			r = -ENOMEM;
+			goto out_free_user_pages;
+		}
 
 		r = amdgpu_ttm_tt_get_user_pages(bo, e->range);
 		if (r)
Signature · 1 line
2.51.0