Skip to contentSkip to conversation

uaccess: decouple INLINE_COPY_FROM_USER and CONFIG_RUST

PATCH Superseded Yury Norov (NVIDIA) 3 participants 5 messages Oct 23, 2025 – Mar 24

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 uaccess: decouple INLINE_COPY_FROM_USER and CONFIG_RUST

Commit 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with CONFIG_RUST") exports _copy_{from,to}_user() unconditionally, if RUST is enabled. This pollutes exported symbols namespace, and spreads RUST ifdefery in core files.

It's better to declare a corresponding helper under the rust/helpers, similarly to how non-underscored copy_{from,to}_user() is handled.

---
 lib/usercopy.c         |  4 ++--
 rust/helpers/uaccess.c | 12 ++++++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)
lib/usercopy.c +2 -2
index 7b17b83c8042..b00a3a957de6 100644
@@ -12,7 +12,7 @@
 
 /* out-of-line parts */
 
-#if !defined(INLINE_COPY_FROM_USER) || defined(CONFIG_RUST)
+#if !defined(INLINE_COPY_FROM_USER)
 unsigned long _copy_from_user(void *to, const void __user *from, unsigned long n)
 {
 	return _inline_copy_from_user(to, from, n);
@@ -20,7 +20,7 @@ unsigned long _copy_from_user(void *to, const void __user *from, unsigned long n
 EXPORT_SYMBOL(_copy_from_user);
 #endif
 
-#if !defined(INLINE_COPY_TO_USER) || defined(CONFIG_RUST)
+#if !defined(INLINE_COPY_TO_USER)
 unsigned long _copy_to_user(void __user *to, const void *from, unsigned long n)
 {
 	return _inline_copy_to_user(to, from, n);
rust/helpers/uaccess.c +12 -0
index f49076f813cd..4629b2d15529 100644
@@ -13,3 +13,15 @@ unsigned long rust_helper_copy_to_user(void __user *to, const void *from,
 {
 	return copy_to_user(to, from, n);
 }
+
+#ifdef INLINE_COPY_FROM_USER
+unsigned long rust_helper__copy_from_user(void *to, const void __user *from, unsigned long n)
+{
+	return _inline_copy_from_user(to, from, n);
+}
+
+unsigned long rust_helper__copy_to_user(void __user *to, const void *from, unsigned long n)
+{
+	return _inline_copy_to_user(to, from, n);
+}
+#endif
Signature · 1 line
2.43.0
reviewer Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 9 lines · Yury Norov (NVIDIA)

Commit 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with CONFIG_RUST") exports _copy_{from,to}_user() unconditionally, if RUST is enabled. This pollutes exported symbols namespace, and spreads RUST ifdefery in core files.

It's better to declare a corresponding helper under the rust/helpers, similarly to how non-underscored copy_{from,to}_user() is handled.

Overall LGTM:

In include/linux/uaccess.h there is the comment:

Rust code always uses the extern definition.

I think we should reword this comment as part of this change. You can say that Rust accesses _inline_copy_from_user() through a helper, or similar.

After all, when using LTO or other mechanism to inline helpers, it is no longer the case that Rust always uses the a function call.

Alice

author
#2 lore raw
Quoted 18 lines · Alice Ryhl
Quoted 9 lines · Yury Norov (NVIDIA)

Commit 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with CONFIG_RUST") exports _copy_{from,to}_user() unconditionally, if RUST is enabled. This pollutes exported symbols namespace, and spreads RUST ifdefery in core files.

It's better to declare a corresponding helper under the rust/helpers, similarly to how non-underscored copy_{from,to}_user() is handled.

Overall LGTM:

In include/linux/uaccess.h there is the comment:

Quoted 8 lines

Rust code always uses the extern definition.

I think we should reword this comment as part of this change. You can say that Rust accesses _inline_copy_from_user() through a helper, or similar.

After all, when using LTO or other mechanism to inline helpers, it is no longer the case that Rust always uses the a function call.

It is actually worth to just drop the rust part of the comment - with this patch there's nothing special in managing the _copy_from_user().

I'll send v2. Thanks for review!

Thanks,
Yury

reviewer
#3 lore raw
Quoted 26 lines · Yury Norov
Quoted 24 lines · Alice Ryhl
Quoted 9 lines · Yury Norov (NVIDIA)

Commit 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with CONFIG_RUST") exports _copy_{from,to}_user() unconditionally, if RUST is enabled. This pollutes exported symbols namespace, and spreads RUST ifdefery in core files.

It's better to declare a corresponding helper under the rust/helpers, similarly to how non-underscored copy_{from,to}_user() is handled.

Overall LGTM:

In include/linux/uaccess.h there is the comment:

Rust code always uses the extern definition.

I think we should reword this comment as part of this change. You can say that Rust accesses _inline_copy_from_user() through a helper, or similar.

Quoted 5 lines
Quoted 2 lines

After all, when using LTO or other mechanism to inline helpers, it is no longer the case that Rust always uses the a function call.

It is actually worth to just drop the rust part of the comment - with this patch there's nothing special in managing the _copy_from_user().

Yeah, makes sense.

Alice

#4 lore raw
In reply to Yury Norov (NVIDIA)

Le 23/10/2025 à 19:16, Yury Norov (NVIDIA) a écrit :

Quoted 41 lines

Commit 1f9a8286bc0c ("uaccess: always export _copy_[from|to]_user with CONFIG_RUST") exports _copy_{from,to}_user() unconditionally, if RUST is enabled. This pollutes exported symbols namespace, and spreads RUST ifdefery in core files.

It's better to declare a corresponding helper under the rust/helpers, similarly to how non-underscored copy_{from,to}_user() is handled.

---
  lib/usercopy.c         |  4 ++--
  rust/helpers/uaccess.c | 12 ++++++++++++
  2 files changed, 14 insertions(+), 2 deletions(-)
lib/usercopy.c +2 -2
index 7b17b83c8042..b00a3a957de6 100644
@@ -12,7 +12,7 @@
 
  /* out-of-line parts */
 
-#if !defined(INLINE_COPY_FROM_USER) || defined(CONFIG_RUST)
+#if !defined(INLINE_COPY_FROM_USER)
  unsigned long _copy_from_user(void *to, const void __user *from, unsigned long n)
  {
  	return _inline_copy_from_user(to, from, n);
@@ -20,7 +20,7 @@ unsigned long _copy_from_user(void *to, const void __user *from, unsigned long n
  EXPORT_SYMBOL(_copy_from_user);
  #endif
 
-#if !defined(INLINE_COPY_TO_USER) || defined(CONFIG_RUST)
+#if !defined(INLINE_COPY_TO_USER)
  unsigned long _copy_to_user(void __user *to, const void *from, unsigned long n)
  {
  	return _inline_copy_to_user(to, from, n);
rust/helpers/uaccess.c +0 -0
index f49076f813cd..4629b2d15529 100644

rust/helpers/uaccess.c unsigned long rust_helper_copy_to_user(void __user *to, const void *from, · line 22

Quoted 10 lines
rust/helpers/uaccess.c +7 -0
@@ -13,3 +13,15 @@ unsigned long rust_helper_copy_to_user(void __user *to, const void *from,
  {
  	return copy_to_user(to, from, n);
  }
+
+#ifdef INLINE_COPY_FROM_USER
+unsigned long rust_helper__copy_from_user(void *to, const void __user *from, unsigned long n)
+{
+	return _inline_copy_from_user(to, from, n);
+}
+

Shouldn't the below part be guarded by INLINE_COPY_TO_USER ?

Quoted 5 lines
rust/helpers/uaccess.c +5 -0
+unsigned long rust_helper__copy_to_user(void __user *to, const void *from, unsigned long n)
+{
+	return _inline_copy_to_user(to, from, n);
+}
+#endif