ASoC: SDCA: bug fix while parsing mipi-sdca-control-cn-list
Subsystems (3)
PATCH 1/1 ASoC: SDCA: bug fix while parsing mipi-sdca-control-cn-list
"struct sdca_control" declares "values" field as integer array. But the memory allocated to it is of char array. This causes crash for sdca_parse_function API. This patch addresses the issue by allocating correct data size.
--- sound/soc/sdca/sdca_functions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
sound/soc/sdca/sdca_functions.c +2 -1
@@ -950,7 +950,8 @@ static int find_sdca_entity_control(struct device *dev, struct sdca_entity *entireturn ret; } - control->values =devm_kzalloc (dev,hweight64 (control->cn_list),GFP_KERNEL ); + control->values =devm_kzalloc (dev,hweight64 (control->cn_list) *sizeof (int ), +GFP_KERNEL );if (!control->values)return -ENOMEM ;
Signature · 1 line
2.25.1
Charles Keepax
maintainerQuoted 7 lines · Niranjan H Y
"struct
sdca_control" declares "values" field as integer array. But the memory allocated to it is of char array. This causes crash forsdca_parse_functionAPI. This patch addresses the issue by allocating correct data size.Signed-off-by Niranjan H Y <[email protected]>---
Thanks very much for spotting this.
Quoted 8 lines
sound/soc/sdca/sdca_functions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)sound/soc/sdca/sdca_functions.c +0
-0
sound/soc/sdca/sdca_functions.c static int find_sdca_entity_control(struct device *dev, struct sdca_entity *enti · line 954
Quoted 6 lines
sound/soc/sdca/sdca_functions.c +2
-1@@ -950,7 +950,8 @@ static int find_sdca_entity_control(struct device *dev, struct sdca_entity *entireturn ret; } - control->values =devm_kzalloc (dev,hweight64 (control->cn_list),GFP_KERNEL ); + control->values =devm_kzalloc (dev,hweight64 (control->cn_list) *sizeof (int ), +GFP_KERNEL );
Should probably switch to devm_kcalloc, rather than doing the multiply manually.
Thanks,
Charles
Quoted 6 lines
sound/soc/sdca/sdca_functions.c +0
-0if (!control->values)return -ENOMEM ;Signature · 1 line
2.25.1