Skip to contentSkip to conversation

xhci: dbgtty: fix device unregister: fixup

PATCH Superseded Łukasz Bartosik 2 participants 2 messages Nov 27, 2025

Subsystems (3)
Stable branch USB USB xHCI driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Łukasz Bartosik

author
#0 lore raw

PATCH 1/1 xhci: dbgtty: fix device unregister: fixup

From: Łukasz Bartosik <[email protected]>

This fixup replaces tty_vhangup() call with call to tty_port_tty_vhangup(). Both calls hangup tty device synchronously however tty_port_tty_vhangup() increases reference count during the hangup operation using scoped_guard(tty_port_tty).

Fixes 1f73b8b56cf3 ("xhci: dbgtty: fix device unregister")
Signed-off-by Łukasz Bartosik <[email protected]>
---
 drivers/usb/host/xhci-dbgtty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/xhci-dbgtty.c +1 -1
index 57cdda4e09c8..90282e51e23e 100644
@@ -554,7 +554,7 @@ static void xhci_dbc_tty_unregister_device(struct xhci_dbc *dbc)
 	 * Hang up the TTY. This wakes up any blocked
 	 * writers and causes subsequent writes to fail.
 	 */
-	tty_vhangup(port->port.tty);
+	tty_port_tty_vhangup(&port->port);
 
 	tty_unregister_device(dbc_tty_driver, port->minor);
 	xhci_dbc_tty_exit_port(port);
Signature · 1 line
2.52.0.487.g5c8c507ade-goog
build bot
#1 lore raw
FYI: kernel test robot notices the stable kernel rule is not satisfied.

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: [email protected]" in the sign-off area to have the patch automatically included in the stable tree.
Subject: [PATCH v1] xhci: dbgtty: fix device unregister: fixup

Link https://lore.kernel.org/stable/20251127101904.3097504-1-ukaszb%40google.com open here
Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki