Skip to contentSkip to conversation

pinctrl: fix compile test defaults

PATCH Superseded Johan Hovold 2 participants 3 messages Dec 10, 2025 – Dec 12, 2025

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: fix compile test defaults

Enabling compile testing should not enable every individual driver (we have "allyesconfig" for that) but two new drivers got this wrong.

Fixes 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
Fixes 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
Cc Conor Dooley <[email protected]>
---
 drivers/pinctrl/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/Kconfig +2 -2
index bc7f37afc48b..ce5685215b92 100644
@@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
+	default ARCH_MICROCHIP
 	help
 	  This selects the pinctrl driver for gpio2 on pic64gx.
 
@@ -511,7 +511,7 @@ config PINCTRL_POLARFIRE_SOC
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
+	default ARCH_MICROCHIP
 	help
 	  This selects the pinctrl driver for Microchip Polarfire SoC.
 
Signature · 1 line
2.52.0
#1 lore raw
Quoted 16 lines · Johan Hovold

Enabling compile testing should not enable every individual driver (we have "allyesconfig" for that) but two new drivers got this wrong.

Fixes 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
Fixes 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
Cc Conor Dooley <[email protected]>
---
 drivers/pinctrl/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pinctrl/Kconfig +0 -0
index bc7f37afc48b..ce5685215b92 100644

drivers/pinctrl/Kconfig config PINCTRL_PIC64GX · line 494

Quoted 5 lines
drivers/pinctrl/Kconfig +1 -1
@@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
+	default ARCH_MICROCHIP

Nah, not a fan of this kind of thing, please just make it default n if this compile test behaviour bothers you.

Quoted 15 lines
drivers/pinctrl/Kconfig +1 -1
 	help
 	  This selects the pinctrl driver for gpio2 on pic64gx.
 
@@ -511,7 +511,7 @@ config PINCTRL_POLARFIRE_SOC
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
+	default ARCH_MICROCHIP
 	help
 	  This selects the pinctrl driver for Microchip Polarfire SoC.
 
Signature · 1 line
2.52.0
#2 lore raw
Quoted 12 lines · Conor Dooley
Quoted 11 lines · Johan Hovold

Enabling compile testing should not enable every individual driver (we have "allyesconfig" for that) but two new drivers got this wrong.

Fixes 38cf9d641314 ("pinctrl: add pic64gx "gpio2" pinmux driver")
Fixes 46397274da22 ("pinctrl: add polarfire soc iomux0 pinmux driver")
Cc Conor Dooley <[email protected]>
---
 drivers/pinctrl/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Quoted 13 lines

drivers/pinctrl/Kconfig config PINCTRL_PIC64GX · line 494

Quoted 10 lines
drivers/pinctrl/Kconfig +1 -1
index bc7f37afc48b..ce5685215b92 100644
@@ -491,7 +491,7 @@ config PINCTRL_PIC64GX
 	depends on ARCH_MICROCHIP || COMPILE_TEST
 	depends on OF
 	select GENERIC_PINCONF
-	default y
+	default ARCH_MICROCHIP

Nah, not a fan of this kind of thing, please just make it default n if this compile test behaviour bothers you.

Sure, I guess that's better here as these drivers are not needed in every Microchip build either.

Johan