Skip to contentSkip to conversation

mmc: dw_mmc: add dw_mci_prepare_desc() for both of 32bit and 64bit DMA

bug report Dan Carpenter 2 participants 2 messages Dec 17, 2025 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

Hello Shawn Lin,

Commit af7dde31afcc ("mmc: dw_mmc: add dw_mci_prepare_desc() for both of 32bit and 64bit DMA") from Nov 26, 2025 (linux-next), leads to the following Smatch static checker warning:

	drivers/mmc/host/dw_mmc.c:597 dw_mci_prepare_desc()
	error: uninitialized symbol 'desc'.

drivers/mmc/host/dw_mmc.c

    578 static inline int dw_mci_prepare_desc(struct dw_mci *host, struct mmc_data *data,
    579                                       unsigned int sg_len, bool is_64bit)
    580 {
    581         unsigned int desc_len;
    582         struct idmac_desc *desc_first, *desc_last, *desc;
    583         struct idmac_desc_64addr *desc64_first, *desc64_last, *desc64;
    584         u32 val, des0;
    585         int i, err;
    586 
    587         if (is_64bit)
    588                 desc64_first = desc64_last = desc64 = host->sg_cpu;
    589         else
    590                 desc_first = desc_last = desc = host->sg_cpu;
                                                 ^^^^

    591 
    592         for (i = 0; i < sg_len; i++) {
    593                 unsigned int length = sg_dma_len(&data->sg[i]);
    594 
    595                 u64 mem_addr = sg_dma_address(&data->sg[i]);
    596 

--> 597 for ( ; length ; desc++) {

desc is only initialized for 32bit.

    598                         desc_len = (length <= DW_MCI_DESC_DATA_LENGTH) ?
    599                                    length : DW_MCI_DESC_DATA_LENGTH;
    600 
    601                         length -= desc_len;
    602 
    603                         /*
    604                          * Wait for the former clear OWN bit operation
    605                          * of IDMAC to make sure that this descriptor
    606                          * isn't still owned by IDMAC as IDMAC's write
    607                          * ops and CPU's read ops are asynchronous.
    608                          */
    609                         if (is_64bit)
    610                                 err = readl_poll_timeout_atomic(&desc64->des0, val,
    611                                         IDMAC_OWN_CLR64(val), 10, 100 * USEC_PER_MSEC);
    612                         else
    613                                 err = readl_poll_timeout_atomic(&desc->des0, val,
    614                                         IDMAC_OWN_CLR64(val), 10, 100 * USEC_PER_MSEC);
    615                         if (err)
    616                                 goto err_own_bit;
    617 
    618                         des0 = IDMAC_DES0_OWN | IDMAC_DES0_DIC | IDMAC_DES0_CH;
    619                         if (is_64bit)
    620                                 desc64->des0 = des0;
    621                         else
    622                                 desc->des0 = cpu_to_le32(des0);
    623 
    624                         /*
    625                          * 1. Set OWN bit and disable interrupts for this descriptor
    626                          * 2. Set Buffer length
    627                          * Set physical address to DMA to/from
    628                          */
    629                         if (is_64bit) {
    630                                 desc64->des0 = IDMAC_DES0_OWN | IDMAC_DES0_DIC | IDMAC_DES0_CH;
    631                                 IDMAC_64ADDR_SET_BUFFER1_SIZE(desc64, desc_len);
    632                                 desc64->des4 = mem_addr & 0xffffffff;
    633                                 desc64->des5 = mem_addr >> 32;
    634                         } else {
    635                                 IDMAC_SET_BUFFER1_SIZE(desc, desc_len);
    636                                 desc->des2 = cpu_to_le32(mem_addr);
    637                         }
    638 
    639                         /* Update physical address for the next desc */
    640                         mem_addr += desc_len;
    641 
    642                         /* Save pointer to the last descriptor */
    643                         if (is_64bit)
    644                                 desc64_last = desc64;
    645                         else
    646                                 desc_last = desc;
    647                 }
    648         }
    649 
    650         /* Set the first descriptor and the last descriptor */
    651         if (is_64bit) {
    652                 desc64_first->des0 |= IDMAC_DES0_FD;
    653                 desc64_last->des0 &= ~(IDMAC_DES0_CH | IDMAC_DES0_DIC);
    654                 desc64_last->des0 |= IDMAC_DES0_LD;
    655         } else {
    656                 desc_first->des0 |= cpu_to_le32(IDMAC_DES0_FD);
    657                 desc_last->des0 &= cpu_to_le32(~(IDMAC_DES0_CH | IDMAC_DES0_DIC));
    658                 desc_last->des0 |= cpu_to_le32(IDMAC_DES0_LD);
    659         }
    660 
    661         return 0;
    662 err_own_bit:
    663         /* restore the descriptor chain as it's polluted */
    664         dev_dbg(host->dev, "descriptor is still owned by IDMAC.\n");
    665         memset(host->sg_cpu, 0, DESC_RING_BUF_SZ);
    666         dw_mci_idmac_init(host);
    667         return -EINVAL;
    668 }

regards,
dan carpenter

#1 lore raw

Hi Dan,

Quoted 9 lines · Dan Carpenter

Hello Shawn Lin,

Commit af7dde31afcc ("mmc: dw_mmc: add dw_mci_prepare_desc() for both of 32bit and 64bit DMA") from Nov 26, 2025 (linux-next), leads to the following Smatch static checker warning:

	drivers/mmc/host/dw_mmc.c:597 dw_mci_prepare_desc()
	error: uninitialized symbol 'desc'.

Thanks for pointing out this issue. I've sent an incremental patch.

Ulf, could you please help fold it into the offending patch? Sorry for the inconvenience.

Quoted 101 lines

drivers/mmc/host/dw_mmc.c

     578 static inline int dw_mci_prepare_desc(struct dw_mci *host, struct mmc_data *data,
     579                                       unsigned int sg_len, bool is_64bit)
     580 {
     581         unsigned int desc_len;
     582         struct idmac_desc *desc_first, *desc_last, *desc;
     583         struct idmac_desc_64addr *desc64_first, *desc64_last, *desc64;
     584         u32 val, des0;
     585         int i, err;
     586
     587         if (is_64bit)
     588                 desc64_first = desc64_last = desc64 = host->sg_cpu;
     589         else
     590                 desc_first = desc_last = desc = host->sg_cpu;
                                                  ^^^^

     591
     592         for (i = 0; i < sg_len; i++) {
     593                 unsigned int length = sg_dma_len(&data->sg[i]);
     594
     595                 u64 mem_addr = sg_dma_address(&data->sg[i]);
     596

--> 597 for ( ; length ; desc++) {

desc is only initialized for 32bit.

     598                         desc_len = (length <= DW_MCI_DESC_DATA_LENGTH) ?
     599                                    length : DW_MCI_DESC_DATA_LENGTH;
     600
     601                         length -= desc_len;
     602
     603                         /*
     604                          * Wait for the former clear OWN bit operation
     605                          * of IDMAC to make sure that this descriptor
     606                          * isn't still owned by IDMAC as IDMAC's write
     607                          * ops and CPU's read ops are asynchronous.
     608                          */
     609                         if (is_64bit)
     610                                 err = readl_poll_timeout_atomic(&desc64->des0, val,
     611                                         IDMAC_OWN_CLR64(val), 10, 100 * USEC_PER_MSEC);
     612                         else
     613                                 err = readl_poll_timeout_atomic(&desc->des0, val,
     614                                         IDMAC_OWN_CLR64(val), 10, 100 * USEC_PER_MSEC);
     615                         if (err)
     616                                 goto err_own_bit;
     617
     618                         des0 = IDMAC_DES0_OWN | IDMAC_DES0_DIC | IDMAC_DES0_CH;
     619                         if (is_64bit)
     620                                 desc64->des0 = des0;
     621                         else
     622                                 desc->des0 = cpu_to_le32(des0);
     623
     624                         /*
     625                          * 1. Set OWN bit and disable interrupts for this descriptor
     626                          * 2. Set Buffer length
     627                          * Set physical address to DMA to/from
     628                          */
     629                         if (is_64bit) {
     630                                 desc64->des0 = IDMAC_DES0_OWN | IDMAC_DES0_DIC | IDMAC_DES0_CH;
     631                                 IDMAC_64ADDR_SET_BUFFER1_SIZE(desc64, desc_len);
     632                                 desc64->des4 = mem_addr & 0xffffffff;
     633                                 desc64->des5 = mem_addr >> 32;
     634                         } else {
     635                                 IDMAC_SET_BUFFER1_SIZE(desc, desc_len);
     636                                 desc->des2 = cpu_to_le32(mem_addr);
     637                         }
     638
     639                         /* Update physical address for the next desc */
     640                         mem_addr += desc_len;
     641
     642                         /* Save pointer to the last descriptor */
     643                         if (is_64bit)
     644                                 desc64_last = desc64;
     645                         else
     646                                 desc_last = desc;
     647                 }
     648         }
     649
     650         /* Set the first descriptor and the last descriptor */
     651         if (is_64bit) {
     652                 desc64_first->des0 |= IDMAC_DES0_FD;
     653                 desc64_last->des0 &= ~(IDMAC_DES0_CH | IDMAC_DES0_DIC);
     654                 desc64_last->des0 |= IDMAC_DES0_LD;
     655         } else {
     656                 desc_first->des0 |= cpu_to_le32(IDMAC_DES0_FD);
     657                 desc_last->des0 &= cpu_to_le32(~(IDMAC_DES0_CH | IDMAC_DES0_DIC));
     658                 desc_last->des0 |= cpu_to_le32(IDMAC_DES0_LD);
     659         }
     660
     661         return 0;
     662 err_own_bit:
     663         /* restore the descriptor chain as it's polluted */
     664         dev_dbg(host->dev, "descriptor is still owned by IDMAC.\n");
     665         memset(host->sg_cpu, 0, DESC_RING_BUF_SZ);
     666         dw_mci_idmac_init(host);
     667         return -EINVAL;
     668 }

regards,
dan carpenter