Skip to contentSkip to conversation

dmaengine: sh: Discard pm_runtime_put() return value

PATCH RESEND In review Rafael J. Wysocki 2 participants 3 messages Jan 8 – Jan 9 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 dmaengine: sh: Discard pm_runtime_put() return value

From: Rafael J. Wysocki <[email protected]>

Clobbering an error value to be returned from shdma_tx_submit() with a pm_runtime_put() return value is not particularly useful, especially if the latter is 0, so stop doing that.

This will facilitate a planned change of the pm_runtime_put() return type to void in the future.

---

This is requisite for converting pm_runtime_put() into a void function.

If you decide to pick it up, please let me know.

Otherwise, an ACK or equivalent will be appreciated, but also the lack of specific criticism will be eventually regarded as consent.

Originally posted here:

https://lore.kernel.org/linux-pm/[email protected]/

---
 drivers/dma/sh/shdma-base.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/sh/shdma-base.c +1 -1
@@ -143,7 +143,7 @@ static dma_cookie_t shdma_tx_submit(stru
 				}
 
 				schan->pm_state = SHDMA_PM_ESTABLISHED;
-				ret = pm_runtime_put(schan->dev);
+				pm_runtime_put(schan->dev);
 
 				spin_unlock_irq(&schan->chan_lock);
 				return ret;
maintainer
#1 lore raw
Quoted 8 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

Clobbering an error value to be returned from shdma_tx_submit() with a pm_runtime_put() return value is not particularly useful, especially if the latter is 0, so stop doing that.

This will facilitate a planned change of the pm_runtime_put() return type to void in the future.

Hey Rafael,

This is commit b442377c0ea2044a8f50ffa3fe59448f9ed922c in my tree.

Quoted 32 lines

---

This is requisite for converting pm_runtime_put() into a void function.

If you decide to pick it up, please let me know.

Otherwise, an ACK or equivalent will be appreciated, but also the lack of specific criticism will be eventually regarded as consent.

Originally posted here:

https://lore.kernel.org/linux-pm/[email protected]/

---
 drivers/dma/sh/shdma-base.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/dma/sh/shdma-base.c +1 -1
@@ -143,7 +143,7 @@ static dma_cookie_t shdma_tx_submit(stru
 				}
 
 				schan->pm_state = SHDMA_PM_ESTABLISHED;
-				ret = pm_runtime_put(schan->dev);
+				pm_runtime_put(schan->dev);
 
 				spin_unlock_irq(&schan->chan_lock);
 				return ret;
Signature · 1 line
~Vinod
#2 lore raw
Quoted 8 lines · Vinod Koul
Quoted 6 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

Clobbering an error value to be returned from shdma_tx_submit() with a pm_runtime_put() return value is not particularly useful, especially if the latter is 0, so stop doing that.

Quoted 6 lines
Quoted 2 lines

This will facilitate a planned change of the pm_runtime_put() return type to void in the future.

Hey Rafael,

This is commit b442377c0ea2044a8f50ffa3fe59448f9ed922c in my tree.

Cool, thanks!