Context based TLB invalidations
Subsystems (2)
Matthew Brost
maintainerv4 cover Context based TLB invalidations
Add support for context based TLB invalidations.
Matt
Matthew Brost (12):
drm/xe: Add normalize_invalidation_range
drm/xe: Make usm.asid_to_vm allocation use GFP_NOWAIT drm/xe: Add has_ctx_tlb_inval to device info
drm/xe: Add xe_device_asid_to_vm helper
drm/xe: Add vm to exec queues association
drm/xe: Taint TLB invalidation seqno lock with GFP_KERNEL drm/xe: Rename send_tlb_inval_ppgtt to send_tlb_inval_asid_ppgtt drm/xe: Add send_tlb_inval_ppgtt helper
drm/xe: Add xe_tlb_inval_idle helper
drm/xe: Add exec queue active vfunc
drm/xe: Add context-based invalidation to GuC TLB invalidation backend drm/xe: Enable context TLB invalidations for CI
drivers/gpu/drm/xe/xe_device.c | 25 +++ drivers/gpu/drm/xe/xe_device.h | 11 +- drivers/gpu/drm/xe/xe_device_types.h | 9 + drivers/gpu/drm/xe/xe_exec_queue.c | 7 +- drivers/gpu/drm/xe/xe_exec_queue_types.h | 5 + drivers/gpu/drm/xe/xe_execlist.c | 7 + drivers/gpu/drm/xe/xe_guc_submit.c | 6 + drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 238 ++++++++++++++++++----- drivers/gpu/drm/xe/xe_pci.c | 2 + drivers/gpu/drm/xe/xe_pci_types.h | 1 + drivers/gpu/drm/xe/xe_tlb_inval.c | 33 ++++ drivers/gpu/drm/xe/xe_tlb_inval.h | 2 + drivers/gpu/drm/xe/xe_vm.c | 64 +++++- drivers/gpu/drm/xe/xe_vm.h | 3 + drivers/gpu/drm/xe/xe_vm_types.h | 16 ++ 15 files changed, 375 insertions(+), 54 deletions(-)
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 1/12 drm/xe: Add normalize_invalidation_range
Extract the code that determines the alignment of TLB invalidation into a helper function — normalize_invalidation_range. This will be useful when adding context-based invalidations to the GuC TLB invalidation backend.
--- drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 71 +++++++++++++-------------- 1 file changed, 35 insertions(+), 36 deletions(-)
drivers/gpu/drm/xe/xe_guc_tlb_inval.c +35 -36
@@ -111,6 +111,38 @@ static int send_page_reclaim(struct xe_guc *guc, u32 seqno, G2H_LEN_DW_PAGE_RECLAMATION, 1); } +static u64 normalize_invalidation_range (struct xe_gt *gt,u64 *start,u64 *end) +{ +u64 orig_start = *start; +u64 length = *end - *start; +u64 align; + +if (length <SZ_4K ) + length =SZ_4K ; + + align =roundup_pow_of_two (length); + *start =ALIGN_DOWN (*start, align); + *end =ALIGN (*end, align); + length = align; +while (*start + length < *end) { + length <<=1 ; + *start =ALIGN_DOWN (orig_start, length); + } + +if (length >=SZ_2M ) { + length =max_t (u64,SZ_16M , length); + *start =ALIGN_DOWN (orig_start, length); + } + +xe_gt_assert (gt, length >=SZ_4K ); +xe_gt_assert (gt,is_power_of_2 (length)); +xe_gt_assert (gt, !(length &GENMASK (ilog2 (SZ_16M ) -1 , +ilog2 (SZ_2M ) +1 ))); +xe_gt_assert (gt,IS_ALIGNED (*start, length)); + +return length; +} +/* * Ensure that roundup_pow_of_two(length) doesn't overflow. * Note that roundup_pow_of_two() operates on unsigned long,
@@ -138,48 +170,15 @@ static int send_tlb_inval_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno, length > MAX_RANGE_TLB_INVALIDATION_LENGTH) { action[len++] = MAKE_INVAL_OP(XE_GUC_TLB_INVAL_FULL); } else { -u64 orig_start = start; -u64 align; - -if (length <SZ_4K ) - length =SZ_4K ; - -/* -* We need to invalidate a higher granularity if start address -* is not aligned to length. When start is not aligned with -* length we need to find the length large enough to create an -* address mask covering the required range. -*/ - align =roundup_pow_of_two (length); - start =ALIGN_DOWN (start, align); - end =ALIGN (end, align); - length = align; -while (start + length < end) { - length <<=1 ; - start =ALIGN_DOWN (orig_start, length); - } - -/* -* Minimum invalidation size for a 2MB page that the hardware -* expects is 16MB -*/ -if (length >=SZ_2M ) { - length =max_t (u64,SZ_16M , length); - start =ALIGN_DOWN (orig_start, length); - } - -xe_gt_assert (gt, length >=SZ_4K ); -xe_gt_assert (gt,is_power_of_2 (length)); -xe_gt_assert (gt, !(length &GENMASK (ilog2 (SZ_16M ) -1 , -ilog2 (SZ_2M ) +1 ))); -xe_gt_assert (gt,IS_ALIGNED (start, length)); +u64 normalize_len =normalize_invalidation_range (gt, &start, + &end);/* Flush on NULL case, Media is not required to modify flush due to no PPC so NOP */ action[len++] =MAKE_INVAL_OP_FLUSH (XE_GUC_TLB_INVAL_PAGE_SELECTIVE , !prl_sa); action[len++] = asid; action[len++] =lower_32_bits (start); action[len++] =upper_32_bits (start); - action[len++] =ilog2 (length) -ilog2 (SZ_4K ); + action[len++] =ilog2 (normalize_len) -ilog2 (SZ_4K ); }xe_gt_assert (gt, len <=MAX_TLB_INVALIDATION_LEN );
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 2/12 drm/xe: Make usm.asid_to_vm allocation use GFP_NOWAIT
In reply to Matthew BrostEnsure the asid_to_vm lookup is reclaim-safe so it can be performed during TLB invalidations, which is necessary for context-based TLB invalidation support.
--- drivers/gpu/drm/xe/xe_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/xe/xe_vm.c +1 -1
@@ -1654,7 +1654,7 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags, struct xe_file *xef)down_write (&xe->usm.lock); err =xa_alloc_cyclic (&xe->usm.asid_to_vm, &asid, vm,XA_LIMIT (1 ,XE_MAX_ASID -1 ), - &xe->usm.next_asid,GFP_KERNEL ); + &xe->usm.next_asid,GFP_NOWAIT );up_write (&xe->usm.lock);if (err <0 ) goto err_close;
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 3/12 drm/xe: Add has_ctx_tlb_inval to device info
In reply to Matthew BrostAdd has_ctx_tlb_inval to device info indicating a device has context basd TLB invalidation.
--- drivers/gpu/drm/xe/xe_device_types.h | 2 ++ drivers/gpu/drm/xe/xe_pci.c | 1 + drivers/gpu/drm/xe/xe_pci_types.h | 1 + 3 files changed, 4 insertions(+)
drivers/gpu/drm/xe/xe_device_types.h +2 -0
@@ -351,6 +351,8 @@ struct xe_device { u8 has_pre_prod_wa:1;/** @info.has_pxp: Device has PXP support */ u8 has_pxp:1; +/** @info.has_ctx_tlb_inval: Has context based TLB invalidations */ + u8 has_ctx_tlb_inval:1;/** @info.has_range_tlb_inval: Has range based TLB invalidations */ u8 has_range_tlb_inval:1;/** @info.has_soc_remapper_sysctrl: Has SoC remapper system controller */
drivers/gpu/drm/xe/xe_pci.c +1 -0
@@ -889,6 +889,7 @@ static int xe_info_init(struct xe_device *xe, xe->info.has_device_atomics_on_smem =1 ; xe->info.has_range_tlb_inval = graphics_desc->has_range_tlb_inval; + xe->info.has_ctx_tlb_inval = graphics_desc->has_ctx_tlb_inval; xe->info.has_usm = graphics_desc->has_usm; xe->info.has_64bit_timestamp = graphics_desc->has_64bit_timestamp;
drivers/gpu/drm/xe/xe_pci_types.h +1 -0
@@ -71,6 +71,7 @@ struct xe_graphics_desc { u8 has_atomic_enable_pte_bit:1; u8 has_indirect_ring_state:1; u8 has_range_tlb_inval:1; + u8 has_ctx_tlb_inval:1; u8 has_usm:1; u8 has_64bit_timestamp:1; };
Signature · 1 line
2.34.1
Re: [PATCH v4 03/12] drm/xe: Add has_ctx_tlb_inval to device info
Quoted 4 lines · Matthew Brost
Add
has_ctx_tlb_invalto device info indicating a device has context basd TLB invalidation.Signed-off-by Matthew Brost <[email protected]>
Quoted 52 lines
---
drivers/gpu/drm/xe/xe_device_types.h | 2 ++
drivers/gpu/drm/xe/xe_pci.c | 1 +
drivers/gpu/drm/xe/xe_pci_types.h | 1 +3 files changed, 4 insertions(+)drivers/gpu/drm/xe/xe_device_types.h +1
-0@@ -351,6 +351,8 @@ struct xe_device { u8 has_pre_prod_wa:1; /** @info.has_pxp: Device has PXP support */ u8 has_pxp:1; + /** @info.has_ctx_tlb_inval: Has context based TLBinvalidations */
+ u8 has_ctx_tlb_inval:1;
/** @info.has_range_tlb_inval: Has range based TLB invalidations */
u8 has_range_tlb_inval:1;
/** @info.has_soc_remapper_sysctrl: Has SoC remapper system controller */drivers/gpu/drm/xe/xe_pci.c +0
-0@@ -889,6 +889,7 @@ static int xe_info_init(struct xe_device *xe, xe->info.has_device_atomics_on_smem = 1;
xe->info.has_range_tlb_inval = graphics_desc-Quoted 1 line
has_range_tlb_inval;+ xe->info.has_ctx_tlb_inval = graphics_desc-
Quoted 1 line
has_ctx_tlb_inval;xe->info.has_usm =
graphics_desc->has_usm;xe->info.has_64bit_timestamp= graphics_desc-Quoted 1 line
has_64bit_timestamp;drivers/gpu/drm/xe/xe_pci_types.h +1
-0@@ -71,6 +71,7 @@ struct xe_graphics_desc { u8 has_atomic_enable_pte_bit:1; u8 has_indirect_ring_state:1; u8 has_range_tlb_inval:1; + u8 has_ctx_tlb_inval:1; u8 has_usm:1; u8 has_64bit_timestamp:1; };
Matthew Brost
maintainerPATCH v4 4/12 drm/xe: Add xe_device_asid_to_vm helper
In reply to Matthew BrostIntroduce the xe_device_asid_to_vm helper, which can be used throughout the driver to resolve the VM from a given ASID.
v4:
- Move forward declare after includes (Stuart)
--- drivers/gpu/drm/xe/xe_device.c | 25 +++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_device.h | 4 ++++ 2 files changed, 29 insertions(+)
drivers/gpu/drm/xe/xe_device.c +25 -0
@@ -1417,3 +1417,28 @@ const char *xe_wedged_mode_to_string(enum xe_wedged_mode mode)return "<invalid>" ; } } + +/** +* xe_device_asid_to_vm() - Find VM from ASID +* @xe: the &xe_device +* @asid: Address space ID +* +* Find a VM from ASID and take a reference to VM which caller must drop. +* Reclaim safe. +* +* Return: VM on success, ERR_PTR on failure +*/ +struct xe_vm *xe_device_asid_to_vm (struct xe_device *xe,u32 asid) +{ +struct xe_vm *vm; + +down_read (&xe->usm.lock); + vm =xa_load (&xe->usm.asid_to_vm, asid); +if (vm) +xe_vm_get (vm); +else + vm =ERR_PTR (-EINVAL ); +up_read (&xe->usm.lock); + +return vm; +}
drivers/gpu/drm/xe/xe_device.h +4 -0
@@ -12,6 +12,8 @@#include "xe_gt_types.h" #include "xe_sriov.h" +struct xe_vm ; +static inline struct xe_device *to_xe_device (const struct drm_device *dev) { return container_of(dev, struct xe_device, drm);
@@ -204,6 +206,8 @@ int xe_is_injection_active(void);bool xe_is_xe_file (const struct file *file); +struct xe_vm *xe_device_asid_to_vm (struct xe_device *xe,u32 asid); +/* * Occasionally it is seen that the G2H worker starts running after a delay of more than * a second even after being queued and activated by the Linux workqueue subsystem. This
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 5/12 drm/xe: Add vm to exec queues association
In reply to Matthew BrostMaintain a list of exec queues per vm which will be used by TLB invalidation code to do context-ID based tlb invalidations.
v4:
- More asserts (Stuart)
- Per GT list (CI)
- Skip adding / removal if context TLB invalidatiions not supported (Stuart)
--- drivers/gpu/drm/xe/xe_device.h | 7 --- drivers/gpu/drm/xe/xe_device_types.h | 7 +++ drivers/gpu/drm/xe/xe_exec_queue.c | 7 ++- drivers/gpu/drm/xe/xe_exec_queue_types.h | 3 ++ drivers/gpu/drm/xe/xe_vm.c | 62 ++++++++++++++++++++++++ drivers/gpu/drm/xe/xe_vm.h | 3 ++ drivers/gpu/drm/xe/xe_vm_types.h | 16 ++++++ 7 files changed, 97 insertions(+), 8 deletions(-)
drivers/gpu/drm/xe/xe_device.h +0 -7
@@ -62,13 +62,6 @@ static inline struct xe_tile *xe_device_get_root_tile(struct xe_device *xe)return &xe->tiles[0 ]; } -/* -* Highest GT/tile count for any platform. Used only for memory allocation -* sizing. Any logic looping over GTs or mapping userspace GT IDs into GT -* structures should use the per-platform xe->info.max_gt_per_tile instead. -*/ -#define XE_MAX_GT_PER_TILE 2 -static inline struct xe_gt *xe_device_get_gt (struct xe_device *xe,u8 gt_id) {struct xe_tile *tile;
drivers/gpu/drm/xe/xe_device_types.h +7 -0
@@ -79,6 +79,13 @@ enum xe_wedged_mode {#define XE_GT1 1#define XE_MAX_TILES_PER_DEVICE (XE_GT1 + 1) +/* +* Highest GT/tile count for any platform. Used only for memory allocation +* sizing. Any logic looping over GTs or mapping userspace GT IDs into GT +* structures should use the per-platform xe->info.max_gt_per_tile instead. +*/ +#define XE_MAX_GT_PER_TILE 2 +#define XE_MAX_ASID (BIT(20))#define IS_PLATFORM_STEP (_xe, _platform, min_step, max_step) \
drivers/gpu/drm/xe/xe_exec_queue.c +6 -1
@@ -154,8 +154,10 @@ static void __xe_exec_queue_free(struct xe_exec_queue *q)if (xe_exec_queue_is_multi_queue (q))xe_exec_queue_group_cleanup (q); -if (q->vm) +if (q->vm) { +xe_vm_remove_exec_queue (q->vm, q);xe_vm_put (q->vm); + }if (q->xef)xe_file_put (q->xef);
@@ -226,6 +228,7 @@ static struct xe_exec_queue *__xe_exec_queue_alloc(struct xe_device *xe, q->ring_ops = gt->ring_ops[hwe->class]; q->ops = gt->exec_queue_ops;INIT_LIST_HEAD (&q->lr.link); +INIT_LIST_HEAD (&q->vm_exec_queue_link);INIT_LIST_HEAD (&q->multi_gt_link);INIT_LIST_HEAD (&q->hw_engine_group_link);INIT_LIST_HEAD (&q->pxp.link);
@@ -1205,6 +1208,8 @@ int xe_exec_queue_create_ioctl(struct drm_device *dev, void *data, } q->xef =xe_file_get (xef); +if (eci[0 ].engine_class !=DRM_XE_ENGINE_CLASS_VM_BIND ) +xe_vm_add_exec_queue (vm, q);/* user id alloc must always be last in ioctl to prevent UAF */ err =xa_alloc (&xef->exec_queue.xa, &id, q, xa_limit_32b,GFP_KERNEL );
drivers/gpu/drm/xe/xe_exec_queue_types.h +3 -0
@@ -205,6 +205,9 @@ struct xe_exec_queue {struct dma_fence *last_fence; } tlb_inval[XE_EXEC_QUEUE_TLB_INVAL_COUNT ]; +/** @vm_exec_queue_link: Link to track exec queue within a VM's list of exec queues. */ +struct list_head vm_exec_queue_link; +/** @pxp: PXP info tracking */ struct {/** @pxp.type: PXP session type used by this queue */
drivers/gpu/drm/xe/xe_vm.c +62 -0
76 lines not on this page · raw message
drivers/gpu/drm/xe/xe_vm.h +3 -0
@@ -287,6 +287,9 @@ static inline struct dma_resv *xe_vm_resv(struct xe_vm *vm)void xe_vm_kill (struct xe_vm *vm,bool unlocked); +void xe_vm_add_exec_queue (struct xe_vm *vm,struct xe_exec_queue *q); +void xe_vm_remove_exec_queue (struct xe_vm *vm,struct xe_exec_queue *q); +/** * xe_vm_assert_held(vm) - Assert that the vm's reservation object is held. * @vm: The vm
drivers/gpu/drm/xe/xe_vm_types.h +16 -0
@@ -298,6 +298,22 @@ struct xe_vm {struct list_head pm_activate_link; } preempt; +/** @exec_queues: Manages list of exec queues attached to this VM, protected by lock. */ +struct { +/** +* @exec_queues.list: list of exec queues attached to this VM, +* per GT +*/ +struct list_head list[XE_MAX_TILES_PER_DEVICE *XE_MAX_GT_PER_TILE ]; +/** +* @exec_queues.count: count of exec queues attached to this VM, +* per GT +*/ +int count[XE_MAX_TILES_PER_DEVICE *XE_MAX_GT_PER_TILE ]; +/** @exec_queues.lock: lock to protect exec_queues list */ +struct rw_semaphore lock; + } exec_queues; +/** @um: unified memory state */ struct {/** @asid: address space ID, unique to each VM */
Signature · 1 line
2.34.1
Re: [PATCH v4 05/12] drm/xe: Add vm to exec queues association
Quoted 9 lines · Matthew Brost
Maintain a list of exec queues per vm which will be used by TLB invalidation code to do context-ID based tlb invalidations.
v4:
- More asserts (Stuart)
- Per GT list (CI)
- Skip adding / removal if context TLB invalidatiions not supported (Stuart)
Quoted 3 lines
Signed-off-by Nirmoy Das <[email protected]>Signed-off-by Matthew Brost <[email protected]>Reviewed-by Stuart Summers <[email protected]>
R-B on these latest changes, although still predicated on what happens in that later patch that does the actual invalidation list add/remove and invalidation sent, since that's where the active check is happening. If we decide to move away from that approach, this patch will need to be changed too (or we can go with the prior approach of merging as-is and fixing the GuC side later).
Thanks,
Stuart
Quoted 255 lines
---
drivers/gpu/drm/xe/xe_device.h | 7 --- drivers/gpu/drm/xe/xe_device_types.h | 7 +++ drivers/gpu/drm/xe/xe_exec_queue.c | 7 ++-drivers/gpu/drm/xe/xe_exec_queue_types.h| 3 ++ drivers/gpu/drm/xe/xe_vm.c | 62
++++++++++++++++++++++++
drivers/gpu/drm/xe/xe_vm.h | 3 ++ drivers/gpu/drm/xe/xe_vm_types.h | 16 ++++++7 files changed, 97 insertions(+), 8 deletions(-)drivers/gpu/drm/xe/xe_device.h +0
-0@@ -62,13 +62,6 @@ static inline struct xe_tile *xe_device_get_root_tile(struct xe_device *xe) return &xe->tiles[0]; }
-/*
- * Highest GT/tile count for any platform. Used only for memory allocation
- * sizing. Any logic looping over GTs or mapping userspace GT IDs into GT
- * structures should use the per-platformxe->info.max_gt_per_tileinstead.
- */drivers/gpu/drm/xe/xe_device.h +0
-2-#define XE_MAX_GT_PER_TILE 2 -static inline struct
xe_gt*xe_device_get_gt(structxe_device*xe, u8gt_id)
{
structxe_tile*tile;drivers/gpu/drm/xe/xe_device_types.h +0
-0@@ -79,6 +79,13 @@ enum xe_wedged_mode { #define XE_GT1 1 #define XE_MAX_TILES_PER_DEVICE (XE_GT1 + 1)
+/*
+ * Highest GT/tile count for any platform. Used only for memory allocation
+ * sizing. Any logic looping over GTs or mapping userspace GT IDs into GT
+ * structures should use the per-platformxe->info.max_gt_per_tileinstead.
+ */drivers/gpu/drm/xe/xe_device_types.h +2
-0+#define XE_MAX_GT_PER_TILE 2 +#define XE_MAX_ASID (BIT(20))
#defineIS_PLATFORM_STEP(_xe, _platform, min_step, max_step)\drivers/gpu/drm/xe/xe_exec_queue.c +0
-0@@ -154,8 +154,10 @@ static void __xe_exec_queue_free(struct xe_exec_queue *q) if (xe_exec_queue_is_multi_queue(q)) xe_exec_queue_group_cleanup(q);
- if (q->vm)
+ if (q->vm) {
+ xe_vm_remove_exec_queue(q->vm, q);xe_vm_put(q->vm);
+ }
if (q->xef)
xe_file_put(q->xef);drivers/gpu/drm/xe/xe_exec_queue.c +1
-0@@ -226,6 +228,7 @@ static struct xe_exec_queue *__xe_exec_queue_alloc(struct xe_device *xe, q->ring_ops = gt->ring_ops[hwe->class]; q->ops = gt->exec_queue_ops; INIT_LIST_HEAD(&q->lr.link); + INIT_LIST_HEAD(&q->vm_exec_queue_link); INIT_LIST_HEAD(&q->multi_gt_link); INIT_LIST_HEAD(&q->hw_engine_group_link);INIT_LIST_HEAD(&q->pxp.link);
drivers/gpu/drm/xe/xe_exec_queue.c +0
-0@@ -1205,6 +1208,8 @@ int xe_exec_queue_create_ioctl(struct drm_device *dev, void *data, }
q->xef =xe_file_get(xef);
+ if (eci[0].engine_class !=DRM_XE_ENGINE_CLASS_VM_BIND) + xe_vm_add_exec_queue(vm, q);
/* user id alloc must always be last in ioctl to prevent UAF */
err =xa_alloc(&xef->exec_queue.xa, &id, q, xa_limit_32b, GFP_KERNEL);drivers/gpu/drm/xe/xe_exec_queue_types.h +0
-0@@ -205,6 +205,9 @@ struct xe_exec_queue { struct dma_fence *last_fence; } tlb_inval[XE_EXEC_QUEUE_TLB_INVAL_COUNT];
+ /** @vm_exec_queue_link: Link to track exec queue within a VM's list of exec queues. */
+ structlist_headvm_exec_queue_link;
+
/** @pxp: PXP info tracking */
struct {
/** @pxp.type: PXP session type used by this queue */drivers/gpu/drm/xe/xe_vm.c +0
-0@@ -1530,11 +1530,24 @@ struct xe_vm *xe_vm_create(struct xe_device *xe, u32 flags, struct xe_file *xef) INIT_WORK(&vm->destroy_work, vm_destroy_work_func);
INIT_LIST_HEAD(&vm->preempt.exec_queues); + for (id = 0; id <XE_MAX_TILES_PER_DEVICE*XE_MAX_GT_PER_TILE; ++id)
+ INIT_LIST_HEAD(&vm->exec_queues.list[id]); if (flags &XE_VM_FLAG_FAULT_MODE)vm->preempt.min_run_period_ms= xe-Quoted 1 line
min_run_period_pf_ms;else
vm->preempt.min_run_period_ms = xe-Quoted 1 line
min_run_period_lr_ms;
+ init_rwsem(&vm->exec_queues.lock); + if (IS_ENABLED(CONFIG_PROVE_LOCKING)) { + fs_reclaim_acquire(GFP_KERNEL); + might_lock(&vm->exec_queues.lock); + fs_reclaim_release(GFP_KERNEL);drivers/gpu/drm/xe/xe_vm.c +6
-0+ + down_read(&vm->exec_queues.lock); + might_lock(&xe_root_mmio_gt(xe)->uc.guc.ct.lock); + up_read(&vm->exec_queues.lock); + } +for_each_tile(tile, xe, id)
xe_range_fence_tree_init(&vm->rftree[id]);drivers/gpu/drm/xe/xe_vm.c +0
-0@@ -4570,3 +4583,52 @@ int xe_vm_alloc_cpu_addr_mirror_vma(struct
xe_vm*vm,uint64_tstart,uint64_tr
returnxe_vm_alloc_vma(vm, &map_req, false);
}
+/**
+ *xe_vm_add_exec_queue()- Add exec queue to VM
+ * @vm: The VM.
+ * @q: Theexec_queue
+ *
+ * Add exec queue to VM, skipped if the device does not have context based TLB
+ * invalidations.
+ */drivers/gpu/drm/xe/xe_vm.c +17
-0+void xe_vm_add_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q) +{ + struct xe_device *xe = vm->xe; + + /* User VMs and queues only */ + xe_assert(xe, !(q->flags & EXEC_QUEUE_FLAG_KERNEL)); + xe_assert(xe, !(q->flags & EXEC_QUEUE_FLAG_PERMANENT)); + xe_assert(xe, !(q->flags & EXEC_QUEUE_FLAG_VM)); + xe_assert(xe, !(q->flags & EXEC_QUEUE_FLAG_MIGRATE)); + xe_assert(xe, vm->xef); + xe_assert(xe, vm == q->vm); + + if (!xe->info.has_ctx_tlb_inval) + return; + + down_write(&vm->exec_queues.lock); + list_add(&q->vm_exec_queue_link, &vm->exec_queues.list[q->gt-Quoted 1 line
info.id]);
+ ++vm->exec_queues.count[q->gt->info.id];
+ up_write(&vm->exec_queues.lock);drivers/gpu/drm/xe/xe_vm.c +8
-0+} + +/** +* xe_vm_remove_exec_queue() - Remove exec queue from VM +* @vm: The VM. +* @q: The exec_queue +* +* Remove exec queue from VM, skipped if the device does not have context based
+ * TLB invalidations.
+ */
+voidxe_vm_remove_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q)drivers/gpu/drm/xe/xe_vm.c +11
-0+{ + if (!vm->xe->info.has_ctx_tlb_inval) + return; + + down_write(&vm->exec_queues.lock); + if (!list_empty(&q->vm_exec_queue_link)) { + list_del(&q->vm_exec_queue_link); + --vm->exec_queues.count[q->gt->info.id]; + } + up_write(&vm->exec_queues.lock); +}drivers/gpu/drm/xe/xe_vm.h +0
-0@@ -287,6 +287,9 @@ static inline struct dma_resv *xe_vm_resv(struct xe_vm *vm)
voidxe_vm_kill(struct xe_vm *vm, bool unlocked);
+voidxe_vm_add_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q);
+voidxe_vm_remove_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q);
+
/**
*xe_vm_assert_held(vm)- Assert that the vm's reservation object is held.
* @vm: The vmdrivers/gpu/drm/xe/xe_vm_types.h +0
-0@@ -298,6 +298,22 @@ struct xe_vm { struct list_head pm_activate_link; } preempt;
+ /** @exec_queues: Manages list of exec queues attached to this VM, protected by lock. */
+ struct {
+ /**
+ * @exec_queues.list: list of exec queues attached to this VM,
+ * per GT
+ */
+ structlist_headlist[XE_MAX_TILES_PER_DEVICE *XE_MAX_GT_PER_TILE];
+ /**
+ * @exec_queues.count: count of exec queues attached to this VM,
+ * per GT
+ */
+ int count[XE_MAX_TILES_PER_DEVICE *XE_MAX_GT_PER_TILE];
+ /** @exec_queues.lock: lock to protectexec_queueslist */
+ structrw_semaphorelock;
+ }exec_queues;
+
/** @um: unified memory state */
struct {
/** @asid: address space ID, unique to each VM */
Matthew Brost
maintainerPATCH v4 6/12 drm/xe: Taint TLB invalidation seqno lock with GFP_KERNEL
In reply to Matthew BrostTaint TLB invalidation seqno lock with GFP_KERNEL as TLB invalidations can be in the path of reclaim (e.g., MMU notifiers).
--- drivers/gpu/drm/xe/xe_tlb_inval.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/gpu/drm/xe/xe_tlb_inval.c +12 -0
@@ -114,6 +114,16 @@ static void tlb_inval_fini(struct drm_device *drm, void *arg)xe_tlb_inval_reset (tlb_inval); } +static void primelockdep (struct xe_tlb_inval *tlb_inval) +{ +if (!IS_ENABLED (CONFIG_LOCKDEP )) +return ; + +fs_reclaim_acquire (GFP_KERNEL ); +might_lock (&tlb_inval->seqno_lock); +fs_reclaim_release (GFP_KERNEL ); +} +/** * xe_gt_tlb_inval_init - Initialize TLB invalidation state * @gt: GT structure
@@ -140,6 +150,8 @@ int xe_gt_tlb_inval_init_early(struct xe_gt *gt)if (err)return err; +primelockdep (tlb_inval); + tlb_inval->job_wq =drmm_alloc_ordered_workqueue (&xe->drm,"gt-tbl-inval-job-wq" ,WQ_MEM_RECLAIM );
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 7/12 drm/xe: Rename send_tlb_inval_ppgtt to send_tlb_inval_asid_ppgtt
In reply to Matthew BrostContext-based TLB invalidations have their own set of GuC TLB invalidation operations. Rename the current PPGTT invalidation function, which operates on ASIDs, to a more descriptive name that reflects its purpose.
--- drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4 -4
@@ -150,9 +150,9 @@ static u64 normalize_invalidation_range(struct xe_gt *gt, u64 *start, u64 *end)*/ #define MAX_RANGE_TLB_INVALIDATION_LENGTH (rounddown_pow_of_two(ULONG_MAX)) -static int send_tlb_inval_ppgtt (struct xe_tlb_inval *tlb_inval,u32 seqno, -u64 start,u64 end,u32 asid, -struct drm_suballoc *prl_sa) +static int send_tlb_inval_asid_ppgtt (struct xe_tlb_inval *tlb_inval,u32 seqno, +u64 start,u64 end,u32 asid, +struct drm_suballoc *prl_sa) {#define MAX_TLB_INVALIDATION_LEN 7struct xe_guc *guc = tlb_inval->private;
@@ -219,7 +219,7 @@ static long tlb_inval_timeout_delay(struct xe_tlb_inval *tlb_inval)static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { .all = send_tlb_inval_all, .ggtt = send_tlb_inval_ggtt, - .ppgtt = send_tlb_inval_ppgtt, + .ppgtt = send_tlb_inval_asid_ppgtt, .initialized = tlb_inval_initialized, .flush = tlb_inval_flush, .timeout_delay = tlb_inval_timeout_delay,
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 8/12 drm/xe: Add send_tlb_inval_ppgtt helper
In reply to Matthew BrostExtract the common code that issues a TLB invalidation H2G for PPGTTs into a helper function. This helper can be reused for both ASID-based and context-based TLB invalidations.
--- drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 30 +++++++++++++++++++-------- 1 file changed, 21 insertions(+), 9 deletions(-)
drivers/gpu/drm/xe/xe_guc_tlb_inval.c +21 -9
@@ -150,20 +150,16 @@ static u64 normalize_invalidation_range(struct xe_gt *gt, u64 *start, u64 *end)*/ #define MAX_RANGE_TLB_INVALIDATION_LENGTH (rounddown_pow_of_two(ULONG_MAX)) -static int send_tlb_inval_asid_ppgtt (struct xe_tlb_inval *tlb_inval,u32 seqno, -u64 start,u64 end,u32 asid, -struct drm_suballoc *prl_sa) +static int send_tlb_inval_ppgtt (struct xe_guc *guc,u32 seqno,u64 start, +u64 end,u32 id,u32 type, +struct drm_suballoc *prl_sa) {#define MAX_TLB_INVALIDATION_LEN 7 -struct xe_guc *guc = tlb_inval->private;struct xe_gt *gt =guc_to_gt (guc);u32 action[MAX_TLB_INVALIDATION_LEN ];u64 length = end - start;int len =0 , err; -if (guc_to_xe (guc)->info.force_execlist) -return -ECANCELED ; - action[len++] =XE_GUC_ACTION_TLB_INVALIDATION ; action[len++] = !prl_sa ? seqno :TLB_INVALIDATION_SEQNO_INVALID ; if (!gt_to_xe(gt)->info.has_range_tlb_inval ||
@@ -174,14 +170,15 @@ static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno, &end);/* Flush on NULL case, Media is not required to modify flush due to no PPC so NOP */ - action[len++] =MAKE_INVAL_OP_FLUSH (XE_GUC_TLB_INVAL_PAGE_SELECTIVE , !prl_sa); - action[len++] = asid; + action[len++] =MAKE_INVAL_OP_FLUSH (type, !prl_sa); + action[len++] = id; action[len++] =lower_32_bits (start); action[len++] =upper_32_bits (start); action[len++] =ilog2 (normalize_len) -ilog2 (SZ_4K ); }xe_gt_assert (gt, len <=MAX_TLB_INVALIDATION_LEN ); +#undef MAX_TLB_INVALIDATION_LEN err =send_tlb_inval (guc, action, len);if (!err && prl_sa)
@@ -189,6 +186,21 @@ static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno,return err; } +static int send_tlb_inval_asid_ppgtt (struct xe_tlb_inval *tlb_inval,u32 seqno, +u64 start,u64 end,u32 asid, +struct drm_suballoc *prl_sa) +{ +struct xe_guc *guc = tlb_inval->private; + +lockdep_assert_held (&tlb_inval->seqno_lock); + +if (guc_to_xe (guc)->info.force_execlist) +return -ECANCELED ; + +return send_tlb_inval_ppgtt (guc, seqno, start, end, asid, +XE_GUC_TLB_INVAL_PAGE_SELECTIVE , prl_sa); +} +static bool tlb_inval_initialized (struct xe_tlb_inval *tlb_inval) {struct xe_guc *guc = tlb_inval->private;
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 9/12 drm/xe: Add xe_tlb_inval_idle helper
In reply to Matthew BrostIntroduce the xe_tlb_inval_idle helper to detect whether any TLB invalidations are currently in flight. This is used in context-based TLB invalidations to determine whether dummy TLB invalidations need to be sent to maintain proper TLB invalidation fence ordering..
v2:
- Implement xe_tlb_inval_idle based on pending list
--- drivers/gpu/drm/xe/xe_tlb_inval.c | 21 +++++++++++++++++++++ drivers/gpu/drm/xe/xe_tlb_inval.h | 2 ++ 2 files changed, 23 insertions(+)
drivers/gpu/drm/xe/xe_tlb_inval.c +21 -0
@@ -44,11 +44,14 @@ static void xe_tlb_inval_fence_fini(struct xe_tlb_inval_fence *fence)static void xe_tlb_inval_fence_signal (struct xe_tlb_inval_fence *fence) { +struct xe_tlb_inval *tlb_inval = fence->tlb_inval;bool stack =test_bit (FENCE_STACK_BIT , &fence->base.flags);lockdep_assert_held (&fence->tlb_inval->pending_lock);list_del (&fence->link); +if (list_empty (&tlb_inval->pending_fences)) +cancel_delayed_work (&tlb_inval->fence_tdr);trace_xe_tlb_inval_fence_signal (fence->tlb_inval->xe, fence);xe_tlb_inval_fence_fini (fence);dma_fence_signal (&fence->base);
@@ -464,3 +467,21 @@ void xe_tlb_inval_fence_init(struct xe_tlb_inval *tlb_inval,dma_fence_get (&fence->base); fence->tlb_inval = tlb_inval; } + +/** +* xe_tlb_inval_idle() - Initialize TLB invalidation is idle +* @tlb_inval: TLB invalidation client +* +* Check the TLB invalidation seqno to determine if it is idle (i.e., no TLB +* invalidations are in flight). Expected to be called in the backend after the +* fence has been added to the pending list, and takes this into account. +* +* Return: True if TLB invalidation client is idle, False otherwise +*/ +bool xe_tlb_inval_idle (struct xe_tlb_inval *tlb_inval) +{ +lockdep_assert_held (&tlb_inval->seqno_lock); + +guard (spinlock_irq)(&tlb_inval->pending_lock); +return list_is_singular (&tlb_inval->pending_fences); +}
drivers/gpu/drm/xe/xe_tlb_inval.h +2 -0
@@ -43,4 +43,6 @@ xe_tlb_inval_fence_wait(struct xe_tlb_inval_fence *fence)void xe_tlb_inval_done_handler (struct xe_tlb_inval *tlb_inval,int seqno); +bool xe_tlb_inval_idle (struct xe_tlb_inval *tlb_inval); +#endif /* _XE_TLB_INVAL_ */
Signature · 1 line
2.34.1
Matthew Brost
maintainerPATCH v4 10/12 drm/xe: Add exec queue active vfunc
In reply to Matthew BrostIf an exec queue is inactive (e.g., not registered or scheduling is disabled), TLB invalidations are not issued for that queue. Add a virtual function to determine the active state, which TLB invalidation logic can hook into.
--- drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++ drivers/gpu/drm/xe/xe_execlist.c | 7 +++++++ drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++++ 3 files changed, 15 insertions(+)
drivers/gpu/drm/xe/xe_exec_queue_types.h +2 -0
@@ -298,6 +298,8 @@ struct xe_exec_queue_ops {void (*resume)(struct xe_exec_queue *q);/** @reset_status: check exec queue reset status */ bool (*reset_status)(struct xe_exec_queue *q); +/** @active: check exec queue is active */ + bool (*active)(struct xe_exec_queue *q); };#endif
drivers/gpu/drm/xe/xe_execlist.c +7 -0
@@ -469,6 +469,12 @@ static bool execlist_exec_queue_reset_status(struct xe_exec_queue *q)return false; } +static bool execlist_exec_queue_active (struct xe_exec_queue *q) +{ +/* NIY */ +return false; +} +static const struct xe_exec_queue_ops execlist_exec_queue_ops = { .init = execlist_exec_queue_init, .kill = execlist_exec_queue_kill,
@@ -481,6 +487,7 @@ static const struct xe_exec_queue_ops execlist_exec_queue_ops = { .suspend_wait = execlist_exec_queue_suspend_wait, .resume = execlist_exec_queue_resume, .reset_status = execlist_exec_queue_reset_status, + .active = execlist_exec_queue_active, };int xe_execlist_init (struct xe_gt *gt)
drivers/gpu/drm/xe/xe_guc_submit.c +6 -0
@@ -2203,6 +2203,11 @@ static bool guc_exec_queue_reset_status(struct xe_exec_queue *q)return exec_queue_reset (q) ||exec_queue_killed_or_banned_or_wedged (q); } +static bool guc_exec_queue_active (struct xe_exec_queue *q) +{ +return exec_queue_enabled (q) && !exec_queue_pending_disable (q); +} +/* * All of these functions are an abstraction layer which other parts of Xe can * use to trap into the GuC backend. All of these functions, aside from init,
@@ -2222,6 +2227,7 @@ static const struct xe_exec_queue_ops guc_exec_queue_ops = { .suspend_wait = guc_exec_queue_suspend_wait, .resume = guc_exec_queue_resume, .reset_status = guc_exec_queue_reset_status, + .active = guc_exec_queue_active, };static void guc_exec_queue_stop (struct xe_guc *guc,struct xe_exec_queue *q)
Signature · 1 line
2.34.1
Re: [PATCH v4 10/12] drm/xe: Add exec queue active vfunc
Quoted 69 lines · Matthew Brost
If an exec queue is inactive (e.g., not registered or scheduling is disabled), TLB invalidations are not issued for that queue. Add a virtual function to determine the active state, which TLB invalidation
logic can hook into.Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++ drivers/gpu/drm/xe/xe_execlist.c | 7 +++++++ drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++++3 files changed, 15 insertions(+)drivers/gpu/drm/xe/xe_exec_queue_types.h +2
-0@@ -298,6 +298,8 @@ struct xe_exec_queue_ops { void (*resume)(struct xe_exec_queue *q); /** @reset_status: check exec queue reset status */ bool (*reset_status)(struct xe_exec_queue *q); + /** @active: check exec queue is active */ + bool (*active)(struct xe_exec_queue *q); };
#endifdrivers/gpu/drm/xe/xe_execlist.c +0
-0@@ -469,6 +469,12 @@ static bool execlist_exec_queue_reset_status(struct xe_exec_queue *q) return false; }drivers/gpu/drm/xe/xe_execlist.c +6
-0+static bool execlist_exec_queue_active (struct xe_exec_queue *q) +{ + /* NIY */ + return false; +} +static const struct
xe_exec_queue_opsexeclist_exec_queue_ops= { .init =execlist_exec_queue_init,
.kill =execlist_exec_queue_kill,drivers/gpu/drm/xe/xe_execlist.c +1
-0@@ -481,6 +487,7 @@ static const struct xe_exec_queue_ops execlist_exec_queue_ops = { .suspend_wait = execlist_exec_queue_suspend_wait, .resume = execlist_exec_queue_resume, .reset_status = execlist_exec_queue_reset_status, + .active = execlist_exec_queue_active, };
intxe_execlist_init(struct xe_gt *gt)drivers/gpu/drm/xe/xe_guc_submit.c +0
-0@@ -2203,6 +2203,11 @@ static bool guc_exec_queue_reset_status(struct xe_exec_queue *q)return
exec_queue_reset(q)||exec_queue_killed_or_banned_or_wedged(q);
}drivers/gpu/drm/xe/xe_guc_submit.c +3
-0+static bool guc_exec_queue_active (struct xe_exec_queue *q) +{ + return exec_queue_enabled(q) &&
Quoted 1 line
!exec_queue_pending_disable(q);
So I think the requirement here is !exec_queue_pending_disable && !exec_queue_destroyed rather than exec_queue_enabled... But if the context isn't enabled (set runnable to true in GuC), it means hardware shouldn't be touching any of the associated memory anyway and we shouldn't be issuing any invalidations, so this still looks ok to me. It means we'll be doing full invalidations for those I think though which could add some performance impact in the time between register and enable. For now though as long as this is working (still doing some testing on my end and I had some questions in a later patch), we can go with this.
Thanks,
Stuart
Quoted 17 lines
drivers/gpu/drm/xe/xe_guc_submit.c +2
-0+} +/*
* All of these functions are an abstraction layer which other parts of Xe can
* use to trap into the GuC backend. All of these functions, aside from init,drivers/gpu/drm/xe/xe_guc_submit.c +1
-0@@ -2222,6 +2227,7 @@ static const struct xe_exec_queue_ops guc_exec_queue_ops = { .suspend_wait = guc_exec_queue_suspend_wait, .resume = guc_exec_queue_resume, .reset_status = guc_exec_queue_reset_status, + .active = guc_exec_queue_active, };
static voidguc_exec_queue_stop(struct xe_guc *guc, struct xe_exec_queue *q)
Matthew Brost
maintainerRe: [PATCH v4 10/12] drm/xe: Add exec queue active vfunc
Quoted 66 lines · Stuart
Quoted 65 lines · Matthew Brost
If an exec queue is inactive (e.g., not registered or scheduling is disabled), TLB invalidations are not issued for that queue. Add a virtual function to determine the active state, which TLB invalidation
logic can hook into.Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++ drivers/gpu/drm/xe/xe_execlist.c | 7 +++++++ drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++++3 files changed, 15 insertions(+)drivers/gpu/drm/xe/xe_exec_queue_types.h +2
-0@@ -298,6 +298,8 @@ struct xe_exec_queue_ops { void (*resume)(struct xe_exec_queue *q); /** @reset_status: check exec queue reset status */ bool (*reset_status)(struct xe_exec_queue *q); + /** @active: check exec queue is active */ + bool (*active)(struct xe_exec_queue *q); };
#endifdrivers/gpu/drm/xe/xe_execlist.c +0
-0@@ -469,6 +469,12 @@ static bool execlist_exec_queue_reset_status(struct xe_exec_queue *q) return false; }drivers/gpu/drm/xe/xe_execlist.c +6
-0+static bool execlist_exec_queue_active (struct xe_exec_queue *q) +{ + /* NIY */ + return false; +} +static const struct
xe_exec_queue_opsexeclist_exec_queue_ops= { .init =execlist_exec_queue_init,
.kill =execlist_exec_queue_kill,drivers/gpu/drm/xe/xe_execlist.c +1
-0@@ -481,6 +487,7 @@ static const struct xe_exec_queue_ops execlist_exec_queue_ops = { .suspend_wait = execlist_exec_queue_suspend_wait, .resume = execlist_exec_queue_resume, .reset_status = execlist_exec_queue_reset_status, + .active = execlist_exec_queue_active, };
intxe_execlist_init(struct xe_gt *gt)drivers/gpu/drm/xe/xe_guc_submit.c +0
-0@@ -2203,6 +2203,11 @@ static bool guc_exec_queue_reset_status(struct xe_exec_queue *q)return
exec_queue_reset(q)||exec_queue_killed_or_banned_or_wedged(q);
}
Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_guc_submit.c +3
-0+static bool guc_exec_queue_active (struct xe_exec_queue *q) +{ + return exec_queue_enabled(q) &&!exec_queue_pending_disable(q);
So I think the requirement here is !exec_queue_pending_disable && !exec_queue_destroyed rather than
exec_queue_enabled... But if the
If destroyed is set, the refcounting exchange in the following patch will fail, so exec_queue_destroyed check here isn't needed.
Quoted 8 lines
context isn't enabled (set runnable to true in GuC), it means hardware shouldn't be touching any of the associated memory anyway and we shouldn't be issuing any invalidations, so this still looks ok to me. It means we'll be doing full invalidations for those I think though which could add some performance impact in the time between register and enable. For now though as long as this is working (still doing some testing on my end and I had some questions in a later patch), we can go with this.
My reasoning here is that the context is not enabled, so we don’t need to issue an invalidation because the next context switch to the hardware will issue one—that’s the current hardware behavior. If that changes, this could simply become an exec_queue_registered check. I forget if this is changing in future hardware.
I also noticed I have a multi-queue bug here too. This needs to check the primary queue’s state for multi-queue.
Matt
Quoted 22 lines
Thanks,
StuartQuoted 17 lines
drivers/gpu/drm/xe/xe_guc_submit.c +2
-0+} +/*
* All of these functions are an abstraction layer which other parts of Xe can
* use to trap into the GuC backend. All of these functions, aside from init,drivers/gpu/drm/xe/xe_guc_submit.c +1
-0@@ -2222,6 +2227,7 @@ static const struct xe_exec_queue_ops guc_exec_queue_ops = { .suspend_wait = guc_exec_queue_suspend_wait, .resume = guc_exec_queue_resume, .reset_status = guc_exec_queue_reset_status, + .active = guc_exec_queue_active, };
static voidguc_exec_queue_stop(struct xe_guc *guc, struct xe_exec_queue *q)
Re: [PATCH v4 10/12] drm/xe: Add exec queue active vfunc
Quoted 79 lines · Matthew Brost
Quoted 69 lines · Stuart
Quoted 68 lines · Matthew Brost
If an exec queue is inactive (e.g., not registered or scheduling is
disabled), TLB invalidations are not issued for that queue. Add a virtual function to determine the active state, which TLB invalidation
logic can hook into.Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++ drivers/gpu/drm/xe/xe_execlist.c | 7 +++++++ drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++++3 files changed, 15 insertions(+)drivers/gpu/drm/xe/xe_exec_queue_types.h +2
-0@@ -298,6 +298,8 @@ struct xe_exec_queue_ops { void (*resume)(struct xe_exec_queue *q); /** @reset_status: check exec queue reset status */ bool (*reset_status)(struct xe_exec_queue *q); + /** @active: check exec queue is active */ + bool (*active)(struct xe_exec_queue *q); };
#endifdrivers/gpu/drm/xe/xe_execlist.c +0
-0@@ -469,6 +469,12 @@ static bool execlist_exec_queue_reset_status(struct xe_exec_queue *q) return false; }drivers/gpu/drm/xe/xe_execlist.c +6
-0+static bool execlist_exec_queue_active (struct xe_exec_queue *q) +{ + /* NIY */ + return false; +} +static const struct
xe_exec_queue_opsexeclist_exec_queue_ops= {
.init =execlist_exec_queue_init,
.kill =execlist_exec_queue_kill,drivers/gpu/drm/xe/xe_execlist.c +1
-0@@ -481,6 +487,7 @@ static const struct xe_exec_queue_ops execlist_exec_queue_ops = { .suspend_wait = execlist_exec_queue_suspend_wait, .resume = execlist_exec_queue_resume, .reset_status = execlist_exec_queue_reset_status, + .active = execlist_exec_queue_active, };
intxe_execlist_init(struct xe_gt *gt)drivers/gpu/drm/xe/xe_guc_submit.c +0
-0@@ -2203,6 +2203,11 @@ static boolguc_exec_queue_reset_status(struct
xe_exec_queue*q)
returnexec_queue_reset(q)||exec_queue_killed_or_banned_or_wedged(q);
}Quoted 8 lines
Quoted 5 lines
drivers/gpu/drm/xe/xe_guc_submit.c +3
-0+static bool guc_exec_queue_active (struct xe_exec_queue *q) +{ + return exec_queue_enabled(q) &&!exec_queue_pending_disable(q);
So I think the requirement here is !exec_queue_pending_disable && !exec_queue_destroyed rather than
exec_queue_enabled... But if the
Quoted 2 lines
If destroyed is set, the refcounting exchange in the following patch will fail, so
exec_queue_destroyedcheck here isn't needed.
Ok. Still looking over that other comment but it looks promising...
Quoted 15 lines
Quoted 14 lines
context isn't enabled (set runnable to true in GuC), it means hardware
shouldn't be touching any of the associated memory anyway and we shouldn't be issuing any invalidations, so this still looks ok to me.
It means we'll be doing full invalidations for those I think though which could add some performance impact in the time between register
and enable. For now though as long as this is working (still doing some
testing on my end and I had some questions in a later patch), we can go
with this.
Quoted 7 lines
My reasoning here is that the context is not enabled, so we don’t need
to issue an invalidation because the next context switch to the hardware
will issue one—that’s the current hardware behavior. If that changes, this could simply become anexec_queue_registeredcheck. I forget if this is changing in future hardware.
Ok... yeah I guess we can address this if it comes up. I was more worried about this falling back to the full invalidation if the list was empty here.
Quoted 3 lines
I also noticed I have a multi-queue bug here too. This needs to check the primary queue’s state for multi-queue.
Ah true, good catch...
Thanks,
Stuart
Quoted 27 lines
Matt
Quoted 24 lines
Thanks,
StuartQuoted 19 lines
drivers/gpu/drm/xe/xe_guc_submit.c +2
-0+} +/*
* All of these functions are an abstraction layer which other parts
of Xe can
* use to trap into the GuC backend. All of these functions, aside
from init,drivers/gpu/drm/xe/xe_guc_submit.c +1
-0@@ -2222,6 +2227,7 @@ static const struct xe_exec_queue_ops guc_exec_queue_ops = { .suspend_wait = guc_exec_queue_suspend_wait, .resume = guc_exec_queue_resume, .reset_status = guc_exec_queue_reset_status, + .active = guc_exec_queue_active, };
static voidguc_exec_queue_stop(struct xe_guc *guc, struct xe_exec_queue *q)
Re: [PATCH v4 10/12] drm/xe: Add exec queue active vfunc
Quoted 123 lines · Stuart
Quoted 84 lines · Matthew Brost
Quoted 74 lines · Stuart
Quoted 73 lines · Matthew Brost
If an exec queue is inactive (e.g., not registered or scheduling
is
disabled), TLB invalidations are not issued for that queue. Add a
virtual function to determine the active state, which TLB invalidation
logic can hook into.Signed-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/xe_exec_queue_types.h | 2 ++ drivers/gpu/drm/xe/xe_execlist.c | 7 +++++++ drivers/gpu/drm/xe/xe_guc_submit.c | 6 ++++++3 files changed, 15 insertions(+)drivers/gpu/drm/xe/xe_exec_queue_types.h +2
-0@@ -298,6 +298,8 @@ struct xe_exec_queue_ops { void (*resume)(struct xe_exec_queue *q); /** @reset_status: check exec queue reset status */ bool (*reset_status)(struct xe_exec_queue *q); + /** @active: check exec queue is active */ + bool (*active)(struct xe_exec_queue *q); };
#endifdrivers/gpu/drm/xe/xe_execlist.c +0
-0@@ -469,6 +469,12 @@ static bool execlist_exec_queue_reset_status(struct xe_exec_queue *q) return false; }
+static boolexeclist_exec_queue_active(struct xe_exec_queue *q)drivers/gpu/drm/xe/xe_execlist.c +5
-0+{ + /* NIY */ + return false; +} +static const struct
xe_exec_queue_opsexeclist_exec_queue_ops=
{
.init =execlist_exec_queue_init,
.kill =execlist_exec_queue_kill,drivers/gpu/drm/xe/xe_execlist.c +1
-0@@ -481,6 +487,7 @@ static const struct xe_exec_queue_ops execlist_exec_queue_ops = { .suspend_wait = execlist_exec_queue_suspend_wait, .resume = execlist_exec_queue_resume, .reset_status = execlist_exec_queue_reset_status, + .active = execlist_exec_queue_active, };
intxe_execlist_init(struct xe_gt *gt)drivers/gpu/drm/xe/xe_guc_submit.c +0
-0@@ -2203,6 +2203,11 @@ static boolguc_exec_queue_reset_status(struct
xe_exec_queue*q)
returnexec_queue_reset(q)||exec_queue_killed_or_banned_or_wedged(q);
}Quoted 8 lines
Quoted 4 lines
drivers/gpu/drm/xe/xe_guc_submit.c +3
-0+static bool guc_exec_queue_active (struct xe_exec_queue *q) +{ + return exec_queue_enabled(q) &&!exec_queue_pending_disable(q);
So I think the requirement here is !exec_queue_pending_disable && !exec_queue_destroyed rather than
exec_queue_enabled... But if theQuoted 3 lines
If destroyed is set, the refcounting exchange in the following patch
will fail, soexec_queue_destroyedcheck here isn't needed.Ok. Still looking over that other comment but it looks promising...
Quoted 17 lines
Quoted 16 lines
context isn't enabled (set runnable to true in GuC), it means hardware
shouldn't be touching any of the associated memory anyway and we shouldn't be issuing any invalidations, so this still looks ok to me.
It means we'll be doing full invalidations for those I think though
which could add some performance impact in the time between register
and enable. For now though as long as this is working (still doing
some
testing on my end and I had some questions in a later patch), we can go
with this.Quoted 9 lines
My reasoning here is that the context is not enabled, so we don’t need
to issue an invalidation because the next context switch to the hardware
will issue one—that’s the current hardware behavior. If that changes,
this could simply become anexec_queue_registeredcheck. I forget if
this is changing in future hardware.Ok... yeah I guess we can address this if it comes up. I was more worried about this falling back to the full invalidation if the list was empty here.
Quoted 1 line
Quoted 5 lines
Quoted 3 lines
I also noticed I have a multi-queue bug here too. This needs to check
the primary queue’s state for multi-queue.Ah true, good catch...
Just a quick confirmation.. no other concerns from me on this patch outside of the secondary queue check you had mentioned.
Thanks,
Stuart
Quoted 32 lines
Thanks,
StuartQuoted 27 lines
Matt
Quoted 24 lines
Thanks,
StuartQuoted 19 lines
drivers/gpu/drm/xe/xe_guc_submit.c +2
-0+} +/*
* All of these functions are an abstraction layer which other parts
of Xe can
* use to trap into the GuC backend. All of these functions, aside
from init,drivers/gpu/drm/xe/xe_guc_submit.c +1
-0@@ -2222,6 +2227,7 @@ static const struct xe_exec_queue_ops guc_exec_queue_ops = { .suspend_wait = guc_exec_queue_suspend_wait, .resume = guc_exec_queue_resume, .reset_status = guc_exec_queue_reset_status, + .active = guc_exec_queue_active, };
static voidguc_exec_queue_stop(struct xe_guc *guc, struct xe_exec_queue *q)
Matthew Brost
maintainerPATCH v4 11/12 drm/xe: Add context-based invalidation to GuC TLB invalidation backend
In reply to Matthew BrostIntroduce context-based invalidation support to the GuC TLB invalidation backend. This is implemented by iterating over each exec queue per GT within a VM, skipping inactive queues, and issuing a context-based (GuC ID) H2G TLB invalidation. All H2G messages, except the final one, are sent with an invalid seqno, which the G2H handler drops to ensure the TLB invalidation fence is only signaled once all H2G messages are completed.
A watermark mechanism is also added to switch between context-based TLB invalidations and full device-wide invalidations, as the return on investment for context-based invalidation diminishes when many exec queues are mapped.
v2:
- Fix checkpatch warnings
v3:
- Rebase on PRL
- Use ref counting to avoid racing with deregisters
v4:
- Extra braces (Stuart)
- Use per GT list (CI)
- Reorder put
--- drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 145 +++++++++++++++++++++++++- 1 file changed, 141 insertions(+), 4 deletions(-)
drivers/gpu/drm/xe/xe_guc_tlb_inval.c +141 -4
@@ -6,15 +6,19 @@#include "abi/guc_actions_abi.h" #include "xe_device.h" +#include "xe_exec_queue.h" +#include "xe_exec_queue_types.h" #include "xe_gt_stats.h" #include "xe_gt_types.h" #include "xe_guc.h" #include "xe_guc_ct.h" +#include "xe_guc_exec_queue_types.h" #include "xe_guc_tlb_inval.h" #include "xe_force_wake.h" #include "xe_mmio.h" #include "xe_sa.h" #include "xe_tlb_inval.h" +#include "xe_vm.h" #include "regs/xe_guc_regs.h"
@@ -156,10 +160,16 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start, {#define MAX_TLB_INVALIDATION_LEN 7struct xe_gt *gt =guc_to_gt (guc); +struct xe_device *xe =guc_to_xe (guc);u32 action[MAX_TLB_INVALIDATION_LEN ];u64 length = end - start;int len =0 , err; +xe_gt_assert (gt, (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE && + !xe->info.has_ctx_tlb_inval) || + (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX && + xe->info.has_ctx_tlb_inval)); + action[len++] =XE_GUC_ACTION_TLB_INVALIDATION ; action[len++] = !prl_sa ? seqno :TLB_INVALIDATION_SEQNO_INVALID ; if (!gt_to_xe(gt)->info.has_range_tlb_inval ||
@@ -168,9 +178,11 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start, }else {u64 normalize_len =normalize_invalidation_range (gt, &start, &end); +bool need_flush = !prl_sa && + seqno !=TLB_INVALIDATION_SEQNO_INVALID ;/* Flush on NULL case, Media is not required to modify flush due to no PPC so NOP */ - action[len++] =MAKE_INVAL_OP_FLUSH (type, !prl_sa); + action[len++] =MAKE_INVAL_OP_FLUSH (type, need_flush); action[len++] = id; action[len++] =lower_32_bits (start); action[len++] =upper_32_bits (start);
@@ -181,8 +193,10 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start,#undef MAX_TLB_INVALIDATION_LEN err =send_tlb_inval (guc, action, len); -if (!err && prl_sa) +if (!err && prl_sa) { +xe_gt_assert (gt, seqno !=TLB_INVALIDATION_SEQNO_INVALID ); err =send_page_reclaim (guc, seqno,xe_sa_bo_gpu_addr (prl_sa)); + }return err; }
@@ -201,6 +215,114 @@ static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno, XE_GUC_TLB_INVAL_PAGE_SELECTIVE, prl_sa); } +static int send_tlb_inval_ctx_ppgtt (struct xe_tlb_inval *tlb_inval,u32 seqno, +u64 start,u64 end,u32 asid, +struct drm_suballoc *prl_sa) +{ +struct xe_guc *guc = tlb_inval->private; +struct xe_device *xe =guc_to_xe (guc); +struct xe_exec_queue *q, *next, *last_q =NULL ; +struct xe_vm *vm; +LIST_HEAD (tlb_inval_list); +int err =0 , id =guc_to_gt (guc)->info.id; + +lockdep_assert_held (&tlb_inval->seqno_lock); + +if (xe->info.force_execlist) +return -ECANCELED ; + + vm =xe_device_asid_to_vm (xe, asid); +if (IS_ERR (vm)) +return PTR_ERR (vm); + +down_read (&vm->exec_queues.lock); + +/* +* XXX: Randomly picking a threshold for now. This will need to be +* tuned based on expected UMD queue counts and performance profiling. +*/ +#define EXEC_QUEUE_COUNT_FULL_THRESHOLD 8 +if (vm->exec_queues.count[id] >=EXEC_QUEUE_COUNT_FULL_THRESHOLD ) { +u32 action[] = { +XE_GUC_ACTION_TLB_INVALIDATION , + seqno, +MAKE_INVAL_OP (XE_GUC_TLB_INVAL_FULL ), + }; + + err =send_tlb_inval (guc, action,ARRAY_SIZE (action)); + goto err_unlock; + } +#undef EXEC_QUEUE_COUNT_FULL_THRESHOLD + +/* +* Move exec queues to a temporary list to issue invalidations. The exec +* queue must active and a reference must be taken to prevent concurrent +* deregistrations. +* +* List modification is safe because we hold 'vm->exec_queues.lock' for +* reading, which prevents external modifications. Using a per-GT list +* is also safe since 'tlb_inval->seqno_lock' ensures no other GT users +* can enter this code path. +*/ +list_for_each_entry_safe (q, next, &vm->exec_queues.list[id], + vm_exec_queue_link) { +if (q->ops->active (q) &&xe_exec_queue_get_unless_zero (q)) { + last_q = q; +list_move_tail (&q->vm_exec_queue_link, &tlb_inval_list); + } + } + +if (!last_q) { +/* +* We can't break fence ordering for TLB invalidation jobs, if +* TLB invalidations are inflight issue a dummy invalidation to +* maintain ordering. Nor can we move safely the seqno_recv when +* returning -ECANCELED if TLB invalidations are in flight. Use +* GGTT invalidation as dummy invalidation given ASID +* invalidations are unsupported here. +*/ +if (xe_tlb_inval_idle (tlb_inval)) + err = -ECANCELED ; +else + err =send_tlb_inval_ggtt (tlb_inval, seqno); + goto err_unlock; + } + +list_for_each_entry_safe (q, next, &tlb_inval_list, vm_exec_queue_link) { +struct drm_suballoc *__prl_sa =NULL ; +int __seqno =TLB_INVALIDATION_SEQNO_INVALID ; +u32 type =XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX ; + +xe_assert (xe, q->vm == vm); + +if (err) + goto unref; + +if (last_q == q) { + __prl_sa = prl_sa; + __seqno = seqno; + } + + err =send_tlb_inval_ppgtt (guc, __seqno, start, end, + q->guc->id, type, __prl_sa); + +unref: +/* +* Must always return exec queue to original list / drop +* reference +*/ +list_move_tail (&q->vm_exec_queue_link, + &vm->exec_queues.list[id]); +xe_exec_queue_put (q); + } + +err_unlock: +up_read (&vm->exec_queues.lock); +xe_vm_put (vm); + +return err; +} +static bool tlb_inval_initialized (struct xe_tlb_inval *tlb_inval) {struct xe_guc *guc = tlb_inval->private;
@@ -228,7 +350,7 @@ static long tlb_inval_timeout_delay(struct xe_tlb_inval *tlb_inval)return hw_tlb_timeout +2 * delay; } -static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { +static const struct xe_tlb_inval_ops guc_tlb_inval_asid_ops = { .all = send_tlb_inval_all, .ggtt = send_tlb_inval_ggtt, .ppgtt = send_tlb_inval_asid_ppgtt,
@@ -237,6 +359,15 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { .timeout_delay = tlb_inval_timeout_delay, }; +static const struct xe_tlb_inval_ops guc_tlb_inval_ctx_ops = { + .ggtt = send_tlb_inval_ggtt, + .all = send_tlb_inval_all, + .ppgtt = send_tlb_inval_ctx_ppgtt, + .initialized = tlb_inval_initialized, + .flush = tlb_inval_flush, + .timeout_delay = tlb_inval_timeout_delay, +}; +/** * xe_guc_tlb_inval_init_early() - Init GuC TLB invalidation early * @guc: GuC object
@@ -248,8 +379,14 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = {void xe_guc_tlb_inval_init_early (struct xe_guc *guc,struct xe_tlb_inval *tlb_inval) { +struct xe_device *xe =guc_to_xe (guc); + tlb_inval->private = guc; - tlb_inval->ops = &guc_tlb_inval_ops; + +if (xe->info.has_ctx_tlb_inval) + tlb_inval->ops = &guc_tlb_inval_ctx_ops; +else + tlb_inval->ops = &guc_tlb_inval_asid_ops; }/**
Signature · 1 line
2.34.1
Re: [PATCH v4 11/12] drm/xe: Add context-based invalidation to GuC TLB invalidation backend
Quoted 168 lines · Matthew Brost
Introduce context-based invalidation support to the GuC TLB invalidation
backend. This is implemented by iterating over each exec queue per GT within a VM, skipping inactive queues, and issuing a context-based (GuC
ID) H2G TLB invalidation. All H2G messages, except the final one, are sent with an invalid seqno, which the G2H handler drops to ensure the TLB invalidation fence is only signaled once all H2G messages are completed.A watermark mechanism is also added to switch between context-based TLB
invalidations and full device-wide invalidations, as the return on investment for context-based invalidation diminishes when many exec queues are mapped.v2:
- Fix checkpatch warnings
v3:
- Rebase on PRL
- Use ref counting to avoid racing with deregisters v4:
- Extra braces (Stuart)
- Use per GT list (CI)
- Reorder putSigned-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 145
+++++++++++++++++++++++++-1 file changed, 141 insertions(+), 4 deletions(-)drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -6,15 +6,19 @@ #include "abi/guc_actions_abi.h"
#include "xe_device.h"drivers/gpu/drm/xe/xe_guc_tlb_inval.c +2
-0+#include "xe_exec_queue.h" +#include "xe_exec_queue_types.h" #include "
xe_gt_stats.h"
#include "xe_gt_types.h"
#include "xe_guc.h"
#include "xe_guc_ct.h"
+#include "xe_guc_exec_queue_types.h"
#include "xe_guc_tlb_inval.h"
#include "xe_force_wake.h"
#include "xe_mmio.h"
#include "xe_sa.h"
#include "xe_tlb_inval.h"
+#include "xe_vm.h"
#include "regs/xe_guc_regs.h"drivers/gpu/drm/xe/xe_guc_tlb_inval.c +1
-0@@ -156,10 +160,16 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start, { #define MAX_TLB_INVALIDATION_LEN 7 struct xe_gt *gt = guc_to_gt(guc); + struct xe_device *xe = guc_to_xe(guc); u32 action[MAX_TLB_INVALIDATION_LEN]; u64 length = end - start; int len = 0, err;
+ xe_gt_assert(gt, (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE&& + !xe->info.has_ctx_tlb_inval) || + (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX&& +xe->info.has_ctx_tlb_inval));
+
action[len++] =XE_GUC_ACTION_TLB_INVALIDATION; action[len++] = !prl_sa ? seqno :TLB_INVALIDATION_SEQNO_INVALID;
if (!gt_to_xe(gt)->info.has_range_tlb_inval ||drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -168,9 +178,11 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start, } else { u64 normalize_len = normalize_invalidation_range(gt, &start,
&end);
+ boolneed_flush= !prl_sa &&
+ seqno !=TLB_INVALIDATION_SEQNO_INVALID;
/* Flush on NULL case, Media is not required to modify flush due to no PPC so NOP */
- action[len++] =MAKE_INVAL_OP_FLUSH(type, !prl_sa); + action[len++] =MAKE_INVAL_OP_FLUSH(type, need_flush);
action[len++] = id;
action[len++] =lower_32_bits(start); action[len++] =upper_32_bits(start);drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -181,8 +193,10 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start, #undef MAX_TLB_INVALIDATION_LEN
err =send_tlb_inval(guc, action, len); - if (!err &&prl_sa)
+ if (!err &&prl_sa) {
+ xe_gt_assert(gt, seqno !=TLB_INVALIDATION_SEQNO_INVALID);
err =send_page_reclaim(guc, seqno, xe_sa_bo_gpu_addr(prl_sa));
+ }
return err;
}drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -201,6 +215,114 @@ static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno, XE_GUC_TLB_INVAL_PAGE_SELECTIVE, prl_sa); }
+static int send_tlb_inval_ctx_ppgtt(structxe_tlb_inval*tlb_inval, u32 seqno,
+ u64 start, u64 end, u32 asid, + structdrm_suballoc*prl_sa)drivers/gpu/drm/xe/xe_guc_tlb_inval.c +21
-0+{ + struct xe_guc *guc = tlb_inval->private; + struct xe_device *xe = guc_to_xe(guc); + struct xe_exec_queue *q, *next, *last_q = NULL; + struct xe_vm *vm; + LIST_HEAD(tlb_inval_list); + int err = 0, id = guc_to_gt(guc)->info.id; + + lockdep_assert_held(&tlb_inval->seqno_lock); + + if (xe->info.force_execlist) + return -ECANCELED; + + vm = xe_device_asid_to_vm(xe, asid); + if (IS_ERR(vm)) + return PTR_ERR(vm); + + down_read(&vm->exec_queues.lock); + + /* +* XXX: Randomly picking a threshold for now. This will need to be
+ * tuned based on expected UMD queue counts and performance profiling.
+ */
+#define EXEC_QUEUE_COUNT_FULL_THRESHOLD 8
+ if (vm->exec_queues.count[id] >=EXEC_QUEUE_COUNT_FULL_THRESHOLD) {
+ u32 action[] = {
+ XE_GUC_ACTION_TLB_INVALIDATION, + seqno,
+ MAKE_INVAL_OP(XE_GUC_TLB_INVAL_FULL), + };
+
+ err =send_tlb_inval(guc, action, ARRAY_SIZE(action));
+ gotoerr_unlock;
+ }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4
-0+#undef EXEC_QUEUE_COUNT_FULL_THRESHOLD + + /* +* Move exec queues to a temporary list to issue invalidations. The exec
+ * queue must active and a reference must be taken to prevent concurrent
+ * deregistrations.
+ *
+ * List modification is safe because we hold 'vm-Quoted 1 line
exec_queues.lock' for
Quoted 13 lines
+ * reading, which prevents external modifications. Using a per-GT list
+ * is also safe since 'tlb_inval->seqno_lock' ensures no other GT users
+ * can enter this code path.
+ */
+ list_for_each_entry_safe(q, next, &vm->exec_queues.list[id], +vm_exec_queue_link) {
+ if (q->ops->active(q)&&xe_exec_queue_get_unless_zero(q)) {
+ last_q = q;
+ list_move_tail(&q->vm_exec_queue_link,&tlb_inval_list);
It would be nice if we could consolidate this into a single list instead of moving things around like this, but I realize this makes it easier to track the last active queue so no issue...
I don't see anything blocking us from deregistering a queue though after it has been moved to the tlb_inval_list here. Should we add that seqno_lock in the register/deregister routines to be safe? Or maybe block until tlb_inval_list is empty? Or if I'm missing it otherwise, how are you preventing the deregistration after this is on the list?
Thanks,
Stuart
Quoted 108 lines
+ }
+ }
+
+ if (!last_q) {
+ /*
+ * We can't break fence ordering for TLB invalidation jobs, if
+ * TLB invalidations are inflight issue a dummy invalidation to
+ * maintain ordering. Nor can we move safely theseqno_recvwhen
+ * returning-ECANCELEDif TLB invalidations are in flight. Use
+ * GGTT invalidation as dummy invalidation given ASID + * invalidations are unsupported here.
+ */
+ if (xe_tlb_inval_idle(tlb_inval))
+ err =-ECANCELED;
+ else
+ err =send_tlb_inval_ggtt(tlb_inval, seqno); + gotoerr_unlock;
+ }
+
+ list_for_each_entry_safe(q, next,&tlb_inval_list,vm_exec_queue_link) {
+ structdrm_suballoc*__prl_sa= NULL;
+ int__seqno=TLB_INVALIDATION_SEQNO_INVALID; + u32 type =XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX;drivers/gpu/drm/xe/xe_guc_tlb_inval.c +13
-0+ + xe_assert(xe, q->vm == vm); + + if (err) + goto unref; + + if (last_q == q) { + __prl_sa = prl_sa; + __seqno = seqno; + } + + err = send_tlb_inval_ppgtt(guc, __seqno, start, end, + q->guc->id, type,
__prl_sa);drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4
-0+ +unref: + /* +* Must always return exec queue to original list / drop
+ * reference
+ */
+ list_move_tail(&q->vm_exec_queue_link, + &vm->exec_queues.list[id]); + xe_exec_queue_put(q);
+ }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +8
-0+ +err_unlock: + up_read(&vm->exec_queues.lock); + xe_vm_put(vm); + + return err; +} +static bool
tlb_inval_initialized(struct xe_tlb_inval *tlb_inval){
structxe_guc*guc =tlb_inval->private;drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -228,7 +350,7 @@ static long tlb_inval_timeout_delay(struct xe_tlb_inval *tlb_inval) return hw_tlb_timeout + 2 * delay; }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +1
-1-static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { +static const struct xe_tlb_inval_ops guc_tlb_inval_asid_ops = {.all =
send_tlb_inval_all,
.ggtt =send_tlb_inval_ggtt,
.ppgtt =send_tlb_inval_asid_ppgtt,drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -237,6 +359,15 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { .timeout_delay = tlb_inval_timeout_delay, };drivers/gpu/drm/xe/xe_guc_tlb_inval.c +9
-0+static const struct xe_tlb_inval_ops guc_tlb_inval_ctx_ops = { + .ggtt = send_tlb_inval_ggtt, + .all = send_tlb_inval_all, + .ppgtt = send_tlb_inval_ctx_ppgtt, + .initialized = tlb_inval_initialized, + .flush = tlb_inval_flush, + .timeout_delay = tlb_inval_timeout_delay, +}; +/**
*xe_guc_tlb_inval_init_early()- Init GuC TLB invalidation early
* @guc: GuC objectdrivers/gpu/drm/xe/xe_guc_tlb_inval.c +7
-1@@ -248,8 +379,14 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { void xe_guc_tlb_inval_init_early(struct xe_guc *guc, struct xe_tlb_inval *tlb_inval) { + struct xe_device *xe = guc_to_xe(guc); + tlb_inval->private = guc; - tlb_inval->ops = &guc_tlb_inval_ops; + + if (xe->info.has_ctx_tlb_inval) + tlb_inval->ops = &guc_tlb_inval_ctx_ops; + else + tlb_inval->ops = &guc_tlb_inval_asid_ops; }
/**
Matthew Brost
maintainerRe: [PATCH v4 11/12] drm/xe: Add context-based invalidation to GuC TLB invalidation backend
Quoted 183 lines · Stuart
Quoted 168 lines · Matthew Brost
Introduce context-based invalidation support to the GuC TLB invalidation
backend. This is implemented by iterating over each exec queue per GT within a VM, skipping inactive queues, and issuing a context-based (GuC
ID) H2G TLB invalidation. All H2G messages, except the final one, are sent with an invalid seqno, which the G2H handler drops to ensure the TLB invalidation fence is only signaled once all H2G messages are completed.A watermark mechanism is also added to switch between context-based TLB
invalidations and full device-wide invalidations, as the return on investment for context-based invalidation diminishes when many exec queues are mapped.v2:
- Fix checkpatch warnings
v3:
- Rebase on PRL
- Use ref counting to avoid racing with deregisters v4:
- Extra braces (Stuart)
- Use per GT list (CI)
- Reorder putSigned-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 145
+++++++++++++++++++++++++-1 file changed, 141 insertions(+), 4 deletions(-)drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -6,15 +6,19 @@ #include "abi/guc_actions_abi.h"
#include "xe_device.h"drivers/gpu/drm/xe/xe_guc_tlb_inval.c +2
-0+#include "xe_exec_queue.h" +#include "xe_exec_queue_types.h" #include "
xe_gt_stats.h"
#include "xe_gt_types.h"
#include "xe_guc.h"
#include "xe_guc_ct.h"
+#include "xe_guc_exec_queue_types.h"
#include "xe_guc_tlb_inval.h"
#include "xe_force_wake.h"
#include "xe_mmio.h"
#include "xe_sa.h"
#include "xe_tlb_inval.h"
+#include "xe_vm.h"
#include "regs/xe_guc_regs.h"drivers/gpu/drm/xe/xe_guc_tlb_inval.c +1
-0@@ -156,10 +160,16 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start, { #define MAX_TLB_INVALIDATION_LEN 7 struct xe_gt *gt = guc_to_gt(guc); + struct xe_device *xe = guc_to_xe(guc); u32 action[MAX_TLB_INVALIDATION_LEN]; u64 length = end - start; int len = 0, err;
+ xe_gt_assert(gt, (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE&& + !xe->info.has_ctx_tlb_inval) || + (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX&& +xe->info.has_ctx_tlb_inval));
+
action[len++] =XE_GUC_ACTION_TLB_INVALIDATION; action[len++] = !prl_sa ? seqno :TLB_INVALIDATION_SEQNO_INVALID;
if (!gt_to_xe(gt)->info.has_range_tlb_inval ||drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -168,9 +178,11 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start, } else { u64 normalize_len = normalize_invalidation_range(gt, &start,
&end);
+ boolneed_flush= !prl_sa &&
+ seqno !=TLB_INVALIDATION_SEQNO_INVALID;
/* Flush on NULL case, Media is not required to modify flush due to no PPC so NOP */
- action[len++] =MAKE_INVAL_OP_FLUSH(type, !prl_sa); + action[len++] =MAKE_INVAL_OP_FLUSH(type, need_flush);
action[len++] = id;
action[len++] =lower_32_bits(start); action[len++] =upper_32_bits(start);drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -181,8 +193,10 @@ static int send_tlb_inval_ppgtt(struct xe_guc *guc, u32 seqno, u64 start, #undef MAX_TLB_INVALIDATION_LEN
err =send_tlb_inval(guc, action, len); - if (!err &&prl_sa)
+ if (!err &&prl_sa) {
+ xe_gt_assert(gt, seqno !=TLB_INVALIDATION_SEQNO_INVALID);
err =send_page_reclaim(guc, seqno, xe_sa_bo_gpu_addr(prl_sa));
+ }
return err;
}drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -201,6 +215,114 @@ static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno, XE_GUC_TLB_INVAL_PAGE_SELECTIVE, prl_sa); }
+static int send_tlb_inval_ctx_ppgtt(structxe_tlb_inval*tlb_inval, u32 seqno,
+ u64 start, u64 end, u32 asid, + structdrm_suballoc*prl_sa)drivers/gpu/drm/xe/xe_guc_tlb_inval.c +21
-0+{ + struct xe_guc *guc = tlb_inval->private; + struct xe_device *xe = guc_to_xe(guc); + struct xe_exec_queue *q, *next, *last_q = NULL; + struct xe_vm *vm; + LIST_HEAD(tlb_inval_list); + int err = 0, id = guc_to_gt(guc)->info.id; + + lockdep_assert_held(&tlb_inval->seqno_lock); + + if (xe->info.force_execlist) + return -ECANCELED; + + vm = xe_device_asid_to_vm(xe, asid); + if (IS_ERR(vm)) + return PTR_ERR(vm); + + down_read(&vm->exec_queues.lock); + + /* +* XXX: Randomly picking a threshold for now. This will need to be
+ * tuned based on expected UMD queue counts and performance profiling.
+ */
+#define EXEC_QUEUE_COUNT_FULL_THRESHOLD 8
+ if (vm->exec_queues.count[id] >=EXEC_QUEUE_COUNT_FULL_THRESHOLD) {
+ u32 action[] = {
+ XE_GUC_ACTION_TLB_INVALIDATION, + seqno,
+ MAKE_INVAL_OP(XE_GUC_TLB_INVAL_FULL), + };
+
+ err =send_tlb_inval(guc, action, ARRAY_SIZE(action));
+ gotoerr_unlock;
+ }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4
-0+#undef EXEC_QUEUE_COUNT_FULL_THRESHOLD + + /* +* Move exec queues to a temporary list to issue invalidations. The exec
+ * queue must active and a reference must be taken to prevent concurrent
+ * deregistrations.
+ *
+ * List modification is safe because we hold 'vm-Quoted 1 line
exec_queues.lock' for
Quoted 13 lines
+ * reading, which prevents external modifications. Using a per-GT list
+ * is also safe since 'tlb_inval->seqno_lock' ensures no other GT users
+ * can enter this code path.
+ */
+ list_for_each_entry_safe(q, next, &vm->exec_queues.list[id], +vm_exec_queue_link) {
+ if (q->ops->active(q)&&xe_exec_queue_get_unless_zero(q)) {
+ last_q = q;
+ list_move_tail(&q->vm_exec_queue_link,&tlb_inval_list);
Quoted 4 lines
It would be nice if we could consolidate this into a single list instead of moving things around like this, but I realize this makes it easier to track the last active queue so no issue...
Yes, the active check is stable exactly once, which would make it impossible to find last_q if we do two passes.
Quoted 2 lines
I don't see anything blocking us from deregistering a queue though after it has been moved to the
tlb_inval_listhere. Should we add that
The xe_exec_queue_get_unless_zero is what makes this safe. Deregistrations are now completely tied to the reference count, which changed here [1]. A reference count of zero means all jobs have signaled on the queue, so there’s no need to issue an invalidation.
[1] https://patchwork.freedesktop.org/patch/697820/?series=155314&rev=10
Quoted 4 lines
seqno_lockin the register/deregister routines to be safe? Or maybe block untiltlb_inval_listis empty? Or if I'm missing it otherwise, how are you preventing the deregistration after this is on the list?
See above—I’m pretty sure this is safe. Refcounting tricks wouldn’t be my first choice, but a cross-component lock would be considerably worse.
Matt
Quoted 112 lines
Thanks,
StuartQuoted 108 lines
+ }
+ }
+
+ if (!last_q) {
+ /*
+ * We can't break fence ordering for TLB invalidation jobs, if
+ * TLB invalidations are inflight issue a dummy invalidation to
+ * maintain ordering. Nor can we move safely theseqno_recvwhen
+ * returning-ECANCELEDif TLB invalidations are in flight. Use
+ * GGTT invalidation as dummy invalidation given ASID + * invalidations are unsupported here.
+ */
+ if (xe_tlb_inval_idle(tlb_inval))
+ err =-ECANCELED;
+ else
+ err =send_tlb_inval_ggtt(tlb_inval, seqno); + gotoerr_unlock;
+ }
+
+ list_for_each_entry_safe(q, next,&tlb_inval_list,vm_exec_queue_link) {
+ structdrm_suballoc*__prl_sa= NULL;
+ int__seqno=TLB_INVALIDATION_SEQNO_INVALID; + u32 type =XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX;drivers/gpu/drm/xe/xe_guc_tlb_inval.c +13
-0+ + xe_assert(xe, q->vm == vm); + + if (err) + goto unref; + + if (last_q == q) { + __prl_sa = prl_sa; + __seqno = seqno; + } + + err = send_tlb_inval_ppgtt(guc, __seqno, start, end, + q->guc->id, type,
__prl_sa);drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4
-0+ +unref: + /* +* Must always return exec queue to original list / drop
+ * reference
+ */
+ list_move_tail(&q->vm_exec_queue_link, + &vm->exec_queues.list[id]); + xe_exec_queue_put(q);
+ }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +8
-0+ +err_unlock: + up_read(&vm->exec_queues.lock); + xe_vm_put(vm); + + return err; +} +static bool
tlb_inval_initialized(struct xe_tlb_inval *tlb_inval){
structxe_guc*guc =tlb_inval->private;drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -228,7 +350,7 @@ static long tlb_inval_timeout_delay(struct xe_tlb_inval *tlb_inval) return hw_tlb_timeout + 2 * delay; }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +1
-1-static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { +static const struct xe_tlb_inval_ops guc_tlb_inval_asid_ops = {.all =
send_tlb_inval_all,
.ggtt =send_tlb_inval_ggtt,
.ppgtt =send_tlb_inval_asid_ppgtt,drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -237,6 +359,15 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { .timeout_delay = tlb_inval_timeout_delay, };drivers/gpu/drm/xe/xe_guc_tlb_inval.c +9
-0+static const struct xe_tlb_inval_ops guc_tlb_inval_ctx_ops = { + .ggtt = send_tlb_inval_ggtt, + .all = send_tlb_inval_all, + .ppgtt = send_tlb_inval_ctx_ppgtt, + .initialized = tlb_inval_initialized, + .flush = tlb_inval_flush, + .timeout_delay = tlb_inval_timeout_delay, +}; +/**
*xe_guc_tlb_inval_init_early()- Init GuC TLB invalidation early
* @guc: GuC objectdrivers/gpu/drm/xe/xe_guc_tlb_inval.c +7
-1@@ -248,8 +379,14 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { void xe_guc_tlb_inval_init_early(struct xe_guc *guc, struct xe_tlb_inval *tlb_inval) { + struct xe_device *xe = guc_to_xe(guc); + tlb_inval->private = guc; - tlb_inval->ops = &guc_tlb_inval_ops; + + if (xe->info.has_ctx_tlb_inval) + tlb_inval->ops = &guc_tlb_inval_ctx_ops; + else + tlb_inval->ops = &guc_tlb_inval_asid_ops; }
/**
Re: [PATCH v4 11/12] drm/xe: Add context-based invalidation to GuC TLB invalidation backend
Quoted 219 lines · Matthew Brost
Quoted 204 lines · Stuart
Quoted 195 lines · Matthew Brost
Introduce context-based invalidation support to the GuC TLB invalidation
backend. This is implemented by iterating over each exec queue per GT
within a VM, skipping inactive queues, and issuing a context- based
(GuC
ID) H2G TLB invalidation. All H2G messages, except the final one, are
sent with an invalid seqno, which the G2H handler drops to ensure the
TLB invalidation fence is only signaled once all H2G messages are completed.A watermark mechanism is also added to switch between context- based
TLB
invalidations and full device-wide invalidations, as the return on
investment for context-based invalidation diminishes when many exec
queues are mapped.v2:
- Fix checkpatch warnings
v3:
- Rebase on PRL
- Use ref counting to avoid racing with deregisters v4:
- Extra braces (Stuart)
- Use per GT list (CI)
- Reorder putSigned-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 145
+++++++++++++++++++++++++-1 file changed, 141 insertions(+), 4 deletions(-)drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -6,15 +6,19 @@ #include "abi/guc_actions_abi.h"
#include "xe_device.h"drivers/gpu/drm/xe/xe_guc_tlb_inval.c +2
-0+#include "xe_exec_queue.h" +#include "xe_exec_queue_types.h" #include "
xe_gt_stats.h"
#include "xe_gt_types.h"
#include "xe_guc.h"
#include "xe_guc_ct.h"
+#include "xe_guc_exec_queue_types.h"
#include "xe_guc_tlb_inval.h"
#include "xe_force_wake.h"
#include "xe_mmio.h"
#include "xe_sa.h"
#include "xe_tlb_inval.h"
+#include "xe_vm.h"
#include "regs/xe_guc_regs.h"drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -156,10 +160,16 @@ static int send_tlb_inval_ppgtt(struct
xe_guc
*guc, u32 seqno, u64 start,
{
#define MAX_TLB_INVALIDATION_LEN 7
structxe_gt*gt =guc_to_gt(guc);
+ structxe_device*xe =guc_to_xe(guc);
u32 action[MAX_TLB_INVALIDATION_LEN];
u64 length = end - start;
int len = 0, err;
+ xe_gt_assert(gt, (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE&&
+ !xe->info.has_ctx_tlb_inval) || + (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX&&
+xe->info.has_ctx_tlb_inval));
+
action[len++] =XE_GUC_ACTION_TLB_INVALIDATION; action[len++] = !prl_sa ? seqno :TLB_INVALIDATION_SEQNO_INVALID;
if (!gt_to_xe(gt)->info.has_range_tlb_inval ||drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -168,9 +178,11 @@ static int send_tlb_inval_ppgtt(struct
xe_guc
*guc, u32 seqno, u64 start,
} else {
u64normalize_len= normalize_invalidation_range(gt,
&start,
&end);
+ boolneed_flush= !prl_sa &&
+ seqno !=TLB_INVALIDATION_SEQNO_INVALID;
/* Flush on NULL case, Media is not required to modify flush due to no PPC so NOP */
- action[len++] =MAKE_INVAL_OP_FLUSH(type, !prl_sa);
+ action[len++] =MAKE_INVAL_OP_FLUSH(type, need_flush);
action[len++] = id;
action[len++] =lower_32_bits(start); action[len++] =upper_32_bits(start);drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -181,8 +193,10 @@ static int send_tlb_inval_ppgtt(struct
xe_guc
*guc, u32 seqno, u64 start,
#undefMAX_TLB_INVALIDATION_LEN
err =send_tlb_inval(guc, action, len); - if (!err &&prl_sa)
+ if (!err &&prl_sa) {
+ xe_gt_assert(gt, seqno !=TLB_INVALIDATION_SEQNO_INVALID);
err =send_page_reclaim(guc, seqno, xe_sa_bo_gpu_addr(prl_sa));
+ }
return err;
}drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -201,6 +215,114 @@ static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno,
XE_GUC_TLB_INVAL_PAGE_SELECTIVE,prl_sa);
}
+static int send_tlb_inval_ctx_ppgtt(structxe_tlb_inval*tlb_inval,
u32 seqno,
+ u64 start, u64 end, u32 asid, + structdrm_suballoc*prl_sa)drivers/gpu/drm/xe/xe_guc_tlb_inval.c +21
-0+{ + struct xe_guc *guc = tlb_inval->private; + struct xe_device *xe = guc_to_xe(guc); + struct xe_exec_queue *q, *next, *last_q = NULL; + struct xe_vm *vm; + LIST_HEAD(tlb_inval_list); + int err = 0, id = guc_to_gt(guc)->info.id; + + lockdep_assert_held(&tlb_inval->seqno_lock); + + if (xe->info.force_execlist) + return -ECANCELED; + + vm = xe_device_asid_to_vm(xe, asid); + if (IS_ERR(vm)) + return PTR_ERR(vm); + + down_read(&vm->exec_queues.lock); + + /* +* XXX: Randomly picking a threshold for now. This will need
to be
+ * tuned based on expected UMD queue counts and performance
profiling.
+ */
+#define EXEC_QUEUE_COUNT_FULL_THRESHOLD 8
+ if (vm->exec_queues.count[id] >=EXEC_QUEUE_COUNT_FULL_THRESHOLD) {
+ u32 action[] = {
+ XE_GUC_ACTION_TLB_INVALIDATION, + seqno,
+ MAKE_INVAL_OP(XE_GUC_TLB_INVAL_FULL), + };
+
+ err =send_tlb_inval(guc, action, ARRAY_SIZE(action));
+ gotoerr_unlock;
+ }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4
-0+#undef EXEC_QUEUE_COUNT_FULL_THRESHOLD + + /* +* Move exec queues to a temporary list to issue invalidations. The exec
+ * queue must active and a reference must be taken to prevent
concurrent
+ * deregistrations.
+ *
+ * List modification is safe because we hold 'vm-Quoted 1 line
exec_queues.lock' for
+ * reading, which prevents external modifications. Using a
per-GT list
+ * is also safe since 'tlb_inval->seqno_lock' ensures no other GT users
+ * can enter this code path.
+ */
+ list_for_each_entry_safe(q, next, &vm-Quoted 7 lines
Quoted 1 line
exec_queues.list[id],
+
vm_exec_queue_link) { + if (q->ops->active(q)&&xe_exec_queue_get_unless_zero(q)) {
+ last_q = q;
+ list_move_tail(&q->vm_exec_queue_link,&tlb_inval_list);Quoted 5 lines
It would be nice if we could consolidate this into a single list instead of moving things around like this, but I realize this makes it
easier to track the last active queue so no issue...Yes, the active check is stable exactly once, which would make it impossible to find
last_qif we do two passes.Quoted 3 lines
I don't see anything blocking us from deregistering a queue though after it has been moved to the
tlb_inval_listhere. Should we add that
Quoted 5 lines
The
xe_exec_queue_get_unless_zerois what makes this safe. Deregistrations are now completely tied to the reference count, which changed here [1]. A reference count of zero means all jobs have signaled
on the queue, so there’s no need to issue an invalidation.
Oh I hadn't seen this patch yet, thanks for the link!
So basically before we were doing this extra reference which meant a get/put here would not trigger anything until the deregistration happened later as part of that schedule disable (assuming it didn't time out or something). By dropping that extra ref, the expectation is if scheduling ends after we check active here, i.e. someone does an exec_queue_put(), as soon as we do the put in this new routine, it will trigger exec_queue_destroy() which sets that pending disable. Is that right?
And I guess since we're doing the get_unless_zero here, we're also protected in the situation where a schedule disable is in progress but we haven't yet hit that pending disable?
Still need to get some more testing in here to prove all of that, but I agree it makes sense.
Quoted 11 lines
[1]
https://patchwork.freedesktop.org/patch/697820/?series=155314&rev=10Quoted 6 lines
seqno_lockin the register/deregister routines to be safe? Or maybe block untiltlb_inval_listis empty? Or if I'm missing it otherwise,
how are you preventing the deregistration after this is on the list?
Quoted 4 lines
See above—I’m pretty sure this is safe. Refcounting tricks wouldn’t be
my first choice, but a cross-component lock would be considerably worse.
Agreed.
Thanks,
Stuart
Quoted 123 lines
Matt
Quoted 120 lines
Thanks,
StuartQuoted 116 lines
+ }
+ }
+
+ if (!last_q) {
+ /*
+ * We can't break fence ordering for TLB invalidation
jobs, if
+ * TLB invalidations are inflight issue a dummy invalidation to
+ * maintain ordering. Nor can we move safely theseqno_recvwhen
+ * returning-ECANCELEDif TLB invalidations are in
flight. Use
+ * GGTT invalidation as dummy invalidation given ASID
+ * invalidations are unsupported here. + */
+ if (xe_tlb_inval_idle(tlb_inval))
+ err =-ECANCELED;
+ else
+ err =send_tlb_inval_ggtt(tlb_inval, seqno);
+ gotoerr_unlock;
+ }
+
+ list_for_each_entry_safe(q, next,&tlb_inval_list,vm_exec_queue_link) {
+ structdrm_suballoc*__prl_sa= NULL; + int__seqno=TLB_INVALIDATION_SEQNO_INVALID; + u32 type =XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX;drivers/gpu/drm/xe/xe_guc_tlb_inval.c +12
-0+ + xe_assert(xe, q->vm == vm); + + if (err) + goto unref; + + if (last_q == q) { + __prl_sa = prl_sa; + __seqno = seqno; + } + + err = send_tlb_inval_ppgtt(guc, __seqno, start,end,
+q->guc->id, type,__prl_sa);drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4
-0+ +unref: + /* +* Must always return exec queue to original list /
drop
+ * reference
+ */
+ list_move_tail(&q->vm_exec_queue_link, + &vm->exec_queues.list[id]); + xe_exec_queue_put(q);
+ }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +8
-0+ +err_unlock: + up_read(&vm->exec_queues.lock); + xe_vm_put(vm); + + return err; +} +static bool
tlb_inval_initialized(struct xe_tlb_inval *tlb_inval)
{
structxe_guc*guc =tlb_inval->private;drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -228,7 +350,7 @@ static long tlb_inval_timeout_delay(struct xe_tlb_inval *tlb_inval) return hw_tlb_timeout + 2 * delay; }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +1
-1-static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { +static const struct xe_tlb_inval_ops guc_tlb_inval_asid_ops = {.all =
send_tlb_inval_all,
.ggtt =send_tlb_inval_ggtt,
.ppgtt =send_tlb_inval_asid_ppgtt,drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -237,6 +359,15 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { .timeout_delay = tlb_inval_timeout_delay, };drivers/gpu/drm/xe/xe_guc_tlb_inval.c +9
-0+static const struct xe_tlb_inval_ops guc_tlb_inval_ctx_ops = { + .ggtt = send_tlb_inval_ggtt, + .all = send_tlb_inval_all, + .ppgtt = send_tlb_inval_ctx_ppgtt, + .initialized = tlb_inval_initialized, + .flush = tlb_inval_flush, + .timeout_delay = tlb_inval_timeout_delay, +}; +/**
*xe_guc_tlb_inval_init_early()- Init GuC TLB invalidation early
* @guc: GuC objectdrivers/gpu/drm/xe/xe_guc_tlb_inval.c +7
-1@@ -248,8 +379,14 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { void xe_guc_tlb_inval_init_early(struct xe_guc *guc, struct xe_tlb_inval *tlb_inval) { + struct xe_device *xe = guc_to_xe(guc); + tlb_inval->private = guc; - tlb_inval->ops = &guc_tlb_inval_ops; + + if (xe->info.has_ctx_tlb_inval) + tlb_inval->ops = &guc_tlb_inval_ctx_ops; + else + tlb_inval->ops = &guc_tlb_inval_asid_ops; }
/**
Matthew Brost
maintainerRe: [PATCH v4 11/12] drm/xe: Add context-based invalidation to GuC TLB invalidation backend
Quoted 228 lines · Stuart
Quoted 219 lines · Matthew Brost
Quoted 204 lines · Stuart
Quoted 195 lines · Matthew Brost
Introduce context-based invalidation support to the GuC TLB invalidation
backend. This is implemented by iterating over each exec queue per GT
within a VM, skipping inactive queues, and issuing a context- based
(GuC
ID) H2G TLB invalidation. All H2G messages, except the final one, are
sent with an invalid seqno, which the G2H handler drops to ensure the
TLB invalidation fence is only signaled once all H2G messages are completed.A watermark mechanism is also added to switch between context- based
TLB
invalidations and full device-wide invalidations, as the return on
investment for context-based invalidation diminishes when many exec
queues are mapped.v2:
- Fix checkpatch warnings
v3:
- Rebase on PRL
- Use ref counting to avoid racing with deregisters v4:
- Extra braces (Stuart)
- Use per GT list (CI)
- Reorder putSigned-off-by Matthew Brost <[email protected]>---
drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 145
+++++++++++++++++++++++++-1 file changed, 141 insertions(+), 4 deletions(-)drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -6,15 +6,19 @@ #include "abi/guc_actions_abi.h"
#include "xe_device.h"drivers/gpu/drm/xe/xe_guc_tlb_inval.c +2
-0+#include "xe_exec_queue.h" +#include "xe_exec_queue_types.h" #include "
xe_gt_stats.h"
#include "xe_gt_types.h"
#include "xe_guc.h"
#include "xe_guc_ct.h"
+#include "xe_guc_exec_queue_types.h"
#include "xe_guc_tlb_inval.h"
#include "xe_force_wake.h"
#include "xe_mmio.h"
#include "xe_sa.h"
#include "xe_tlb_inval.h"
+#include "xe_vm.h"
#include "regs/xe_guc_regs.h"drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -156,10 +160,16 @@ static int send_tlb_inval_ppgtt(struct
xe_guc
*guc, u32 seqno, u64 start,
{
#define MAX_TLB_INVALIDATION_LEN 7
structxe_gt*gt =guc_to_gt(guc);
+ structxe_device*xe =guc_to_xe(guc);
u32 action[MAX_TLB_INVALIDATION_LEN];
u64 length = end - start;
int len = 0, err;
+ xe_gt_assert(gt, (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE&&
+ !xe->info.has_ctx_tlb_inval) || + (type ==XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX&&
+xe->info.has_ctx_tlb_inval));
+
action[len++] =XE_GUC_ACTION_TLB_INVALIDATION; action[len++] = !prl_sa ? seqno :TLB_INVALIDATION_SEQNO_INVALID;
if (!gt_to_xe(gt)->info.has_range_tlb_inval ||drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -168,9 +178,11 @@ static int send_tlb_inval_ppgtt(struct
xe_guc
*guc, u32 seqno, u64 start,
} else {
u64normalize_len= normalize_invalidation_range(gt,
&start,
&end);
+ boolneed_flush= !prl_sa &&
+ seqno !=TLB_INVALIDATION_SEQNO_INVALID;
/* Flush on NULL case, Media is not required to modify flush due to no PPC so NOP */
- action[len++] =MAKE_INVAL_OP_FLUSH(type, !prl_sa);
+ action[len++] =MAKE_INVAL_OP_FLUSH(type, need_flush);
action[len++] = id;
action[len++] =lower_32_bits(start); action[len++] =upper_32_bits(start);drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -181,8 +193,10 @@ static int send_tlb_inval_ppgtt(struct
xe_guc
*guc, u32 seqno, u64 start,
#undefMAX_TLB_INVALIDATION_LEN
err =send_tlb_inval(guc, action, len); - if (!err &&prl_sa)
+ if (!err &&prl_sa) {
+ xe_gt_assert(gt, seqno !=TLB_INVALIDATION_SEQNO_INVALID);
err =send_page_reclaim(guc, seqno, xe_sa_bo_gpu_addr(prl_sa));
+ }
return err;
}drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -201,6 +215,114 @@ static int send_tlb_inval_asid_ppgtt(struct xe_tlb_inval *tlb_inval, u32 seqno,
XE_GUC_TLB_INVAL_PAGE_SELECTIVE,prl_sa);
}
+static int send_tlb_inval_ctx_ppgtt(structxe_tlb_inval*tlb_inval,
u32 seqno,
+ u64 start, u64 end, u32 asid, + structdrm_suballoc*prl_sa)drivers/gpu/drm/xe/xe_guc_tlb_inval.c +21
-0+{ + struct xe_guc *guc = tlb_inval->private; + struct xe_device *xe = guc_to_xe(guc); + struct xe_exec_queue *q, *next, *last_q = NULL; + struct xe_vm *vm; + LIST_HEAD(tlb_inval_list); + int err = 0, id = guc_to_gt(guc)->info.id; + + lockdep_assert_held(&tlb_inval->seqno_lock); + + if (xe->info.force_execlist) + return -ECANCELED; + + vm = xe_device_asid_to_vm(xe, asid); + if (IS_ERR(vm)) + return PTR_ERR(vm); + + down_read(&vm->exec_queues.lock); + + /* +* XXX: Randomly picking a threshold for now. This will need
to be
+ * tuned based on expected UMD queue counts and performance
profiling.
+ */
+#define EXEC_QUEUE_COUNT_FULL_THRESHOLD 8
+ if (vm->exec_queues.count[id] >=EXEC_QUEUE_COUNT_FULL_THRESHOLD) {
+ u32 action[] = {
+ XE_GUC_ACTION_TLB_INVALIDATION, + seqno,
+ MAKE_INVAL_OP(XE_GUC_TLB_INVAL_FULL), + };
+
+ err =send_tlb_inval(guc, action, ARRAY_SIZE(action));
+ gotoerr_unlock;
+ }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4
-0+#undef EXEC_QUEUE_COUNT_FULL_THRESHOLD + + /* +* Move exec queues to a temporary list to issue invalidations. The exec
+ * queue must active and a reference must be taken to prevent
concurrent
+ * deregistrations.
+ *
+ * List modification is safe because we hold 'vm-Quoted 1 line
exec_queues.lock' for
+ * reading, which prevents external modifications. Using a
per-GT list
+ * is also safe since 'tlb_inval->seqno_lock' ensures no other GT users
+ * can enter this code path.
+ */
+ list_for_each_entry_safe(q, next, &vm-Quoted 7 lines
Quoted 1 line
exec_queues.list[id],
+
vm_exec_queue_link) { + if (q->ops->active(q)&&xe_exec_queue_get_unless_zero(q)) {
+ last_q = q;
+ list_move_tail(&q->vm_exec_queue_link,&tlb_inval_list);Quoted 5 lines
It would be nice if we could consolidate this into a single list instead of moving things around like this, but I realize this makes it
easier to track the last active queue so no issue...Yes, the active check is stable exactly once, which would make it impossible to find
last_qif we do two passes.Quoted 3 lines
I don't see anything blocking us from deregistering a queue though after it has been moved to the
tlb_inval_listhere. Should we add thatQuoted 5 lines
The
xe_exec_queue_get_unless_zerois what makes this safe. Deregistrations are now completely tied to the reference count, which changed here [1]. A reference count of zero means all jobs have signaled
on the queue, so there’s no need to issue an invalidation.Oh I hadn't seen this patch yet, thanks for the link!
Quoted 9 lines
So basically before we were doing this extra reference which meant a get/put here would not trigger anything until the deregistration happened later as part of that schedule disable (assuming it didn't time out or something). By dropping that extra ref, the expectation is if scheduling ends after we check active here, i.e. someone does an
exec_queue_put(), as soon as we do the put in this new routine, it will triggerexec_queue_destroy()which sets that pending disable. Is that right?
Schedule disable is a bit different. It can happen for several reasons—the TDR kicks something off the hardware, a preempt fence triggers, or we switch from page fault mode to DMA fence mode. It’s safe if any of these race; ->active() just opportunistically checks if a queue is disabled and skips the invalidation. It’s harmless if a disable races because the queue is still registered, so the TLB invalidation will still work.
Yes, the refcount protects against guc_exec_queue_destroy being entered. We also issue a schedule disable here (or more precisely, the message scheduler work item does this), and when that returns, we issue a deregistration—the latter is what we care about and want to avoid. It’s possible that the TLB invalidation code triggers guc_exec_queue_destroy upon put, but that’s fine.
Quoted 4 lines
And I guess since we're doing the
get_unless_zerohere, we're also protected in the situation where a schedule disable is in progress but we haven't yet hit that pending disable?
The refcount protects against queue cleanup from starting. If refcount == 0, the cleanup process has already started, so there’s no need for an invalidation. Again since queue cleanup is the only place that issue deregistration, this is all safe.
The vm->exec_queues.lock also protects against any queue memory disappearing in the TLB invalidation code.
Matt
Quoted 148 lines
Still need to get some more testing in here to prove all of that, but I agree it makes sense.
Quoted 11 lines
[1]
https://patchwork.freedesktop.org/patch/697820/?series=155314&rev=10Quoted 6 lines
seqno_lockin the register/deregister routines to be safe? Or maybe block untiltlb_inval_listis empty? Or if I'm missing it otherwise,
how are you preventing the deregistration after this is on the list?Quoted 4 lines
See above—I’m pretty sure this is safe. Refcounting tricks wouldn’t be
my first choice, but a cross-component lock would be considerably worse.Agreed.
Thanks,
StuartQuoted 123 lines
Matt
Quoted 120 lines
Thanks,
StuartQuoted 116 lines
+ }
+ }
+
+ if (!last_q) {
+ /*
+ * We can't break fence ordering for TLB invalidation
jobs, if
+ * TLB invalidations are inflight issue a dummy invalidation to
+ * maintain ordering. Nor can we move safely theseqno_recvwhen
+ * returning-ECANCELEDif TLB invalidations are in
flight. Use
+ * GGTT invalidation as dummy invalidation given ASID
+ * invalidations are unsupported here. + */
+ if (xe_tlb_inval_idle(tlb_inval))
+ err =-ECANCELED;
+ else
+ err =send_tlb_inval_ggtt(tlb_inval, seqno);
+ gotoerr_unlock;
+ }
+
+ list_for_each_entry_safe(q, next,&tlb_inval_list,vm_exec_queue_link) {
+ structdrm_suballoc*__prl_sa= NULL; + int__seqno=TLB_INVALIDATION_SEQNO_INVALID; + u32 type =XE_GUC_TLB_INVAL_PAGE_SELECTIVE_CTX;drivers/gpu/drm/xe/xe_guc_tlb_inval.c +12
-0+ + xe_assert(xe, q->vm == vm); + + if (err) + goto unref; + + if (last_q == q) { + __prl_sa = prl_sa; + __seqno = seqno; + } + + err = send_tlb_inval_ppgtt(guc, __seqno, start,end,
+q->guc->id, type,__prl_sa);drivers/gpu/drm/xe/xe_guc_tlb_inval.c +4
-0+ +unref: + /* +* Must always return exec queue to original list /
drop
+ * reference
+ */
+ list_move_tail(&q->vm_exec_queue_link, + &vm->exec_queues.list[id]); + xe_exec_queue_put(q);
+ }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +8
-0+ +err_unlock: + up_read(&vm->exec_queues.lock); + xe_vm_put(vm); + + return err; +} +static bool
tlb_inval_initialized(struct xe_tlb_inval *tlb_inval)
{
structxe_guc*guc =tlb_inval->private;drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -228,7 +350,7 @@ static long tlb_inval_timeout_delay(struct xe_tlb_inval *tlb_inval) return hw_tlb_timeout + 2 * delay; }drivers/gpu/drm/xe/xe_guc_tlb_inval.c +1
-1-static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { +static const struct xe_tlb_inval_ops guc_tlb_inval_asid_ops = {.all =
send_tlb_inval_all,
.ggtt =send_tlb_inval_ggtt,
.ppgtt =send_tlb_inval_asid_ppgtt,drivers/gpu/drm/xe/xe_guc_tlb_inval.c +0
-0@@ -237,6 +359,15 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { .timeout_delay = tlb_inval_timeout_delay, };drivers/gpu/drm/xe/xe_guc_tlb_inval.c +9
-0+static const struct xe_tlb_inval_ops guc_tlb_inval_ctx_ops = { + .ggtt = send_tlb_inval_ggtt, + .all = send_tlb_inval_all, + .ppgtt = send_tlb_inval_ctx_ppgtt, + .initialized = tlb_inval_initialized, + .flush = tlb_inval_flush, + .timeout_delay = tlb_inval_timeout_delay, +}; +/**
*xe_guc_tlb_inval_init_early()- Init GuC TLB invalidation early
* @guc: GuC objectdrivers/gpu/drm/xe/xe_guc_tlb_inval.c +7
-1@@ -248,8 +379,14 @@ static const struct xe_tlb_inval_ops guc_tlb_inval_ops = { void xe_guc_tlb_inval_init_early(struct xe_guc *guc, struct xe_tlb_inval *tlb_inval) { + struct xe_device *xe = guc_to_xe(guc); + tlb_inval->private = guc; - tlb_inval->ops = &guc_tlb_inval_ops; + + if (xe->info.has_ctx_tlb_inval) + tlb_inval->ops = &guc_tlb_inval_ctx_ops; + else + tlb_inval->ops = &guc_tlb_inval_asid_ops; }
/**
Matthew Brost
maintainerPATCH v4 12/12 drm/xe: Enable context TLB invalidations for CI
In reply to Matthew BrostDo not review, CI only.
--- drivers/gpu/drm/xe/xe_pci.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/xe/xe_pci.c +1 -0
@@ -96,6 +96,7 @@ static const struct xe_graphics_desc graphics_xelpg = { .has_asid = 1, \ .has_atomic_enable_pte_bit = 1, \ .has_range_tlb_inval = 1, \ + .has_ctx_tlb_inval = 1, \ .has_usm = 1, \ .has_64bit_timestamp = 1, \ .hw_engine_mask = \
Signature · 1 line
2.34.1
Patchwork
CI✓ CI.KUnit: success for Context based TLB invalidations (rev4)
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Context based TLB invalidations (rev4)
URL : https://patchwork.freedesktop.org/series/156874/
State : success
== Summary ==
+ trap cleanup EXIT
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/xe/.kunitconfig [02:59:19] Configuring KUnit Kernel ...
Generating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [02:59:24] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [02:59:55] Starting KUnit Kernel (1/1)... [02:59:55] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [02:59:55] ================== guc_buf (11 subtests) =================== [02:59:55] [PASSED] test_smallest [02:59:55] [PASSED] test_largest [02:59:55] [PASSED] test_granular [02:59:55] [PASSED] test_unique [02:59:55] [PASSED] test_overlap [02:59:55] [PASSED] test_reusable [02:59:55] [PASSED] test_too_big [02:59:55] [PASSED] test_flush [02:59:55] [PASSED] test_lookup [02:59:55] [PASSED] test_data [02:59:55] [PASSED] test_class [02:59:55] ===================== [PASSED] guc_buf ===================== [02:59:55] =================== guc_dbm (7 subtests) =================== [02:59:55] [PASSED] test_empty [02:59:55] [PASSED] test_default [02:59:55] ======================== test_size ======================== [02:59:55] [PASSED] 4 [02:59:55] [PASSED] 8 [02:59:55] [PASSED] 32 [02:59:55] [PASSED] 256 [02:59:55] ==================== [PASSED] test_size ==================== [02:59:55] ======================= test_reuse ======================== [02:59:55] [PASSED] 4 [02:59:55] [PASSED] 8 [02:59:55] [PASSED] 32 [02:59:55] [PASSED] 256 [02:59:55] =================== [PASSED] test_reuse ==================== [02:59:55] =================== test_range_overlap ==================== [02:59:55] [PASSED] 4 [02:59:55] [PASSED] 8 [02:59:55] [PASSED] 32 [02:59:55] [PASSED] 256 [02:59:55] =============== [PASSED] test_range_overlap ================ [02:59:55] =================== test_range_compact ==================== [02:59:55] [PASSED] 4 [02:59:55] [PASSED] 8 [02:59:55] [PASSED] 32 [02:59:55] [PASSED] 256 [02:59:55] =============== [PASSED] test_range_compact ================ [02:59:55] ==================== test_range_spare ===================== [02:59:55] [PASSED] 4 [02:59:55] [PASSED] 8 [02:59:55] [PASSED] 32 [02:59:55] [PASSED] 256 [02:59:55] ================ [PASSED] test_range_spare ================= [02:59:55] ===================== [PASSED] guc_dbm ===================== [02:59:55] =================== guc_idm (6 subtests) =================== [02:59:55] [PASSED] bad_init [02:59:55] [PASSED] no_init [02:59:55] [PASSED] init_fini [02:59:55] [PASSED] check_used [02:59:55] [PASSED] check_quota [02:59:55] [PASSED] check_all [02:59:55] ===================== [PASSED] guc_idm ===================== [02:59:55] ================== no_relay (3 subtests) =================== [02:59:55] [PASSED] xe_drops_guc2pf_if_not_ready [02:59:55] [PASSED] xe_drops_guc2vf_if_not_ready [02:59:55] [PASSED] xe_rejects_send_if_not_ready [02:59:55] ==================== [PASSED] no_relay ===================== [02:59:55] ================== pf_relay (14 subtests) ================== [02:59:55] [PASSED] pf_rejects_guc2pf_too_short [02:59:55] [PASSED] pf_rejects_guc2pf_too_long [02:59:55] [PASSED] pf_rejects_guc2pf_no_payload [02:59:55] [PASSED] pf_fails_no_payload [02:59:55] [PASSED] pf_fails_bad_origin [02:59:55] [PASSED] pf_fails_bad_type [02:59:55] [PASSED] pf_txn_reports_error [02:59:55] [PASSED] pf_txn_sends_pf2guc [02:59:55] [PASSED] pf_sends_pf2guc [02:59:55] [SKIPPED] pf_loopback_nop [02:59:55] [SKIPPED] pf_loopback_echo [02:59:55] [SKIPPED] pf_loopback_fail [02:59:55] [SKIPPED] pf_loopback_busy [02:59:55] [SKIPPED] pf_loopback_retry [02:59:55] ==================== [PASSED] pf_relay ===================== [02:59:55] ================== vf_relay (3 subtests) =================== [02:59:55] [PASSED] vf_rejects_guc2vf_too_short [02:59:55] [PASSED] vf_rejects_guc2vf_too_long [02:59:55] [PASSED] vf_rejects_guc2vf_no_payload [02:59:55] ==================== [PASSED] vf_relay ===================== [02:59:55] ================ pf_gt_config (6 subtests) ================= [02:59:55] [PASSED] fair_contexts_1vf [02:59:55] [PASSED] fair_doorbells_1vf [02:59:55] [PASSED] fair_ggtt_1vf [02:59:55] ====================== fair_contexts ====================== [02:59:55] [PASSED] 1 VF [02:59:55] [PASSED] 2 VFs [02:59:55] [PASSED] 3 VFs [02:59:55] [PASSED] 4 VFs [02:59:55] [PASSED] 5 VFs [02:59:55] [PASSED] 6 VFs [02:59:55] [PASSED] 7 VFs [02:59:55] [PASSED] 8 VFs [02:59:55] [PASSED] 9 VFs [02:59:55] [PASSED] 10 VFs [02:59:55] [PASSED] 11 VFs [02:59:55] [PASSED] 12 VFs [02:59:55] [PASSED] 13 VFs [02:59:55] [PASSED] 14 VFs [02:59:55] [PASSED] 15 VFs [02:59:55] [PASSED] 16 VFs [02:59:55] [PASSED] 17 VFs [02:59:55] [PASSED] 18 VFs [02:59:55] [PASSED] 19 VFs [02:59:55] [PASSED] 20 VFs [02:59:55] [PASSED] 21 VFs [02:59:55] [PASSED] 22 VFs [02:59:55] [PASSED] 23 VFs [02:59:55] [PASSED] 24 VFs [02:59:55] [PASSED] 25 VFs [02:59:55] [PASSED] 26 VFs [02:59:55] [PASSED] 27 VFs [02:59:55] [PASSED] 28 VFs [02:59:55] [PASSED] 29 VFs [02:59:55] [PASSED] 30 VFs [02:59:55] [PASSED] 31 VFs [02:59:55] [PASSED] 32 VFs [02:59:55] [PASSED] 33 VFs [02:59:55] [PASSED] 34 VFs [02:59:55] [PASSED] 35 VFs [02:59:55] [PASSED] 36 VFs [02:59:55] [PASSED] 37 VFs [02:59:55] [PASSED] 38 VFs [02:59:55] [PASSED] 39 VFs [02:59:55] [PASSED] 40 VFs [02:59:55] [PASSED] 41 VFs [02:59:55] [PASSED] 42 VFs [02:59:55] [PASSED] 43 VFs [02:59:55] [PASSED] 44 VFs [02:59:55] [PASSED] 45 VFs [02:59:55] [PASSED] 46 VFs [02:59:55] [PASSED] 47 VFs [02:59:55] [PASSED] 48 VFs [02:59:55] [PASSED] 49 VFs [02:59:55] [PASSED] 50 VFs [02:59:55] [PASSED] 51 VFs [02:59:55] [PASSED] 52 VFs [02:59:55] [PASSED] 53 VFs [02:59:55] [PASSED] 54 VFs [02:59:55] [PASSED] 55 VFs [02:59:55] [PASSED] 56 VFs [02:59:55] [PASSED] 57 VFs [02:59:55] [PASSED] 58 VFs [02:59:55] [PASSED] 59 VFs [02:59:55] [PASSED] 60 VFs [02:59:55] [PASSED] 61 VFs [02:59:55] [PASSED] 62 VFs [02:59:55] [PASSED] 63 VFs [02:59:55] ================== [PASSED] fair_contexts ================== [02:59:55] ===================== fair_doorbells ====================== [02:59:55] [PASSED] 1 VF [02:59:55] [PASSED] 2 VFs [02:59:55] [PASSED] 3 VFs [02:59:55] [PASSED] 4 VFs [02:59:55] [PASSED] 5 VFs [02:59:55] [PASSED] 6 VFs [02:59:55] [PASSED] 7 VFs [02:59:55] [PASSED] 8 VFs [02:59:55] [PASSED] 9 VFs [02:59:55] [PASSED] 10 VFs [02:59:55] [PASSED] 11 VFs [02:59:55] [PASSED] 12 VFs [02:59:55] [PASSED] 13 VFs [02:59:55] [PASSED] 14 VFs [02:59:55] [PASSED] 15 VFs [02:59:55] [PASSED] 16 VFs [02:59:55] [PASSED] 17 VFs [02:59:55] [PASSED] 18 VFs [02:59:55] [PASSED] 19 VFs [02:59:55] [PASSED] 20 VFs [02:59:55] [PASSED] 21 VFs [02:59:55] [PASSED] 22 VFs [02:59:55] [PASSED] 23 VFs [02:59:55] [PASSED] 24 VFs [02:59:55] [PASSED] 25 VFs [02:59:55] [PASSED] 26 VFs [02:59:55] [PASSED] 27 VFs [02:59:55] [PASSED] 28 VFs [02:59:55] [PASSED] 29 VFs [02:59:55] [PASSED] 30 VFs [02:59:55] [PASSED] 31 VFs [02:59:55] [PASSED] 32 VFs [02:59:55] [PASSED] 33 VFs [02:59:55] [PASSED] 34 VFs [02:59:55] [PASSED] 35 VFs [02:59:55] [PASSED] 36 VFs [02:59:55] [PASSED] 37 VFs [02:59:55] [PASSED] 38 VFs [02:59:55] [PASSED] 39 VFs [02:59:55] [PASSED] 40 VFs [02:59:55] [PASSED] 41 VFs [02:59:55] [PASSED] 42 VFs [02:59:55] [PASSED] 43 VFs [02:59:55] [PASSED] 44 VFs [02:59:55] [PASSED] 45 VFs [02:59:55] [PASSED] 46 VFs [02:59:55] [PASSED] 47 VFs [02:59:55] [PASSED] 48 VFs [02:59:55] [PASSED] 49 VFs [02:59:55] [PASSED] 50 VFs [02:59:55] [PASSED] 51 VFs [02:59:55] [PASSED] 52 VFs [02:59:55] [PASSED] 53 VFs [02:59:55] [PASSED] 54 VFs [02:59:55] [PASSED] 55 VFs [02:59:55] [PASSED] 56 VFs [02:59:55] [PASSED] 57 VFs [02:59:55] [PASSED] 58 VFs [02:59:55] [PASSED] 59 VFs [02:59:55] [PASSED] 60 VFs [02:59:55] [PASSED] 61 VFs [02:59:55] [PASSED] 62 VFs [02:59:55] [PASSED] 63 VFs [02:59:55] ================= [PASSED] fair_doorbells ================== [02:59:55] ======================== fair_ggtt ======================== [02:59:55] [PASSED] 1 VF [02:59:55] [PASSED] 2 VFs [02:59:55] [PASSED] 3 VFs [02:59:55] [PASSED] 4 VFs [02:59:55] [PASSED] 5 VFs [02:59:55] [PASSED] 6 VFs [02:59:55] [PASSED] 7 VFs [02:59:55] [PASSED] 8 VFs [02:59:55] [PASSED] 9 VFs [02:59:55] [PASSED] 10 VFs [02:59:55] [PASSED] 11 VFs [02:59:55] [PASSED] 12 VFs [02:59:55] [PASSED] 13 VFs [02:59:55] [PASSED] 14 VFs [02:59:55] [PASSED] 15 VFs [02:59:55] [PASSED] 16 VFs [02:59:55] [PASSED] 17 VFs [02:59:55] [PASSED] 18 VFs [02:59:55] [PASSED] 19 VFs [02:59:55] [PASSED] 20 VFs [02:59:55] [PASSED] 21 VFs [02:59:55] [PASSED] 22 VFs [02:59:55] [PASSED] 23 VFs [02:59:55] [PASSED] 24 VFs [02:59:55] [PASSED] 25 VFs [02:59:55] [PASSED] 26 VFs [02:59:55] [PASSED] 27 VFs [02:59:55] [PASSED] 28 VFs [02:59:55] [PASSED] 29 VFs [02:59:55] [PASSED] 30 VFs [02:59:55] [PASSED] 31 VFs [02:59:55] [PASSED] 32 VFs [02:59:55] [PASSED] 33 VFs [02:59:55] [PASSED] 34 VFs [02:59:55] [PASSED] 35 VFs [02:59:55] [PASSED] 36 VFs [02:59:55] [PASSED] 37 VFs [02:59:55] [PASSED] 38 VFs [02:59:55] [PASSED] 39 VFs [02:59:55] [PASSED] 40 VFs [02:59:55] [PASSED] 41 VFs [02:59:55] [PASSED] 42 VFs [02:59:55] [PASSED] 43 VFs [02:59:55] [PASSED] 44 VFs [02:59:55] [PASSED] 45 VFs [02:59:55] [PASSED] 46 VFs [02:59:55] [PASSED] 47 VFs [02:59:55] [PASSED] 48 VFs [02:59:55] [PASSED] 49 VFs [02:59:55] [PASSED] 50 VFs [02:59:55] [PASSED] 51 VFs [02:59:55] [PASSED] 52 VFs [02:59:55] [PASSED] 53 VFs [02:59:55] [PASSED] 54 VFs [02:59:55] [PASSED] 55 VFs [02:59:55] [PASSED] 56 VFs [02:59:55] [PASSED] 57 VFs [02:59:55] [PASSED] 58 VFs [02:59:55] [PASSED] 59 VFs [02:59:55] [PASSED] 60 VFs [02:59:55] [PASSED] 61 VFs [02:59:55] [PASSED] 62 VFs [02:59:55] [PASSED] 63 VFs [02:59:55] ==================== [PASSED] fair_ggtt ==================== [02:59:55] ================== [PASSED] pf_gt_config =================== [02:59:55] ===================== lmtt (1 subtest) ===================== [02:59:55] ======================== test_ops ========================= [02:59:55] [PASSED] 2-level [02:59:55] [PASSED] multi-level [02:59:55] ==================== [PASSED] test_ops ===================== [02:59:55] ====================== [PASSED] lmtt ======================= [02:59:55] ================= pf_service (11 subtests) ================= [02:59:55] [PASSED] pf_negotiate_any [02:59:55] [PASSED] pf_negotiate_base_match [02:59:55] [PASSED] pf_negotiate_base_newer [02:59:55] [PASSED] pf_negotiate_base_next [02:59:55] [SKIPPED] pf_negotiate_base_older [02:59:55] [PASSED] pf_negotiate_base_prev [02:59:55] [PASSED] pf_negotiate_latest_match [02:59:55] [PASSED] pf_negotiate_latest_newer [02:59:55] [PASSED] pf_negotiate_latest_next [02:59:55] [SKIPPED] pf_negotiate_latest_older [02:59:55] [SKIPPED] pf_negotiate_latest_prev [02:59:55] =================== [PASSED] pf_service ==================== [02:59:55] ================= xe_guc_g2g (2 subtests) ================== [02:59:55] ============== xe_live_guc_g2g_kunit_default ============== [02:59:55] ========= [SKIPPED] xe_live_guc_g2g_kunit_default ========== [02:59:55] ============== xe_live_guc_g2g_kunit_allmem =============== [02:59:55] ========== [SKIPPED] xe_live_guc_g2g_kunit_allmem ========== [02:59:55] =================== [SKIPPED] xe_guc_g2g =================== [02:59:55] =================== xe_mocs (2 subtests) =================== [02:59:55] ================ xe_live_mocs_kernel_kunit ================ [02:59:55] =========== [SKIPPED] xe_live_mocs_kernel_kunit ============ [02:59:55] ================ xe_live_mocs_reset_kunit ================= [02:59:55] ============ [SKIPPED] xe_live_mocs_reset_kunit ============ [02:59:55] ==================== [SKIPPED] xe_mocs ===================== [02:59:55] ================= xe_migrate (2 subtests) ================== [02:59:55] ================= xe_migrate_sanity_kunit ================= [02:59:55] ============ [SKIPPED] xe_migrate_sanity_kunit ============= [02:59:55] ================== xe_validate_ccs_kunit ================== [02:59:55] ============= [SKIPPED] xe_validate_ccs_kunit ============== [02:59:55] =================== [SKIPPED] xe_migrate =================== [02:59:55] ================== xe_dma_buf (1 subtest) ================== [02:59:55] ==================== xe_dma_buf_kunit ===================== [02:59:55] ================ [SKIPPED] xe_dma_buf_kunit ================ [02:59:55] =================== [SKIPPED] xe_dma_buf =================== [02:59:55] ================= xe_bo_shrink (1 subtest) ================= [02:59:55] =================== xe_bo_shrink_kunit ==================== [02:59:55] =============== [SKIPPED] xe_bo_shrink_kunit =============== [02:59:55] ================== [SKIPPED] xe_bo_shrink ================== [02:59:55] ==================== xe_bo (2 subtests) ==================== [02:59:55] ================== xe_ccs_migrate_kunit =================== [02:59:55] ============== [SKIPPED] xe_ccs_migrate_kunit ============== [02:59:55] ==================== xe_bo_evict_kunit ==================== [02:59:55] =============== [SKIPPED] xe_bo_evict_kunit ================ [02:59:55] ===================== [SKIPPED] xe_bo ====================== [02:59:55] ==================== args (13 subtests) ==================== [02:59:55] [PASSED] count_args_test [02:59:55] [PASSED] call_args_example [02:59:55] [PASSED] call_args_test [02:59:55] [PASSED] drop_first_arg_example [02:59:55] [PASSED] drop_first_arg_test [02:59:55] [PASSED] first_arg_example [02:59:55] [PASSED] first_arg_test [02:59:55] [PASSED] last_arg_example [02:59:55] [PASSED] last_arg_test [02:59:55] [PASSED] pick_arg_example [02:59:55] [PASSED] if_args_example [02:59:55] [PASSED] if_args_test [02:59:55] [PASSED] sep_comma_example [02:59:55] ====================== [PASSED] args ======================= [02:59:55] =================== xe_pci (3 subtests) ==================== [02:59:55] ==================== check_graphics_ip ==================== [02:59:55] [PASSED] 12.00 Xe_LP [02:59:55] [PASSED] 12.10 Xe_LP+ [02:59:55] [PASSED] 12.55 Xe_HPG [02:59:55] [PASSED] 12.60 Xe_HPC [02:59:55] [PASSED] 12.70 Xe_LPG [02:59:55] [PASSED] 12.71 Xe_LPG [02:59:55] [PASSED] 12.74 Xe_LPG+ [02:59:55] [PASSED] 20.01 Xe2_HPG [02:59:55] [PASSED] 20.02 Xe2_HPG [02:59:55] [PASSED] 20.04 Xe2_LPG [02:59:55] [PASSED] 30.00 Xe3_LPG [02:59:55] [PASSED] 30.01 Xe3_LPG [02:59:55] [PASSED] 30.03 Xe3_LPG [02:59:55] [PASSED] 30.04 Xe3_LPG [02:59:55] [PASSED] 30.05 Xe3_LPG [02:59:55] [PASSED] 35.11 Xe3p_XPC [02:59:55] ================ [PASSED] check_graphics_ip ================ [02:59:55] ===================== check_media_ip ====================== [02:59:55] [PASSED] 12.00 Xe_M [02:59:55] [PASSED] 12.55 Xe_HPM [02:59:55] [PASSED] 13.00 Xe_LPM+ [02:59:55] [PASSED] 13.01 Xe2_HPM [02:59:55] [PASSED] 20.00 Xe2_LPM [02:59:55] [PASSED] 30.00 Xe3_LPM [02:59:55] [PASSED] 30.02 Xe3_LPM [02:59:55] [PASSED] 35.00 Xe3p_LPM [02:59:55] [PASSED] 35.03 Xe3p_HPM [02:59:55] ================= [PASSED] check_media_ip ================== [02:59:55] =================== check_platform_desc =================== [02:59:55] [PASSED] 0x9A60 (TIGERLAKE) [02:59:55] [PASSED] 0x9A68 (TIGERLAKE) [02:59:55] [PASSED] 0x9A70 (TIGERLAKE) [02:59:55] [PASSED] 0x9A40 (TIGERLAKE) [02:59:55] [PASSED] 0x9A49 (TIGERLAKE) [02:59:55] [PASSED] 0x9A59 (TIGERLAKE) [02:59:55] [PASSED] 0x9A78 (TIGERLAKE) [02:59:55] [PASSED] 0x9AC0 (TIGERLAKE) [02:59:55] [PASSED] 0x9AC9 (TIGERLAKE) [02:59:55] [PASSED] 0x9AD9 (TIGERLAKE) [02:59:55] [PASSED] 0x9AF8 (TIGERLAKE) [02:59:55] [PASSED] 0x4C80 (ROCKETLAKE) [02:59:55] [PASSED] 0x4C8A (ROCKETLAKE) [02:59:55] [PASSED] 0x4C8B (ROCKETLAKE) [02:59:55] [PASSED] 0x4C8C (ROCKETLAKE) [02:59:55] [PASSED] 0x4C90 (ROCKETLAKE) [02:59:55] [PASSED] 0x4C9A (ROCKETLAKE) [02:59:55] [PASSED] 0x4680 (ALDERLAKE_S) [02:59:55] [PASSED] 0x4682 (ALDERLAKE_S) [02:59:55] [PASSED] 0x4688 (ALDERLAKE_S) [02:59:55] [PASSED] 0x468A (ALDERLAKE_S) [02:59:55] [PASSED] 0x468B (ALDERLAKE_S) [02:59:55] [PASSED] 0x4690 (ALDERLAKE_S) [02:59:55] [PASSED] 0x4692 (ALDERLAKE_S) [02:59:55] [PASSED] 0x4693 (ALDERLAKE_S) [02:59:55] [PASSED] 0x46A0 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46A1 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46A2 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46A3 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46A6 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46A8 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46AA (ALDERLAKE_P) [02:59:55] [PASSED] 0x462A (ALDERLAKE_P) [02:59:55] [PASSED] 0x4626 (ALDERLAKE_P) [02:59:55] [PASSED] 0x4628 (ALDERLAKE_P) stty: 'standard input': Inappropriate ioctl for device [02:59:55] [PASSED] 0x46B0 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46B1 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46B2 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46B3 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46C0 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46C1 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46C2 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46C3 (ALDERLAKE_P) [02:59:55] [PASSED] 0x46D0 (ALDERLAKE_N) [02:59:55] [PASSED] 0x46D1 (ALDERLAKE_N) [02:59:55] [PASSED] 0x46D2 (ALDERLAKE_N) [02:59:55] [PASSED] 0x46D3 (ALDERLAKE_N) [02:59:55] [PASSED] 0x46D4 (ALDERLAKE_N) [02:59:55] [PASSED] 0xA721 (ALDERLAKE_P) [02:59:55] [PASSED] 0xA7A1 (ALDERLAKE_P) [02:59:55] [PASSED] 0xA7A9 (ALDERLAKE_P) [02:59:55] [PASSED] 0xA7AC (ALDERLAKE_P) [02:59:55] [PASSED] 0xA7AD (ALDERLAKE_P) [02:59:55] [PASSED] 0xA720 (ALDERLAKE_P) [02:59:55] [PASSED] 0xA7A0 (ALDERLAKE_P) [02:59:55] [PASSED] 0xA7A8 (ALDERLAKE_P) [02:59:55] [PASSED] 0xA7AA (ALDERLAKE_P) [02:59:55] [PASSED] 0xA7AB (ALDERLAKE_P) [02:59:55] [PASSED] 0xA780 (ALDERLAKE_S) [02:59:55] [PASSED] 0xA781 (ALDERLAKE_S) [02:59:55] [PASSED] 0xA782 (ALDERLAKE_S) [02:59:55] [PASSED] 0xA783 (ALDERLAKE_S) [02:59:55] [PASSED] 0xA788 (ALDERLAKE_S) [02:59:55] [PASSED] 0xA789 (ALDERLAKE_S) [02:59:55] [PASSED] 0xA78A (ALDERLAKE_S) [02:59:55] [PASSED] 0xA78B (ALDERLAKE_S) [02:59:55] [PASSED] 0x4905 (DG1) [02:59:55] [PASSED] 0x4906 (DG1) [02:59:55] [PASSED] 0x4907 (DG1) [02:59:55] [PASSED] 0x4908 (DG1) [02:59:55] [PASSED] 0x4909 (DG1) [02:59:55] [PASSED] 0x56C0 (DG2) [02:59:55] [PASSED] 0x56C2 (DG2) [02:59:55] [PASSED] 0x56C1 (DG2) [02:59:55] [PASSED] 0x7D51 (METEORLAKE) [02:59:55] [PASSED] 0x7DD1 (METEORLAKE) [02:59:55] [PASSED] 0x7D41 (METEORLAKE) [02:59:55] [PASSED] 0x7D67 (METEORLAKE) [02:59:55] [PASSED] 0xB640 (METEORLAKE) [02:59:55] [PASSED] 0x56A0 (DG2) [02:59:55] [PASSED] 0x56A1 (DG2) [02:59:55] [PASSED] 0x56A2 (DG2) [02:59:55] [PASSED] 0x56BE (DG2) [02:59:55] [PASSED] 0x56BF (DG2) [02:59:55] [PASSED] 0x5690 (DG2) [02:59:55] [PASSED] 0x5691 (DG2) [02:59:55] [PASSED] 0x5692 (DG2) [02:59:55] [PASSED] 0x56A5 (DG2) [02:59:55] [PASSED] 0x56A6 (DG2) [02:59:55] [PASSED] 0x56B0 (DG2) [02:59:55] [PASSED] 0x56B1 (DG2) [02:59:55] [PASSED] 0x56BA (DG2) [02:59:55] [PASSED] 0x56BB (DG2) [02:59:55] [PASSED] 0x56BC (DG2) [02:59:55] [PASSED] 0x56BD (DG2) [02:59:55] [PASSED] 0x5693 (DG2) [02:59:55] [PASSED] 0x5694 (DG2) [02:59:55] [PASSED] 0x5695 (DG2) [02:59:55] [PASSED] 0x56A3 (DG2) [02:59:55] [PASSED] 0x56A4 (DG2) [02:59:56] [PASSED] 0x56B2 (DG2) [02:59:56] [PASSED] 0x56B3 (DG2) [02:59:56] [PASSED] 0x5696 (DG2) [02:59:56] [PASSED] 0x5697 (DG2) [02:59:56] [PASSED] 0xB69 (PVC) [02:59:56] [PASSED] 0xB6E (PVC) [02:59:56] [PASSED] 0xBD4 (PVC) [02:59:56] [PASSED] 0xBD5 (PVC) [02:59:56] [PASSED] 0xBD6 (PVC) [02:59:56] [PASSED] 0xBD7 (PVC) [02:59:56] [PASSED] 0xBD8 (PVC) [02:59:56] [PASSED] 0xBD9 (PVC) [02:59:56] [PASSED] 0xBDA (PVC) [02:59:56] [PASSED] 0xBDB (PVC) [02:59:56] [PASSED] 0xBE0 (PVC) [02:59:56] [PASSED] 0xBE1 (PVC) [02:59:56] [PASSED] 0xBE5 (PVC) [02:59:56] [PASSED] 0x7D40 (METEORLAKE) [02:59:56] [PASSED] 0x7D45 (METEORLAKE) [02:59:56] [PASSED] 0x7D55 (METEORLAKE) [02:59:56] [PASSED] 0x7D60 (METEORLAKE) [02:59:56] [PASSED] 0x7DD5 (METEORLAKE) [02:59:56] [PASSED] 0x6420 (LUNARLAKE) [02:59:56] [PASSED] 0x64A0 (LUNARLAKE) [02:59:56] [PASSED] 0x64B0 (LUNARLAKE) [02:59:56] [PASSED] 0xE202 (BATTLEMAGE) [02:59:56] [PASSED] 0xE209 (BATTLEMAGE) [02:59:56] [PASSED] 0xE20B (BATTLEMAGE) [02:59:56] [PASSED] 0xE20C (BATTLEMAGE) [02:59:56] [PASSED] 0xE20D (BATTLEMAGE) [02:59:56] [PASSED] 0xE210 (BATTLEMAGE) [02:59:56] [PASSED] 0xE211 (BATTLEMAGE) [02:59:56] [PASSED] 0xE212 (BATTLEMAGE) [02:59:56] [PASSED] 0xE216 (BATTLEMAGE) [02:59:56] [PASSED] 0xE220 (BATTLEMAGE) [02:59:56] [PASSED] 0xE221 (BATTLEMAGE) [02:59:56] [PASSED] 0xE222 (BATTLEMAGE) [02:59:56] [PASSED] 0xE223 (BATTLEMAGE) [02:59:56] [PASSED] 0xB080 (PANTHERLAKE) [02:59:56] [PASSED] 0xB081 (PANTHERLAKE) [02:59:56] [PASSED] 0xB082 (PANTHERLAKE) [02:59:56] [PASSED] 0xB083 (PANTHERLAKE) [02:59:56] [PASSED] 0xB084 (PANTHERLAKE) [02:59:56] [PASSED] 0xB085 (PANTHERLAKE) [02:59:56] [PASSED] 0xB086 (PANTHERLAKE) [02:59:56] [PASSED] 0xB087 (PANTHERLAKE) [02:59:56] [PASSED] 0xB08F (PANTHERLAKE) [02:59:56] [PASSED] 0xB090 (PANTHERLAKE) [02:59:56] [PASSED] 0xB0A0 (PANTHERLAKE) [02:59:56] [PASSED] 0xB0B0 (PANTHERLAKE) [02:59:56] [PASSED] 0xFD80 (PANTHERLAKE) [02:59:56] [PASSED] 0xFD81 (PANTHERLAKE) [02:59:56] [PASSED] 0xD740 (NOVALAKE_S) [02:59:56] [PASSED] 0xD741 (NOVALAKE_S) [02:59:56] [PASSED] 0xD742 (NOVALAKE_S) [02:59:56] [PASSED] 0xD743 (NOVALAKE_S) [02:59:56] [PASSED] 0xD744 (NOVALAKE_S) [02:59:56] [PASSED] 0xD745 (NOVALAKE_S) [02:59:56] [PASSED] 0x674C (CRESCENTISLAND) [02:59:56] =============== [PASSED] check_platform_desc =============== [02:59:56] ===================== [PASSED] xe_pci ====================== [02:59:56] =================== xe_rtp (2 subtests) ==================== [02:59:56] =============== xe_rtp_process_to_sr_tests ================ [02:59:56] [PASSED] coalesce-same-reg [02:59:56] [PASSED] no-match-no-add [02:59:56] [PASSED] match-or [02:59:56] [PASSED] match-or-xfail [02:59:56] [PASSED] no-match-no-add-multiple-rules [02:59:56] [PASSED] two-regs-two-entries [02:59:56] [PASSED] clr-one-set-other [02:59:56] [PASSED] set-field [02:59:56] [PASSED] conflict-duplicate [02:59:56] [PASSED] conflict-not-disjoint [02:59:56] [PASSED] conflict-reg-type [02:59:56] =========== [PASSED] xe_rtp_process_to_sr_tests ============ [02:59:56] ================== xe_rtp_process_tests =================== [02:59:56] [PASSED] active1 [02:59:56] [PASSED] active2 [02:59:56] [PASSED] active-inactive [02:59:56] [PASSED] inactive-active [02:59:56] [PASSED] inactive-1st_or_active-inactive [02:59:56] [PASSED] inactive-2nd_or_active-inactive [02:59:56] [PASSED] inactive-last_or_active-inactive [02:59:56] [PASSED] inactive-no_or_active-inactive [02:59:56] ============== [PASSED] xe_rtp_process_tests =============== [02:59:56] ===================== [PASSED] xe_rtp ====================== [02:59:56] ==================== xe_wa (1 subtest) ===================== [02:59:56] ======================== xe_wa_gt ========================= [02:59:56] [PASSED] TIGERLAKE B0 [02:59:56] [PASSED] DG1 A0 [02:59:56] [PASSED] DG1 B0 [02:59:56] [PASSED] ALDERLAKE_S A0 [02:59:56] [PASSED] ALDERLAKE_S B0 [02:59:56] [PASSED] ALDERLAKE_S C0 [02:59:56] [PASSED] ALDERLAKE_S D0 [02:59:56] [PASSED] ALDERLAKE_P A0 [02:59:56] [PASSED] ALDERLAKE_P B0 [02:59:56] [PASSED] ALDERLAKE_P C0 [02:59:56] [PASSED] ALDERLAKE_S RPLS D0 [02:59:56] [PASSED] ALDERLAKE_P RPLU E0 [02:59:56] [PASSED] DG2 G10 C0 [02:59:56] [PASSED] DG2 G11 B1 [02:59:56] [PASSED] DG2 G12 A1 [02:59:56] [PASSED] METEORLAKE 12.70(Xe_LPG) A0 13.00(Xe_LPM+) A0 [02:59:56] [PASSED] METEORLAKE 12.71(Xe_LPG) A0 13.00(Xe_LPM+) A0 [02:59:56] [PASSED] METEORLAKE 12.74(Xe_LPG+) A0 13.00(Xe_LPM+) A0 [02:59:56] [PASSED] LUNARLAKE 20.04(Xe2_LPG) A0 20.00(Xe2_LPM) A0 [02:59:56] [PASSED] LUNARLAKE 20.04(Xe2_LPG) B0 20.00(Xe2_LPM) A0 [02:59:56] [PASSED] BATTLEMAGE 20.01(Xe2_HPG) A0 13.01(Xe2_HPM) A1 [02:59:56] [PASSED] PANTHERLAKE 30.00(Xe3_LPG) A0 30.00(Xe3_LPM) A0 [02:59:56] ==================== [PASSED] xe_wa_gt ===================== [02:59:56] ====================== [PASSED] xe_wa ====================== [02:59:56] ============================================================ [02:59:56] Testing complete. Ran 512 tests: passed: 494, skipped: 18 [02:59:56] Elapsed time: 36.217s total, 4.250s configuring, 31.498s building, 0.456s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/tests/.kunitconfig [02:59:56] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [02:59:57] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [03:00:23] Starting KUnit Kernel (1/1)... [03:00:23] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [03:00:23] ============ drm_test_pick_cmdline (2 subtests) ============ [03:00:23] [PASSED] drm_test_pick_cmdline_res_1920_1080_60 [03:00:23] =============== drm_test_pick_cmdline_named =============== [03:00:23] [PASSED] NTSC [03:00:23] [PASSED] NTSC-J [03:00:23] [PASSED] PAL [03:00:23] [PASSED] PAL-M [03:00:23] =========== [PASSED] drm_test_pick_cmdline_named =========== [03:00:23] ============== [PASSED] drm_test_pick_cmdline ============== [03:00:23] == drm_test_atomic_get_connector_for_encoder (1 subtest) === [03:00:23] [PASSED] drm_test_drm_atomic_get_connector_for_encoder [03:00:23] ==== [PASSED] drm_test_atomic_get_connector_for_encoder ==== [03:00:23] =========== drm_validate_clone_mode (2 subtests) =========== [03:00:23] ============== drm_test_check_in_clone_mode =============== [03:00:23] [PASSED] in_clone_mode [03:00:23] [PASSED] not_in_clone_mode [03:00:23] ========== [PASSED] drm_test_check_in_clone_mode =========== [03:00:23] =============== drm_test_check_valid_clones =============== [03:00:23] [PASSED] not_in_clone_mode [03:00:23] [PASSED] valid_clone [03:00:23] [PASSED] invalid_clone [03:00:23] =========== [PASSED] drm_test_check_valid_clones =========== [03:00:23] ============= [PASSED] drm_validate_clone_mode ============= [03:00:23] ============= drm_validate_modeset (1 subtest) ============= [03:00:23] [PASSED] drm_test_check_connector_changed_modeset [03:00:23] ============== [PASSED] drm_validate_modeset =============== [03:00:23] ====== drm_test_bridge_get_current_state (2 subtests) ====== [03:00:23] [PASSED] drm_test_drm_bridge_get_current_state_atomic [03:00:23] [PASSED] drm_test_drm_bridge_get_current_state_legacy [03:00:23] ======== [PASSED] drm_test_bridge_get_current_state ======== [03:00:23] ====== drm_test_bridge_helper_reset_crtc (3 subtests) ====== [03:00:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic [03:00:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_atomic_disabled [03:00:23] [PASSED] drm_test_drm_bridge_helper_reset_crtc_legacy [03:00:23] ======== [PASSED] drm_test_bridge_helper_reset_crtc ======== [03:00:23] ============== drm_bridge_alloc (2 subtests) =============== [03:00:23] [PASSED] drm_test_drm_bridge_alloc_basic [03:00:23] [PASSED] drm_test_drm_bridge_alloc_get_put [03:00:23] ================ [PASSED] drm_bridge_alloc ================= [03:00:23] ================== drm_buddy (8 subtests) ================== [03:00:23] [PASSED] drm_test_buddy_alloc_limit [03:00:23] [PASSED] drm_test_buddy_alloc_optimistic [03:00:23] [PASSED] drm_test_buddy_alloc_pessimistic [03:00:23] [PASSED] drm_test_buddy_alloc_pathological [03:00:23] [PASSED] drm_test_buddy_alloc_contiguous [03:00:23] [PASSED] drm_test_buddy_alloc_clear [03:00:23] [PASSED] drm_test_buddy_alloc_range_bias [03:00:23] [PASSED] drm_test_buddy_fragmentation_performance [03:00:23] ==================== [PASSED] drm_buddy ==================== [03:00:23] ============= drm_cmdline_parser (40 subtests) ============= [03:00:23] [PASSED] drm_test_cmdline_force_d_only [03:00:23] [PASSED] drm_test_cmdline_force_D_only_dvi [03:00:23] [PASSED] drm_test_cmdline_force_D_only_hdmi [03:00:23] [PASSED] drm_test_cmdline_force_D_only_not_digital [03:00:23] [PASSED] drm_test_cmdline_force_e_only [03:00:23] [PASSED] drm_test_cmdline_res [03:00:23] [PASSED] drm_test_cmdline_res_vesa [03:00:23] [PASSED] drm_test_cmdline_res_vesa_rblank [03:00:23] [PASSED] drm_test_cmdline_res_rblank [03:00:23] [PASSED] drm_test_cmdline_res_bpp [03:00:23] [PASSED] drm_test_cmdline_res_refresh [03:00:23] [PASSED] drm_test_cmdline_res_bpp_refresh [03:00:23] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced [03:00:23] [PASSED] drm_test_cmdline_res_bpp_refresh_margins [03:00:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_off [03:00:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on [03:00:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_analog [03:00:23] [PASSED] drm_test_cmdline_res_bpp_refresh_force_on_digital [03:00:23] [PASSED] drm_test_cmdline_res_bpp_refresh_interlaced_margins_force_on [03:00:23] [PASSED] drm_test_cmdline_res_margins_force_on [03:00:23] [PASSED] drm_test_cmdline_res_vesa_margins [03:00:23] [PASSED] drm_test_cmdline_name [03:00:23] [PASSED] drm_test_cmdline_name_bpp [03:00:23] [PASSED] drm_test_cmdline_name_option [03:00:23] [PASSED] drm_test_cmdline_name_bpp_option [03:00:23] [PASSED] drm_test_cmdline_rotate_0 [03:00:23] [PASSED] drm_test_cmdline_rotate_90 [03:00:23] [PASSED] drm_test_cmdline_rotate_180 [03:00:23] [PASSED] drm_test_cmdline_rotate_270 [03:00:23] [PASSED] drm_test_cmdline_hmirror [03:00:23] [PASSED] drm_test_cmdline_vmirror [03:00:23] [PASSED] drm_test_cmdline_margin_options [03:00:23] [PASSED] drm_test_cmdline_multiple_options [03:00:23] [PASSED] drm_test_cmdline_bpp_extra_and_option [03:00:23] [PASSED] drm_test_cmdline_extra_and_option [03:00:23] [PASSED] drm_test_cmdline_freestanding_options [03:00:23] [PASSED] drm_test_cmdline_freestanding_force_e_and_options [03:00:23] [PASSED] drm_test_cmdline_panel_orientation [03:00:23] ================ drm_test_cmdline_invalid ================= [03:00:23] [PASSED] margin_only [03:00:23] [PASSED] interlace_only [03:00:23] [PASSED] res_missing_x [03:00:23] [PASSED] res_missing_y [03:00:23] [PASSED] res_bad_y [03:00:23] [PASSED] res_missing_y_bpp [03:00:23] [PASSED] res_bad_bpp [03:00:23] [PASSED] res_bad_refresh [03:00:23] [PASSED] res_bpp_refresh_force_on_off [03:00:23] [PASSED] res_invalid_mode [03:00:23] [PASSED] res_bpp_wrong_place_mode [03:00:23] [PASSED] name_bpp_refresh [03:00:23] [PASSED] name_refresh [03:00:23] [PASSED] name_refresh_wrong_mode [03:00:23] [PASSED] name_refresh_invalid_mode [03:00:23] [PASSED] rotate_multiple [03:00:23] [PASSED] rotate_invalid_val [03:00:23] [PASSED] rotate_truncated [03:00:23] [PASSED] invalid_option [03:00:23] [PASSED] invalid_tv_option [03:00:23] [PASSED] truncated_tv_option [03:00:23] ============ [PASSED] drm_test_cmdline_invalid ============= [03:00:23] =============== drm_test_cmdline_tv_options =============== [03:00:23] [PASSED] NTSC [03:00:23] [PASSED] NTSC_443 [03:00:23] [PASSED] NTSC_J [03:00:23] [PASSED] PAL [03:00:23] [PASSED] PAL_M [03:00:23] [PASSED] PAL_N [03:00:23] [PASSED] SECAM [03:00:23] [PASSED] MONO_525 [03:00:23] [PASSED] MONO_625 [03:00:23] =========== [PASSED] drm_test_cmdline_tv_options =========== [03:00:23] =============== [PASSED] drm_cmdline_parser ================ [03:00:23] ========== drmm_connector_hdmi_init (20 subtests) ========== [03:00:23] [PASSED] drm_test_connector_hdmi_init_valid [03:00:23] [PASSED] drm_test_connector_hdmi_init_bpc_8 [03:00:23] [PASSED] drm_test_connector_hdmi_init_bpc_10 [03:00:23] [PASSED] drm_test_connector_hdmi_init_bpc_12 [03:00:23] [PASSED] drm_test_connector_hdmi_init_bpc_invalid [03:00:23] [PASSED] drm_test_connector_hdmi_init_bpc_null [03:00:23] [PASSED] drm_test_connector_hdmi_init_formats_empty [03:00:23] [PASSED] drm_test_connector_hdmi_init_formats_no_rgb [03:00:23] === drm_test_connector_hdmi_init_formats_yuv420_allowed === [03:00:23] [PASSED] supported_formats=0x9 yuv420_allowed=1 [03:00:23] [PASSED] supported_formats=0x9 yuv420_allowed=0 [03:00:23] [PASSED] supported_formats=0x3 yuv420_allowed=1 [03:00:23] [PASSED] supported_formats=0x3 yuv420_allowed=0 [03:00:23] === [PASSED] drm_test_connector_hdmi_init_formats_yuv420_allowed === [03:00:23] [PASSED] drm_test_connector_hdmi_init_null_ddc [03:00:23] [PASSED] drm_test_connector_hdmi_init_null_product [03:00:23] [PASSED] drm_test_connector_hdmi_init_null_vendor [03:00:23] [PASSED] drm_test_connector_hdmi_init_product_length_exact [03:00:23] [PASSED] drm_test_connector_hdmi_init_product_length_too_long [03:00:23] [PASSED] drm_test_connector_hdmi_init_product_valid [03:00:23] [PASSED] drm_test_connector_hdmi_init_vendor_length_exact [03:00:23] [PASSED] drm_test_connector_hdmi_init_vendor_length_too_long [03:00:23] [PASSED] drm_test_connector_hdmi_init_vendor_valid [03:00:23] ========= drm_test_connector_hdmi_init_type_valid ========= [03:00:23] [PASSED] HDMI-A [03:00:23] [PASSED] HDMI-B [03:00:23] ===== [PASSED] drm_test_connector_hdmi_init_type_valid ===== [03:00:23] ======== drm_test_connector_hdmi_init_type_invalid ======== [03:00:23] [PASSED] Unknown [03:00:23] [PASSED] VGA [03:00:23] [PASSED] DVI-I [03:00:23] [PASSED] DVI-D [03:00:23] [PASSED] DVI-A [03:00:23] [PASSED] Composite [03:00:23] [PASSED] SVIDEO [03:00:23] [PASSED] LVDS [03:00:23] [PASSED] Component [03:00:23] [PASSED] DIN [03:00:23] [PASSED] DP [03:00:23] [PASSED] TV [03:00:23] [PASSED] eDP [03:00:23] [PASSED] Virtual [03:00:23] [PASSED] DSI [03:00:23] [PASSED] DPI [03:00:23] [PASSED] Writeback [03:00:23] [PASSED] SPI [03:00:23] [PASSED] USB [03:00:23] ==== [PASSED] drm_test_connector_hdmi_init_type_invalid ==== [03:00:23] ============ [PASSED] drmm_connector_hdmi_init ============= [03:00:23] ============= drmm_connector_init (3 subtests) ============= [03:00:23] [PASSED] drm_test_drmm_connector_init [03:00:23] [PASSED] drm_test_drmm_connector_init_null_ddc [03:00:23] ========= drm_test_drmm_connector_init_type_valid ========= [03:00:23] [PASSED] Unknown [03:00:23] [PASSED] VGA [03:00:23] [PASSED] DVI-I [03:00:23] [PASSED] DVI-D [03:00:23] [PASSED] DVI-A [03:00:23] [PASSED] Composite [03:00:23] [PASSED] SVIDEO [03:00:23] [PASSED] LVDS [03:00:23] [PASSED] Component [03:00:23] [PASSED] DIN [03:00:23] [PASSED] DP [03:00:23] [PASSED] HDMI-A [03:00:23] [PASSED] HDMI-B [03:00:23] [PASSED] TV [03:00:23] [PASSED] eDP [03:00:23] [PASSED] Virtual [03:00:23] [PASSED] DSI [03:00:23] [PASSED] DPI [03:00:23] [PASSED] Writeback [03:00:23] [PASSED] SPI [03:00:23] [PASSED] USB [03:00:23] ===== [PASSED] drm_test_drmm_connector_init_type_valid ===== [03:00:23] =============== [PASSED] drmm_connector_init =============== [03:00:23] ========= drm_connector_dynamic_init (6 subtests) ========== [03:00:23] [PASSED] drm_test_drm_connector_dynamic_init [03:00:23] [PASSED] drm_test_drm_connector_dynamic_init_null_ddc [03:00:23] [PASSED] drm_test_drm_connector_dynamic_init_not_added [03:00:23] [PASSED] drm_test_drm_connector_dynamic_init_properties [03:00:23] ===== drm_test_drm_connector_dynamic_init_type_valid ====== [03:00:23] [PASSED] Unknown [03:00:23] [PASSED] VGA [03:00:23] [PASSED] DVI-I [03:00:23] [PASSED] DVI-D [03:00:23] [PASSED] DVI-A [03:00:23] [PASSED] Composite [03:00:23] [PASSED] SVIDEO [03:00:23] [PASSED] LVDS [03:00:23] [PASSED] Component [03:00:23] [PASSED] DIN [03:00:23] [PASSED] DP [03:00:23] [PASSED] HDMI-A [03:00:23] [PASSED] HDMI-B [03:00:23] [PASSED] TV [03:00:23] [PASSED] eDP [03:00:23] [PASSED] Virtual [03:00:23] [PASSED] DSI [03:00:23] [PASSED] DPI [03:00:23] [PASSED] Writeback [03:00:23] [PASSED] SPI [03:00:23] [PASSED] USB [03:00:23] = [PASSED] drm_test_drm_connector_dynamic_init_type_valid == [03:00:23] ======== drm_test_drm_connector_dynamic_init_name ========= [03:00:23] [PASSED] Unknown [03:00:23] [PASSED] VGA [03:00:23] [PASSED] DVI-I [03:00:23] [PASSED] DVI-D [03:00:23] [PASSED] DVI-A [03:00:23] [PASSED] Composite [03:00:23] [PASSED] SVIDEO [03:00:23] [PASSED] LVDS [03:00:23] [PASSED] Component [03:00:23] [PASSED] DIN [03:00:23] [PASSED] DP [03:00:23] [PASSED] HDMI-A [03:00:23] [PASSED] HDMI-B [03:00:23] [PASSED] TV [03:00:23] [PASSED] eDP [03:00:23] [PASSED] Virtual [03:00:23] [PASSED] DSI [03:00:23] [PASSED] DPI [03:00:23] [PASSED] Writeback [03:00:23] [PASSED] SPI [03:00:23] [PASSED] USB [03:00:23] ==== [PASSED] drm_test_drm_connector_dynamic_init_name ===== [03:00:23] =========== [PASSED] drm_connector_dynamic_init ============ [03:00:23] ==== drm_connector_dynamic_register_early (4 subtests) ===== [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_early_on_list [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_early_defer [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_early_no_init [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_early_no_mode_object [03:00:23] ====== [PASSED] drm_connector_dynamic_register_early ======= [03:00:23] ======= drm_connector_dynamic_register (7 subtests) ======== [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_on_list [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_no_defer [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_no_init [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_mode_object [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_sysfs [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_sysfs_name [03:00:23] [PASSED] drm_test_drm_connector_dynamic_register_debugfs [03:00:23] ========= [PASSED] drm_connector_dynamic_register ========== [03:00:23] = drm_connector_attach_broadcast_rgb_property (2 subtests) = [03:00:23] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property [03:00:23] [PASSED] drm_test_drm_connector_attach_broadcast_rgb_property_hdmi_connector [03:00:23] === [PASSED] drm_connector_attach_broadcast_rgb_property === [03:00:23] ========== drm_get_tv_mode_from_name (2 subtests) ========== [03:00:23] ========== drm_test_get_tv_mode_from_name_valid =========== [03:00:23] [PASSED] NTSC [03:00:23] [PASSED] NTSC-443 [03:00:23] [PASSED] NTSC-J [03:00:23] [PASSED] PAL [03:00:23] [PASSED] PAL-M [03:00:23] [PASSED] PAL-N [03:00:23] [PASSED] SECAM [03:00:23] [PASSED] Mono [03:00:23] ====== [PASSED] drm_test_get_tv_mode_from_name_valid ======= [03:00:23] [PASSED] drm_test_get_tv_mode_from_name_truncated [03:00:23] ============ [PASSED] drm_get_tv_mode_from_name ============ [03:00:23] = drm_test_connector_hdmi_compute_mode_clock (12 subtests) = [03:00:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb [03:00:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc [03:00:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1 [03:00:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc [03:00:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1 [03:00:23] [PASSED] drm_test_drm_hdmi_compute_mode_clock_rgb_double [03:00:23] = drm_test_connector_hdmi_compute_mode_clock_yuv420_valid = [03:00:23] [PASSED] VIC 96 [03:00:23] [PASSED] VIC 97 [03:00:23] [PASSED] VIC 101 [03:00:23] [PASSED] VIC 102 [03:00:23] [PASSED] VIC 106 [03:00:23] [PASSED] VIC 107 [03:00:23] === [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_valid === [03:00:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc [03:00:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc [03:00:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc [03:00:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc [03:00:23] [PASSED] drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc [03:00:23] === [PASSED] drm_test_connector_hdmi_compute_mode_clock ==== [03:00:23] == drm_hdmi_connector_get_broadcast_rgb_name (2 subtests) == [03:00:23] === drm_test_drm_hdmi_connector_get_broadcast_rgb_name ==== [03:00:23] [PASSED] Automatic [03:00:23] [PASSED] Full [03:00:23] [PASSED] Limited 16:235 [03:00:23] === [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name === [03:00:23] [PASSED] drm_test_drm_hdmi_connector_get_broadcast_rgb_name_invalid [03:00:23] ==== [PASSED] drm_hdmi_connector_get_broadcast_rgb_name ==== [03:00:23] == drm_hdmi_connector_get_output_format_name (2 subtests) == [03:00:23] === drm_test_drm_hdmi_connector_get_output_format_name ==== [03:00:23] [PASSED] RGB [03:00:23] [PASSED] YUV 4:2:0 [03:00:23] [PASSED] YUV 4:2:2 [03:00:23] [PASSED] YUV 4:4:4 [03:00:23] === [PASSED] drm_test_drm_hdmi_connector_get_output_format_name === [03:00:23] [PASSED] drm_test_drm_hdmi_connector_get_output_format_name_invalid [03:00:23] ==== [PASSED] drm_hdmi_connector_get_output_format_name ==== [03:00:23] ============= drm_damage_helper (21 subtests) ============== [03:00:23] [PASSED] drm_test_damage_iter_no_damage [03:00:23] [PASSED] drm_test_damage_iter_no_damage_fractional_src [03:00:23] [PASSED] drm_test_damage_iter_no_damage_src_moved [03:00:23] [PASSED] drm_test_damage_iter_no_damage_fractional_src_moved [03:00:23] [PASSED] drm_test_damage_iter_no_damage_not_visible [03:00:23] [PASSED] drm_test_damage_iter_no_damage_no_crtc [03:00:23] [PASSED] drm_test_damage_iter_no_damage_no_fb [03:00:23] [PASSED] drm_test_damage_iter_simple_damage [03:00:23] [PASSED] drm_test_damage_iter_single_damage [03:00:23] [PASSED] drm_test_damage_iter_single_damage_intersect_src [03:00:23] [PASSED] drm_test_damage_iter_single_damage_outside_src [03:00:23] [PASSED] drm_test_damage_iter_single_damage_fractional_src [03:00:23] [PASSED] drm_test_damage_iter_single_damage_intersect_fractional_src [03:00:23] [PASSED] drm_test_damage_iter_single_damage_outside_fractional_src [03:00:23] [PASSED] drm_test_damage_iter_single_damage_src_moved [03:00:23] [PASSED] drm_test_damage_iter_single_damage_fractional_src_moved [03:00:23] [PASSED] drm_test_damage_iter_damage [03:00:23] [PASSED] drm_test_damage_iter_damage_one_intersect [03:00:23] [PASSED] drm_test_damage_iter_damage_one_outside [03:00:23] [PASSED] drm_test_damage_iter_damage_src_moved [03:00:23] [PASSED] drm_test_damage_iter_damage_not_visible [03:00:23] ================ [PASSED] drm_damage_helper ================ [03:00:23] ============== drm_dp_mst_helper (3 subtests) ============== [03:00:23] ============== drm_test_dp_mst_calc_pbn_mode ============== [03:00:23] [PASSED] Clock 154000 BPP 30 DSC disabled [03:00:23] [PASSED] Clock 234000 BPP 30 DSC disabled [03:00:23] [PASSED] Clock 297000 BPP 24 DSC disabled [03:00:23] [PASSED] Clock 332880 BPP 24 DSC enabled [03:00:23] [PASSED] Clock 324540 BPP 24 DSC enabled [03:00:23] ========== [PASSED] drm_test_dp_mst_calc_pbn_mode ========== [03:00:23] ============== drm_test_dp_mst_calc_pbn_div =============== [03:00:23] [PASSED] Link rate 2000000 lane count 4 [03:00:23] [PASSED] Link rate 2000000 lane count 2 [03:00:23] [PASSED] Link rate 2000000 lane count 1 [03:00:23] [PASSED] Link rate 1350000 lane count 4 [03:00:23] [PASSED] Link rate 1350000 lane count 2 [03:00:23] [PASSED] Link rate 1350000 lane count 1 [03:00:23] [PASSED] Link rate 1000000 lane count 4 [03:00:23] [PASSED] Link rate 1000000 lane count 2 [03:00:23] [PASSED] Link rate 1000000 lane count 1 [03:00:23] [PASSED] Link rate 810000 lane count 4 [03:00:23] [PASSED] Link rate 810000 lane count 2 [03:00:23] [PASSED] Link rate 810000 lane count 1 [03:00:23] [PASSED] Link rate 540000 lane count 4 [03:00:23] [PASSED] Link rate 540000 lane count 2 [03:00:23] [PASSED] Link rate 540000 lane count 1 [03:00:23] [PASSED] Link rate 270000 lane count 4 [03:00:23] [PASSED] Link rate 270000 lane count 2 [03:00:23] [PASSED] Link rate 270000 lane count 1 [03:00:23] [PASSED] Link rate 162000 lane count 4 [03:00:23] [PASSED] Link rate 162000 lane count 2 [03:00:23] [PASSED] Link rate 162000 lane count 1 [03:00:23] ========== [PASSED] drm_test_dp_mst_calc_pbn_div =========== [03:00:23] ========= drm_test_dp_mst_sideband_msg_req_decode ========= [03:00:23] [PASSED] DP_ENUM_PATH_RESOURCES with port number [03:00:23] [PASSED] DP_POWER_UP_PHY with port number [03:00:23] [PASSED] DP_POWER_DOWN_PHY with port number [03:00:23] [PASSED] DP_ALLOCATE_PAYLOAD with SDP stream sinks [03:00:23] [PASSED] DP_ALLOCATE_PAYLOAD with port number [03:00:23] [PASSED] DP_ALLOCATE_PAYLOAD with VCPI [03:00:23] [PASSED] DP_ALLOCATE_PAYLOAD with PBN [03:00:23] [PASSED] DP_QUERY_PAYLOAD with port number [03:00:23] [PASSED] DP_QUERY_PAYLOAD with VCPI [03:00:23] [PASSED] DP_REMOTE_DPCD_READ with port number [03:00:23] [PASSED] DP_REMOTE_DPCD_READ with DPCD address [03:00:23] [PASSED] DP_REMOTE_DPCD_READ with max number of bytes [03:00:23] [PASSED] DP_REMOTE_DPCD_WRITE with port number [03:00:23] [PASSED] DP_REMOTE_DPCD_WRITE with DPCD address [03:00:23] [PASSED] DP_REMOTE_DPCD_WRITE with data array [03:00:23] [PASSED] DP_REMOTE_I2C_READ with port number [03:00:23] [PASSED] DP_REMOTE_I2C_READ with I2C device ID [03:00:23] [PASSED] DP_REMOTE_I2C_READ with transactions array [03:00:23] [PASSED] DP_REMOTE_I2C_WRITE with port number [03:00:23] [PASSED] DP_REMOTE_I2C_WRITE with I2C device ID [03:00:23] [PASSED] DP_REMOTE_I2C_WRITE with data array [03:00:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream ID [03:00:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with client ID [03:00:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream event [03:00:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with valid stream event [03:00:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with stream behavior [03:00:23] [PASSED] DP_QUERY_STREAM_ENC_STATUS with a valid stream behavior [03:00:23] ===== [PASSED] drm_test_dp_mst_sideband_msg_req_decode ===== [03:00:23] ================ [PASSED] drm_dp_mst_helper ================ [03:00:23] ================== drm_exec (7 subtests) =================== [03:00:23] [PASSED] sanitycheck [03:00:23] [PASSED] test_lock [03:00:23] [PASSED] test_lock_unlock [03:00:23] [PASSED] test_duplicates [03:00:23] [PASSED] test_prepare [03:00:23] [PASSED] test_prepare_array [03:00:23] [PASSED] test_multiple_loops [03:00:23] ==================== [PASSED] drm_exec ===================== [03:00:23] =========== drm_format_helper_test (17 subtests) =========== [03:00:23] ============== drm_test_fb_xrgb8888_to_gray8 ============== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ========== [PASSED] drm_test_fb_xrgb8888_to_gray8 ========== [03:00:23] ============= drm_test_fb_xrgb8888_to_rgb332 ============== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb332 ========== [03:00:23] ============= drm_test_fb_xrgb8888_to_rgb565 ============== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb565 ========== [03:00:23] ============ drm_test_fb_xrgb8888_to_xrgb1555 ============= [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ======== [PASSED] drm_test_fb_xrgb8888_to_xrgb1555 ========= [03:00:23] ============ drm_test_fb_xrgb8888_to_argb1555 ============= [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ======== [PASSED] drm_test_fb_xrgb8888_to_argb1555 ========= [03:00:23] ============ drm_test_fb_xrgb8888_to_rgba5551 ============= [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ======== [PASSED] drm_test_fb_xrgb8888_to_rgba5551 ========= [03:00:23] ============= drm_test_fb_xrgb8888_to_rgb888 ============== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ========= [PASSED] drm_test_fb_xrgb8888_to_rgb888 ========== [03:00:23] ============= drm_test_fb_xrgb8888_to_bgr888 ============== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ========= [PASSED] drm_test_fb_xrgb8888_to_bgr888 ========== [03:00:23] ============ drm_test_fb_xrgb8888_to_argb8888 ============= [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ======== [PASSED] drm_test_fb_xrgb8888_to_argb8888 ========= [03:00:23] =========== drm_test_fb_xrgb8888_to_xrgb2101010 =========== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ======= [PASSED] drm_test_fb_xrgb8888_to_xrgb2101010 ======= [03:00:23] =========== drm_test_fb_xrgb8888_to_argb2101010 =========== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ======= [PASSED] drm_test_fb_xrgb8888_to_argb2101010 ======= [03:00:23] ============== drm_test_fb_xrgb8888_to_mono =============== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ========== [PASSED] drm_test_fb_xrgb8888_to_mono =========== [03:00:23] ==================== drm_test_fb_swab ===================== [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ================ [PASSED] drm_test_fb_swab ================= [03:00:23] ============ drm_test_fb_xrgb8888_to_xbgr8888 ============= [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ======== [PASSED] drm_test_fb_xrgb8888_to_xbgr8888 ========= [03:00:23] ============ drm_test_fb_xrgb8888_to_abgr8888 ============= [03:00:23] [PASSED] single_pixel_source_buffer [03:00:23] [PASSED] single_pixel_clip_rectangle [03:00:23] [PASSED] well_known_colors [03:00:23] [PASSED] destination_pitch [03:00:23] ======== [PASSED] drm_test_fb_xrgb8888_to_abgr8888 ========= [03:00:23] ================= drm_test_fb_clip_offset ================= [03:00:23] [PASSED] pass through [03:00:23] [PASSED] horizontal offset [03:00:23] [PASSED] vertical offset [03:00:23] [PASSED] horizontal and vertical offset [03:00:23] [PASSED] horizontal offset (custom pitch) [03:00:23] [PASSED] vertical offset (custom pitch) [03:00:23] [PASSED] horizontal and vertical offset (custom pitch) [03:00:23] ============= [PASSED] drm_test_fb_clip_offset ============= [03:00:23] =================== drm_test_fb_memcpy ==================== [03:00:23] [PASSED] single_pixel_source_buffer: XR24 little-endian (0x34325258) [03:00:23] [PASSED] single_pixel_source_buffer: XRA8 little-endian (0x38415258) [03:00:23] [PASSED] single_pixel_source_buffer: YU24 little-endian (0x34325559) [03:00:23] [PASSED] single_pixel_clip_rectangle: XB24 little-endian (0x34324258) [03:00:23] [PASSED] single_pixel_clip_rectangle: XRA8 little-endian (0x38415258) [03:00:23] [PASSED] single_pixel_clip_rectangle: YU24 little-endian (0x34325559) [03:00:23] [PASSED] well_known_colors: XB24 little-endian (0x34324258) [03:00:23] [PASSED] well_known_colors: XRA8 little-endian (0x38415258) [03:00:23] [PASSED] well_known_colors: YU24 little-endian (0x34325559) [03:00:23] [PASSED] destination_pitch: XB24 little-endian (0x34324258) [03:00:23] [PASSED] destination_pitch: XRA8 little-endian (0x38415258) [03:00:23] [PASSED] destination_pitch: YU24 little-endian (0x34325559) [03:00:23] =============== [PASSED] drm_test_fb_memcpy ================ [03:00:23] ============= [PASSED] drm_format_helper_test ============== [03:00:23] ================= drm_format (18 subtests) ================= [03:00:23] [PASSED] drm_test_format_block_width_invalid [03:00:23] [PASSED] drm_test_format_block_width_one_plane [03:00:23] [PASSED] drm_test_format_block_width_two_plane [03:00:23] [PASSED] drm_test_format_block_width_three_plane [03:00:23] [PASSED] drm_test_format_block_width_tiled [03:00:23] [PASSED] drm_test_format_block_height_invalid [03:00:23] [PASSED] drm_test_format_block_height_one_plane [03:00:23] [PASSED] drm_test_format_block_height_two_plane [03:00:23] [PASSED] drm_test_format_block_height_three_plane [03:00:23] [PASSED] drm_test_format_block_height_tiled [03:00:23] [PASSED] drm_test_format_min_pitch_invalid [03:00:23] [PASSED] drm_test_format_min_pitch_one_plane_8bpp [03:00:23] [PASSED] drm_test_format_min_pitch_one_plane_16bpp [03:00:23] [PASSED] drm_test_format_min_pitch_one_plane_24bpp [03:00:23] [PASSED] drm_test_format_min_pitch_one_plane_32bpp [03:00:23] [PASSED] drm_test_format_min_pitch_two_plane [03:00:23] [PASSED] drm_test_format_min_pitch_three_plane_8bpp [03:00:23] [PASSED] drm_test_format_min_pitch_tiled [03:00:23] =================== [PASSED] drm_format ==================== [03:00:23] ============== drm_framebuffer (10 subtests) =============== [03:00:23] ========== drm_test_framebuffer_check_src_coords ========== [03:00:23] [PASSED] Success: source fits into fb [03:00:23] [PASSED] Fail: overflowing fb with x-axis coordinate [03:00:23] [PASSED] Fail: overflowing fb with y-axis coordinate [03:00:23] [PASSED] Fail: overflowing fb with source width [03:00:23] [PASSED] Fail: overflowing fb with source height [03:00:23] ====== [PASSED] drm_test_framebuffer_check_src_coords ====== [03:00:23] [PASSED] drm_test_framebuffer_cleanup [03:00:23] =============== drm_test_framebuffer_create =============== [03:00:23] [PASSED] ABGR8888 normal sizes [03:00:23] [PASSED] ABGR8888 max sizes [03:00:23] [PASSED] ABGR8888 pitch greater than min required [03:00:23] [PASSED] ABGR8888 pitch less than min required [03:00:23] [PASSED] ABGR8888 Invalid width [03:00:23] [PASSED] ABGR8888 Invalid buffer handle [03:00:23] [PASSED] No pixel format [03:00:23] [PASSED] ABGR8888 Width 0 [03:00:23] [PASSED] ABGR8888 Height 0 [03:00:23] [PASSED] ABGR8888 Out of bound height * pitch combination [03:00:23] [PASSED] ABGR8888 Large buffer offset [03:00:23] [PASSED] ABGR8888 Buffer offset for inexistent plane [03:00:23] [PASSED] ABGR8888 Invalid flag [03:00:23] [PASSED] ABGR8888 Set DRM_MODE_FB_MODIFIERS without modifiers [03:00:23] [PASSED] ABGR8888 Valid buffer modifier [03:00:23] [PASSED] ABGR8888 Invalid buffer modifier(DRM_FORMAT_MOD_SAMSUNG_64_32_TILE) [03:00:23] [PASSED] ABGR8888 Extra pitches without DRM_MODE_FB_MODIFIERS [03:00:23] [PASSED] ABGR8888 Extra pitches with DRM_MODE_FB_MODIFIERS [03:00:23] [PASSED] NV12 Normal sizes [03:00:23] [PASSED] NV12 Max sizes [03:00:23] [PASSED] NV12 Invalid pitch [03:00:23] [PASSED] NV12 Invalid modifier/missing DRM_MODE_FB_MODIFIERS flag [03:00:23] [PASSED] NV12 different modifier per-plane [03:00:23] [PASSED] NV12 with DRM_FORMAT_MOD_SAMSUNG_64_32_TILE [03:00:23] [PASSED] NV12 Valid modifiers without DRM_MODE_FB_MODIFIERS [03:00:23] [PASSED] NV12 Modifier for inexistent plane [03:00:23] [PASSED] NV12 Handle for inexistent plane [03:00:23] [PASSED] NV12 Handle for inexistent plane without DRM_MODE_FB_MODIFIERS [03:00:23] [PASSED] YVU420 DRM_MODE_FB_MODIFIERS set without modifier [03:00:23] [PASSED] YVU420 Normal sizes [03:00:23] [PASSED] YVU420 Max sizes [03:00:23] [PASSED] YVU420 Invalid pitch [03:00:23] [PASSED] YVU420 Different pitches [03:00:23] [PASSED] YVU420 Different buffer offsets/pitches [03:00:23] [PASSED] YVU420 Modifier set just for plane 0, without DRM_MODE_FB_MODIFIERS [03:00:23] [PASSED] YVU420 Modifier set just for planes 0, 1, without DRM_MODE_FB_MODIFIERS [03:00:23] [PASSED] YVU420 Modifier set just for plane 0, 1, with DRM_MODE_FB_MODIFIERS [03:00:23] [PASSED] YVU420 Valid modifier [03:00:23] [PASSED] YVU420 Different modifiers per plane [03:00:23] [PASSED] YVU420 Modifier for inexistent plane [03:00:23] [PASSED] YUV420_10BIT Invalid modifier(DRM_FORMAT_MOD_LINEAR) [03:00:23] [PASSED] X0L2 Normal sizes [03:00:23] [PASSED] X0L2 Max sizes [03:00:23] [PASSED] X0L2 Invalid pitch [03:00:23] [PASSED] X0L2 Pitch greater than minimum required [03:00:23] [PASSED] X0L2 Handle for inexistent plane [03:00:23] [PASSED] X0L2 Offset for inexistent plane, without DRM_MODE_FB_MODIFIERS set [03:00:23] [PASSED] X0L2 Modifier without DRM_MODE_FB_MODIFIERS set [03:00:23] [PASSED] X0L2 Valid modifier [03:00:23] [PASSED] X0L2 Modifier for inexistent plane [03:00:23] =========== [PASSED] drm_test_framebuffer_create =========== [03:00:23] [PASSED] drm_test_framebuffer_free [03:00:23] [PASSED] drm_test_framebuffer_init [03:00:23] [PASSED] drm_test_framebuffer_init_bad_format [03:00:23] [PASSED] drm_test_framebuffer_init_dev_mismatch [03:00:23] [PASSED] drm_test_framebuffer_lookup [03:00:23] [PASSED] drm_test_framebuffer_lookup_inexistent [03:00:23] [PASSED] drm_test_framebuffer_modifiers_not_supported [03:00:23] ================= [PASSED] drm_framebuffer ================= [03:00:23] ================ drm_gem_shmem (8 subtests) ================ [03:00:23] [PASSED] drm_gem_shmem_test_obj_create [03:00:23] [PASSED] drm_gem_shmem_test_obj_create_private [03:00:23] [PASSED] drm_gem_shmem_test_pin_pages [03:00:23] [PASSED] drm_gem_shmem_test_vmap [03:00:23] [PASSED] drm_gem_shmem_test_get_sg_table [03:00:23] [PASSED] drm_gem_shmem_test_get_pages_sgt [03:00:23] [PASSED] drm_gem_shmem_test_madvise [03:00:23] [PASSED] drm_gem_shmem_test_purge [03:00:23] ================== [PASSED] drm_gem_shmem ================== [03:00:23] === drm_atomic_helper_connector_hdmi_check (27 subtests) === [03:00:23] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode [03:00:23] [PASSED] drm_test_check_broadcast_rgb_auto_cea_mode_vic_1 [03:00:23] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode [03:00:23] [PASSED] drm_test_check_broadcast_rgb_full_cea_mode_vic_1 [03:00:23] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode [03:00:23] [PASSED] drm_test_check_broadcast_rgb_limited_cea_mode_vic_1 [03:00:23] ====== drm_test_check_broadcast_rgb_cea_mode_yuv420 ======= [03:00:23] [PASSED] Automatic [03:00:23] [PASSED] Full [03:00:23] [PASSED] Limited 16:235 [03:00:23] == [PASSED] drm_test_check_broadcast_rgb_cea_mode_yuv420 === [03:00:23] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_changed [03:00:23] [PASSED] drm_test_check_broadcast_rgb_crtc_mode_not_changed [03:00:23] [PASSED] drm_test_check_disable_connector [03:00:23] [PASSED] drm_test_check_hdmi_funcs_reject_rate [03:00:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_rgb [03:00:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_yuv420 [03:00:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv422 [03:00:23] [PASSED] drm_test_check_max_tmds_rate_bpc_fallback_ignore_yuv420 [03:00:23] [PASSED] drm_test_check_driver_unsupported_fallback_yuv420 [03:00:23] [PASSED] drm_test_check_output_bpc_crtc_mode_changed [03:00:23] [PASSED] drm_test_check_output_bpc_crtc_mode_not_changed [03:00:23] [PASSED] drm_test_check_output_bpc_dvi [03:00:23] [PASSED] drm_test_check_output_bpc_format_vic_1 [03:00:23] [PASSED] drm_test_check_output_bpc_format_display_8bpc_only [03:00:23] [PASSED] drm_test_check_output_bpc_format_display_rgb_only [03:00:23] [PASSED] drm_test_check_output_bpc_format_driver_8bpc_only [03:00:23] [PASSED] drm_test_check_output_bpc_format_driver_rgb_only [03:00:23] [PASSED] drm_test_check_tmds_char_rate_rgb_8bpc [03:00:23] [PASSED] drm_test_check_tmds_char_rate_rgb_10bpc [03:00:23] [PASSED] drm_test_check_tmds_char_rate_rgb_12bpc [03:00:23] ===== [PASSED] drm_atomic_helper_connector_hdmi_check ====== [03:00:23] === drm_atomic_helper_connector_hdmi_reset (6 subtests) ==== [03:00:23] [PASSED] drm_test_check_broadcast_rgb_value [03:00:23] [PASSED] drm_test_check_bpc_8_value [03:00:23] [PASSED] drm_test_check_bpc_10_value [03:00:23] [PASSED] drm_test_check_bpc_12_value [03:00:23] [PASSED] drm_test_check_format_value [03:00:23] [PASSED] drm_test_check_tmds_char_value [03:00:23] ===== [PASSED] drm_atomic_helper_connector_hdmi_reset ====== [03:00:23] = drm_atomic_helper_connector_hdmi_mode_valid (4 subtests) = [03:00:23] [PASSED] drm_test_check_mode_valid [03:00:23] [PASSED] drm_test_check_mode_valid_reject [03:00:23] [PASSED] drm_test_check_mode_valid_reject_rate [03:00:23] [PASSED] drm_test_check_mode_valid_reject_max_clock [03:00:23] === [PASSED] drm_atomic_helper_connector_hdmi_mode_valid === [03:00:23] ================= drm_managed (2 subtests) ================= [03:00:23] [PASSED] drm_test_managed_release_action [03:00:23] [PASSED] drm_test_managed_run_action [03:00:23] =================== [PASSED] drm_managed =================== [03:00:23] =================== drm_mm (6 subtests) ==================== [03:00:23] [PASSED] drm_test_mm_init [03:00:23] [PASSED] drm_test_mm_debug [03:00:23] [PASSED] drm_test_mm_align32 [03:00:23] [PASSED] drm_test_mm_align64 [03:00:23] [PASSED] drm_test_mm_lowest [03:00:23] [PASSED] drm_test_mm_highest [03:00:23] ===================== [PASSED] drm_mm ====================== [03:00:23] ============= drm_modes_analog_tv (5 subtests) ============= [03:00:23] [PASSED] drm_test_modes_analog_tv_mono_576i [03:00:23] [PASSED] drm_test_modes_analog_tv_ntsc_480i [03:00:23] [PASSED] drm_test_modes_analog_tv_ntsc_480i_inlined [03:00:23] [PASSED] drm_test_modes_analog_tv_pal_576i [03:00:23] [PASSED] drm_test_modes_analog_tv_pal_576i_inlined [03:00:23] =============== [PASSED] drm_modes_analog_tv =============== [03:00:23] ============== drm_plane_helper (2 subtests) =============== [03:00:23] =============== drm_test_check_plane_state ================ [03:00:23] [PASSED] clipping_simple [03:00:23] [PASSED] clipping_rotate_reflect [03:00:23] [PASSED] positioning_simple [03:00:23] [PASSED] upscaling [03:00:23] [PASSED] downscaling [03:00:23] [PASSED] rounding1 [03:00:23] [PASSED] rounding2 [03:00:23] [PASSED] rounding3 [03:00:23] [PASSED] rounding4 [03:00:23] =========== [PASSED] drm_test_check_plane_state ============ [03:00:23] =========== drm_test_check_invalid_plane_state ============ [03:00:23] [PASSED] positioning_invalid [03:00:23] [PASSED] upscaling_invalid [03:00:23] [PASSED] downscaling_invalid [03:00:23] ======= [PASSED] drm_test_check_invalid_plane_state ======== [03:00:23] ================ [PASSED] drm_plane_helper ================= [03:00:23] ====== drm_connector_helper_tv_get_modes (1 subtest) ======= [03:00:23] ====== drm_test_connector_helper_tv_get_modes_check ======= [03:00:23] [PASSED] None [03:00:23] [PASSED] PAL [03:00:23] [PASSED] NTSC [03:00:23] [PASSED] Both, NTSC Default [03:00:23] [PASSED] Both, PAL Default [03:00:23] [PASSED] Both, NTSC Default, with PAL on command-line [03:00:23] [PASSED] Both, PAL Default, with NTSC on command-line [03:00:23] == [PASSED] drm_test_connector_helper_tv_get_modes_check === [03:00:23] ======== [PASSED] drm_connector_helper_tv_get_modes ======== [03:00:23] ================== drm_rect (9 subtests) =================== [03:00:23] [PASSED] drm_test_rect_clip_scaled_div_by_zero [03:00:23] [PASSED] drm_test_rect_clip_scaled_not_clipped [03:00:23] [PASSED] drm_test_rect_clip_scaled_clipped [03:00:23] [PASSED] drm_test_rect_clip_scaled_signed_vs_unsigned [03:00:23] ================= drm_test_rect_intersect ================= [03:00:23] [PASSED] top-left x bottom-right: 2x2+1+1 x 2x2+0+0 [03:00:23] [PASSED] top-right x bottom-left: 2x2+0+0 x 2x2+1-1 [03:00:23] [PASSED] bottom-left x top-right: 2x2+1-1 x 2x2+0+0 [03:00:23] [PASSED] bottom-right x top-left: 2x2+0+0 x 2x2+1+1 [03:00:23] [PASSED] right x left: 2x1+0+0 x 3x1+1+0 [03:00:23] [PASSED] left x right: 3x1+1+0 x 2x1+0+0 [03:00:23] [PASSED] up x bottom: 1x2+0+0 x 1x3+0-1 [03:00:23] [PASSED] bottom x up: 1x3+0-1 x 1x2+0+0 [03:00:23] [PASSED] touching corner: 1x1+0+0 x 2x2+1+1 [03:00:23] [PASSED] touching side: 1x1+0+0 x 1x1+1+0 [03:00:23] [PASSED] equal rects: 2x2+0+0 x 2x2+0+0 [03:00:23] [PASSED] inside another: 2x2+0+0 x 1x1+1+1 [03:00:23] [PASSED] far away: 1x1+0+0 x 1x1+3+6 [03:00:23] [PASSED] points intersecting: 0x0+5+10 x 0x0+5+10 [03:00:23] [PASSED] points not intersecting: 0x0+0+0 x 0x0+5+10 [03:00:23] ============= [PASSED] drm_test_rect_intersect ============= [03:00:23] ================ drm_test_rect_calc_hscale ================ [03:00:23] [PASSED] normal use [03:00:23] [PASSED] out of max range [03:00:23] [PASSED] out of min range [03:00:23] [PASSED] zero dst [03:00:23] [PASSED] negative src [03:00:23] [PASSED] negative dst [03:00:23] ============ [PASSED] drm_test_rect_calc_hscale ============ [03:00:23] ================ drm_test_rect_calc_vscale ================ [03:00:23] [PASSED] normal use stty: 'standard input': Inappropriate ioctl for device [03:00:23] [PASSED] out of max range [03:00:23] [PASSED] out of min range [03:00:23] [PASSED] zero dst [03:00:23] [PASSED] negative src [03:00:23] [PASSED] negative dst [03:00:23] ============ [PASSED] drm_test_rect_calc_vscale ============ [03:00:23] ================== drm_test_rect_rotate =================== [03:00:23] [PASSED] reflect-x [03:00:23] [PASSED] reflect-y [03:00:23] [PASSED] rotate-0 [03:00:23] [PASSED] rotate-90 [03:00:23] [PASSED] rotate-180 [03:00:23] [PASSED] rotate-270 [03:00:23] ============== [PASSED] drm_test_rect_rotate =============== [03:00:23] ================ drm_test_rect_rotate_inv ================= [03:00:23] [PASSED] reflect-x [03:00:23] [PASSED] reflect-y [03:00:23] [PASSED] rotate-0 [03:00:23] [PASSED] rotate-90 [03:00:23] [PASSED] rotate-180 [03:00:23] [PASSED] rotate-270 [03:00:23] ============ [PASSED] drm_test_rect_rotate_inv ============= [03:00:23] ==================== [PASSED] drm_rect ===================== [03:00:23] ============ drm_sysfb_modeset_test (1 subtest) ============ [03:00:23] ============ drm_test_sysfb_build_fourcc_list ============= [03:00:23] [PASSED] no native formats [03:00:23] [PASSED] XRGB8888 as native format [03:00:23] [PASSED] remove duplicates [03:00:23] [PASSED] convert alpha formats [03:00:23] [PASSED] random formats [03:00:23] ======== [PASSED] drm_test_sysfb_build_fourcc_list ========= [03:00:23] ============= [PASSED] drm_sysfb_modeset_test ============== [03:00:23] ================== drm_fixp (2 subtests) =================== [03:00:23] [PASSED] drm_test_int2fixp [03:00:23] [PASSED] drm_test_sm2fixp [03:00:23] ==================== [PASSED] drm_fixp ===================== [03:00:23] ============================================================ [03:00:23] Testing complete. Ran 624 tests: passed: 624 [03:00:23] Elapsed time: 27.453s total, 1.639s configuring, 25.341s building, 0.424s running
+ /kernel/tools/testing/kunit/kunit.py run --kunitconfig /kernel/drivers/gpu/drm/ttm/tests/.kunitconfig [03:00:23] Configuring KUnit Kernel ...
Regenerating .config ...
Populating config with:
$ make ARCH=um O=.kunit olddefconfig [03:00:25] Building KUnit Kernel ... Populating config with: $ make ARCH=um O=.kunit olddefconfig Building with: $ make all compile_commands.json scripts_gdb ARCH=um O=.kunit --jobs=48 [03:00:34] Starting KUnit Kernel (1/1)... [03:00:34] ============================================================ Running tests with: $ .kunit/linux kunit.enable=1 mem=1G console=tty kunit_shutdown=halt [03:00:34] ================= ttm_device (5 subtests) ================== [03:00:34] [PASSED] ttm_device_init_basic [03:00:34] [PASSED] ttm_device_init_multiple [03:00:34] [PASSED] ttm_device_fini_basic [03:00:34] [PASSED] ttm_device_init_no_vma_man [03:00:34] ================== ttm_device_init_pools ================== [03:00:34] [PASSED] No DMA allocations, no DMA32 required [03:00:34] [PASSED] DMA allocations, DMA32 required [03:00:34] [PASSED] No DMA allocations, DMA32 required [03:00:34] [PASSED] DMA allocations, no DMA32 required [03:00:34] ============== [PASSED] ttm_device_init_pools ============== [03:00:34] =================== [PASSED] ttm_device ==================== [03:00:34] ================== ttm_pool (8 subtests) =================== [03:00:34] ================== ttm_pool_alloc_basic =================== [03:00:34] [PASSED] One page [03:00:34] [PASSED] More than one page [03:00:34] [PASSED] Above the allocation limit [03:00:34] [PASSED] One page, with coherent DMA mappings enabled [03:00:34] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [03:00:34] ============== [PASSED] ttm_pool_alloc_basic =============== [03:00:34] ============== ttm_pool_alloc_basic_dma_addr ============== [03:00:34] [PASSED] One page [03:00:34] [PASSED] More than one page [03:00:34] [PASSED] Above the allocation limit [03:00:34] [PASSED] One page, with coherent DMA mappings enabled [03:00:34] [PASSED] Above the allocation limit, with coherent DMA mappings enabled [03:00:34] ========== [PASSED] ttm_pool_alloc_basic_dma_addr ========== [03:00:34] [PASSED] ttm_pool_alloc_order_caching_match [03:00:34] [PASSED] ttm_pool_alloc_caching_mismatch [03:00:34] [PASSED] ttm_pool_alloc_order_mismatch [03:00:34] [PASSED] ttm_pool_free_dma_alloc [03:00:34] [PASSED] ttm_pool_free_no_dma_alloc [03:00:34] [PASSED] ttm_pool_fini_basic [03:00:34] ==================== [PASSED] ttm_pool ===================== [03:00:34] ================ ttm_resource (8 subtests) ================= [03:00:34] ================= ttm_resource_init_basic ================= [03:00:34] [PASSED] Init resource in TTM_PL_SYSTEM [03:00:34] [PASSED] Init resource in TTM_PL_VRAM [03:00:34] [PASSED] Init resource in a private placement [03:00:34] [PASSED] Init resource in TTM_PL_SYSTEM, set placement flags [03:00:34] ============= [PASSED] ttm_resource_init_basic ============= [03:00:34] [PASSED] ttm_resource_init_pinned [03:00:34] [PASSED] ttm_resource_fini_basic [03:00:34] [PASSED] ttm_resource_manager_init_basic [03:00:34] [PASSED] ttm_resource_manager_usage_basic [03:00:34] [PASSED] ttm_resource_manager_set_used_basic [03:00:34] [PASSED] ttm_sys_man_alloc_basic [03:00:34] [PASSED] ttm_sys_man_free_basic [03:00:34] ================== [PASSED] ttm_resource =================== [03:00:34] =================== ttm_tt (15 subtests) =================== [03:00:34] ==================== ttm_tt_init_basic ==================== [03:00:34] [PASSED] Page-aligned size [03:00:34] [PASSED] Extra pages requested [03:00:34] ================ [PASSED] ttm_tt_init_basic ================ [03:00:34] [PASSED] ttm_tt_init_misaligned [03:00:34] [PASSED] ttm_tt_fini_basic [03:00:34] [PASSED] ttm_tt_fini_sg [03:00:34] [PASSED] ttm_tt_fini_shmem [03:00:34] [PASSED] ttm_tt_create_basic [03:00:34] [PASSED] ttm_tt_create_invalid_bo_type [03:00:34] [PASSED] ttm_tt_create_ttm_exists [03:00:34] [PASSED] ttm_tt_create_failed [03:00:34] [PASSED] ttm_tt_destroy_basic [03:00:34] [PASSED] ttm_tt_populate_null_ttm [03:00:34] [PASSED] ttm_tt_populate_populated_ttm [03:00:34] [PASSED] ttm_tt_unpopulate_basic [03:00:34] [PASSED] ttm_tt_unpopulate_empty_ttm [03:00:34] [PASSED] ttm_tt_swapin_basic [03:00:34] ===================== [PASSED] ttm_tt ====================== [03:00:34] =================== ttm_bo (14 subtests) =================== [03:00:34] =========== ttm_bo_reserve_optimistic_no_ticket =========== [03:00:34] [PASSED] Cannot be interrupted and sleeps [03:00:34] [PASSED] Cannot be interrupted, locks straight away [03:00:34] [PASSED] Can be interrupted, sleeps [03:00:34] ======= [PASSED] ttm_bo_reserve_optimistic_no_ticket ======= [03:00:34] [PASSED] ttm_bo_reserve_locked_no_sleep [03:00:34] [PASSED] ttm_bo_reserve_no_wait_ticket [03:00:34] [PASSED] ttm_bo_reserve_double_resv [03:00:34] [PASSED] ttm_bo_reserve_interrupted [03:00:34] [PASSED] ttm_bo_reserve_deadlock [03:00:34] [PASSED] ttm_bo_unreserve_basic [03:00:34] [PASSED] ttm_bo_unreserve_pinned [03:00:34] [PASSED] ttm_bo_unreserve_bulk [03:00:34] [PASSED] ttm_bo_fini_basic [03:00:34] [PASSED] ttm_bo_fini_shared_resv [03:00:34] [PASSED] ttm_bo_pin_basic [03:00:34] [PASSED] ttm_bo_pin_unpin_resource [03:00:34] [PASSED] ttm_bo_multiple_pin_one_unpin [03:00:34] ===================== [PASSED] ttm_bo ====================== [03:00:34] ============== ttm_bo_validate (21 subtests) =============== [03:00:34] ============== ttm_bo_init_reserved_sys_man =============== [03:00:34] [PASSED] Buffer object for userspace [03:00:34] [PASSED] Kernel buffer object [03:00:34] [PASSED] Shared buffer object [03:00:34] ========== [PASSED] ttm_bo_init_reserved_sys_man =========== [03:00:34] ============== ttm_bo_init_reserved_mock_man ============== [03:00:34] [PASSED] Buffer object for userspace [03:00:34] [PASSED] Kernel buffer object [03:00:34] [PASSED] Shared buffer object [03:00:34] ========== [PASSED] ttm_bo_init_reserved_mock_man ========== [03:00:34] [PASSED] ttm_bo_init_reserved_resv [03:00:34] ================== ttm_bo_validate_basic ================== [03:00:34] [PASSED] Buffer object for userspace [03:00:34] [PASSED] Kernel buffer object [03:00:34] [PASSED] Shared buffer object [03:00:34] ============== [PASSED] ttm_bo_validate_basic ============== [03:00:34] [PASSED] ttm_bo_validate_invalid_placement [03:00:34] ============= ttm_bo_validate_same_placement ============== [03:00:34] [PASSED] System manager [03:00:34] [PASSED] VRAM manager [03:00:34] ========= [PASSED] ttm_bo_validate_same_placement ========== [03:00:34] [PASSED] ttm_bo_validate_failed_alloc [03:00:34] [PASSED] ttm_bo_validate_pinned [03:00:34] [PASSED] ttm_bo_validate_busy_placement [03:00:34] ================ ttm_bo_validate_multihop ================= [03:00:34] [PASSED] Buffer object for userspace [03:00:34] [PASSED] Kernel buffer object [03:00:34] [PASSED] Shared buffer object [03:00:34] ============ [PASSED] ttm_bo_validate_multihop ============= [03:00:34] ========== ttm_bo_validate_no_placement_signaled ========== [03:00:34] [PASSED] Buffer object in system domain, no page vector [03:00:34] [PASSED] Buffer object in system domain with an existing page vector [03:00:34] ====== [PASSED] ttm_bo_validate_no_placement_signaled ====== [03:00:34] ======== ttm_bo_validate_no_placement_not_signaled ======== [03:00:34] [PASSED] Buffer object for userspace [03:00:34] [PASSED] Kernel buffer object [03:00:34] [PASSED] Shared buffer object [03:00:34] ==== [PASSED] ttm_bo_validate_no_placement_not_signaled ==== [03:00:34] [PASSED] ttm_bo_validate_move_fence_signaled [03:00:35] ========= ttm_bo_validate_move_fence_not_signaled ========= [03:00:35] [PASSED] Waits for GPU [03:00:35] [PASSED] Tries to lock straight away [03:00:35] ===== [PASSED] ttm_bo_validate_move_fence_not_signaled ===== [03:00:35] [PASSED] ttm_bo_validate_happy_evict [03:00:35] [PASSED] ttm_bo_validate_all_pinned_evict [03:00:35] [PASSED] ttm_bo_validate_allowed_only_evict [03:00:35] [PASSED] ttm_bo_validate_deleted_evict [03:00:35] [PASSED] ttm_bo_validate_busy_domain_evict [03:00:35] [PASSED] ttm_bo_validate_evict_gutting [03:00:35] [PASSED] ttm_bo_validate_recrusive_evict stty: 'standard input': Inappropriate ioctl for device [03:00:35] ================= [PASSED] ttm_bo_validate ================= [03:00:35] ============================================================ [03:00:35] Testing complete. Ran 101 tests: passed: 101 [03:00:35] Elapsed time: 11.333s total, 1.656s configuring, 9.461s building, 0.180s running
+ cleanup
++ stat -c %u:%g /kernel
+ chown -R 1003:1003 /kernel
Patchwork
CI✓ Xe.CI.BAT: success for Context based TLB invalidations (rev4)
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Context based TLB invalidations (rev4)
URL : https://patchwork.freedesktop.org/series/156874/
State : success
== Summary ==
CI Bug Log - changes from xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5_BAT -> xe-pw-156874v4_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Changes
-------
No changes found
Build changes
-------------
* Linux: xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5 -> xe-pw-156874v4
IGT_8698: a631adf809d1cea93174adecc7bfbac121c7d315 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5: 7907558010710b0829258fc6a7bbcbb8783b8aa5
xe-pw-156874v4: 156874v4
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/index.html
Patchwork
CI✓ Xe.CI.Full: success for Context based TLB invalidations (rev4)
In reply to Matthew Brost== Series Details ==
== Series Details ==
Series: Context based TLB invalidations (rev4)
URL : https://patchwork.freedesktop.org/series/156874/
State : success
== Summary ==
CI Bug Log - changes from xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5_FULL -> xe-pw-156874v4_FULL
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (2 -> 2)
------------------------------
No changes in participating hosts
Known issues
------------
Here are the changes found in xe-pw-156874v4_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][1] ([Intel XE#2327]) +1 other test skip
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@[email protected]
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-bmg: NOTRUN -> [SKIP][2] ([Intel XE#1124]) +4 other tests skip
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@[email protected]
* igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow:
- shard-bmg: NOTRUN -> [SKIP][3] ([Intel XE#607])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-2/igt@[email protected]
* igt@kms_bw@connected-linear-tiling-3-displays-3840x2160p:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2314] / [Intel XE#2894])
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@[email protected]
* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-rc-ccs-cc:
- shard-bmg: NOTRUN -> [SKIP][5] ([Intel XE#2887]) +6 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-2/igt@[email protected]
* igt@kms_ccs@crc-primary-suspend-4-tiled-lnl-ccs@pipe-d-hdmi-a-3:
- shard-bmg: NOTRUN -> [SKIP][6] ([Intel XE#2652] / [Intel XE#787]) +8 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@kms_ccs@[email protected]
* igt@kms_chamelium_color@ctm-negative:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#2325])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- shard-bmg: NOTRUN -> [SKIP][8] ([Intel XE#2252]) +8 other tests skip
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/igt@[email protected]
* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-bmg: NOTRUN -> [SKIP][9] ([Intel XE#2321])
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@kms_cursor_crc@cursor-onscreen-32x32:
- shard-bmg: NOTRUN -> [SKIP][10] ([Intel XE#2320]) +1 other test skip
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-bmg: [PASS][11] -> [DMESG-WARN][12] ([Intel XE#5354])
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-1/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-3/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-bmg: [PASS][13] -> [FAIL][14] ([Intel XE#4633])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-10/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-8/igt@[email protected]
* igt@kms_dirtyfb@psr-dirtyfb-ioctl:
- shard-bmg: NOTRUN -> [SKIP][15] ([Intel XE#1508])
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@kms_dsc@dsc-fractional-bpp-with-bpc:
- shard-bmg: NOTRUN -> [SKIP][16] ([Intel XE#2244])
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode:
- shard-bmg: NOTRUN -> [SKIP][17] ([Intel XE#2293]) +3 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-32bpp-yftileccs-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-bmg: NOTRUN -> [SKIP][18] ([Intel XE#2293] / [Intel XE#2380]) +3 other tests skip
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render:
- shard-bmg: NOTRUN -> [SKIP][19] ([Intel XE#4141]) +8 other tests skip
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcdrrs-rgb565-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#2311]) +14 other tests skip
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][21] ([Intel XE#2313]) +15 other tests skip
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_plane_multiple@2x-tiling-yf:
- shard-bmg: NOTRUN -> [SKIP][22] ([Intel XE#5021])
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@[email protected]
* igt@kms_pm_dc@dc3co-vpb-simulation:
- shard-bmg: NOTRUN -> [SKIP][23] ([Intel XE#2391])
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-2/igt@[email protected]
* igt@kms_pm_dc@dc6-psr:
- shard-bmg: NOTRUN -> [SKIP][24] ([Intel XE#2392])
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@kms_pm_rpm@modeset-lpsp-stress:
- shard-bmg: NOTRUN -> [SKIP][25] ([Intel XE#1439] / [Intel XE#3141] / [Intel XE#836]) +1 other test skip
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@[email protected]
* igt@kms_psr2_sf@pr-primary-plane-update-sf-dmg-area:
- shard-bmg: NOTRUN -> [SKIP][26] ([Intel XE#1406] / [Intel XE#1489]) +3 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@kms_psr@psr-suspend:
- shard-bmg: NOTRUN -> [SKIP][27] ([Intel XE#1406] / [Intel XE#2234] / [Intel XE#2850]) +5 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/igt@[email protected]
* igt@kms_rotation_crc@multiplane-rotation:
- shard-lnl: [PASS][28] -> [FAIL][29] ([Intel XE#1874])
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-lnl-7/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-lnl-2/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-270:
- shard-bmg: NOTRUN -> [SKIP][30] ([Intel XE#3414] / [Intel XE#3904])
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- shard-bmg: NOTRUN -> [SKIP][31] ([Intel XE#1435])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@[email protected]
* igt@kms_sharpness_filter@filter-suspend:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#6503]) +1 other test skip
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@kms_vrr@flipline:
- shard-bmg: NOTRUN -> [SKIP][33] ([Intel XE#1499])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@testdisplay:
- shard-bmg: [PASS][34] -> [ABORT][35] ([Intel XE#6740] / [Intel XE#6976])
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-10/[email protected]
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/[email protected]
* igt@xe_eudebug@basic-read-event:
- shard-bmg: NOTRUN -> [SKIP][36] ([Intel XE#4837]) +4 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/igt@[email protected]
* igt@xe_eudebug_online@breakpoint-many-sessions-tiles:
- shard-bmg: NOTRUN -> [SKIP][37] ([Intel XE#4837] / [Intel XE#6665]) +2 other tests skip
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue:
- shard-bmg: NOTRUN -> [SKIP][38] ([Intel XE#2322]) +4 other tests skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue.html
* igt@xe_exec_multi_queue@few-execs-preempt-mode-close-fd-smem:
- shard-bmg: NOTRUN -> [SKIP][39] ([Intel XE#6874]) +14 other tests skip
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-1/igt@[email protected]
* igt@xe_exec_system_allocator@many-64k-mmap-huge-nomemset:
- shard-bmg: NOTRUN -> [SKIP][40] ([Intel XE#5007])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-7/igt@[email protected]
* igt@xe_exec_system_allocator@many-large-mmap-new-huge-nomemset:
- shard-bmg: NOTRUN -> [SKIP][41] ([Intel XE#4943]) +8 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma:
- shard-lnl: [PASS][42] -> [FAIL][43] ([Intel XE#5625])
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-lnl-5/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-lnl-1/igt@xe_exec_system_allocator@pat-index-madvise-pat-idx-uc-single-vma.html
* igt@xe_mmap@small-bar:
- shard-bmg: NOTRUN -> [SKIP][44] ([Intel XE#586])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@xe_multigpu_svm@mgpu-latency-basic:
- shard-bmg: NOTRUN -> [SKIP][45] ([Intel XE#6964]) +1 other test skip
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@xe_query@multigpu-query-pxp-status:
- shard-bmg: NOTRUN -> [SKIP][46] ([Intel XE#944]) +1 other test skip
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
#### Possible fixes ####
* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-bmg: [INCOMPLETE][47] ([Intel XE#6819]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-3/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-b-dp-2:
- shard-bmg: [INCOMPLETE][49] -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-3/igt@kms_atomic_transition@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@kms_atomic_transition@[email protected]
* igt@kms_dp_link_training@non-uhbr-sst:
- shard-bmg: [DMESG-WARN][51] ([Intel XE#5254]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-6/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-8/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-bmg: [INCOMPLETE][53] ([Intel XE#2049] / [Intel XE#2597]) -> [PASS][54] +1 other test pass
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-6/igt@[email protected]
* igt@xe_exec_system_allocator@many-stride-malloc-prefetch:
- shard-bmg: [WARN][55] ([Intel XE#5786]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-2/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-2/igt@[email protected]
#### Warnings ####
* igt@kms_tiled_display@basic-test-pattern-with-chamelium:
- shard-bmg: [SKIP][57] ([Intel XE#2509]) -> ([SKIP][58], [SKIP][59]) ([Intel XE#2426] / [Intel XE#2509])
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5/shard-bmg-6/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-10/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/shard-bmg-5/igt@[email protected]
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1435]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1435
[Intel XE#1439]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1439
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499
[Intel XE#1508]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1508
[Intel XE#1874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1874
[Intel XE#2049]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2049
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2244]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2244
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2293]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2293
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2314
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2321
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2325]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2325
[Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
[Intel XE#2380]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2380
[Intel XE#2391]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2391
[Intel XE#2392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2392
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509
[Intel XE#2597]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2597
[Intel XE#2652]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2652
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2894]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2894
[Intel XE#3141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3141
[Intel XE#3414]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3414
[Intel XE#3904]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3904
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#4633]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4633
[Intel XE#4837]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4837
[Intel XE#4943]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4943
[Intel XE#5007]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5007
[Intel XE#5021]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5021
[Intel XE#5254]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5254
[Intel XE#5354]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5354
[Intel XE#5625]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5625
[Intel XE#5786]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5786
[Intel XE#586]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/586
[Intel XE#607]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/607
[Intel XE#6503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6503
[Intel XE#6665]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6665
[Intel XE#6740]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6740
[Intel XE#6819]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6819
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#6964]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6964
[Intel XE#6976]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6976
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#836]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/836
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
Build changes
-------------
* Linux: xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5 -> xe-pw-156874v4
IGT_8698: a631adf809d1cea93174adecc7bfbac121c7d315 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-4373-7907558010710b0829258fc6a7bbcbb8783b8aa5: 7907558010710b0829258fc6a7bbcbb8783b8aa5
xe-pw-156874v4: 156874v4
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/xe-pw-156874v4/index.html
Ok at least today, this definitely is going to need to be included with [1]. Without that, I'm seeing DMAR faults and various other issues. But with [1], I haven't seen any issues yet around the registration/deregistration, so I think the ref count model here is sound (as discussed inline of course as well).
So:
The only concern I have at this point is around the ring invalidations. Maybe we can discuss more in that review, but I'm a little hessitant to put a full R-B on this series unless we also include that other one or fixes that you had suggested (which needs more debug still).
Thanks,
Stuart
[1]: https://patchwork.freedesktop.org/series/160057/
Quoted 37 lines · Matthew Brost
Add support for context based TLB invalidations.
Matt
Matthew Brost (12):
drm/xe: Addnormalize_invalidation_range
drm/xe: Make usm.asid_to_vm allocation useGFP_NOWAITdrm/xe: Addhas_ctx_tlb_invalto device info
drm/xe: Addxe_device_asid_to_vmhelper
drm/xe: Add vm to exec queues association
drm/xe: Taint TLB invalidation seqno lock withGFP_KERNELdrm/xe: Renamesend_tlb_inval_ppgtttosend_tlb_inval_asid_ppgttdrm/xe: Addsend_tlb_inval_ppgtthelper
drm/xe: Addxe_tlb_inval_idlehelper
drm/xe: Add exec queue active vfunc
drm/xe: Add context-based invalidation to GuC TLB invalidation backend
drm/xe: Enable context TLB invalidations for CIdrivers/gpu/drm/xe/xe_device.c | 25 +++ drivers/gpu/drm/xe/xe_device.h | 11 +- drivers/gpu/drm/xe/xe_device_types.h | 9 + drivers/gpu/drm/xe/xe_exec_queue.c | 7 +-
drivers/gpu/drm/xe/xe_exec_queue_types.h| 5 + drivers/gpu/drm/xe/xe_execlist.c | 7 + drivers/gpu/drm/xe/xe_guc_submit.c | 6 + drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 238 ++++++++++++++++++--- --
drivers/gpu/drm/xe/xe_pci.c | 2 +drivers/gpu/drm/xe/xe_pci_types.h | 1 + drivers/gpu/drm/xe/xe_tlb_inval.c | 33 ++++ drivers/gpu/drm/xe/xe_tlb_inval.h | 2 + drivers/gpu/drm/xe/xe_vm.c | 64 +++++- drivers/gpu/drm/xe/xe_vm.h | 3 + drivers/gpu/drm/xe/xe_vm_types.h | 16 ++ 15 files changed, 375 insertions(+), 54 deletions(-)
Matthew Brost
maintainerQuoted 8 lines · Stuart
Ok at least today, this definitely is going to need to be included with [1]. Without that, I'm seeing DMAR faults and various other issues. But with [1], I haven't seen any issues yet around the registration/deregistration, so I think the ref count model here is sound (as discussed inline of course as well).
So:
Tested-by Stuart Summers <[email protected]>
Thanks.
Quoted 2 lines
The only concern I have at this point is around the ring invalidations.
I have one bug to fix around multi-q too.
Quoted 4 lines
Maybe we can discuss more in that review, but I'm a little hessitant to put a full R-B on this series unless we also include that other one or fixes that you had suggested (which needs more debug still).
I'm not sure ring invalidations is strickly related. I agree would should reach on conclusion on what needs to be done there though.
I'm fairly behind at the moment. I think for ring invalidations it is unfortunately going probably be at least week before I have bandwidth to think about those :(.
Matt
Quoted 44 lines
Thanks,
Stuart[1]: https://patchwork.freedesktop.org/series/160057/
Quoted 37 lines · Matthew Brost
Add support for context based TLB invalidations.
Matt
Matthew Brost (12):
drm/xe: Addnormalize_invalidation_range
drm/xe: Make usm.asid_to_vm allocation useGFP_NOWAITdrm/xe: Addhas_ctx_tlb_invalto device info
drm/xe: Addxe_device_asid_to_vmhelper
drm/xe: Add vm to exec queues association
drm/xe: Taint TLB invalidation seqno lock withGFP_KERNELdrm/xe: Renamesend_tlb_inval_ppgtttosend_tlb_inval_asid_ppgttdrm/xe: Addsend_tlb_inval_ppgtthelper
drm/xe: Addxe_tlb_inval_idlehelper
drm/xe: Add exec queue active vfunc
drm/xe: Add context-based invalidation to GuC TLB invalidation backend
drm/xe: Enable context TLB invalidations for CIdrivers/gpu/drm/xe/xe_device.c | 25 +++ drivers/gpu/drm/xe/xe_device.h | 11 +- drivers/gpu/drm/xe/xe_device_types.h | 9 + drivers/gpu/drm/xe/xe_exec_queue.c | 7 +-
drivers/gpu/drm/xe/xe_exec_queue_types.h| 5 + drivers/gpu/drm/xe/xe_execlist.c | 7 + drivers/gpu/drm/xe/xe_guc_submit.c | 6 + drivers/gpu/drm/xe/xe_guc_tlb_inval.c | 238 ++++++++++++++++++--- --
drivers/gpu/drm/xe/xe_pci.c | 2 +drivers/gpu/drm/xe/xe_pci_types.h | 1 + drivers/gpu/drm/xe/xe_tlb_inval.c | 33 ++++ drivers/gpu/drm/xe/xe_tlb_inval.h | 2 + drivers/gpu/drm/xe/xe_vm.c | 64 +++++- drivers/gpu/drm/xe/xe_vm.h | 3 + drivers/gpu/drm/xe/xe_vm_types.h | 16 ++ 15 files changed, 375 insertions(+), 54 deletions(-)