tests/functional: Enforce sha256 as hashsum algorithm for all tests
PATCH 1/1 tests/functional: Enforce sha256 as hashsum algorithm for all tests
From: Thomas Huth <[email protected]>
The functional testing framework currently supports both, sha256 and sha512 as hashsums for the assets. However, all but one test currently only use sha256, which should also be sufficient according to the current security standards. Having two algorithms around already caused some confusion (e.g. the clean_functional_cache.py script only supports sha256 right now), so standardize now on enforcing sha256 before more tests use a mix of the two algorithms.
--- tests/functional/ppc64/test_fadump.py | 4 +--- tests/functional/qemu_test/asset.py | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-)
tests/functional/ppc64/test_fadump.py +1 -3
@@ -32,9 +32,7 @@ class QEMUFadump(LinuxKernelTest): ASSET_VMLINUZ_KERNEL = Asset( ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/' 'releases/39/Everything/ppc64le/os/ppc/ppc64/vmlinuz'), - ('81e5541d243b50c8f9568906c6918dda22239744d637bb9a7b22d23c3d661226' - '8d5302beb2ca5c06f93bdbc9736c414ef5120756c8bf496ff488ad07d116d67f') - ) + '6d77658130a7de1dd014ae14d7983c27f8ba1a61fa02e8d9064afdb8519e7e96') ASSET_FEDORA_INITRD = Asset( ('https://archives.fedoraproject.org/pub/archive/fedora-secondary/'
tests/functional/qemu_test/asset.py +1 -3
@@ -57,10 +57,8 @@ def _check(self, cache_file): return True if len(self.hash) == 64: hl = hashlib.sha256() - elif len(self.hash) == 128: - hl = hashlib.sha512() else: - raise AssetError(self, "unknown hash type") + raise AssetError(self, "unsupported hash type") # Calculate the hash of the file: with open(cache_file, 'rb') as file:
Signature · 1 line
2.52.0
Quoted 10 lines · Thomas Huth
From: Thomas Huth <[email protected]>
The functional testing framework currently supports both, sha256 and sha512 as hashsums for the assets. However, all but one test currently only use sha256, which should also be sufficient according to the current security standards. Having two algorithms around already caused some confusion (e.g. the
clean_functional_cache.pyscript only supports sha256 right now), so standardize now on enforcing sha256 before more tests use a mix of the two algorithms.
Quoted 5 lines
Signed-off-by Thomas Huth <[email protected]>--- tests/functional/ppc64/test_fadump.py | 4 +--- tests/functional/qemu_test/asset.py | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-)
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 10 lines · Thomas Huth
From: Thomas Huth<[email protected]>
The functional testing framework currently supports both, sha256 and sha512 as hashsums for the assets. However, all but one test currently only use sha256, which should also be sufficient according to the current security standards. Having two algorithms around already caused some confusion (e.g. the
clean_functional_cache.pyscript only supports sha256 right now), so standardize now on enforcing sha256 before more tests use a mix of the two algorithms.
Quoted 5 lines
Signed-off-by Thomas Huth<[email protected]>--- tests/functional/ppc64/test_fadump.py | 4 +--- tests/functional/qemu_test/asset.py | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-)
r~
Quoted 10 lines · Thomas Huth
From: Thomas Huth <[email protected]>
The functional testing framework currently supports both, sha256 and sha512 as hashsums for the assets. However, all but one test currently only use sha256, which should also be sufficient according to the current security standards. Having two algorithms around already caused some confusion (e.g. the
clean_functional_cache.pyscript only supports sha256 right now), so standardize now on enforcing sha256 before more tests use a mix of the two algorithms.
Quoted 5 lines
Signed-off-by Thomas Huth <[email protected]>--- tests/functional/ppc64/test_fadump.py | 4 +--- tests/functional/qemu_test/asset.py | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-)
Looks good to me.
Thanks,
- Aditya G