Skip to contentSkip to conversation

linux-next: build failure after merge of the net-next tree

DISCUSSION Mark Brown 2 participants 2 messages Jan 26

Subsystems (3)
lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Hi all,

After merging the net-next tree, today's linux-next build (arm64 defconfig) failed like this:

/tmp/next/build/net/core/sysctl_net_core.c: In function 'proc_do_rss_key':
/tmp/next/build/net/core/sysctl_net_core.c:333:23: error: implicit declaration of function 'hex_byte_pack' [-Wimplicit-function-declaration]

  333 |                 pos = hex_byte_pack(pos, netdev_rss_key[i]);
      |                       ^~~~~~~~~~~~~

/tmp/next/build/net/core/sysctl_net_core.c:333:21: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
333 | pos = hex_byte_pack(pos, netdev_rss_key[i]);
| ^

Caused by commit

37b0ea8fef56c (net: expand NETDEV_RSS_KEY_LEN to 256 bytes)

I have used the tree from 20260123 instead.

#1 lore raw
Quoted 14 lines · Mark Brown

Hi all,

After merging the net-next tree, today's linux-next build (arm64 defconfig) failed like this:

/tmp/next/build/net/core/sysctl_net_core.c: In function 'proc_do_rss_key':
/tmp/next/build/net/core/sysctl_net_core.c:333:23: error: implicit declaration of function 'hex_byte_pack' [-Wimplicit-function-declaration]

  333 |                 pos = hex_byte_pack(pos, netdev_rss_key[i]);
      |                       ^~~~~~~~~~~~~

/tmp/next/build/net/core/sysctl_net_core.c:333:21: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
333 | pos = hex_byte_pack(pos, netdev_rss_key[i]);
| ^

Quoted 5 lines

Caused by commit

   37b0ea8fef56c (net: expand NETDEV_RSS_KEY_LEN to 256 bytes)

I have used the tree from 20260123 instead.

I will send this fix then, thank you

net/core/sysctl_net_core.c +1 -0
index 0f761d4b9447..03aea10073f0 100644
@@ -17,6 +17,7 @@
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/sched/isolation.h>
+#include <linux/hex.h>
 
 #include <net/ip.h>
 #include <net/sock.h>