iio: proximity: Add interrupt support for RFD77402
v8 cover iio: proximity: Add interrupt support for RFD77402
This series improves the RFD77402 ToF driver by cleaning up include ordering, improving resource lifetime handling, switching to kernel polling helpers, and adding optional interrupt-driven operation.
Changes in v8:
- Add comment for polling timeout value.
- Fix indentation for macro's.
---
Changelog:
v6 to v7:
- Add new patch to align polling timeout with datasheet.
- Rename the polled value variable in rfd77402_wait_for_result().
- Fix read_poll_timeout() condition.
- Update commit message for devm_mutex_init() patch.
- Update commit message for 'Use kernel helper for result polling' patch.
Link to v7:
https://lore.kernel.org/r/[email protected]
v5 to v6:
- Convert rfd77402_data comments to proper kernel-doc format.
- Re-order the patch sequence as suggested.
- Add missing header files.
- Refactor code to get rid of the i2c_set_clientdata() and respective getter calls.
Link to v6:
https://lore.kernel.org/r/[email protected]/
v4 to v5:
- Add precursor patch to reorder includes before functional changes.
- Use devm_mutex_init() for proper lifetime management.
- Address maintainer feedback on polling helper usage.
- Remove dead code from interrupt_handler.
- Add blank line in rfd77402_wait_for_irq.
- Update measurement timeout comment.
- Add helper function for result polling.
- Fix comment format in rfd77402_init.
- Remove 'data->irq_en = false', as it already initialized by kzalloc.
- Improve documentation of private driver data.
Link to v4: https://lore.kernel.org/all/[email protected]/
v3 to v4:
- No code change.
Link to v3: https://lore.kernel.org/all/[email protected]/
v2 to v3:
- Add 'Reviewed-by' tag to dt-binding patch.
- Update commit message in OF device ID patch.
- Update commit message in the third patch.
- Replace rfd77402_result_polling() with read_poll_timeout().
- Add 'struct rfd77402_data' details in kernel-doc format.
- Arrange includes in order.
- Add comment for completion timeout value.
- Remove blank lines.
- Indent the comments to code.
- Convert mutex_init() to devm_mutex_init().
- Remove 'IRQF_TRIGGER_FALLING' flag from devm_request_threaded_irq().
- Drop the duplicate message.
- Replace 'dev_info' with 'dev_dbg()'.
- Update 'dev_id' to 'pdata' in rfd77402_interrupt_handler().
- Drop 'interrupt mode' comment
- Use 'if(ret)' instead of 'if(ret < 0) for consistency.
- Use 'return i2c_smbus_write_byte_data()' in 'rfd77402_config_irq'.
Link to v2: https://lore.kernel.org/all/[email protected]/
v1 to v2:
- Fix commit message for dt-binding patch
- Update interrupt description in dt-binding
- Add 'vdd-supply' to 'required' property in dt-binding
- Add patch for moving polling implementation to helper
- Add helper rfd77402_wait_for_irq()
- Code refactoring
- Return failure if request IRQ fail
Link to v1: https://lore.kernel.org/all/[email protected]/
---
Shrikant Raskar (6):
iio: proximity: rfd77402: Reorder header includes
iio: proximity: rfd77402: Align polling timeout with datasheet
iio: proximity: rfd77402: Use kernel helper for result polling
iio: proximity: rfd77402: Use devm-managed mutex initialization
iio: proximity: rfd77402: Document device private data structure
iio: proximity: rfd77402: Add interrupt handling support
drivers/iio/proximity/rfd77402.c | 174 +++++++++++++++++++++++++++++++++------ 1 file changed, 147 insertions(+), 27 deletions(-)
---
base-commit: 0f61b1860cc3f52aef9036d7235ed1f017632193
change-id: 20260121-b4-rfd77402_v5-558b8e28c387
Best regards,
Signature · 1 line
Shrikant Raskar <[email protected]>
PATCH v8 1/6 iio: proximity: rfd77402: Reorder header includes
Reorder header includes to follow kernel include
ordering conventions.
--- drivers/iio/proximity/rfd77402.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/iio/proximity/rfd77402.c +2 -2
@@ -10,9 +10,9 @@* https://media.digikey.com/pdf/Data%20Sheets/RF%20Digital%20PDFs/RFD77402.pdf */ -#include <linux/module.h> -#include <linux/i2c.h> #include <linux/delay.h> +#include <linux/i2c.h> +#include <linux/module.h> #include <linux/iio/iio.h>
Signature · 1 line
2.43.0
Jonathan Cameron
maintainerRe: [PATCH v8 1/6] iio: proximity: rfd77402: Reorder header includes
Quoted 7 lines · On Wed, 28 Jan 2026 23:21:48 +0530 Shrikant Raskar via B4 Relay…
From: Shrikant Raskar <[email protected]>
Reorder header includes to follow kernel include
ordering conventions.Reviewed-by Andy Shevchenko <[email protected]>Signed-off-by Shrikant Raskar <[email protected]>
As per earlier discussion I picked this already so it shouldn't have been in this posting. Ah well, easily skipped.
J
Quoted 21 lines
--- drivers/iio/proximity/rfd77402.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/iio/proximity/rfd77402.c +2
-2@@ -10,9 +10,9 @@* https://media.digikey.com/pdf/Data%20Sheets/RF%20Digital%20PDFs/RFD77402.pdf */ -#include <linux/module.h> -#include <linux/i2c.h> #include <linux/delay.h> +#include <linux/i2c.h> +#include <linux/module.h> #include <linux/iio/iio.h>
PATCH v8 2/6 iio: proximity: rfd77402: Align polling timeout with datasheet
In reply to Shrikant RaskarUpdate the polling delay to use a 100 ms timeout, as specified in the RFD77402 datasheet.
--- drivers/iio/proximity/rfd77402.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/iio/proximity/rfd77402.c +5 -1
@@ -132,7 +132,11 @@ static int rfd77402_measure(struct i2c_client *client) goto err;if (ret &RFD77402_ICSR_RESULT )break ; -msleep (20 ); +/* +* As per RFD77402 datasheet section '3.1.1 Single Measure', +* the suggested timeout value for single measure is 100ms. +*/ +msleep (10 ); }if (tries <0 ) {
Signature · 1 line
2.43.0
Re: [PATCH v8 2/6] iio: proximity: rfd77402: Align polling timeout with datasheet
Quoted 2 lines · On Wed, Jan 28, 2026 at 11:21:49PM +0530, Shrikant Raskar via B4 Relay wrote:
Update the polling delay to use a 100 ms timeout, as specified in the RFD77402 datasheet.
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v8 3/6 iio: proximity: rfd77402: Use kernel helper for result polling
In reply to Shrikant RaskarReplace the manually written polling loop with read_poll_timeout(), the kernel's standard helper for waiting on hardware status.This makes the code easier to read.
Move the polling logic into a dedicated helper function, as it will be reused by future updates.
--- drivers/iio/proximity/rfd77402.c | 42 ++++++++++++++++++++++------------------ 1 file changed, 23 insertions(+), 19 deletions(-)
drivers/iio/proximity/rfd77402.c +23 -19
@@ -12,6 +12,7 @@#include <linux/delay.h> #include <linux/i2c.h> +#include <linux/iopoll.h> #include <linux/module.h> #include <linux/iio/iio.h>
@@ -110,10 +111,27 @@ static int rfd77402_set_state(struct i2c_client *client, u8 state, u16 check)return 0 ; } -static int rfd77402_measure (struct i2c_client *client) +static int rfd77402_wait_for_result (struct rfd77402_data *data) { +struct i2c_client *client = data->client; +int val, ret; + + ret =read_poll_timeout (i2c_smbus_read_byte_data, val, + (val <0 ) || (val &RFD77402_ICSR_RESULT ), +10 *USEC_PER_MSEC , +10 *10 *USEC_PER_MSEC , + false, + client,RFD77402_ICSR ); +if (val <0 ) +return val; + +return ret; +} + +static int rfd77402_measure (struct rfd77402_data *data) +{ +struct i2c_client *client = data->client;int ret; -int tries =10 ; ret =rfd77402_set_state (client,RFD77402_CMD_MCPU_ON ,RFD77402_STATUS_MCPU_ON );
@@ -126,23 +144,9 @@ static int rfd77402_measure(struct i2c_client *client)if (ret <0 ) goto err; -while (tries-- >0 ) { - ret =i2c_smbus_read_byte_data (client,RFD77402_ICSR ); -if (ret <0 ) - goto err; -if (ret &RFD77402_ICSR_RESULT ) -break ; -/* -* As per RFD77402 datasheet section '3.1.1 Single Measure', -* the suggested timeout value for single measure is 100ms. -*/ -msleep (10 ); - } - -if (tries <0 ) { - ret = -ETIMEDOUT ; + ret =rfd77402_wait_for_result (data); +if (ret <0 ) goto err; - } ret =i2c_smbus_read_word_data (client,RFD77402_RESULT_R );if (ret <0 )
@@ -172,7 +176,7 @@ static int rfd77402_read_raw(struct iio_dev *indio_dev,switch (mask) {case IIO_CHAN_INFO_RAW :mutex_lock (&data->lock); - ret =rfd77402_measure (data->client); + ret =rfd77402_measure (data);mutex_unlock (&data->lock);if (ret <0 )return ret;
Signature · 1 line
2.43.0
Re: [PATCH v8 3/6] iio: proximity: rfd77402: Use kernel helper for result polling
Quoted 6 lines · On Wed, Jan 28, 2026 at 11:21:50PM +0530, Shrikant Raskar via B4 Relay wrote:
Replace the manually written polling loop with
read_poll_timeout(), the kernel's standard helper for waiting on hardware status.This makes the code easier to read.Move the polling logic into a dedicated helper function, as it will be reused by future updates.
...
drivers/iio/proximity/rfd77402.c static int rfd77402_set_state(struct i2c_client *client, u8 state, u16 check) · line 117
Quoted 5 lines
drivers/iio/proximity/rfd77402.c +3
-1-static int rfd77402_measure (struct i2c_client *client) +static int rfd77402_wait_for_result (struct rfd77402_data *data) { +struct i2c_client *client = data->client; +int val, ret;
Where is the newly introduced comment?
Quoted 11 lines
drivers/iio/proximity/rfd77402.c +11
-0+ ret =read_poll_timeout (i2c_smbus_read_byte_data, val, + (val <0 ) || (val &RFD77402_ICSR_RESULT ), +10 *USEC_PER_MSEC , +10 *10 *USEC_PER_MSEC , + false, + client,RFD77402_ICSR ); +if (val <0 ) +return val; + +return ret; +}
...
drivers/iio/proximity/rfd77402.c static int rfd77402_measure(struct i2c_client *client) · line 138
Quoted 4 lines
drivers/iio/proximity/rfd77402.c +0
-4-/* -* As per RFD77402 datasheet section '3.1.1 Single Measure', -* the suggested timeout value for single measure is 100ms. -*/
???
See above.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Jonathan Cameron
maintainerRe: [PATCH v8 3/6] iio: proximity: rfd77402: Use kernel helper for result polling
Quoted 11 lines · On Thu, 29 Jan 2026 00:23:01 +0200 Andy Shevchenko…
Quoted 6 lines · On Wed, Jan 28, 2026 at 11:21:50PM +0530, Shrikant Raskar via B4 Relay wrote:
Replace the manually written polling loop with
read_poll_timeout(), the kernel's standard helper for waiting on hardware status.This makes the code easier to read.Move the polling logic into a dedicated helper function, as it will be reused by future updates.
...
Quoted 8 lines
drivers/iio/proximity/rfd77402.c static int rfd77402_set_state(struct i2c_client *client, u8 state, u16 check) · line 117
Quoted 5 lines
drivers/iio/proximity/rfd77402.c +3
-1-static int rfd77402_measure (struct i2c_client *client) +static int rfd77402_wait_for_result (struct rfd77402_data *data) { +struct i2c_client *client = data->client; +int val, ret;Where is the newly introduced comment?
I put it here whilst applying
J
Quoted 24 lines
Quoted 12 lines
drivers/iio/proximity/rfd77402.c +11
-0+ ret =read_poll_timeout (i2c_smbus_read_byte_data, val, + (val <0 ) || (val &RFD77402_ICSR_RESULT ), +10 *USEC_PER_MSEC , +10 *10 *USEC_PER_MSEC , + false, + client,RFD77402_ICSR ); +if (val <0 ) +return val; + +return ret; +}...
drivers/iio/proximity/rfd77402.c static int rfd77402_measure(struct i2c_client *client) · line 138
Quoted 4 lines
drivers/iio/proximity/rfd77402.c +0
-4-/* -* As per RFD77402 datasheet section '3.1.1 Single Measure', -* the suggested timeout value for single measure is 100ms. -*/ ???
See above.
PATCH v8 4/6 iio: proximity: rfd77402: Use devm-managed mutex initialization
In reply to Shrikant RaskarUse devm_mutex_init() to tie the mutex lifetime to the device and improve debugging when CONFIG_DEBUG_MUTEXES is enabled.
--- drivers/iio/proximity/rfd77402.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/iio/proximity/rfd77402.c +4 -1
@@ -283,7 +283,10 @@ static int rfd77402_probe(struct i2c_client *client) data =iio_priv (indio_dev); data->client = client; -mutex_init (&data->lock); + + ret =devm_mutex_init (&client->dev, &data->lock); +if (ret) +return ret; indio_dev->info = &rfd77402_info; indio_dev->channels = rfd77402_channels;
Signature · 1 line
2.43.0
PATCH v8 5/6 iio: proximity: rfd77402: Document device private data structure
In reply to Shrikant RaskarAdd kernel-doc style comments for struct rfd77402_data to describe the purpose of each member.
--- drivers/iio/proximity/rfd77402.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/iio/proximity/rfd77402.c +5 -1
@@ -77,9 +77,13 @@ static const struct { {RFD77402_HFCFG_3, 0x45d4}, }; +/** +* struct rfd77402_data - device-specific data for the RFD77402 sensor +* @client: I2C client handle +* @lock: mutex to serialize sensor reads +*/ struct rfd77402_data {struct i2c_client *client; -/* Serialize reads from the sensor */ struct mutex lock; };
Signature · 1 line
2.43.0
PATCH v8 6/6 iio: proximity: rfd77402: Add interrupt handling support
In reply to Shrikant RaskarAdd interrupt handling support to enable event-driven data acquisition instead of continuous polling. This improves responsiveness, reduces CPU overhead, and supports low-power operation by allowing the system to remain idle until an interrupt occurs.
--- drivers/iio/proximity/rfd77402.c | 121 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 113 insertions(+), 8 deletions(-)
drivers/iio/proximity/rfd77402.c +113 -8
@@ -6,20 +6,28 @@* * 7-bit I2C slave address 0x4c * -* TODO: interrupt * https://media.digikey.com/pdf/Data%20Sheets/RF%20Digital%20PDFs/RFD77402.pdf */ +#include <linux/bits.h> +#include <linux/completion.h> #include <linux/delay.h> +#include <linux/dev_printk.h> +#include <linux/errno.h> #include <linux/i2c.h> +#include <linux/interrupt.h> #include <linux/iopoll.h> +#include <linux/jiffies.h> #include <linux/module.h> +#include <linux/types.h> #include <linux/iio/iio.h> #define RFD77402_DRV_NAME "rfd77402"#define RFD77402_ICSR 0x00/* Interrupt Control Status Register */ +#define RFD77402_ICSR_CLR_CFG BIT(0) +#define RFD77402_ICSR_CLR_TYPE BIT(1)#define RFD77402_ICSR_INT_MODE BIT(2)#define RFD77402_ICSR_INT_POL BIT(3)#define RFD77402_ICSR_RESULT BIT(4)
@@ -27,6 +35,12 @@#define RFD77402_ICSR_H2M_MSG BIT(6)#define RFD77402_ICSR_RESET BIT(7) +#define RFD77402_IER 0x02 +#define RFD77402_IER_RESULT BIT(0) +#define RFD77402_IER_M2H_MSG BIT(1) +#define RFD77402_IER_H2M_MSG BIT(2) +#define RFD77402_IER_RESET BIT(3) +#define RFD77402_CMD_R 0x04#define RFD77402_CMD_SINGLE 0x01#define RFD77402_CMD_STANDBY 0x10
@@ -81,10 +95,14 @@ static const struct {* struct rfd77402_data - device-specific data for the RFD77402 sensor * @client: I2C client handle * @lock: mutex to serialize sensor reads +* @completion: completion used for interrupt-driven measurements +* @irq_en: indicates whether interrupt mode is enabled */ struct rfd77402_data {struct i2c_client *client;struct mutex lock; +struct completion completion; +bool irq_en; };static const struct iio_chan_spec rfd77402_channels[] = {
@@ -95,6 +113,41 @@ static const struct iio_chan_spec rfd77402_channels[] = { }, }; +static irqreturn_t rfd77402_interrupt_handler (int irq,void *pdata) +{ +struct rfd77402_data *data = pdata; +int ret; + + ret =i2c_smbus_read_byte_data (data->client,RFD77402_ICSR ); +if (ret <0 ) +return IRQ_NONE ; + +/* Check if the interrupt is from our device */ +if (!(ret &RFD77402_ICSR_RESULT )) +return IRQ_NONE ; + +/* Signal completion of measurement */ +complete (&data->completion); +return IRQ_HANDLED ; +} + +static int rfd77402_wait_for_irq (struct rfd77402_data *data) +{ +int ret; + +/* +* According to RFD77402 Datasheet v1.8, +* Section 3.1.1 "Single Measure" (Figure: Single Measure Flow Chart), +* the suggested timeout for single measure is 100 ms. +*/ + ret =wait_for_completion_timeout (&data->completion, +msecs_to_jiffies (100 )); +if (ret ==0 ) +return -ETIMEDOUT ; + +return 0 ; +} +static int rfd77402_set_state (struct i2c_client *client,u8 state,u16 check) {int ret;
@@ -120,6 +173,11 @@ static int rfd77402_wait_for_result(struct rfd77402_data *data)struct i2c_client *client = data->client;int val, ret; +if (data->irq_en) { +reinit_completion (&data->completion); +return rfd77402_wait_for_irq (data); + } + ret = read_poll_timeout(i2c_smbus_read_byte_data, val, (val < 0) || (val & RFD77402_ICSR_RESULT), 10 * USEC_PER_MSEC,
@@ -200,8 +258,20 @@ static const struct iio_info rfd77402_info = { .read_raw = rfd77402_read_raw, }; -static int rfd77402_init (struct i2c_client *client) +static int rfd77402_config_irq (struct i2c_client *client,u8 csr,u8 ier) { +int ret; + + ret =i2c_smbus_write_byte_data (client,RFD77402_ICSR , csr); +if (ret) +return ret; + +return i2c_smbus_write_byte_data (client,RFD77402_IER , ier); +} + +static int rfd77402_init (struct rfd77402_data *data) +{ +struct i2c_client *client = data->client;int ret, i; ret = rfd77402_set_state(client, RFD77402_CMD_STANDBY,
@@ -209,10 +279,26 @@ static int rfd77402_init(struct i2c_client *client)if (ret <0 )return ret; -/* configure INT pad as push-pull, active low */ - ret =i2c_smbus_write_byte_data (client,RFD77402_ICSR , -RFD77402_ICSR_INT_MODE ); -if (ret <0 ) +if (data->irq_en) { +/* +* Enable interrupt mode: +* - Configure ICSR for auto-clear on read and +* push-pull output +* - Enable "result ready" interrupt in IER +*/ + ret =rfd77402_config_irq (client, +RFD77402_ICSR_CLR_CFG | +RFD77402_ICSR_INT_MODE , +RFD77402_IER_RESULT ); + }else { +/* +* Disable all interrupts: +* - Clear ICSR configuration +* - Disable all interrupts in IER +*/ + ret =rfd77402_config_irq (client,0 ,0 ); + } +if (ret)return ret;/* I2C configuration */
@@ -292,13 +378,29 @@ static int rfd77402_probe(struct i2c_client *client)if (ret)return ret; +init_completion (&data->completion); + +if (client->irq >0 ) { + ret =devm_request_threaded_irq (&client->dev, client->irq, +NULL , rfd77402_interrupt_handler, +IRQF_ONESHOT , +"rfd77402" , data); +if (ret) +return ret; + + data->irq_en = true; +dev_dbg (&client->dev,"Using interrupt mode\n" ); + }else { +dev_dbg (&client->dev,"Using polling mode\n" ); + } + indio_dev->info = &rfd77402_info; indio_dev->channels = rfd77402_channels; indio_dev->num_channels =ARRAY_SIZE (rfd77402_channels); indio_dev->name =RFD77402_DRV_NAME ; indio_dev->modes =INDIO_DIRECT_MODE ; - ret =rfd77402_init (client); + ret =rfd77402_init (data);if (ret <0 )return ret;
@@ -316,7 +418,10 @@ static int rfd77402_suspend(struct device *dev)static int rfd77402_resume (struct device *dev) { -return rfd77402_init (to_i2c_client (dev)); +struct iio_dev *indio_dev =dev_get_drvdata (dev); +struct rfd77402_data *data =iio_priv (indio_dev); + +return rfd77402_init (data); } static DEFINE_SIMPLE_DEV_PM_OPS(rfd77402_pm_ops, rfd77402_suspend,
Signature · 1 line
2.43.0
Quoted 6 lines · On Wed, Jan 28, 2026 at 11:21:47PM +0530, Shrikant Raskar via B4 Relay wrote:
This series improves the RFD77402 ToF driver by cleaning up include ordering, improving resource lifetime handling, switching to kernel polling helpers, and adding optional interrupt-driven operation.
Changes in v8:
- Add comment for polling timeout value.
And mistakenly removed it...
Quoted 1 line
- Fix indentation for macro's.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines · On Thu, 29 Jan 2026 00:25:19 +0200 Andy Shevchenko…
Quoted 6 lines · On Wed, Jan 28, 2026 at 11:21:47PM +0530, Shrikant Raskar via B4 Relay wrote:
This series improves the RFD77402 ToF driver by cleaning up include ordering, improving resource lifetime handling, switching to kernel polling helpers, and adding optional interrupt-driven operation.
Changes in v8:
- Add comment for polling timeout value.And mistakenly removed it...
Fixed up and applied. Given cycle cut off is effectively tonight I didn't want to have to revisit this next cycle.
Applied to the togreg branch of iio.git
(not I'm skipping normally testing branch to get this some time in next before I make it Greg's problem ;)
Jonathan
Quoted 2 lines
Quoted 1 line
- Fix indentation for macro's.