ASoC: sdca: Fix missing regmap dependencies in Kconfig
Subsystems (3)
PATCH 1/1 ASoC: sdca: Fix missing regmap dependencies in Kconfig
The SDCA modules failed to build with modpost errors:
ERROR: modpost: "__devm_regmap_init_sdw" [sound/soc/sdca/snd-soc-sdca-class.ko] undefined!
ERROR: modpost: "__devm_regmap_init_sdw_mbq" [sound/soc/sdca/snd-soc-sdca-class-function.ko] undefined!
The issue occurs because:
- sdca_class.c calls devm_regmap_init_sdw() which requires REGMAP_SOUNDWIRE
- sdca_class_function.c calls devm_regmap_init_sdw_mbq_cfg() which requires REGMAP_SOUNDWIRE_MBQ
However, the Kconfig didn't select these dependencies, causing the symbols to be unavailable when the SDCA modules are built.
Fix this by adding:
- select REGMAP_SOUNDWIRE to SND_SOC_SDCA_CLASS
- select REGMAP_SOUNDWIRE_MBQ to SND_SOC_SDCA_CLASS_FUNCTION
This ensures the required regmap drivers are enabled when building SDCA support.
Configuration after fix:
CONFIG_SND_SOC_SDCA_CLASS=m
CONFIG_SND_SOC_SDCA_CLASS_FUNCTION=m
CONFIG_REGMAP_SOUNDWIRE=m
CONFIG_REGMAP_SOUNDWIRE_MBQ=m
--- sound/soc/sdca/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
sound/soc/sdca/Kconfig +2 -0
@@ -46,12 +46,14 @@ config SND_SOC_SDCA_CLASS select SND_SOC_SDCA_FDL select SND_SOC_SDCA_HID select SND_SOC_SDCA_IRQ + select REGMAP_SOUNDWIRE help This option enables support for the SDCA Class driver which should support any class compliant SDCA part. config SND_SOC_SDCA_CLASS_FUNCTION tristate + select REGMAP_SOUNDWIRE_MBQ help This option enables support for the SDCA Class Function drivers, these implement the individual functions of the SDCA Class driver.
Signature · 1 line
2.52.0
Quoted 18 lines · Boris Faure
The SDCA modules failed to build with modpost errors:
ERROR: modpost: "
__devm_regmap_init_sdw" [sound/soc/sdca/snd-soc-sdca-class.ko] undefined!
ERROR: modpost: "__devm_regmap_init_sdw_mbq" [sound/soc/sdca/snd-soc-sdca-class-function.ko] undefined!The issue occurs because:
-sdca_class.ccallsdevm_regmap_init_sdw()which requiresREGMAP_SOUNDWIRE
-sdca_class_function.ccallsdevm_regmap_init_sdw_mbq_cfg()which requiresREGMAP_SOUNDWIRE_MBQHowever, the
Kconfigdidn't select these dependencies, causing the symbols to be unavailable when the SDCA modules are built.Fix this by adding:
- selectREGMAP_SOUNDWIREtoSND_SOC_SDCA_CLASS
- selectREGMAP_SOUNDWIRE_MBQtoSND_SOC_SDCA_CLASS_FUNCTIONThis ensures the required regmap drivers are enabled when building SDCA support.
Quoted 8 lines
Configuration after fix:
CONFIG_SND_SOC_SDCA_CLASS=m
CONFIG_SND_SOC_SDCA_CLASS_FUNCTION=m
CONFIG_REGMAP_SOUNDWIRE=m
CONFIG_REGMAP_SOUNDWIRE_MBQ=mSigned-off-by Boris Faure <[email protected]>---
Thanks,
Charles
Mark Brown
maintainerQuoted 10 lines · Boris Faure
The SDCA modules failed to build with modpost errors:
ERROR: modpost: "
__devm_regmap_init_sdw" [sound/soc/sdca/snd-soc-sdca-class.ko] undefined!
ERROR: modpost: "__devm_regmap_init_sdw_mbq" [sound/soc/sdca/snd-soc-sdca-class-function.ko] undefined!The issue occurs because:
-sdca_class.ccallsdevm_regmap_init_sdw()which requiresREGMAP_SOUNDWIRE
-sdca_class_function.ccallsdevm_regmap_init_sdw_mbq_cfg()which requiresREGMAP_SOUNDWIRE_MBQ[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: sdca: Fix missing regmap dependencies in Kconfig
commit: bbb758a6943e19c483ab752cf8220140b46cf22c
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark