Skip to contentSkip to conversation

PM/devfreq: Remove unneeded casting for HZ_PER_KHZ

PATCH In review Andy Shevchenko 3 participants 4 messages Jan 14 – Feb 4 Device frequency (devfreq)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PM/devfreq: Remove unneeded casting for HZ_PER_KHZ

HZ_PER_KHZ is defined as UL (unsigned long), no need to repeat that.

---
 drivers/devfreq/devfreq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/devfreq/devfreq.c +2 -3
index 00979f2e0e27..51eb67fba44b 100644
@@ -146,10 +146,9 @@ void devfreq_get_freq_range(struct devfreq *devfreq,
 					     DEV_PM_QOS_MIN_FREQUENCY);
 	qos_max_freq = dev_pm_qos_read_value(devfreq->dev.parent,
 					     DEV_PM_QOS_MAX_FREQUENCY);
-	*min_freq = max(*min_freq, (unsigned long)HZ_PER_KHZ * qos_min_freq);
+	*min_freq = max(*min_freq, HZ_PER_KHZ * qos_min_freq);
 	if (qos_max_freq != PM_QOS_MAX_FREQUENCY_DEFAULT_VALUE)
-		*max_freq = min(*max_freq,
-				(unsigned long)HZ_PER_KHZ * qos_max_freq);
+		*max_freq = min(*max_freq, HZ_PER_KHZ * qos_max_freq);
 
 	/* Apply constraints from OPP interface */
 	*max_freq = clamp(*max_freq, devfreq->scaling_min_freq, devfreq->scaling_max_freq);
Signature · 1 line
2.50.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Andy Shevchenko

HZ_PER_KHZ is defined as UL (unsigned long), no need to repeat that.

---
 drivers/devfreq/devfreq.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/devfreq/devfreq.c +0 -0
index 00979f2e0e27..51eb67fba44b 100644
@@ -146,10 +146,9 @@ void devfreq_get_freq_range(struct devfreq *devfreq,
 					     DEV_PM_QOS_MIN_FREQUENCY);
 	qos_max_freq = dev_pm_qos_read_value(devfreq->dev.parent,

drivers/devfreq/devfreq.c void devfreq_get_freq_range(struct devfreq *devfreq, · line 154

Quoted 10 lines
drivers/devfreq/devfreq.c +2 -3
 					     DEV_PM_QOS_MAX_FREQUENCY);
-	*min_freq = max(*min_freq, (unsigned long)HZ_PER_KHZ * qos_min_freq);
+	*min_freq = max(*min_freq, HZ_PER_KHZ * qos_min_freq);
 	if (qos_max_freq != PM_QOS_MAX_FREQUENCY_DEFAULT_VALUE)
-		*max_freq = min(*max_freq,
-				(unsigned long)HZ_PER_KHZ * qos_max_freq);
+		*max_freq = min(*max_freq, HZ_PER_KHZ * qos_max_freq);
 
 	/* Apply constraints from OPP interface */
 	*max_freq = clamp(*max_freq, devfreq->scaling_min_freq, devfreq->scaling_max_freq);

Make sense. Thanks!