staging: rtl8723bs: rtw_io: resolve all checkpatch warnings
PATCH 1/1 staging: rtl8723bs: rtw_io: resolve all checkpatch warnings
Resolve all checkpatch.pl warnings in rtw_io.c.
This includes removing redundant parentheses, fixing overly long lines, and adjusting blank lines. The file is now checkpatch-clean. No functional changes.
Signed-off-by Sarah Gershuni <[email protected]>
--- drivers/staging/rtl8723bs/core/rtw_io.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)
drivers/staging/rtl8723bs/core/rtw_io.c +13 -10
@@ -29,7 +29,7 @@ u8 rtw_read8(struct adapter *adapter, u32 addr) {/* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; -struct intf_hdl *pintfhdl = &(pio_priv->intf); +struct intf_hdl *pintfhdl = &pio_priv->intf;u8 (*_read8)(struct intf_hdl *pintfhdl,u32 addr); _read8 = pintfhdl->io_ops._read8;
@@ -41,7 +41,7 @@ u16 rtw_read16(struct adapter *adapter, u32 addr) {/* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; -struct intf_hdl *pintfhdl = &(pio_priv->intf); +struct intf_hdl *pintfhdl = &pio_priv->intf;u16 (*_read16)(struct intf_hdl *pintfhdl,u32 addr); _read16 = pintfhdl->io_ops._read16;
@@ -53,20 +53,19 @@ u32 rtw_read32(struct adapter *adapter, u32 addr) {/* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; -struct intf_hdl *pintfhdl = &(pio_priv->intf); +struct intf_hdl *pintfhdl = &pio_priv->intf;u32 (*_read32)(struct intf_hdl *pintfhdl,u32 addr); _read32 = pintfhdl->io_ops._read32;return _read32 (pintfhdl, addr); - }int rtw_write8 (struct adapter *adapter,u32 addr,u8 val) {/* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; -struct intf_hdl *pintfhdl = &(pio_priv->intf); +struct intf_hdl *pintfhdl = &pio_priv->intf;int (*_write8)(struct intf_hdl *pintfhdl,u32 addr,u8 val);int ret;
@@ -76,11 +75,12 @@ int rtw_write8(struct adapter *adapter, u32 addr, u8 val)return RTW_STATUS_CODE (ret); } +int rtw_write16 (struct adapter *adapter,u32 addr,u16 val) {/* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; -struct intf_hdl *pintfhdl = &(pio_priv->intf); +struct intf_hdl *pintfhdl = &pio_priv->intf;int (*_write16)(struct intf_hdl *pintfhdl,u32 addr,u16 val);int ret;
@@ -89,11 +89,12 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val) ret =_write16 (pintfhdl, addr, val);return RTW_STATUS_CODE (ret); } +int rtw_write32 (struct adapter *adapter,u32 addr,u32 val) {/* struct io_queue *pio_queue = (struct io_queue *)adapter->pio_queue; */ struct io_priv *pio_priv = &adapter->iopriv; -struct intf_hdl *pintfhdl = &(pio_priv->intf); +struct intf_hdl *pintfhdl = &pio_priv->intf;int (*_write32)(struct intf_hdl *pintfhdl,u32 addr,u32 val);int ret;
@@ -108,14 +109,15 @@ u32 rtw_write_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem) {u32 (*_write_port)(struct intf_hdl *pintfhdl,u32 addr,u32 cnt,u8 *pmem);struct io_priv *pio_priv = &adapter->iopriv; -struct intf_hdl *pintfhdl = &(pio_priv->intf); +struct intf_hdl *pintfhdl = &pio_priv->intf; _write_port = pintfhdl->io_ops._write_port;return _write_port (pintfhdl, addr, cnt, pmem); } -int rtw_init_io_priv (struct adapter *padapter,void (*set_intf_ops)(struct adapter *padapter,struct _io_ops *pops)) +int rtw_init_io_priv (struct adapter *padapter, +void (*set_intf_ops)(struct adapter *padapter,struct _io_ops *pops)) {struct io_priv *piopriv = &padapter->iopriv;struct intf_hdl *pintf = &piopriv->intf;
@@ -133,7 +135,8 @@ int rtw_init_io_priv(struct adapter *padapter, void (*set_intf_ops)(struct adapt }/* -* Increase and check if the continual_io_error of this @param dvobjprive is larger than MAX_CONTINUAL_IO_ERR +* Increase and check if the continual_io_error of this @param dvobjprive is +* larger than MAX_CONTINUAL_IO_ERR * @return true: * @return false: */
Signature · 1 line
2.43.0
Quoted 6 lines · Sarah Gershuni
Resolve all checkpatch.pl warnings in
rtw_io.c.
This includes removing redundant parentheses, fixing overly long lines, and adjusting blank lines. The file is now checkpatch-clean. No functional changes.Signed-off-by Sarah Gershuni <[email protected]>
Split it up by type of warning.
regards,
dan carpenter