Skip to contentSkip to conversation

ksmbd: limit repeated connections from clients with the same IP

DISCUSSION Stefan Metzmacher 2 participants 2 messages Aug 15, 2025 – Aug 16, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi Namjae,

this commit relies on IPv4 only, which is wrong!
Can you please have a look, thanks!

commit e6bb9193974059ddbb0ce7763fa3882bd60d4dc3

Author: Namjae Jeon <[email protected]>
Date:   Tue Aug 5 18:13:13 2025 +0900

ksmbd: limit repeated connections from clients with the same IP

Repeated connections from clients with the same IP address may exhaust the max connections and prevent other normal client connections. This patch limit repeated connections from clients with the same IP.

I came to it because smatch reported this:

Warning: server/connection.c:53 function parameter 'inet_addr' not described in 'ksmbd_conn_alloc'

Thanks!
metze

maintainer
#1 lore raw
Quoted 5 lines · Stefan Metzmacher

Hi Namjae,

this commit relies on IPv4 only, which is wrong!
Can you please have a look, thanks!

Okay. I will do it.
Thanks!

Quoted 22 lines

commit e6bb9193974059ddbb0ce7763fa3882bd60d4dc3

Author: Namjae Jeon <[email protected]>
Date:   Tue Aug 5 18:13:13 2025 +0900

ksmbd: limit repeated connections from clients with the same IP

Repeated connections from clients with the same IP address may exhaust the max connections and prevent other normal client connections. This patch limit repeated connections from clients with the same IP.

I came to it because smatch reported this:

Warning: server/connection.c:53 function parameter 'inet_addr' not described in 'ksmbd_conn_alloc'

Thanks!
metze