Skip to contentSkip to conversation

isdn_bsdcomp.c - vfree() checking cleanups

KJ Domen Puncer 2 participants 2 messages Jan 4, 2005 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Review

Quoted 5 lines · On 04/01/05 13:56 -0800, [email protected] wrote:
(quoted diff) +2 -3
-		if (db->dict) {
-			vfree (db->dict);
-			db->dict -		}
+		vfree (db->dict);
+		db->dict  

Khm... mailer problems with '='?
Please fix this (encoding settings?) and resend.
Also: you can test your mail is fine by sending it to youself and feeding it to patch.

Other than this, patches look fine to me.

Domen

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

Oh wow.
I must have missed that strangeness.
I'll send new ones shortly.

Quoted 12 lines · Domen Puncer

Review

Quoted 5 lines · On 04/01/05 13:56 -0800, [email protected] wrote:
(quoted diff) +2 -3
-             if (db->dict) {
-                     vfree (db->dict);
-                     db->dict -              }
+             vfree (db->dict);
+             db->dict

Khm... mailer problems with '='?
Please fix this (encoding settings?) and resend.
Also: you can test your mail is fine by sending it to youself and feeding it to patch.

Quoted 5 lines

Other than this, patches look fine to me.

Domen

_______________________________________________
Kernel-janitors mailing list
[email protected]
http://lists.osdl.org/mailman/listinfo/kernel-janitors