about phosphor pid control package
Hi,
I have a question about getFailSafeMode().
Currently, only sensors that are defined as "temp" types can be checked for failure. I did not find any "fan" type sensors to check if the fan has failed.
Our project need to check the fan fail so I want to add another "fan" sensor type to check.
Can I add one more "for loop" to check the fan sensor in updateSensors() function in zone.cpp??
for (const auto& t : _thermalInputs)
{
........
}
for (const auto& t : _fanInputs)
{
........
}BRs,
Will
Quoted 14 lines · Will Liang (梁永鉉)
Hi,
I have a question about
getFailSafeMode().Currently, only sensors that are defined as "temp" types can be checked for failure. I did not find any "fan" type sensors to check if the fan has failed.
Our project need to check the fan fail so I want to add another "fan" sensor type to check.Can I add one more "for loop" to check the fan sensor in
updateSensors()function in zone.cpp??
Quoted 8 lines
for (const auto& t :
_thermalInputs){ ........ } for (const auto& t : _fanInputs) { ........ }
updateSensors is deliberately not talking to the fans because they're not considered inputs into the thermal config, they're controlled outputs -- the question I have is, what would you like to do if a fan isn't responding? failsafemode drives the fans to a specific pre-defined speed to keep it from thermal issues. If a fan is failing to respond, one can't drive it -- perhaps one can drive the others to some failsafe?
If so, one needs to update the failsafe for a zone outside of the thermal sensors, but rather where the fans are checked (void PIDZone::updateFanTelemetry(void))
Quoted 3 lines
BRs,
Will
Hi,
Quoted 35 lines
-----Original Message-----
From: Patrick Venture [mailto:[email protected]]
Sent: Thursday, May 9, 2019 12:36 AM
To: Will Liang (梁永鉉) <[email protected]>
Cc: OpenBMC Maillist <[email protected]>
Subject: Re: about phosphor pid control packageQuoted 6 lines · Will Liang (梁永鉉)
Hi,
I have a question about
getFailSafeMode().Currently, only sensors that are defined as "temp" types can be checked for
failure.
Quoted 2 lines
I did not find any "fan" type sensors to check if the fan has failed. Our project need to check the fan fail so I want to add another "fan" sensor
type to check.
Quoted 2 lines
Can I add one more "for loop" to check the fan sensor in
updateSensors()function in zone.cpp??
Quoted 9 lines
for (const auto& t :
_thermalInputs){ ........ } for (const auto& t : _fanInputs) { ........ }
Quoted 6 lines
updateSensors is deliberately not talking to the fans because they're not considered inputs into the thermal config, they're controlled outputs -- the question I have is, what would you like to do if a fan isn't responding? failsafemode drives the fans to a specific pre-defined speed to keep it from thermal issues. If a fan is failing to respond, one can't drive it -- perhaps one can drive the others to some failsafe?
If a fan fails, we need to enter the fail safe mode to increase the other fan duty.
Quoted 3 lines
If so, one needs to update the failsafe for a zone outside of the thermal sensors, but rather where the fans are checked (void
PIDZone::updateFanTelemetry(void))
I add following code into the PIDZone::updateFanTelemetry(void) function to check the fan fail. If the fan fails, it will enter fail safe mode.
if (sensor->getFailed())
{
failSafeSensors.insert(f);
}
else
{
// Check if it's in there: remove it.
auto kt = _failSafeSensors.find(f);
if (kt != _failSafeSensors.end()) {
failSafeSensors.erase(kt);
}
But one more question I have is that the above code can only check if a single fan has failed.
Our project needs to check for dual-fan failures. Do you have any suggestions for checking the failure of the dual-fan?
Will
Quoted 3 lines
Quoted 3 lines
BRs,
Will
Quoted 64 lines · Will Liang (梁永鉉)
Hi,
Quoted 35 lines
-----Original Message-----
From: Patrick Venture [mailto:[email protected]]
Sent: Thursday, May 9, 2019 12:36 AM
To: Will Liang (梁永鉉) <[email protected]>
Cc: OpenBMC Maillist <[email protected]>
Subject: Re: about phosphor pid control packageQuoted 6 lines · Will Liang (梁永鉉)
Hi,
I have a question about
getFailSafeMode().Currently, only sensors that are defined as "temp" types can be checked for
failure.
Quoted 2 lines
I did not find any "fan" type sensors to check if the fan has failed. Our project need to check the fan fail so I want to add another "fan" sensor
type to check.
Quoted 2 lines
Can I add one more "for loop" to check the fan sensor in
updateSensors()function in zone.cpp??
Quoted 9 lines
for (const auto& t :
_thermalInputs){ ........ } for (const auto& t : _fanInputs) { ........ }Quoted 6 lines
updateSensors is deliberately not talking to the fans because they're not considered inputs into the thermal config, they're controlled outputs -- the question I have is, what would you like to do if a fan isn't responding? failsafemode drives the fans to a specific pre-defined speed to keep it from thermal issues. If a fan is failing to respond, one can't drive it -- perhaps one can drive the others to some failsafe?
If a fan fails, we need to enter the fail safe mode to increase the other fan duty.
Quoted 3 lines
If so, one needs to update the failsafe for a zone outside of the thermal sensors, but rather where the fans are checked (void
PIDZone::updateFanTelemetry(void))I add following code into the
PIDZone::updateFanTelemetry(void)function to check the fan fail. If the fan fails, it will enter fail safe mode.
if (sensor->getFailed()){ failSafeSensors.insert(f); } else { // Check if it's in there: remove it. auto kt = _failSafeSensors.find(f); if (kt != _failSafeSensors.end()) { failSafeSensors.erase(kt);
Quoted 5 lines
}
But one more question I have is that the above code can only check if a single fan has failed.
Our project needs to check for dual-fan failures. Do you have any suggestions for checking the failure of the dual-fan?
I'm not entirely certain what you mean. You're saying a dual-fan is a fan that has two outputs but one input?
Quoted 5 lines
Will
Quoted 3 lines
Quoted 3 lines
BRs,
Will
Quoted 68 lines · Patrick Venture
Quoted 66 lines · Will Liang (梁永鉉)
Hi,
Quoted 35 lines
-----Original Message-----
From: Patrick Venture [mailto:[email protected]]
Sent: Thursday, May 9, 2019 12:36 AM
To: Will Liang (梁永鉉) <[email protected]>
Cc: OpenBMC Maillist <[email protected]>
Subject: Re: about phosphor pid control packageQuoted 6 lines · Will Liang (梁永鉉)
Hi,
I have a question about
getFailSafeMode().Currently, only sensors that are defined as "temp" types can be checked for
failure.
Quoted 2 lines
I did not find any "fan" type sensors to check if the fan has failed. Our project need to check the fan fail so I want to add another "fan" sensor
type to check.
Quoted 2 lines
Can I add one more "for loop" to check the fan sensor in
updateSensors()function in zone.cpp??
Quoted 9 lines
for (const auto& t :
_thermalInputs){ ........ } for (const auto& t : _fanInputs) { ........ }Quoted 6 lines
updateSensors is deliberately not talking to the fans because they're not considered inputs into the thermal config, they're controlled outputs -- the question I have is, what would you like to do if a fan isn't responding? failsafemode drives the fans to a specific pre-defined speed to keep it from thermal issues. If a fan is failing to respond, one can't drive it -- perhaps one can drive the others to some failsafe?
If a fan fails, we need to enter the fail safe mode to increase the other fan duty.
Quoted 3 lines
If so, one needs to update the failsafe for a zone outside of the thermal sensors, but rather where the fans are checked (void
PIDZone::updateFanTelemetry(void))I add following code into the
PIDZone::updateFanTelemetry(void)function to check the fan fail. If the fan fails, it will enter fail safe mode.
if (sensor->getFailed()){ failSafeSensors.insert(f); } else { // Check if it's in there: remove it. auto kt = _failSafeSensors.find(f); if (kt != _failSafeSensors.end()) { failSafeSensors.erase(kt);}
Quoted 6 lines
Quoted 3 lines
But one more question I have is that the above code can only check if a single fan has failed.
Our project needs to check for dual-fan failures. Do you have any suggestions for checking the failure of the dual-fan?
I'm not entirely certain what you mean. You're saying a dual-fan is a fan that has two outputs but one input?
If this is what you mean, on our systems we simply have a tach sensor per tach in the fan, i.e. fan1a and fan1b. I think the above logic would work for this issue.
Quoted 6 lines
Quoted 6 lines
Will
Quoted 3 lines
Quoted 3 lines
BRs,
Will
Quoted 79 lines · Patrick Venture
Quoted 42 lines
Quoted 40 lines · Will Liang (梁永鉉)
Hi,
Quoted 37 lines
-----Original Message-----
From: Patrick Venture [mailto:[email protected]]
Sent: Thursday, May 9, 2019 12:36 AM
To: Will Liang (梁永鉉) <[email protected]>
Cc: OpenBMC Maillist <[email protected]>
Subject: Re: about phosphor pid control packageQuoted 7 lines · Will Liang (梁永鉉)
Hi,
I have a question about
getFailSafeMode().Currently, only sensors that are defined as "temp" types can be checked for
failure.
Quoted 3 lines
I did not find any "fan" type sensors to check if the fan has failed. Our project need to check the fan fail so I want to add another "fan" sensor
type to check.
Quoted 3 lines
Can I add one more "for loop" to check the fan sensor in
updateSensors()function in zone.cpp??
Quoted 8 lines
for (const auto& t : _thermalInputs) { ........ } for (const auto& t : _fanInputs) { ........ }Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
updateSensors is deliberately not talking to the fans because they're not considered inputs into the thermal config, they're controlled outputs -- the question I have is, what would you like to do if a
fan isn't responding?
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
failsafemode drives the fans to a specific pre-defined speed to keep it from thermal issues. If a fan is failing to respond, one can't drive it -- perhaps one can drive the others to some failsafe?
If a fan fails, we need to enter the fail safe mode to increase the other fan
duty.
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
If so, one needs to update the failsafe for a zone outside of the thermal sensors, but rather where the fans are checked (void
PIDZone::updateFanTelemetry(void))I add following code into the
PIDZone::updateFanTelemetry(void)functionto check the fan fail.
Quoted 14 lines
Quoted 14 lines
If the fan fails, it will enter fail safe mode.
if (sensor->getFailed()){ failSafeSensors.insert(f); } else { // Check if it's in there: remove it. auto kt = _failSafeSensors.find(f); if (kt != _failSafeSensors.end()) { failSafeSensors.erase(kt);}
Quoted 1 line
Quoted 1 line
But one more question I have is that the above code can only check if a
single fan has failed.
Quoted 2 lines
Quoted 2 lines
Our project needs to check for dual-fan failures. Do you have any
Quoted 8 lines
suggestions for checking the failure of the dual-fan?
Quoted 3 lines
I'm not entirely certain what you mean. You're saying a dual-fan is a fan that has two outputs but one input?
If this is what you mean, on our systems we simply have a tach sensor per tach in the fan, i.e. fan1a and fan1b. I think the above logic would work for this issue.
I'm so sorry to make you misunderstand because of my unclear expression. The "dual-fan" means "Dual rotor fan" , two tachometer output one PWM input.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Will
Quoted 3 lines
Quoted 3 lines
BRs,
Will
Quoted 101 lines
-----Original Message-----
From: Will Liang (梁永鉉)
Sent: Friday, May 10, 2019 8:06 AM
To: 'James Feist' <[email protected]>; Patrick Venture <[email protected]>
Cc: OpenBMC Maillist <[email protected]>
Subject: RE: about phosphor pid control packageQuoted 90 lines · Patrick Venture
Quoted 42 lines
Quoted 40 lines · Will Liang (梁永鉉)
Hi,
Quoted 37 lines
-----Original Message-----
From: Patrick Venture [mailto:[email protected]]
Sent: Thursday, May 9, 2019 12:36 AM
To: Will Liang (梁永鉉) <[email protected]>
Cc: OpenBMC Maillist <[email protected]>
Subject: Re: about phosphor pid control packageQuoted 7 lines · Will Liang (梁永鉉)
Hi,
I have a question about
getFailSafeMode().Currently, only sensors that are defined as "temp" types can be checked for
failure.
Quoted 3 lines
I did not find any "fan" type sensors to check if the fan has failed. Our project need to check the fan fail so I want to add another "fan" sensor
type to check.
Quoted 3 lines
Can I add one more "for loop" to check the fan sensor in
updateSensors()function in zone.cpp??
Quoted 8 lines
for (const auto& t : _thermalInputs) { ........ } for (const auto& t : _fanInputs) { ........ }Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
updateSensors is deliberately not talking to the fans because they're not considered inputs into the thermal config, they're controlled outputs -- the question I have is, what would you like to do if a
fan isn't responding?
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
failsafemode drives the fans to a specific pre-defined speed to keep it from thermal issues. If a fan is failing to respond, one can't drive it -- perhaps one can drive the others to some failsafe?
If a fan fails, we need to enter the fail safe mode to increase the other fan
duty.
Quoted 7 lines
Quoted 7 lines
Quoted 4 lines
If so, one needs to update the failsafe for a zone outside of the thermal sensors, but rather where the fans are checked (void
PIDZone::updateFanTelemetry(void))I add following code into the
PIDZone::updateFanTelemetry(void)functionto check the fan fail.
Quoted 14 lines
Quoted 14 lines
If the fan fails, it will enter fail safe mode.
if (sensor->getFailed()){ failSafeSensors.insert(f); } else { // Check if it's in there: remove it. auto kt = _failSafeSensors.find(f); if (kt != _failSafeSensors.end()) { failSafeSensors.erase(kt);}
Quoted 2 lines
Quoted 2 lines
But one more question I have is that the above code can only check if a
single fan has failed.
Quoted 2 lines
Quoted 2 lines
Our project needs to check for dual-fan failures. Do you have any
suggestions for checking the failure of the dual-fan?
Quoted 3 lines
I'm not entirely certain what you mean. You're saying a dual-fan is a fan that has two outputs but one input?
If this is what you mean, on our systems we simply have a tach sensor per tach in the fan, i.e. fan1a and fan1b. I think the above logic would work for this issue.
I think someone may also need to check for one rotor fan fail, I will push the above code into gerrit
Quoted 3 lines
I'm so sorry to make you misunderstand because of my unclear expression. The "dual-fan" means "Dual rotor fan" , two tachometer output one PWM input.
Our architecture is that both fan1a and fan1b fail (dual rotor fan failure) and then this situation is identified as one fan fail.
Would you have any suggestion or idea?
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Will
Quoted 3 lines
Quoted 3 lines
BRs,
Will
Quoted 14 lines
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Quoted 3 lines
But one more question I have is that the above code can only check if a
single fan has failed.
Quoted 2 lines
Quoted 2 lines
Our project needs to check for dual-fan failures. Do you have any
Quoted 8 lines
Quoted 8 lines
suggestions for checking the failure of the dual-fan?
Quoted 3 lines
I'm not entirely certain what you mean. You're saying a dual-fan is a fan that has two outputs but one input?
If this is what you mean, on our systems we simply have a tach sensor per tach in the fan, i.e. fan1a and fan1b. I think the above logic would work for this issue.
Quoted 8 lines
I think someone may also need to check for one rotor fan fail, I will push the above code into gerrit
Quoted 3 lines
I'm so sorry to make you misunderstand because of my unclear expression. The "dual-fan" means "Dual rotor fan" , two tachometer output one PWM input.
Our architecture is that both fan1a and fan1b fail (dual rotor fan failure) and then this situation is identified as one fan fail.
Would you have any suggestion or idea?
What we have done in the past is used fan redundancy failures for this sort of thing. I would suggest monitoring the fan redundancy interface for redundancy lost to create failure: https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/xyz/openbmc_project/Control/FanRedundancy.interface.yaml
-James