dt-bindings: watchdog: qcom-wdt: document IPQ5018
Subsystems (4)
PATCH 1/2 dt-bindings: watchdog: qcom-wdt: document IPQ5018
Document the IPQ5018 watchdog compatible.
--- Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml +1 -0
@@ -18,6 +18,7 @@ properties: - items: - enum: - qcom,kpss-wdt-ipq4019 + - qcom,apss-wdt-ipq5018 - qcom,apss-wdt-ipq5332 - qcom,apss-wdt-ipq9574 - qcom,apss-wdt-msm8994
Signature · 1 line
2.41.0
PATCH 2/2 arm64: dts: qcom: ipq5018: add WDT
Add the required DT node for WDT operation.
--- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/qcom/ipq5018.dtsi +7 -0
@@ -182,6 +182,13 @@ v2m1: v2m@1000 { }; }; + watchdog: watchdog@b017000 { + compatible = "qcom,apss-wdt-ipq5018", "qcom,kpss-wdt"; + interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>; + reg = <0x0b017000 0x40>; + clocks = <&sleep_clk>; + }; + timer@b120000 { compatible = "arm,armv7-timer-mem"; reg = <0x0b120000 0x1000>;
Signature · 1 line
2.41.0
Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT
Quoted 12 lines · Robert Marko
Add the required DT node for WDT operation.
Signed-off-by Robert Marko <[email protected]>--- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm64/boot/dts/qcom/ipq5018.dtsi +0
-0
arch/arm64/boot/dts/qcom/ipq5018.dtsi v2m1: v2m@1000 { · line 187
Quoted 6 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi +3
-0@@ -182,6 +182,13 @@ v2m1: v2m@1000 { }; }; + watchdog: watchdog@b017000 { + compatible = "qcom,apss-wdt-ipq5018", "qcom,kpss-wdt"; + interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;
I think all GIC_SPI interrupts are level high.
arch/arm64/boot/dts/qcom/ipq5018.dtsi v2m1: v2m@1000 { · line 188
Quoted 1 line
arch/arm64/boot/dts/qcom/ipq5018.dtsi +1
-0+ reg = <0x0b017000 0x40>;
Keep the reg as second property.
arch/arm64/boot/dts/qcom/ipq5018.dtsi v2m1: v2m@1000 { · line 190
Quoted 2 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi +2
-0+ clocks = <&sleep_clk>; + };
Best regards,
Krzysztof
Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT
Quoted 17 lines · Krzysztof Kozlowski
Quoted 15 lines · Robert Marko
Add the required DT node for WDT operation.
Signed-off-by Robert Marko <[email protected]>--- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm64/boot/dts/qcom/ipq5018.dtsi +0
-0@@ -182,6 +182,13 @@ v2m1: v2m@1000 { }; };
Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi v2m1: v2m@1000 { · line 187
Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi +3
-0+ watchdog: watchdog@b017000 { + compatible = "qcom,apss-wdt-ipq5018", "qcom,kpss-wdt"; + interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;I think all
GIC_SPIinterrupts are level high.
They are most probably using GIC-500 which supports rising edge or active high interrupts.
Both the older GIC-400 and newer GIC-600 also support the same.
Vendor DTS indicates this level, IPQ8074 and IPQ6018 which use the same core, and it
seems the same WDT IP use the rising edge IRQ.
Quoted 4 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi v2m1: v2m@1000 { · line 188
Quoted 2 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi +1
-0+ reg = <0x0b017000 0x40>;Keep the reg as second property.
Ok,
will do.
Regards,
Robert
Quoted 7 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi v2m1: v2m@1000 { · line 190
Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi +2
-0+ clocks = <&sleep_clk>; + };Best regards,
Krzysztof
Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT
Quoted 25 lines · Robert Marko
Quoted 17 lines · Krzysztof Kozlowski
Quoted 15 lines · Robert Marko
Add the required DT node for WDT operation.
Signed-off-by Robert Marko <[email protected]>--- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm64/boot/dts/qcom/ipq5018.dtsi +0
-0@@ -182,6 +182,13 @@ v2m1: v2m@1000 { }; };Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi v2m1: v2m@1000 { · line 187
Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi +3
-0+ watchdog: watchdog@b017000 { + compatible = "qcom,apss-wdt-ipq5018", "qcom,kpss-wdt"; + interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;I think all
GIC_SPIinterrupts are level high.
Quoted 8 lines
They are most probably using GIC-500 which supports rising edge or active high interrupts.
Both the older GIC-400 and newer GIC-600 also support the same.Vendor DTS indicates this level, IPQ8074 and IPQ6018 which use the same core, and it
seems the same WDT IP use the rising edge IRQ.
That's ok, but now I see missing Cc to DT, so standard message goes:
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
You missed at least DT list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof
Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add WDT
Quoted 43 lines · Krzysztof Kozlowski
Quoted 25 lines · Robert Marko
Quoted 17 lines · Krzysztof Kozlowski
Quoted 15 lines · Robert Marko
Add the required DT node for WDT operation.
Signed-off-by Robert Marko <[email protected]>--- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm64/boot/dts/qcom/ipq5018.dtsi +0
-0@@ -182,6 +182,13 @@ v2m1: v2m@1000 { }; };Quoted 5 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi v2m1: v2m@1000 { · line 187
Quoted 3 lines
arch/arm64/boot/dts/qcom/ipq5018.dtsi +3
-0+ watchdog: watchdog@b017000 { + compatible = "qcom,apss-wdt-ipq5018", "qcom,kpss-wdt"; + interrupts = <GIC_SPI 3 IRQ_TYPE_EDGE_RISING>;I think all
GIC_SPIinterrupts are level high.Quoted 8 lines
They are most probably using GIC-500 which supports rising edge or active high interrupts.
Both the older GIC-400 and newer GIC-600 also support the same.Vendor DTS indicates this level, IPQ8074 and IPQ6018 which use the same core, and it
seems the same WDT IP use the rising edge IRQ.That's ok, but now I see missing Cc to DT, so standard message goes:
Please use
scripts/get_maintainers.plto get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Quoted 6 lines
You missed at least DT list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested.
Please kindly resend and include all necessary To/Cc entries.
Indeed it looks like I managed to miss the DT mailing list somehow, everybody else was added.
Apologies for it, will resend it in the morning.
Regards,
Robert
Quoted 4 lines
Best regards,
Krzysztof
Quoted 3 lines · Robert Marko
Document the IPQ5018 watchdog compatible.
Signed-off-by Robert Marko <[email protected]>
Thanks,
Conor.