Skip to contentSkip to conversation

x86: amd_iommu_init.c use NULL pointer

PATCH In review Jaswinder Singh Rajput 2 participants 3 messages May 13, 2009 – May 14, 2009 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: amd_iommu_init.c use NULL pointer

---
 arch/x86/kernel/amd_iommu_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/amd_iommu_init.c +1 -1
index 8c0be09..f728b12 100644
@@ -898,7 +898,7 @@ static int __init init_exclusion_range(struct ivmd_header *m)
 /* called for unity map ACPI definition */
 static int __init init_unity_map_range(struct ivmd_header *m)
 {
-	struct unity_map_entry *e = 0;
+	struct unity_map_entry *e = NULL;
 
 	e = kzalloc(sizeof(*e), GFP_KERNEL);
 	if (e == NULL)
Signature · 1 line
1.6.0.6
#1 lore raw
Quoted 20 lines · Jaswinder Singh Rajput
---
 arch/x86/kernel/amd_iommu_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/amd_iommu_init.c +1 -1
index 8c0be09..f728b12 100644
@@ -898,7 +898,7 @@ static int __init init_exclusion_range(struct
 ivmd_header *m)
 /* called for unity map ACPI definition */
 static int __init init_unity_map_range(struct ivmd_header *m)
 {
-	struct unity_map_entry *e = 0;
+	struct unity_map_entry *e = NULL;
 
 	e = kzalloc(sizeof(*e), GFP_KERNEL);
Quoted 4 lines

if (e == NULL)
--
1.6.0.6

Hi Jaswinder,
I believe you could get rid of such init completely. We do check 'e' after kzalloc anyway.

#2 lore raw
Quoted 20 lines · Cyrill Gorcunov
Quoted 19 lines · Jaswinder Singh Rajput
---
 arch/x86/kernel/amd_iommu_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/amd_iommu_init.c +1 -1
index 8c0be09..f728b12 100644
@@ -898,7 +898,7 @@ static int __init init_exclusion_range(struct
 ivmd_header *m)
 /* called for unity map ACPI definition */
 static int __init init_unity_map_range(struct ivmd_header *m)
 {
-	struct unity_map_entry *e = 0;
+	struct unity_map_entry *e = NULL;
 
Quoted 8 lines
Quoted 5 lines
arch/x86/kernel/amd_iommu_init.c +0 -0
 	e = kzalloc(sizeof(*e), GFP_KERNEL);

if (e == NULL)
--
1.6.0.6

Hi Jaswinder,
I believe you could get rid of such init completely. We do check 'e' after kzalloc anyway.

Thanks, here is another patch:

[PATCH -tip] x86: amd_iommu_init.c fix initialization issue

struct unity_map_entry *e = 0 which should be struct unity_map_entry *e = NULL

But we do not need to initialize e as kzalloc will take care of it.

---
 arch/x86/kernel/amd_iommu_init.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/amd_iommu_init.c +1 -1
index 8c0be09..1ca0383 100644
@@ -898,7 +898,7 @@ static int __init init_exclusion_range(struct ivmd_header *m)
 /* called for unity map ACPI definition */
 static int __init init_unity_map_range(struct ivmd_header *m)
 {
-	struct unity_map_entry *e = 0;
+	struct unity_map_entry *e;
 
 	e = kzalloc(sizeof(*e), GFP_KERNEL);
 	if (e == NULL)
Signature · 1 line
1.6.0.6