Skip to contentSkip to conversation

modules: update qom object module comment

PATCH In review Gerd Hoffmann 2 participants 2 messages Sep 23, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 modules: update qom object module comment

---
 util/module.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
util/module.c +3 -1
index 520986bd70ff..6eb1e917860e 100644
@@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name)
  * only a very few devices & objects.
  *
  * So with the expectation that this will be rather the exception than
- * to rule and the list will not gain that many entries go with a
+ * the rule and the list will not gain that many entries, go with a
  * simple manually maintained list for now.
+ *
+ * The list must be sorted by module (module_load_qom_all() needs this).
  */
 static struct {
     const char *type;
Signature · 1 line
2.27.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 12 lines · Gerd Hoffmann
---
 util/module.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
util/module.c +0 -0
index 520986bd70ff..6eb1e917860e 100644
@@ -255,8 +255,10 @@ bool module_load_one(const char *prefix, const char *lib_name)
  * only a very few devices & objects.

util/module.c bool module_load_one(const char *prefix, const char *lib_name) · line 264

Quoted 10 lines
util/module.c +3 -1
  *
  * So with the expectation that this will be rather the exception than
- * to rule and the list will not gain that many entries go with a
+ * the rule and the list will not gain that many entries, go with a
  * simple manually maintained list for now.
+ *
+ * The list must be sorted by module (module_load_qom_all() needs this).
  */
 static struct {
     const char *type;