Skip to contentSkip to conversation

dt-bindings: arm: fsl: Add Marantec maveo box as a DHCOR i.MX6ULL SoM based board

PATCH In review Christoph Niedermaier 3 participants 14 messages Apr 5, 2023 – Apr 6, 2023

Subsystems (4)
lore
Share & tools
lore

Christoph Niedermaier

author maintainer
#0 lore raw

PATCH 1/2 dt-bindings: arm: fsl: Add Marantec maveo box as a DHCOR i.MX6ULL SoM based board

Add Marantec maveo box. The system is used to get a smart conntection to a door drive. The core of this system is a soldered i.MX6ULL DHCOR SoM from DH electronics.

---
Cc: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Shawn Guo <[email protected]>
CC: Li Yang <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]

---
 Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +6 -0
index b175f2b1bd30..c95254c57571 100644
@@ -717,6 +717,12 @@ properties:
           - const: dh,imx6ull-dhcor-som
           - const: fsl,imx6ull
 
+      - description: i.MX6ULL DHCOR SoM based Boards
+        items:
+          - const: dh,imx6ull-dhcor-maveo-box
+          - const: dh,imx6ull-dhcor-som
+          - const: fsl,imx6ull
+
       - description: i.MX6ULL PHYTEC phyBOARD-Segin
         items:
           - enum:
Signature · 7 lines
2.11.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#1 lore raw

PATCH 2/2 ARM: dts: imx6ull-dhcor: Add Marantec maveo box

Add support for Marantec maveo box. The system is used to get a smart conntection to a door drive. It has USB, WiFi, Bluetooth, Zigbee and NFC interfaces. The core of this system is a soldered i.MX6ULL DHCOR SoM from DH electronics.

---
Cc: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Shawn Guo <[email protected]>
Cc: Li Yang <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]

---
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts | 361 ++++++++++++++++++++++++++
 2 files changed, 362 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts
arch/arm/boot/dts/Makefile +1 -0
index aa8fb4b7cdcc..58d3334164e2 100644
@@ -751,6 +751,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
 	imx6ull-dhcom-drc02.dtb \
 	imx6ull-dhcom-pdk2.dtb \
 	imx6ull-dhcom-picoitx.dtb \
+	imx6ull-dhcor-maveo-box.dtb \
 	imx6ull-jozacp.dtb \
 	imx6ull-kontron-bl.dtb \
 	imx6ull-myir-mys-6ulx-eval.dtb \
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +361 -0

361 lines not on this page · raw message

Signature · 1 line
2.11.0
#2 lore raw

Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

On 4/5/23 18:02, Christoph Niedermaier wrote:

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+	model = "DH electronics i.MX6ULL DHCOR on maveo box";
+	compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+		     "fsl,imx6ull";
+
+	aliases {
+		/delete-property/ mmc0; /* Avoid double definitions */
+		/delete-property/ mmc1;
+		mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

Quoted 3 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +3 -0
+		spi0 = &ecspi4;
+		spi3 = &ecspi1;
+	};

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 221

Quoted 10 lines

+&iomuxc {

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+	pinctrl-0 = <&pinctrl_hog_maveo_box>;
+	pinctrl-names = "default";
+
+	pinctrl_hog_maveo_box: hog-maveo-box-grp {
+		fsl,pins = <
+			MX6UL_PAD_GPIO1_IO05__GPIO1_IO05	0x400120b0 /* BUTTON_USER */
+			MX6UL_PAD_GPIO1_IO08__GPIO1_IO08	0x400120b0 /* BUTTON_RESET */
+			MX6UL_PAD_CSI_PIXCLK__GPIO4_IO18	0x400120b0 /* LED_G */
+			MX6UL_PAD_CSI_DATA02__GPIO4_IO23	0x400120b0 /* LED_B */

Should the "SION(1 << 30): Software Input On Field." bit really be set on GPIOs which are OUTPUT (like LEDs) ?

[...]

author maintainer
#3 lore raw

RE: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 16 lines · Christoph Niedermaier

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Quoted 2 lines

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

Quoted 18 lines
Quoted 4 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +3 -0
+             spi0 = &ecspi4;
+             spi3 = &ecspi1;
+     };

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 221

Quoted 10 lines

+&iomuxc {

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+     pinctrl-0 = <&pinctrl_hog_maveo_box>;
+     pinctrl-names = "default";
+
+     pinctrl_hog_maveo_box: hog-maveo-box-grp {
+             fsl,pins = <
+                     MX6UL_PAD_GPIO1_IO05__GPIO1_IO05        0x400120b0 /* BUTTON_USER */
+                     MX6UL_PAD_GPIO1_IO08__GPIO1_IO08        0x400120b0 /* BUTTON_RESET */
+                     MX6UL_PAD_CSI_PIXCLK__GPIO4_IO18        0x400120b0 /* LED_G */
+                     MX6UL_PAD_CSI_DATA02__GPIO4_IO23        0x400120b0 /* LED_B */
Quoted 2 lines

Should the "SION(1 << 30): Software Input On Field." bit really be set on GPIOs which are OUTPUT (like LEDs) ?

I think for INPUT it doesn't matter, but for OUTPUT I then have a feedback.

Regards
Christoph

#4 lore raw

Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

Quoted 18 lines · Christoph Niedermaier

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 16 lines · Christoph Niedermaier

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Quoted 5 lines
Quoted 2 lines

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

+CC Ulf , I vaguely recall some discussion about this enumeration and I am not sure one can really depend on that.

author maintainer
#5 lore raw

RE: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 8:47 PM

Quoted 19 lines · Christoph Niedermaier
Quoted 18 lines

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 16 lines · Christoph Niedermaier

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

+CC Ulf , I vaguely recall some discussion about this enumeration and I am not sure one can really depend on that.

That why I think it good to have a defined number for mmcblk devices on an embedded system. An excerpt from [1]:

Alternative solutions like PARTUUIDs do not cover the case where multiple mmcblk devices contain the same image. This is a common issue on devices that can boot both from eMMC (for regular boot) and SD cards (as a temporary boot medium for development). When a firmware image is installed to eMMC after a test boot via SD card, there will be no reliable way to refer to a specific device using (PART)UUIDs oder LABELs

[1] https://patchwork.kernel.org/project/linux-mmc/patch/[email protected]/

So far I have never had a problem with numbering mmcblk devices via aliases.

Regards
Christoph

#6 lore raw

Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

Quoted 24 lines · Christoph Niedermaier

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 8:47 PM

Quoted 22 lines · Christoph Niedermaier
Quoted 21 lines

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 18 lines · Christoph Niedermaier

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

+CC Ulf , I vaguely recall some discussion about this enumeration and I am not sure one can really depend on that.

That why I think it good to have a defined number for mmcblk devices on an embedded system. An excerpt from [1]:

I might be misremembering this, but could it be that, if any non-OF SDMMC controller probes early and hogs the /dev/mmcblk2 before the OF ones have a chance to probe, then the OF ones would fail to probe ?

Quoted 2 lines

Alternative solutions like PARTUUIDs do not cover the case where multiple mmcblk devices contain the same image.

I agree, this is indeed a downside of PARTUUID .

Quoted 6 lines

This is a common issue on devices
that can boot both from eMMC (for regular boot) and SD cards (as a temporary boot medium for development). When a firmware image is installed to eMMC after a test boot via SD card, there will be no reliable way to refer to a specific device using (PART)UUIDs oder LABELs

This can be solved by the installer updating the PARTUUID on the eMMC however.

Quoted 3 lines

[1] https://patchwork.kernel.org/project/linux-mmc/patch/[email protected]/

So far I have never had a problem with numbering mmcblk devices via aliases.

Based on the above, I don't think either the aliases or PARTUUID is a perfect solution, but the aliases should be fine for mx6ull at least? So I think we can conclude this discussion thread ?

author maintainer
#7 lore raw

RE: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

From: Marek Vasut [mailto:[email protected]]
Sent: Thursday, April 6, 2023 4:10 PM

Quoted 53 lines · Christoph Niedermaier
Quoted 24 lines

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 8:47 PM

Quoted 22 lines · Christoph Niedermaier
Quoted 21 lines

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 18 lines · Christoph Niedermaier

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

+CC Ulf , I vaguely recall some discussion about this enumeration and I am not sure one can really depend on that.

That why I think it good to have a defined number for mmcblk devices on an embedded system. An excerpt from [1]:

I might be misremembering this, but could it be that, if any non-OF SDMMC controller probes early and hogs the /dev/mmcblk2 before the OF ones have a chance to probe, then the OF ones would fail to probe ?

Quoted 2 lines

Alternative solutions like PARTUUIDs do not cover the case where multiple mmcblk devices contain the same image.

I agree, this is indeed a downside of PARTUUID .

Quoted 6 lines

This is a common issue on devices
that can boot both from eMMC (for regular boot) and SD cards (as a temporary boot medium for development). When a firmware image is installed to eMMC after a test boot via SD card, there will be no reliable way to refer to a specific device using (PART)UUIDs oder LABELs

This can be solved by the installer updating the PARTUUID on the eMMC however.

Quoted 7 lines
Quoted 3 lines

[1] https://patchwork.kernel.org/project/linux-mmc/patch/[email protected]/

So far I have never had a problem with numbering mmcblk devices via aliases.

Based on the above, I don't think either the aliases or PARTUUID is a perfect solution, but the aliases should be fine for mx6ull at least? So I think we can conclude this discussion thread ?

Yes, I will send a new version with the changes on the first patch.

Regards
Christoph

#8 lore raw

Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

Quoted 57 lines · Christoph Niedermaier

From: Marek Vasut [mailto:[email protected]]
Sent: Thursday, April 6, 2023 4:10 PM

Quoted 55 lines · Christoph Niedermaier
Quoted 24 lines

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 8:47 PM

Quoted 22 lines · Christoph Niedermaier
Quoted 21 lines

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 18 lines · Christoph Niedermaier

[...]

Review

Quoted 9 lines
(quoted diff) +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

+CC Ulf , I vaguely recall some discussion about this enumeration and I am not sure one can really depend on that.

That why I think it good to have a defined number for mmcblk devices on an embedded system. An excerpt from [1]:

I might be misremembering this, but could it be that, if any non-OF SDMMC controller probes early and hogs the /dev/mmcblk2 before the OF ones have a chance to probe, then the OF ones would fail to probe ?

Quoted 2 lines

Alternative solutions like PARTUUIDs do not cover the case where multiple mmcblk devices contain the same image.

I agree, this is indeed a downside of PARTUUID .

Quoted 6 lines

This is a common issue on devices
that can boot both from eMMC (for regular boot) and SD cards (as a temporary boot medium for development). When a firmware image is installed to eMMC after a test boot via SD card, there will be no reliable way to refer to a specific device using (PART)UUIDs oder LABELs

This can be solved by the installer updating the PARTUUID on the eMMC however.

Quoted 2 lines

[1] https://patchwork.kernel.org/project/linux-mmc/patch/[email protected]/

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

So far I have never had a problem with numbering mmcblk devices via aliases.

Based on the above, I don't think either the aliases or PARTUUID is a perfect solution, but the aliases should be fine for mx6ull at least? So I think we can conclude this discussion thread ?

Yes, I will send a new version with the changes on the first patch.

Thank you

#9 lore raw

Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

In reply to Christoph Niedermaier
Quoted 18 lines · Christoph Niedermaier

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 16 lines · Christoph Niedermaier

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Quoted 5 lines
Quoted 2 lines

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

That's not the reason to have aliases. The number should match numbering in your datasheet/schematics/user-guide, not what your software wants.

Use PARTUUID for SW dependencies.

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

Quoted 22 lines · Krzysztof Kozlowski
Quoted 21 lines · Christoph Niedermaier

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 18 lines · Christoph Niedermaier

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

Quoted 7 lines
Quoted 2 lines

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

That's not the reason to have aliases. The number should match numbering in your datasheet/schematics/user-guide, not what your software wants.

Use PARTUUID for SW dependencies.

Regarding the PARTUUID, Christoph raised a valid concern I think. These machines can come with A/B update scheme, where the PARTUUID could become identical between two partitions. Or, you can write the same image to both eMMC and SD card. I don't think PARTUUID is the silver bullet solution, but I agree the enumeration is a great solution either.

#11 lore raw

Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor: Add Marantec maveo box

Quoted 29 lines · Marek Vasut
Quoted 28 lines · Krzysztof Kozlowski
Quoted 18 lines · Christoph Niedermaier

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:25 PM

Quoted 16 lines · Christoph Niedermaier

[...]

arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts line 24

Quoted 9 lines
arch/arm/boot/dts/imx6ull-dhcor-maveo-box.dts new file +9 -0
+/ {
+     model = "DH electronics i.MX6ULL DHCOR on maveo box";
+     compatible = "dh,imx6ull-dhcor-maveo-box", "dh,imx6ull-dhcor-som",
+                  "fsl,imx6ull";
+
+     aliases {
+             /delete-property/ mmc0; /* Avoid double definitions */
+             /delete-property/ mmc1;
+             mmc2 = &usdhc2; /* eMMC should be mmc2 */

Why not mmc0 ?

Quoted 5 lines
Quoted 2 lines

Use root=PARTUUID= when booting to avoid any dependency on root=/dev/mmcblk2pN enumeration.

This is due to software interchangeability with the DHCOM i.MX6ULL, where the eMMC is always mmc2.

That's not the reason to have aliases. The number should match numbering in your datasheet/schematics/user-guide, not what your software wants.

Quoted 7 lines
Quoted 1 line

Use PARTUUID for SW dependencies.

Regarding the PARTUUID, Christoph raised a valid concern I think. These machines can come with A/B update scheme, where the PARTUUID could become identical between two partitions. Or, you can write the same image to both eMMC and SD card. I don't think PARTUUID is the silver bullet solution, but I agree the enumeration is a great solution either.

If you remove other aliases it means it comes only with emmc, right? One storage. Then any A/B means you have two partitions. Two partitions will have different PARTUUID as partition number is there. You can also use PARTLABEL=root_a (root_b). That's BTW easy way to switch between A/B partitions.

Best regards,
Krzysztof

#12 lore raw
In reply to Christoph Niedermaier
Quoted 26 lines · Christoph Niedermaier

Add Marantec maveo box. The system is used to get a smart conntection to a door drive. The core of this system is a soldered i.MX6ULL DHCOR SoM from DH electronics.

---
Cc: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Shawn Guo <[email protected]>
CC: Li Yang <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]

---
  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
  1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -0
index b175f2b1bd30..c95254c57571 100644

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 722

Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +3 -0
@@ -717,6 +717,12 @@ properties:
            - const: dh,imx6ull-dhcor-som
            - const: fsl,imx6ull
 
+      - description: i.MX6ULL DHCOR SoM based Boards
+        items:
+          - const: dh,imx6ull-dhcor-maveo-box

This should be using Marantec vendor prefix, not "dh," prefix I think ?

You should add that to Documentation/devicetree/bindings/vendor-prefixes.yaml first, and then use it here.

author maintainer
#13 lore raw

From: Marek Vasut [mailto:[email protected]]
Sent: Wednesday, April 5, 2023 6:26 PM

Quoted 36 lines · Christoph Niedermaier
Quoted 26 lines

Add Marantec maveo box. The system is used to get a smart conntection to a door drive. The core of this system is a soldered i.MX6ULL DHCOR SoM from DH electronics.

---
Cc: Rob Herring <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Shawn Guo <[email protected]>
CC: Li Yang <[email protected]>
Cc: Marek Vasut <[email protected]>
Cc: Fabio Estevam <[email protected]>
Cc: NXP Linux Team <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
To: [email protected]

---
  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
  1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +0 -0
index b175f2b1bd30..c95254c57571 100644

Documentation/devicetree/bindings/arm/fsl.yaml properties: · line 722

Quoted 6 lines
Documentation/devicetree/bindings/arm/fsl.yaml +3 -0
@@ -717,6 +717,12 @@ properties:
            - const: dh,imx6ull-dhcor-som
            - const: fsl,imx6ull
 
+      - description: i.MX6ULL DHCOR SoM based Boards
+        items:
+          - const: dh,imx6ull-dhcor-maveo-box

This should be using Marantec vendor prefix, not "dh," prefix I think ?

Quoted 3 lines

You should add that to Documentation/devicetree/bindings/vendor-prefixes.yaml first, and then use it here.

I will change it in version 2.
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel