i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller
Subsystems (3)
PATCH 1/1 i2c: designware: Add a new ACPI HID for GOOG5000 I2C controller
Define a new ACPI HID for GOOG5000 as used on Google Axion.
This has been validated on Silicon.
--- drivers/i2c/busses/i2c-designware-platdrv.c | 1 + 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-designware-platdrv.c +1 -0
@@ -268,6 +268,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = { { "AMDI0510", 0 }, { "APMC0D0F", 0 }, { "FUJI200B", 0 }, + { "GOOG5000", 0 }, { "HISI02A1", 0 }, { "HISI02A2", 0 }, { "HISI02A3", 0 },
Signature · 1 line
2.53.0.473.g4a7958ca14-goog
Andy Shevchenko
reviewerQuoted 7 lines · Moritz Fischer
Define a new ACPI HID for GOOG5000 as used on Google Axion.
This has been validated on Silicon.
Cc Mika Westerberg <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Jan Dabros <[email protected]>
Please, put Cc list...
Quoted 2 lines
Signed-off-by Moritz Fischer <[email protected]>---
...somewhere here. It will have the same effect on the email. But the positive outcome is the noise reduction in the commit message.
See also this discussion (patch 18 subthread):
https://lore.kernel.org/lkml/[email protected]/
Quoted 2 lines
drivers/i2c/busses/i2c-designware-platdrv.c | 1 + 1 file changed, 1 insertion(+)
...
drivers/i2c/busses/i2c-designware-platdrv.c static const struct acpi_device_id dw_i2c_acpi_match[] = { · line 271
Quoted 1 line
drivers/i2c/busses/i2c-designware-platdrv.c +1
-0+ { "GOOG5000", 0 },
The ID seems legit, but we need an ACPI excerpt from DSDT to show how it's described (just important pieces of the respective Device() object) and better reference to the device / platform in question: Is it already on the market?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi Andy,
Quoted 11 lines · Andy Shevchenko
Quoted 7 lines · Moritz Fischer
Define a new ACPI HID for GOOG5000 as used on Google Axion.
This has been validated on Silicon.
Cc Mika Westerberg <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Jan Dabros <[email protected]>Please, put Cc list...
Quoted 8 lines
Quoted 2 lines
Signed-off-by Moritz Fischer <[email protected]>---
...somewhere here. It will have the same effect on the email. But the positive outcome is the noise reduction in the commit message.
See also this discussion (patch 18 subthread):
https://lore.kernel.org/lkml/[email protected]/
Ok, fair. Do you want me to resend or do you want to patch it when applying?
Quoted 10 lines
Quoted 2 lines
drivers/i2c/busses/i2c-designware-platdrv.c | 1 + 1 file changed, 1 insertion(+)...
drivers/i2c/busses/i2c-designware-platdrv.c static const struct acpi_device_id dw_i2c_acpi_match[] = { · line 271
Quoted 1 line
drivers/i2c/busses/i2c-designware-platdrv.c +1
-0+ { "GOOG5000", 0 },The ID seems legit, but we need an ACPI excerpt from DSDT to show how it's described (just important pieces of the respective
Device()object) and better reference to the device / platform in question: Is it already on the market?
I pulled this out of the EDK2 code, I hope this satisfies your request.
Device (I2C0)
{
Name (_HID, "GOOG5000")
Name (_UID, 0x00)
Method (_STA) {
Return (0xf)
}
Name (_CRS, ResourceTemplate ()
{
QWordMemory (
ResourceProducer,
PosDecode,
MinFixed,
MaxFixed,
NonCacheable,
ReadWrite,
0x0,
0xA02048000,
0xA020480FF,
0x000000000,
0x000000100
)
Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive)
{
109
}
})
...
}This is being used by SoCs powering Google's Axion product line.
I can't go into more details on timelines etc, but they *are* real products.
Thanks,
Moritz
Quoted 3 lines
--
With Best Regards,
Andy Shevchenko
Andy Shevchenko
reviewerQuoted 19 lines · Moritz Fischer
Quoted 17 lines · Andy Shevchenko
Quoted 7 lines · Moritz Fischer
Define a new ACPI HID for GOOG5000 as used on Google Axion.
This has been validated on Silicon.
Cc Mika Westerberg <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Jan Dabros <[email protected]>Please, put Cc list...
Quoted 2 lines
Signed-off-by Moritz Fischer <[email protected]>---
...somewhere here. It will have the same effect on the email. But the positive
outcome is the noise reduction in the commit message.
Quoted 5 lines
Quoted 2 lines
See also this discussion (patch 18 subthread):
https://lore.kernel.org/lkml/[email protected]/Ok, fair. Do you want me to resend or do you want to patch it when applying?
I'm not a maintainer, so from my p.o.v. the safest option is to send a new version with all data gathered and put properly (Cc list, ACPI excerpt, et cetera) in one place.
...
Quoted 40 lines
Quoted 7 lines
drivers/i2c/busses/i2c-designware-platdrv.c static const struct acpi_device_id dw_i2c_acpi_match[] = { · line 271
Quoted 1 line
drivers/i2c/busses/i2c-designware-platdrv.c +1
-0+ { "GOOG5000", 0 },The ID seems legit, but we need an ACPI excerpt from DSDT to show how it's described (just important pieces of the respective
Device()object) and better
reference to the device / platform in question: Is it already on the market?I pulled this out of the EDK2 code, I hope this satisfies your request.
Device (I2C0) { Name (_HID, "GOOG5000") Name (_UID, 0x00) Method (_STA) { Return (0xf) } Name (_CRS, ResourceTemplate () { QWordMemory ( ResourceProducer, PosDecode, MinFixed, MaxFixed, NonCacheable, ReadWrite, 0x0, 0xA02048000, 0xA020480FF, 0x000000000, 0x000000100 ) Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { 109 } }) ... }
Quoted 4 lines
This is being used by SoCs powering Google's Axion product line.
I can't go into more details on timelines etc, but they *are* real products.
Good, just collect summary of this with the ACPI excerpt in the comment field (after '---' line) in a new version, so we will have it for the record in the ML archive in one place.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 23 lines · Andy Shevchenko
Quoted 22 lines · Moritz Fischer
Quoted 20 lines · Andy Shevchenko
Quoted 7 lines · Moritz Fischer
Define a new ACPI HID for GOOG5000 as used on Google Axion.
This has been validated on Silicon.
Cc Mika Westerberg <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Jan Dabros <[email protected]>Please, put Cc list...
Quoted 2 lines
Signed-off-by Moritz Fischer <[email protected]>---
...somewhere here. It will have the same effect on the email. But the positive
outcome is the noise reduction in the commit message.See also this discussion (patch 18 subthread):
https://lore.kernel.org/lkml/[email protected]/
Quoted 6 lines
Quoted 2 lines
Ok, fair. Do you want me to resend or do you want to patch it when applying?
I'm not a maintainer, so from my p.o.v. the safest option is to send a new version with all data gathered and put properly (Cc list, ACPI excerpt, et cetera) in one place.
I don't think the excerpt adds any real value. Only thing that really matters is that the ACPI ID is "correct" meaning that it is properly assigned by the owner and that's true here. For the CC list does not matter to me but if you want to resend with that fixed no problem.
Either way,
Andy Shevchenko
reviewerQuoted 24 lines · Mika Westerberg
Quoted 23 lines · Andy Shevchenko
Quoted 22 lines · Moritz Fischer
Quoted 20 lines · Andy Shevchenko
Quoted 7 lines · Moritz Fischer
Define a new ACPI HID for GOOG5000 as used on Google Axion.
This has been validated on Silicon.
Cc Mika Westerberg <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Jan Dabros <[email protected]>Please, put Cc list...
Quoted 2 lines
Signed-off-by Moritz Fischer <[email protected]>---
...somewhere here. It will have the same effect on the email. But the positive
outcome is the noise reduction in the commit message.See also this discussion (patch 18 subthread):
https://lore.kernel.org/lkml/[email protected]/
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Ok, fair. Do you want me to resend or do you want to patch it when applying?
I'm not a maintainer, so from my p.o.v. the safest option is to send a new version with all data gathered and put properly (Cc list, ACPI excerpt, et cetera) in one place.
I don't think the excerpt adds any real value.
It doesn't per se in the commit message. I am asking to have it in the comment block for the record (in the mailing list archives).
Quoted 8 lines
Only thing that really
matters is that the ACPI ID is "correct" meaning that it is properly assigned by the owner and that's true here. For the CC list does not matter to me but if you want to resend with that fixed no problem.Either way,
Acked-by Mika Westerberg <[email protected]>
Thanks!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 32 lines · Andy Shevchenko
Quoted 12 lines · Mika Westerberg
Quoted 11 lines · Andy Shevchenko
Quoted 10 lines · Moritz Fischer
Quoted 8 lines · Andy Shevchenko
Quoted 7 lines · Moritz Fischer
Define a new ACPI HID for GOOG5000 as used on Google Axion.
This has been validated on Silicon.
Cc Mika Westerberg <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Jan Dabros <[email protected]>Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Please, put Cc list...
Quoted 2 lines
Signed-off-by Moritz Fischer <[email protected]>---
...somewhere here. It will have the same effect on the email. But
the
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
positive
outcome is the noise reduction in the commit message.See also this discussion (patch 18 subthread):
https://lore.kernel.org/lkml/[email protected]/
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Ok, fair. Do you want me to resend or do you want to patch it when applying?
I'm not a maintainer, so from my p.o.v. the safest option is to send
a new
Quoted 8 lines
Quoted 1 line
Quoted 1 line
version with all data gathered and put properly (Cc list, ACPI
excerpt, et
Quoted 3 lines
Quoted 1 line
cetera) in one place.
I don't think the excerpt adds any real value.
It doesn't per se in the commit message. I am asking to have it in the comment block for the record (in the mailing list archives).
Will do next time. I think now we have already a record in this thread that'll get archived.
Quoted 9 lines
Quoted 3 lines
Only thing that really
matters is that the ACPI ID is "correct" meaning that it is properly assigned by the owner and that's true here. For the CC list does notmatter
Quoted 5 lines
to me but if you want to resend with that fixed no problem.
Either way,
Acked-by Mika Westerberg <[email protected]>
Ok, will leave it as is then. Thanks
- Moritz