Skip to contentSkip to conversation

ARM: dts: stm32: Add alternate pinmux for DCMI pins

PATCH In review Marek Vasut 3 participants 7 messages Aug 22, 2020 – Aug 28, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Add alternate pinmux for DCMI pins

Add another mux option for DCMI pins, this is used on AV96 board.

Upstream-Status: Work-in-progress

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 37 ++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +37 -0
index 1c4c3d32efae..d6847787c65a 100644
@@ -118,6 +118,43 @@ pins {
 		};
 	};
 
+	dcmi_pins_b: dcmi-1 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
+				 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
+				 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
+				 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
+				 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
+				 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
+				 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
+				 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
+				 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
+				 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
+				 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
+				 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
+				 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
+			bias-pull-up;
+		};
+	};
+
+	dcmi_sleep_pins_b: dcmi-sleep-1 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
+				 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
+				 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
+				 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
+				 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
+				 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */
+				 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
+				 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
+				 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
+				 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
+				 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
+				 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
+				 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
+		};
+	};
+
 	ethernet0_rgmii_pins_a: rgmii-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('G', 5, AF11)>, /* ETH_RGMII_CLK125 */
Signature · 7 lines
2.28.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw

Hi,

Quoted 3 lines · Marek Vasut

Add another mux option for DCMI pins, this is used on AV96 board.

Upstream-Status: Work-in-progress

Is this a left-over? What is its meaning here?

Cheers,

Quoted 61 lines
Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
 arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 37 ++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +37 -0
index 1c4c3d32efae..d6847787c65a 100644
@@ -118,6 +118,43 @@ pins {
 		};
 	};
 
+	dcmi_pins_b: dcmi-1 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
+				 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
+				 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
+				 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
+				 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
+				 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
+				 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
+				 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
+				 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
+				 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
+				 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
+				 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
+				 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
+			bias-pull-up;
+		};
+	};
+
+	dcmi_sleep_pins_b: dcmi-sleep-1 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
+				 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
+				 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
+				 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
+				 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
+				 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */
+				 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
+				 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
+				 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
+				 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
+				 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
+				 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
+				 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
+		};
+	};
+
 	ethernet0_rgmii_pins_a: rgmii-0 {
 		pins1 {
 			pinmux = <STM32_PINMUX('G', 5, AF11)>, /* ETH_RGMII_CLK125 */
Signature · 9 lines
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#2 lore raw
Quoted 1 line · Ahmad Fatoum

Hi,

Hi,

Quoted 6 lines · Marek Vasut
Quoted 3 lines

Add another mux option for DCMI pins, this is used on AV96 board.

Upstream-Status: Work-in-progress

Is this a left-over? What is its meaning here?

Yep, it's to track the patch status when backporting. Should be removed.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
In reply to Marek Vasut

Hi Marek

Quoted 50 lines · Marek Vasut

Add another mux option for DCMI pins, this is used on AV96 board.

Upstream-Status: Work-in-progress

Cc Alexandre Torgue <[email protected]>
Cc Manivannan Sadhasivam <[email protected]>
Cc Maxime Coquelin <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
  arch/arm/boot/dts/stm32mp15-pinctrl.dtsi | 37 ++++++++++++++++++++++++
  1 file changed, 37 insertions(+)
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +27 -0
index 1c4c3d32efae..d6847787c65a 100644
@@ -118,6 +118,43 @@ pins {
  		};
  	};
 
+	dcmi_pins_b: dcmi-1 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */
+				 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */
+				 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */
+				 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */
+				 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */
+				 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */
+				 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */
+				 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */
+				 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */
+				 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */
+				 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */
+				 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */
+				 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */
+			bias-pull-up;
+		};
+	};
+
+	dcmi_sleep_pins_b: dcmi-sleep-1 {
+		pins {
+			pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
+				 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
+				 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
+				 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
+				 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
+				 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */

arch/arm/boot/dts/stm32mp15-pinctrl.dtsi pins { · line 157

Quoted 10 lines
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +10 -0
+				 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
+				 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
+				 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
+				 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
+				 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
+				 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
+				 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
+		};
+	};
+

Defined but not used. Do you have another patch in pipe ?

regards
alex

arch/arm/boot/dts/stm32mp15-pinctrl.dtsi pins { · line 160

Quoted 4 lines
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +0 -0
  	ethernet0_rgmii_pins_a: rgmii-0 {
  		pins1 {
  			pinmux = <STM32_PINMUX('G', 5, AF11)>, /* ETH_RGMII_CLK125 */

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

[...]

Quoted 30 lines
Quoted 30 lines

+        pins {
+            pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */ +                 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */ +                 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */ +                 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */ +                 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */ +                 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */ +                 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */ +                 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */ +                 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */ +                 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */ +                 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */ +                 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */ +                 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */ +            bias-pull-up;
+        };
+    };
+
+    dcmi_sleep_pins_b: dcmi-sleep-1 {
+        pins {
+            pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */ +                 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */ +                 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */ +                 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */ +                 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */ +                 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */ +                 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */ +                 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */ +                 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */ +                 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */

Quoted 8 lines
Quoted 6 lines

+                 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */ +                 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */ +                 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */ +        };
+    };
+

Defined but not used. Do you have another patch in pipe ?

Yeah, for camera on the AV96, but that depends on DCMI media patches to be usable. Same for the RCC patches.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#5 lore raw

Hi,

Quoted 46 lines · Marek Vasut
Quoted 1 line · Alexandre Torgue

Hi Marek

Hi,

[...]

Quoted 30 lines
Quoted 30 lines

+        pins {
+            pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */ +                 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */ +                 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */ +                 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */ +                 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */ +                 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */ +                 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */ +                 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */ +                 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */ +                 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */ +                 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */ +                 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */ +                 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */ +            bias-pull-up;
+        };
+    };
+
+    dcmi_sleep_pins_b: dcmi-sleep-1 {
+        pins {
+            pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */ +                 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */ +                 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */ +                 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */ +                 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */ +                 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */ +                 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */ +                 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */ +                 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */ +                 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */

Quoted 8 lines
Quoted 6 lines

+                 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */ +                 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */ +                 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */ +        };
+    };
+

Defined but not used. Do you have another patch in pipe ?

Quoted 2 lines

Yeah, for camera on the AV96, but that depends on DCMI media patches to be usable. Same for the RCC patches.

Ok so I prefer to wait for other DCMI patches before merging those ones.

Regards
Alex

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#6 lore raw
Quoted 1 line · Alexandre Torgue

Hi,

Hi,

Quoted 47 lines · Marek Vasut
Quoted 46 lines · Alexandre Torgue
Quoted 1 line

Hi Marek

Hi,

[...]

Quoted 38 lines
Quoted 26 lines

+        pins {
+            pinmux = <STM32_PINMUX('A', 4,  AF13)>,/* DCMI_HSYNC */ +                 <STM32_PINMUX('B', 7,  AF13)>,/* DCMI_VSYNC */ +                 <STM32_PINMUX('A', 6,  AF13)>,/* DCMI_PIXCLK */ +                 <STM32_PINMUX('A', 9,  AF13)>,/* DCMI_D0 */ +                 <STM32_PINMUX('H', 10, AF13)>,/* DCMI_D1 */ +                 <STM32_PINMUX('E', 0, AF13)>,/* DCMI_D2 */ +                 <STM32_PINMUX('E', 1, AF13)>,/* DCMI_D3 */ +                 <STM32_PINMUX('H', 14, AF13)>,/* DCMI_D4 */ +                 <STM32_PINMUX('I', 4,  AF13)>,/* DCMI_D5 */ +                 <STM32_PINMUX('I', 6,  AF13)>,/* DCMI_D6 */ +                 <STM32_PINMUX('E', 6,  AF13)>,/* DCMI_D7 */ +                 <STM32_PINMUX('I', 1,  AF13)>,/* DCMI_D8 */ +                 <STM32_PINMUX('H', 7,  AF13)>;/* DCMI_D9 */ +            bias-pull-up;
+        };
+    };

arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +9 -0
+
+    dcmi_sleep_pins_b: dcmi-sleep-1 {
+        pins {
+            pinmux = <STM32_PINMUX('A', 4,  ANALOG)>,/* DCMI_HSYNC */
+                 <STM32_PINMUX('B', 7,  ANALOG)>,/* DCMI_VSYNC */
+                 <STM32_PINMUX('A', 6,  ANALOG)>,/* DCMI_PIXCLK */
+                 <STM32_PINMUX('A', 9,  ANALOG)>,/* DCMI_D0 */
+                 <STM32_PINMUX('H', 10, ANALOG)>,/* DCMI_D1 */
+                 <STM32_PINMUX('E', 0, ANALOG)>,/* DCMI_D2 */

arch/arm/boot/dts/stm32mp15-pinctrl.dtsi pins { · line 157

Quoted 10 lines
arch/arm/boot/dts/stm32mp15-pinctrl.dtsi +10 -0
+                 <STM32_PINMUX('E', 1, ANALOG)>,/* DCMI_D3 */
+                 <STM32_PINMUX('H', 14, ANALOG)>,/* DCMI_D4 */
+                 <STM32_PINMUX('I', 4,  ANALOG)>,/* DCMI_D5 */
+                 <STM32_PINMUX('I', 6,  ANALOG)>,/* DCMI_D6 */
+                 <STM32_PINMUX('E', 6,  ANALOG)>,/* DCMI_D7 */
+                 <STM32_PINMUX('I', 1,  ANALOG)>,/* DCMI_D8 */
+                 <STM32_PINMUX('H', 7,  ANALOG)>;/* DCMI_D9 */
+        };
+    };
+

Defined but not used. Do you have another patch in pipe ?

Quoted 4 lines
Quoted 2 lines

Yeah, for camera on the AV96, but that depends on DCMI media patches to be usable. Same for the RCC patches.

Ok so I prefer to wait for other DCMI patches before merging those ones.

Fine by me.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel