Skip to contentSkip to conversation

dt-bindings: mfd: Convert lp873x.txt to json-schema

PATCH Applied Nathan Morrisson 5 participants 6 messages Apr 29, 2024 – Jun 13, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: mfd: Convert lp873x.txt to json-schema

Convert the lp873x binding to DT schema format. The gpio-controller and #gpio-cells properties were removed from required because using the device as a GPIO controller is optional.

---
v2:
- Added "mfd:" to subject prefix
- Added vendor TI to file name
- Updated title to match hardware
- Removed | where we do not need to preserve formatting
- Added *-in-supply back to required properties, they should not have been removed
- Added explanation for why gpio properties were removed from required
- Updated the example to be more generic and got rid of unnecessary i2c node

 .../devicetree/bindings/mfd/lp873x.txt        |  67 -----------
 .../devicetree/bindings/mfd/ti,lp8732.yaml    | 112 ++++++++++++++++++
 2 files changed, 112 insertions(+), 67 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mfd/lp873x.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/ti,lp8732.yaml
Documentation/devicetree/bindings/mfd/lp873x.txt deleted +0 -67
deleted file mode 100644
index ae9cf39bd101..000000000000
@@ -1,67 +0,0 @@
-TI LP873X PMIC MFD driver
-
-Required properties:
-  - compatible:	"ti,lp8732", "ti,lp8733"
-  - reg:		I2C slave address.
-  - gpio-controller:	Marks the device node as a GPIO Controller.
-  - #gpio-cells:	Should be two.  The first cell is the pin number and
-			the second cell is used to specify flags.
-			See ../gpio/gpio.txt for more information.
-  - xxx-in-supply:	Phandle to parent supply node of each regulator
-			populated under regulators node. xxx can be
-			buck0, buck1, ldo0 or ldo1.
-  - regulators:	List of child nodes that specify the regulator
-			initialization data.
-Example:
-
-pmic: lp8733@60 {
-	compatible = "ti,lp8733";
-	reg = <0x60>;
-	gpio-controller;
-	#gpio-cells = <2>;
-
-	buck0-in-supply = <&vsys_3v3>;
-	buck1-in-supply = <&vsys_3v3>;
-	ldo0-in-supply = <&vsys_3v3>;
-	ldo1-in-supply = <&vsys_3v3>;
-
-	regulators {
-		lp8733_buck0: buck0 {
-			regulator-name = "lp8733-buck0";
-			regulator-min-microvolt = <800000>;
-			regulator-max-microvolt = <1400000>;
-			regulator-min-microamp = <1500000>;
-			regulator-max-microamp = <4000000>;
-			regulator-ramp-delay = <10000>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-
-		lp8733_buck1: buck1 {
-			regulator-name = "lp8733-buck1";
-			regulator-min-microvolt = <800000>;
-			regulator-max-microvolt = <1400000>;
-			regulator-min-microamp = <1500000>;
-			regulator-max-microamp = <4000000>;
-			regulator-ramp-delay = <10000>;
-			regulator-boot-on;
-			regulator-always-on;
-		};
-
-		lp8733_ldo0: ldo0 {
-			regulator-name = "lp8733-ldo0";
-			regulator-min-microvolt = <800000>;
-			regulator-max-microvolt = <3000000>;
-			regulator-boot-on;
-			regulator-always-on;
-		};
-
-		lp8733_ldo1: ldo1 {
-			regulator-name = "lp8733-ldo1";
-			regulator-min-microvolt = <800000>;
-			regulator-max-microvolt = <3000000>;
-			regulator-always-on;
-			regulator-boot-on;
-		};
-	};
-};
Documentation/devicetree/bindings/mfd/ti,lp8732.yaml new file +112 -0

112 lines not on this page · raw message

Signature · 1 line
2.25.1
#1 lore raw

PATCH v2 2/2 arm64: dts: ti: phycore-am64: Add PMIC

Add a PMIC node to the phycore-am64 device tree.

---
v2: No change

 .../boot/dts/ti/k3-am64-phycore-som.dtsi      | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi +44 -0
index 125e507966fb..2c3b20ddfb8b 100644
@@ -265,6 +265,50 @@ i2c_som_rtc: rtc@52 {
 		interrupts = <70 IRQ_TYPE_EDGE_FALLING>;
 		wakeup-source;
 	};
+
+	pmic@61 {
+		compatible = "ti,lp8733";
+		reg = <0x61>;
+
+		buck0-in-supply = <&vcc_5v0_som>;
+		buck1-in-supply = <&vcc_5v0_som>;
+		ldo0-in-supply = <&vdd_3v3>;
+		ldo1-in-supply = <&vdd_3v3>;
+
+		regulators {
+			vdd_core: buck0 {
+				regulator-name = "VDD_CORE";
+				regulator-min-microvolt = <750000>;
+				regulator-max-microvolt = <750000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			vdd_3v3: buck1 {
+				regulator-name = "VDD_3V3";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			vdd_1v8_ldo0: ldo0 {
+				regulator-name = "VDD_1V8_LDO0";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			vdda_1v8: ldo1 {
+				regulator-name = "VDDA_1V8";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+		};
+	};
 };
 
 &main_r5fss0_core0 {
Signature · 1 line
2.25.1
Reviewed-by on v2 2/2
#2 lore raw

Re: [PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC

Hi,

Am 29.04.24 um 21:58 schrieb Nathan Morrisson:

Quoted 3 lines

Add a PMIC node to the phycore-am64 device tree.

Please enable the PMIC driver in the arm64 defconfig.

REGULATOR_LP873X & CONFIG_MFD_TI_LP873X

Quoted 61 lines

---
v2: No change

  .../boot/dts/ti/k3-am64-phycore-som.dtsi      | 44 +++++++++++++++++++
  1 file changed, 44 insertions(+)
arch/arm64/boot/dts/ti/k3-am64-phycore-som.dtsi +44 -0
index 125e507966fb..2c3b20ddfb8b 100644
@@ -265,6 +265,50 @@ i2c_som_rtc: rtc@52 {
  		interrupts = <70 IRQ_TYPE_EDGE_FALLING>;
  		wakeup-source;
  	};
+
+	pmic@61 {
+		compatible = "ti,lp8733";
+		reg = <0x61>;
+
+		buck0-in-supply = <&vcc_5v0_som>;
+		buck1-in-supply = <&vcc_5v0_som>;
+		ldo0-in-supply = <&vdd_3v3>;
+		ldo1-in-supply = <&vdd_3v3>;
+
+		regulators {
+			vdd_core: buck0 {
+				regulator-name = "VDD_CORE";
+				regulator-min-microvolt = <750000>;
+				regulator-max-microvolt = <750000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			vdd_3v3: buck1 {
+				regulator-name = "VDD_3V3";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			vdd_1v8_ldo0: ldo0 {
+				regulator-name = "VDD_1V8_LDO0";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+
+			vdda_1v8: ldo1 {
+				regulator-name = "VDDA_1V8";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+		};
+	};
  };
 
  &main_r5fss0_core0 {
maintainer Applied
#3 lore raw

Re: (subset)[PATCH v2 2/2] arm64: dts: ti: phycore-am64: Add PMIC

In reply to Nathan Morrisson

Hi Nathan,

Quoted 9 lines · Nathan Morrisson

Add a PMIC node to the phycore-am64 device tree.

---
v2: No change

 .../boot/dts/ti/k3-am64-phycore-som.dtsi      | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)

I have applied the following to branch ti-k3-dts-next on [1]. Thank you!

[2/2] arm64: dts: ti: phycore-am64: Add PMIC

      commit: f3841b6a22f1a7635dc73b94b98596b94d153ed1

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh

Reviewed-by on v2 1/2
#4 lore raw
In reply to Nathan Morrisson
Quoted 5 lines · Nathan Morrisson

Convert the lp873x binding to DT schema format. The gpio-controller and #gpio-cells properties were removed from required because using the device as a GPIO controller is optional.

---

This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof

maintainer Applied
#5 lore raw

Re: (subset) [PATCH v2 1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema

In reply to Nathan Morrisson
Quoted 5 lines · Nathan Morrisson

Convert the lp873x binding to DT schema format. The gpio-controller and #gpio-cells properties were removed from required because using the device as a GPIO controller is optional.

Applied, thanks!

[1/2] dt-bindings: mfd: Convert lp873x.txt to json-schema

      commit: 7fcb2977c0b55c2d11aea3a6baa4c59d53709041

--
Lee Jones [李琼斯]