objtool: HAVE_XXHASH test uses HOSTCFLAGS.

PATCH Applied HONG Yifan 4 participants 5 messages Mar 3 – Mar 9

Subsystems (2)

Kbuild objtool

lore

Share & tools

lore

HONG Yifan

author

2026-03-03 01:03 UTC #0 lore raw

PATCH 1/1 objtool: HAVE_XXHASH test uses HOSTCFLAGS.

Previously, HAVE_XXHASH is tested by invoking HOSTCC without HOSTCFLAGS.

Consider the following scenario:

- The host machine has libxxhash installed
- We build the kernel with HOSTCFLAGS containing a --sysroot that does not have xxhash.h (for hermetic builds)

In this case, HAVE_XXHASH is set to y, but when it builds objtool with HOSTCFLAGS, because the --sysroot does not contain xxhash.h, the following error is raised:

<...>/common/tools/objtool/include/objtool/checksum_types.h:12:10: fatal error: 'xxhash.h' file not found
12 | #include <xxhash.h>

      |          ^~~~~~~~~~

To resolve the error, we test HAVE_XXHASH by invoking HOSTCC with HOSTCFLAGS.

Signed-off-by HONG Yifan <[email protected]>

---
 tools/objtool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/objtool/Makefile +1 -1

index 6964175abdfd..b8b8529f8ea9 100644
@@ -13,7 +13,7 @@ endif
 
 ifeq ($(ARCH_HAS_KLP),y)
 	HAVE_XXHASH = $(shell printf "$(pound)include <xxhash.h>\nXXH3_state_t *state;int main() {}" | \
-		      $(HOSTCC) -xc - -o /dev/null -lxxhash 2> /dev/null && echo y || echo n)
+		      $(HOSTCC) $(HOSTCFLAGS) -xc - -o /dev/null -lxxhash 2> /dev/null && echo y || echo n)
 	ifeq ($(HAVE_XXHASH),y)
 		BUILD_KLP	 := y
 		LIBXXHASH_CFLAGS := $(shell $(HOSTPKG_CONFIG) libxxhash --cflags 2>/dev/null) \

Signature · 1 line

2.53.0.473.g4a7958ca14-goog

Hong, Yifan

author

2026-03-03 01:17 UTC #1 lore raw

Quoted 39 lines · HONG Yifan

Previously, HAVE_XXHASH is tested by invoking HOSTCC without HOSTCFLAGS.
Consider the following scenario:
- The host machine has libxxhash installed
- We build the kernel with HOSTCFLAGS containing a --sysroot that does not have xxhash.h (for hermetic builds)
In this case, HAVE_XXHASH is set to y, but when it builds objtool with HOSTCFLAGS, because the --sysroot does not contain xxhash.h, the following error is raised:
<...>/common/tools/objtool/include/objtool/checksum_types.h:12:10: fatal error: 'xxhash.h' file not found
12 | #include <xxhash.h>
      |          ^~~~~~~~~~
To resolve the error, we test HAVE_XXHASH by invoking HOSTCC with HOSTCFLAGS.
Signed-off-by HONG Yifan <[email protected]>
---
 tools/objtool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/objtool/Makefile +1 -2
index 6964175abdfd..b8b8529f8ea9 100644
@@ -13,7 +13,7 @@ endif
 
 ifeq ($(ARCH_HAS_KLP),y)
        HAVE_XXHASH = $(shell printf "$(pound)include <xxhash.h>\nXXH3_state_t *state;int main() {}" | \
-                     $(HOSTCC) -xc - -o /dev/null -lxxhash 2> /dev/null && echo y || echo n)
+                     $(HOSTCC) $(HOSTCFLAGS) -xc - -o /dev/null -lxxhash 2> /dev/null && echo y || echo n)
        ifeq ($(HAVE_XXHASH),y)
                BUILD_KLP        := y
                LIBXXHASH_CFLAGS := $(shell $(HOSTPKG_CONFIG) libxxhash --cflags 2>/dev/null) \
--

Quoted 2 lines

2.53.0.473.g4a7958ca14-goog

Sorry, I forgot to cc [email protected] as well. Adding now. The original patch is at
https://lore.kernel.org/lkml/[email protected]

Carlos Llamas

Reviewed-by on v1 1/1

2026-03-03 18:24 UTC #2 lore raw

In reply to HONG Yifan

Quoted 14 lines · HONG Yifan' via kernel-team

Previously, HAVE_XXHASH is tested by invoking HOSTCC without HOSTCFLAGS.
Consider the following scenario:
- The host machine has libxxhash installed
- We build the kernel with HOSTCFLAGS containing a --sysroot that does not have xxhash.h (for hermetic builds)
In this case, HAVE_XXHASH is set to y, but when it builds objtool with HOSTCFLAGS, because the --sysroot does not contain xxhash.h, the following error is raised:
<...>/common/tools/objtool/include/objtool/checksum_types.h:12:10: fatal error: 'xxhash.h' file not found
12 | #include <xxhash.h>

Quoted 7 lines

      |          ^~~~~~~~~~
To resolve the error, we test HAVE_XXHASH by invoking HOSTCC with HOSTCFLAGS.
Signed-off-by HONG Yifan <[email protected]>
---

Reviewed-by Carlos Llamas <[email protected]>

Josh Poimboeuf

maintainer Applied

2026-03-05 20:02 UTC #3 lore raw

In reply to HONG Yifan

Quoted 12 lines · HONG Yifan

Previously, HAVE_XXHASH is tested by invoking HOSTCC without HOSTCFLAGS.
Consider the following scenario:
- The host machine has libxxhash installed
- We build the kernel with HOSTCFLAGS containing a --sysroot that does not have xxhash.h (for hermetic builds)
In this case, HAVE_XXHASH is set to y, but when it builds objtool with HOSTCFLAGS, because the --sysroot does not contain xxhash.h, the following error is raised:

Quoted 8 lines

<...>/common/tools/objtool/include/objtool/checksum_types.h:12:10: fatal error: 'xxhash.h' file not found
12 | #include <xxhash.h>
      |          ^~~~~~~~~~
To resolve the error, we test HAVE_XXHASH by invoking HOSTCC with HOSTCFLAGS.
Signed-off-by HONG Yifan <[email protected]>

Queued, thanks!

Signature · 1 line

Josh

tip-bot2 for HONG Yifan

merge bot Applied

2026-03-09 19:54 UTC #4 lore raw

[tip: objtool/urgent] objtool: Use HOSTCFLAGS for HAVE_XXHASH test

In reply to HONG Yifan

The following commit has been merged into the objtool/urgent branch of tip:

Commit-ID:     32234049107d012703d50547e815f198f147968b
Gitweb:        https://git.kernel.org/tip/32234049107d012703d50547e815f198f147968b
Author:        HONG Yifan <[email protected]>
AuthorDate:    Tue, 03 Mar 2026 01:03:39 
Committer:     Josh Poimboeuf <[email protected]>
CommitterDate: Fri, 06 Mar 2026 07:48:41 -08:00

objtool: Use HOSTCFLAGS for HAVE_XXHASH test

Previously, HAVE_XXHASH is tested by invoking HOSTCC without HOSTCFLAGS.

Consider the following scenario:

- The host machine has libxxhash installed
- We build the kernel with HOSTCFLAGS containing a --sysroot that does not have xxhash.h (for hermetic builds)

In this case, HAVE_XXHASH is set to y, but when it builds objtool with HOSTCFLAGS, because the --sysroot does not contain xxhash.h, the following error is raised:

<...>/common/tools/objtool/include/objtool/checksum_types.h:12:10: fatal error: 'xxhash.h' file not found
12 | #include <xxhash.h>

      |          ^~~~~~~~~~

To resolve the error, we test HAVE_XXHASH by invoking HOSTCC with HOSTCFLAGS.

Signed-off-by HONG Yifan <[email protected]>

Reviewed-by Carlos Llamas <[email protected]>

Link https://patch.msgid.link/[email protected] open here

Signed-off-by Josh Poimboeuf <[email protected]>

---
 tools/objtool/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

tools/objtool/Makefile +1 -1

index 6964175..b8b8529 100644
@@ -13,7 +13,7 @@ endif
 
 ifeq ($(ARCH_HAS_KLP),y)
 	HAVE_XXHASH = $(shell printf "$(pound)include <xxhash.h>\nXXH3_state_t *state;int main() {}" | \
-		      $(HOSTCC) -xc - -o /dev/null -lxxhash 2> /dev/null && echo y || echo n)
+		      $(HOSTCC) $(HOSTCFLAGS) -xc - -o /dev/null -lxxhash 2> /dev/null && echo y || echo n)
 	ifeq ($(HAVE_XXHASH),y)
 		BUILD_KLP	 := y
 		LIBXXHASH_CFLAGS := $(shell $(HOSTPKG_CONFIG) libxxhash --cflags 2>/dev/null) \