Skip to contentSkip to conversation

net: airoha: add RCU lock around dev_fill_forward_path

PATCH Applied Qingfang Deng 3 participants 3 messages Mar 20 – Mar 24

Subsystems (4)
Networking Network drivers Arm MediaTek Airoha Ethernet driver
lore
Share & tools
lore

Qingfang Deng

author
#0 lore raw

PATCH v2 1/1 net: airoha: add RCU lock around dev_fill_forward_path

Since 0417adf367a0 ("ppp: fix race conditions in ppp_fill_forward_path") dev_fill_forward_path() should be called with RCU read lock held. This fix was applied to net, while the Airoha flowtable commit was applied to net-next, so it hadn't been an issue until net was merged into net-next.

Fixes a8bdd935d1dd ("net: airoha: Add wlan flowtable TX offload")
Signed-off-by Qingfang Deng <[email protected]>

---
v2: update fixes tag to the flowtable commit
- https://lore.kernel.org/netdev/[email protected]/

 drivers/net/ethernet/airoha/airoha_ppe.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/airoha/airoha_ppe.c +2 -0
index ec5ce41dad80..02deb739a1c7 100644
@@ -227,7 +227,9 @@ static int airoha_ppe_get_wdma_info(struct net_device *dev, const u8 *addr,
 	if (!dev)
 		return -ENODEV;
 
+	rcu_read_lock();
 	err = dev_fill_forward_path(dev, addr, &stack);
+	rcu_read_unlock();
 	if (err)
 		return err;
Signature · 1 line
2.43.0
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 7 lines

Since 0417adf367a0 ("ppp: fix race conditions in ppp_fill_forward_path") dev_fill_forward_path() should be called with RCU read lock held. This fix was applied to net, while the Airoha flowtable commit was applied to net-next, so it hadn't been an issue until net was merged into net-next.

Fixes a8bdd935d1dd ("net: airoha: Add wlan flowtable TX offload")
Signed-off-by Qingfang Deng <[email protected]>

My acked-by tag is still valid.

Acked-by Lorenzo Bianconi <[email protected]>
Quoted 24 lines

---
v2: update fixes tag to the flowtable commit
- https://lore.kernel.org/netdev/[email protected]/

 drivers/net/ethernet/airoha/airoha_ppe.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/airoha/airoha_ppe.c +2 -0
index ec5ce41dad80..02deb739a1c7 100644
@@ -227,7 +227,9 @@ static int airoha_ppe_get_wdma_info(struct net_device *dev, const u8 *addr,
 	if (!dev)
 		return -ENODEV;
 
+	rcu_read_lock();
 	err = dev_fill_forward_path(dev, addr, &stack);
+	rcu_read_unlock();
 	if (err)
 		return err;
Signature · 1 line
2.43.0
CI Applied
#2 lore raw
In reply to Qingfang Deng
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Fri, 20 Mar 2026 17:43:15 +0800 you wrote:

Since 0417adf367a0 ("ppp: fix race conditions in ppp_fill_forward_path") dev_fill_forward_path() should be called with RCU read lock held. This fix was applied to net, while the Airoha flowtable commit was applied to net-next, so it hadn't been an issue until net was merged into net-next.

Fixes a8bdd935d1dd ("net: airoha: Add wlan flowtable TX offload")
Signed-off-by Qingfang Deng <[email protected]>

[...]

Here is the summary with links:
- [net,v2] net: airoha: add RCU lock around dev_fill_forward_path

    https://git.kernel.org/netdev/net/c/1065913dedfd

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html