fs: remove stale and duplicate forward declarations
Subsystems (2)
PATCH v2 1/1 fs: remove stale and duplicate forward declarations
Remove the following unnecessary forward declarations from fs.h, which improves maintainability.
- struct hd_geometry: became unused in fs.h when block_device_operations was moved to blkdev.h in commit 08f858512151 ("[PATCH] move block_device_operations to blkdev.h"). The forward declaration is now added to blkdev.h where it is actually used.
- struct iovec: became unused when aio_read/aio_write were removed in commit 8436318205b9 ("->aio_read and ->aio_write removed")
- struct iov_iter: duplicate forward declaration. This removes the redundant second declaration, added in commit 293bc9822fa9 ("new methods: ->read_iter() and ->write_iter()")
---
Changes in v2:
- Add forward declaration of struct hd_geometry to blkdev.h to fix build errors reported by kernel test robot.
- Verified with allmodconfig build and all configs reported by kernel test robot.
v1: https://lore.kernel.org/lkml/[email protected]/
--- include/linux/blkdev.h | 1 + include/linux/fs.h | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-)
include/linux/blkdev.h +1 -0
@@ -38,6 +38,7 @@ struct blk_flush_queue;struct kiocb ;struct pr_ops ;struct rq_qos ; +struct hd_geometry ;struct blk_report_zones_args ;struct blk_queue_stats ;struct blk_stat_callback ;
include/linux/fs.h +0 -3
@@ -55,8 +55,6 @@ struct bdi_writeback;struct bio ;struct io_comp_batch ;struct fiemap_extent_info ; -struct hd_geometry ; -struct iovec ;struct kiocb ;struct kobject ;struct pipe_inode_info ;
@@ -1917,7 +1915,6 @@ struct dir_context {*/ #define COPY_FILE_SPLICE (1 << 0) -struct iov_iter ;struct io_uring_cmd ;struct offset_ctx ;
Signature · 8 lines
2.50.1 Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284 Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
Quoted 15 lines · Yuto Ohnuki
Remove the following unnecessary forward declarations from
fs.h, which improves maintainability.- struct
hd_geometry: became unused infs.hwhenblock_device_operationswas moved toblkdev.hin commit08f858512151("[PATCH] moveblock_device_operationstoblkdev.h"). The forward declaration is now added toblkdev.hwhere it is actually used.- struct iovec: became unused when aio_read/aio_write were removed in commit
8436318205b9("->aio_read and ->aio_write removed")- struct
iov_iter: duplicate forward declaration. This removes the redundant second declaration, added in commit293bc9822fa9("new methods: ->read_iter() and ->write_iter()")
Quoted 7 lines
Reported-by kernel test robot <[email protected]>Signed-off-by Yuto Ohnuki <[email protected]>
Makes sense. Thanks. Feel free to add:
Honza
Quoted 58 lines
---
Changes in v2:
- Add forward declaration of structhd_geometrytoblkdev.hto fix build errors reported by kernel test robot.
- Verified with allmodconfig build and all configs reported by kernel test robot.v1: https://lore.kernel.org/lkml/[email protected]/
--- include/linux/blkdev.h | 1 + include/linux/fs.h | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-)include/linux/blkdev.h +1
-0@@ -38,6 +38,7 @@ struct blk_flush_queue;struct kiocb ;struct pr_ops ;struct rq_qos ; +struct hd_geometry ;struct blk_report_zones_args ;struct blk_queue_stats ;struct blk_stat_callback ;include/linux/fs.h +0
-3@@ -55,8 +55,6 @@ struct bdi_writeback;struct bio ;struct io_comp_batch ;struct fiemap_extent_info ; -struct hd_geometry ; -struct iovec ;struct kiocb ;struct kobject ;struct pipe_inode_info ;@@ -1917,7 +1915,6 @@ struct dir_context {*/ #define COPY_FILE_SPLICE (1 << 0) -struct iov_iter ;struct io_uring_cmd ;struct offset_ctx ;Signature · 8 lines
2.50.1 Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284 Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 80 lines · Yuto Ohnuki
Remove the following unnecessary forward declarations from
fs.h, which improves maintainability.- struct
hd_geometry: became unused infs.hwhenblock_device_operationswas moved toblkdev.hin commit08f858512151("[PATCH] moveblock_device_operationstoblkdev.h"). The forward declaration is now added toblkdev.hwhere it is actually used.- struct iovec: became unused when aio_read/aio_write were removed in commit
8436318205b9("->aio_read and ->aio_write removed")- struct
iov_iter: duplicate forward declaration. This removes the redundant second declaration, added in commit293bc9822fa9("new methods: ->read_iter() and ->write_iter()")Reported-by kernel test robot <[email protected]>Signed-off-by Yuto Ohnuki <[email protected]>---
Changes in v2:
- Add forward declaration of structhd_geometrytoblkdev.hto fix build errors reported by kernel test robot.
- Verified with allmodconfig build and all configs reported by kernel test robot.v1: https://lore.kernel.org/lkml/[email protected]/
--- include/linux/blkdev.h | 1 + include/linux/fs.h | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-)include/linux/blkdev.h +1
-0@@ -38,6 +38,7 @@ struct blk_flush_queue;struct kiocb ;struct pr_ops ;struct rq_qos ; +struct hd_geometry ;struct blk_report_zones_args ;struct blk_queue_stats ;struct blk_stat_callback ;include/linux/fs.h +0
-3@@ -55,8 +55,6 @@ struct bdi_writeback;struct bio ;struct io_comp_batch ;struct fiemap_extent_info ; -struct hd_geometry ; -struct iovec ;struct kiocb ;struct kobject ;struct pipe_inode_info ;@@ -1917,7 +1915,6 @@ struct dir_context {*/ #define COPY_FILE_SPLICE (1 << 0) -struct iov_iter ;struct io_uring_cmd ;struct offset_ctx ;Signature · 8 lines
2.50.1 Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284 Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
Gentle ping on this patch.
It has a Reviewed-by from Jan Kara.
Please let me know if there is anythins else needed for this to be applied.
Thanks,
Yuto
Amazon Web Services EMEA SARL, 38 avenue John F. Kennedy, L-1855 Luxembourg, R.C.S. Luxembourg B186284
Amazon Web Services EMEA SARL, Irish Branch, One Burlington Plaza, Burlington Road, Dublin 4, Ireland, branch registration number 908705
Quoted 9 lines · Yuto Ohnuki
Remove the following unnecessary forward declarations from
fs.h, which improves maintainability.- struct
hd_geometry: became unused infs.hwhenblock_device_operationswas moved toblkdev.hin commit08f858512151("[PATCH] moveblock_device_operationstoblkdev.h"). The forward declaration is now added toblkdev.hwhere it is actually used.[...]
Applied to the vfs-7.1.misc branch of the vfs/vfs.git tree. Patches in the vfs-7.1.misc branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs-7.1.misc
[1/1] fs: remove stale and duplicate forward declarations
https://git.kernel.org/vfs/vfs/c/3d6bb84f6bb3