bashism in tools/Makefile.in
Hello everybody,
building lvm2 with a shell other than bash fails:
% make -C tools/ command-count.h
make: Entering directory 'lvm2/tools'
[GEN] cmds.h/bin/dash: 1: set: Illegal option -o pipefail
[GEN] command-lines-input.h/bin/dash: 1: set: Illegal option -o pipefail
[GEN] command-count.h/bin/dash: 1: set: Illegal option -o pipefail
make: *** [Makefile:170: command-count.h] Error 2
make: Leaving directory 'lvm2/tools'
Please fix bashism in Makefile. Thanks!
Signature · 3 lines
main(a){char*c=/* Schoene Gruesse */"B?IJj;MEH"
"CX:;",b;for(a/* Best regards my address: */=0;b=c[a++];)
putchar(b-1/(/* Chris cc -ox -xc - && ./x */b/42*2-3)*42);}Dne 06. 01. 20 v 10:48 Christian Hesse napsal(a):
Quoted 15 lines
Hello everybody,
building lvm2 with a shell other than bash fails:
% make -C
tools/command-count.h
make: Entering directory 'lvm2/tools'
[GEN]cmds.h/bin/dash: 1: set: Illegal option -o pipefail
[GEN]command-lines-input.h/bin/dash: 1: set: Illegal option -o pipefail
[GEN]command-count.h/bin/dash: 1: set: Illegal option -o pipefail
make: *** [Makefile:170:command-count.h] Error 2
make: Leaving directory 'lvm2/tools'
Quoted 2 lines
Please fix bashism in
Makefile. Thanks!
Hi
Unfortunately whole lvm2 project is mostly 'bash' based and all developers mostly use bash - so we would welcome patches if they would provide equivalently working code without bashism...
Fixing couple things while the whole rest of project is still requiring bash doesn't make it any better - ATM all scripts/tests/Makefiles mostly expect presence of bash.
Regards
Zdenek
PATCH 1/1 build: force to use bash (was: Re: bashism in tools/Makefile.in)
From: Christian Hesse <[email protected]>
Quoted 7 lines
Unfortunately whole lvm2 project is mostly 'bash' based and all developers mostly use bash - so we would welcome patches if they would provide equivalently working code without bashism...
Fixing couple things while the whole rest of project is still requiring bash doesn't make it any better - ATM all
scripts/tests/Makefilesmostly expect presence of bash.
Fine with me. So how about forcing the build system to use bash?
-- >8 --
From: Christian Hesse <[email protected]>
Subject: build: force to use bash
The build system expects bash, so force to use it. This mitigates issues where other shells are fed with bashism.
--- configure | 15 +++++++++++++++ configure.ac | 15 +++++++++++++++ 2 files changed, 30 insertions(+)
configure +15 -0
@@ -2960,6 +2960,21 @@ ac_configure="$SHELL $ac_aux_dir/configure" # Please don't use this var. +################################################################################ +if test -z "$BASH_VERSION$CONFIG_SHELL" +then + CONFIG_SHELL=bash + export CONFIG_SHELL + if $CONFIG_SHELL -c "exit 0" + then + exec $CONFIG_SHELL $0 "$@" + else + { $as_echo "$as_me:${as_lineno-$LINENO}: The 'bash' shell is needed to build lvm2" >&5 +$as_echo "$as_me: The 'bash' shell is needed to build lvm2" >&6;} + as_fn_error $? "'bash' not found" "$LINENO" 5 + fi +fi + ################################################################################ # Make sure we can run config.sub. $SHELL "$ac_aux_dir/config.sub" sun4 >/dev/null 2>&1 ||
configure.ac +15 -0
@@ -23,6 +23,21 @@ AC_CONFIG_HEADERS([include/configure.h]) dnl -- Setup the directory where autoconf has auxilary files AC_CONFIG_AUX_DIR(autoconf) +################################################################################ +dnl -- We need to run the build system with bash. +if test -z "$BASH_VERSION$CONFIG_SHELL" +then + CONFIG_SHELL=bash + export CONFIG_SHELL + if $CONFIG_SHELL -c "exit 0" + then + exec $CONFIG_SHELL $0 "$@" + else + AC_MSG_NOTICE([The 'bash' shell is needed to build lvm2]) + AC_MSG_ERROR(['bash' not found]) + fi +fi + ################################################################################ dnl -- Get system type AC_CANONICAL_TARGET([])