Skip to contentSkip to conversation

dt-bindings: embedded-controller: qcom,hamoa-crd-ec: add Lenovo Yoga Slim 7x

PATCH RESEND In review Daniel J Blueman 2 participants 3 messages Jul 12 – Jul 13

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND v4 1/2 dt-bindings: embedded-controller: qcom,hamoa-crd-ec: add Lenovo Yoga Slim 7x

The Lenovo Yoga Slim 7x uses the same Embedded Controller as the Qualcomm Hamoa X1 CRD. Add a board-specific compatible with qcom,hamoa-crd-ec as the fallback.

---
v4:
- add reviews and acknowledgements
- updated dependency URL
v3: https://lore.kernel.org/lkml/[email protected]/
- new patch with DT bindings
v2: https://lore.kernel.org/lkml/[email protected]/
v1: https://lore.kernel.org/lkml/[email protected]/

Dependencies:
https://lore.kernel.org/lkml/[email protected]/

 .../bindings/embedded-controller/qcom,hamoa-crd-ec.yaml          | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml +1 -0
index ac5a08f8f76d..813d41769c0b 100644
@@ -20,6 +20,7 @@ properties:
     oneOf:
       - items:
           - enum:
+              - lenovo,yoga-slim7x-ec
               - qcom,glymur-crd-ec
               - qcom,hamoa-iot-evk-ec
           - const: qcom,hamoa-crd-ec
Signature · 1 line
2.53.0
#1 lore raw

PATCH RESEND v4 2/2 arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add Embedded Controller node

The Lenovo Slim7x uses the same Embedded Controller as the Qualcomm Hamoa X1 Customer Reference Device. Use the lenovo,yoga-slim7x-ec compatible for fan control, thermal sensor and suspend behaviour.

---
v4:
- add reviews
v3:
- use lenovo,yoga-slim7x-ec compatible (introduced by patch 1) v2:
- corrected DT compatible node

 .../dts/qcom/x1e80100-lenovo-yoga-slim7x.dts  | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +22 -0
index beb1475d7fa0..1ee2a2296129 100644
@@ -951,6 +951,22 @@ retimer_ss0_con_sbu_out: endpoint {
 	};
 };
 
+&i2c5 {
+	clock-frequency = <400000>;
+
+	status = "okay";
+
+	embedded-controller@76 {
+		compatible = "lenovo,yoga-slim7x-ec", "qcom,hamoa-crd-ec";
+		reg = <0x76>;
+
+		interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
+
+		pinctrl-0 = <&ec_int_n_default>;
+		pinctrl-names = "default";
+	};
+};
+
 &i2c7 {
 	clock-frequency = <400000>;
 
@@ -1352,6 +1368,12 @@ &tlmm {
 			       <44 4>, /* SPI (TPM) */
 			       <238 1>; /* UFS Reset */
 
+	ec_int_n_default: ec-int-n-state {
+		pins = "gpio66";
+		function = "gpio";
+		bias-disable;
+	};
+
 	edp_reg_en: edp-reg-en-state {
 		pins = "gpio70";
 		function = "gpio";
Signature · 1 line
2.53.0
maintainer Reviewed-by on v4 1/2
#2 lore raw
In reply to Daniel J Blueman
Quoted 27 lines · Daniel J Blueman

The Lenovo Yoga Slim 7x uses the same Embedded Controller as the Qualcomm Hamoa X1 CRD. Add a board-specific compatible with qcom,hamoa-crd-ec as the fallback.

---
v4:
- add reviews and acknowledgements
- updated dependency URL
v3: https://lore.kernel.org/lkml/[email protected]/
- new patch with DT bindings
v2: https://lore.kernel.org/lkml/[email protected]/
v1: https://lore.kernel.org/lkml/[email protected]/

Dependencies:
https://lore.kernel.org/lkml/[email protected]/

 .../bindings/embedded-controller/qcom,hamoa-crd-ec.yaml          | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml +0 -0
index ac5a08f8f76d..813d41769c0b 100644

Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml properties: · line 26

Quoted 7 lines
Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml +1 -0
@@ -20,6 +20,7 @@ properties:
     oneOf:
       - items:
           - enum:
+              - lenovo,yoga-slim7x-ec
               - qcom,glymur-crd-ec
               - qcom,hamoa-iot-evk-ec
           - const: qcom,hamoa-crd-ec
Signature · 2 lines
Best Regards,
Anvesh